Re: [dpdk-dev] [PATCH] doc: update firmware/driver mapping table for i40e

2020-11-12 Thread Guo, Jia
Acked-by: Jeff Guo > -Original Message- > From: Shougang Wang > Sent: Wednesday, November 11, 2020 11:27 AM > To: dev@dpdk.org > Cc: Chen, Zhaoyan ; Lin, Xueqin > ; Xing, Beilei ; Guo, Jia > ; Wang, ShougangX > Subject: [PATCH] doc: update firmware/driver mapping table for i40e > > Upd

[dpdk-dev] [PATCH] app/testpmd: fix testpmd packets dump overlapping

2020-11-12 Thread Jiawei Wang
When testpmd enabled the verbosity for the received packets, if two packets was received at the same time, for example, sampling packet and normal packet, the dump output of these packets may be overlapping due to multiple core handled the multiple queues simultaneously. The patch uses one string

Re: [dpdk-dev] [PATCH] net/virtio: enable packet data prefetch on x86

2020-11-12 Thread Maxime Coquelin
Hi Marvin, On 11/11/20 4:40 PM, Marvin Liu wrote: > Data prefetch instruction can preload data into cpu’s hierarchical > cache before data access. Virtio datapath utilized this feature for > data access acceleration. As config RTE_PMD_PACKET_PREFETCH was > discarded, now packet data prefetch is en

[dpdk-dev] [PATCH] net/mlx5: fix counter offset support discover

2020-11-12 Thread Suanming Mou
Currently, the counter offset support is discovered by creating the rule with invalid offset counter and jump action in root table. If the rule creation fails with EINVAL errno, that mean counter offset is not supported in root table. However, jump action may not be supported in some rdma-core ver

Re: [dpdk-dev] [PATCH] net/virtio: enable packet data prefetch on x86

2020-11-12 Thread David Marchand
On Thu, Nov 12, 2020 at 9:48 AM Maxime Coquelin wrote: > On 11/11/20 4:40 PM, Marvin Liu wrote: > > Data prefetch instruction can preload data into cpu’s hierarchical > > cache before data access. Virtio datapath utilized this feature for > > data access acceleration. As config RTE_PMD_PACKET_PREF

Re: [dpdk-dev] [PATCH v2 2/2] examples: skip installing unbuildable examples

2020-11-12 Thread David Marchand
On Wed, Nov 11, 2020 at 6:33 PM Bruce Richardson wrote: > > On Wed, Nov 11, 2020 at 03:56:47PM +, Bruce Richardson wrote: > > Rather than just installing all examples, we can use the build checks to > > filter out any examples that are missing dependencies or are otherwise > > unbuildable on t

Re: [dpdk-dev] [PATCH v2 2/2] examples: skip installing unbuildable examples

2020-11-12 Thread Bruce Richardson
On Thu, Nov 12, 2020 at 10:14:23AM +0100, David Marchand wrote: > On Wed, Nov 11, 2020 at 6:33 PM Bruce Richardson > wrote: > > > > On Wed, Nov 11, 2020 at 03:56:47PM +, Bruce Richardson wrote: > > > Rather than just installing all examples, we can use the build checks to > > > filter out any

Re: [dpdk-dev] [v4]net/hinic: fix coredump when the scondary process using the hinic port.

2020-11-12 Thread Ferruh Yigit
On 11/12/2020 2:11 AM, Wangxiaoyun (Cloud) wrote: Hi Ferruh, Align with Qingqing Li, this path will not apply to dpdk master now, some dev_ops may casue fail when run in secondary proc, so need to modify it later and add tests for other dev_ops. So will there be a new version in next relea

Re: [dpdk-dev] [PATCH v2 2/2] examples: skip installing unbuildable examples

2020-11-12 Thread David Marchand
On Thu, Nov 12, 2020 at 10:25 AM Bruce Richardson wrote: > > Strange, the v3 patches 2 and 3 linked to the v2 series. > > As far as I can see, the lab only tested the v3 series with patches > > 84029 and 30, so the error on Windows is still reported. > > > > -- > > David Marchand > > > Yes, I see

Re: [dpdk-dev] [PATCH v1] examples/vhost: fix ioat dependency issue

2020-11-12 Thread Bruce Richardson
On Thu, Nov 12, 2020 at 07:14:26AM +, Jiang, Cheng1 wrote: > Hi, > > > -Original Message- > > From: David Marchand > > Sent: Wednesday, November 11, 2020 10:36 PM > > To: Jiang, Cheng1 > > Cc: Maxime Coquelin ; Xia, Chenbo > > ; dev ; Fu, Patrick > > ; Yang, YvonneX ; Hu, > > Jiayu ;

[dpdk-dev] [PATCH] malloc: cleanup coding style

2020-11-12 Thread wangyunjian
From: Yunjian Wang Cleanup code style issue reported by kernel checkpatch. As follows: * ERROR:CODE_INDENT: code indent should use tabs where possible * ERROR:SPACING: spaces required around that '?' (ctx:VxE) * WARNING:INDENTED_LABEL: labels should not be indented Fixes: b0489e7bca2f ("ma

Re: [dpdk-dev] [PATCH v2 2/2] examples: skip installing unbuildable examples

2020-11-12 Thread Bruce Richardson
On Thu, Nov 12, 2020 at 10:27:09AM +0100, David Marchand wrote: > On Thu, Nov 12, 2020 at 10:25 AM Bruce Richardson > wrote: > > > Strange, the v3 patches 2 and 3 linked to the v2 series. > > > As far as I can see, the lab only tested the v3 series with patches > > > 84029 and 30, so the error on

Re: [dpdk-dev] [PATCH v3] examples/vhost: fix ioat dependency issue

2020-11-12 Thread David Marchand
On Thu, Nov 12, 2020 at 8:30 AM Cheng Jiang wrote: > > Fix vhost-switch compiling issue when ioat dependency is missing. > Change 'RTE_x86' check into 'RTE_RAW_IOAT' check in meson build file > and update Makefile. Clean some codes. > > Fixes: abec60e7115d ("examples/vhost: support vhost async dat

Re: [dpdk-dev] [PATCH v1] examples/vhost: fix ioat dependency issue

2020-11-12 Thread David Marchand
On Thu, Nov 12, 2020 at 10:31 AM Bruce Richardson wrote: > > > main.c should check for RTE_RAW_IOAT before including ioat.h. > > > And then in this header, you can remove this stub too. > > > > > > > As for this one, ioat.h don't have dependency on IOAT driver, it is needed > > by the example reg

[dpdk-dev] [PATCH v4 2/4] examples/l2fwd-keepalive: skip build when no librt

2020-11-12 Thread Bruce Richardson
When librt is not present on a system, processing the meson.build file for this example application causes an error. Make the library non-mandatory and just mark the example as unbuildable if it is not present. Fixes: 89f0711f9ddf ("examples: build some samples with meson") Cc: sta...@dpdk.org Si

[dpdk-dev] [PATCH v4 0/4] improve examples installation

2020-11-12 Thread Bruce Richardson
This patch improves the installation of the examples when "ninja install" is run. It removes issues with the directory structure being flattened out, and removes from the install list any examples that are not buildable with built DPDK code. V4: resubmit v3 to retest in CI hopefully with proper pa

[dpdk-dev] [PATCH v4 1/4] examples: fix flattening directory layout on install

2020-11-12 Thread Bruce Richardson
By installing the examples one-by-one in a loop in the examples meson.build file we effectively flattened out the structure of the examples folder and omitted some common and shared subfolders that were never directly built. Instead, we can remove the loop and just have the whole "examples" folder

[dpdk-dev] [PATCH v4 3/4] examples: stop processing build file if build is impossible

2020-11-12 Thread Bruce Richardson
Once it has been determined that an example cannot be built, there is little point in continuing to process the meson.build file for that example, so we can use subdir_done() to return to the calling file. This can potentially prevent problems where later statement in the file may cause an error on

[dpdk-dev] [PATCH v4 4/4] examples: skip installing unbuildable examples

2020-11-12 Thread Bruce Richardson
Rather than just installing all examples, we can use the build checks to filter out any examples that are missing dependencies or are otherwise unbuildable on the current system. Signed-off-by: Bruce Richardson --- examples/meson.build | 54 +++- meson.bui

Re: [dpdk-dev] [RFC V2 1/2] app/testpmd: fix queue stats mapping configuration

2020-11-12 Thread Ferruh Yigit
On 11/12/2020 2:28 AM, Min Hu (Connor) wrote: Hi Ferruh, any suggestions? 在 2020/11/3 14:30, Min Hu (Connor) 写道: Hi Ferruh, I agree with your proposal. But if we remove record structures, we will not be able to query the current queue stats mapping configuration. Or we can provide a query API

Re: [dpdk-dev] [PATCH v1] examples/vhost: fix ioat dependency issue

2020-11-12 Thread Bruce Richardson
On Thu, Nov 12, 2020 at 10:39:33AM +0100, David Marchand wrote: > On Thu, Nov 12, 2020 at 10:31 AM Bruce Richardson > wrote: > > > > main.c should check for RTE_RAW_IOAT before including ioat.h. > > > > And then in this header, you can remove this stub too. > > > > > > > > > > As for this one, ioa

Re: [dpdk-dev] [PATCH v3] examples/vhost: fix ioat dependency issue

2020-11-12 Thread Bruce Richardson
On Thu, Nov 12, 2020 at 10:36:50AM +0100, David Marchand wrote: > On Thu, Nov 12, 2020 at 8:30 AM Cheng Jiang wrote: > > > > Fix vhost-switch compiling issue when ioat dependency is missing. > > Change 'RTE_x86' check into 'RTE_RAW_IOAT' check in meson build file > > and update Makefile. Clean som

[dpdk-dev] [PATCH v1] eal/arm: fix clang build of native target

2020-11-12 Thread Ruifeng Wang
When doing Clang build with '-mcpu=native' on N1 platform, build failed with: ../lib/librte_eal/arm/include/rte_atomic_64.h:76:39: error: instruction requires: lse __ATOMIC128_CAS_OP(__cas_128_release, "caspl") This is because native detection for Neoverse N1 was added in Clang-11. Prior v

Re: [dpdk-dev] [PATCH v8 09/14] ci: switch to generic Arm builds

2020-11-12 Thread Ruifeng Wang
> -Original Message- > From: Juraj Linkeš > Sent: Thursday, November 12, 2020 12:19 AM > To: Ruifeng Wang ; Honnappa Nagarahalli > ; bruce.richard...@intel.com; Phil Yang > ; vcchu...@amazon.com; Dharmik Thakkar > ; jerinjac...@gmail.com; > hemant.agra...@nxp.com; Ajit Khaparde (ajit.khap

[dpdk-dev] [PATCH v3] net/i40e: fix argument in RSS action

2020-11-12 Thread Kumar Amber
The driver must check for the queue number in the RSS action list and if not should return with a proper error message to user. Bugzilla ID: 573 Fixes: 9486d60b94b5 ("net/i40e: fix flow RSS queue index check") Cc: wei.zh...@intel.com Signed-off-by: Kumar Amber --- drivers/net/i40e/i40e_flow.c |

[dpdk-dev] [PATCH v4] net/i40e: fix argument in RSS action

2020-11-12 Thread Kumar Amber
The driver must check for the queue number in the RSS action list and if not should return with a proper error message to user. Bugzilla ID: 573 Fixes: 9486d60b94b5 ("net/i40e: fix flow RSS queue index check") Cc: wei.zh...@intel.com Signed-off-by: Kumar Amber --- drivers/net/i40e/i40e_flow.c |

Re: [dpdk-dev] [PATCH v4 0/4] improve examples installation

2020-11-12 Thread David Marchand
On Thu, Nov 12, 2020 at 10:42 AM Bruce Richardson wrote: > > This patch improves the installation of the examples when "ninja install" is > run. It removes issues with the directory structure being flattened out, and > removes from the install list any examples that are not buildable with built >

Re: [dpdk-dev] [PATCH v3] examples/vhost: fix ioat dependency issue

2020-11-12 Thread Jiang, Cheng1
Hi Bruce, > -Original Message- > From: Bruce Richardson > Sent: Thursday, November 12, 2020 6:28 PM > To: David Marchand > Cc: Jiang, Cheng1 ; Maxime Coquelin > ; Xia, Chenbo ; > dev ; Fu, Patrick ; Yang, YvonneX > ; Hu, Jiayu > Subject: Re: [dpdk-dev] [PATCH v3] examples/vhost: fix ioa

[dpdk-dev] [PATCH v1] build: add Wformat to fix gcc compile error

2020-11-12 Thread Conor Walsh
On some systems Wformat-nonliteral and Wformat-security could not be checked without Wformat also being specified. This patch adds Wformat to config/meson.build Signed-off-by: Conor Walsh --- config/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/config/meson.build b/config/meson

Re: [dpdk-dev] [PATCH v4 0/4] improve examples installation

2020-11-12 Thread Bruce Richardson
On Thu, Nov 12, 2020 at 12:14:27PM +0100, David Marchand wrote: > On Thu, Nov 12, 2020 at 10:42 AM Bruce Richardson > wrote: > > > > This patch improves the installation of the examples when "ninja install" is > > run. It removes issues with the directory structure being flattened out, and > > rem

[dpdk-dev] DPDK Release Status Meeting 12/11/2020

2020-11-12 Thread Ferruh Yigit
Meeting minutes of 12 November 2020 --- Agenda: * Release Dates * Roadmaps * -rc3 status * Subtrees * LTS Participants: * Arm * Debian/Microsoft * Intel * Marvell * Nvidia * Red Hat Release Dates - * v20.11 dates * -rc3 is released on Thursda

Re: [dpdk-dev] [PATCH] malloc: cleanup coding style

2020-11-12 Thread Burakov, Anatoly
On 12-Nov-20 9:31 AM, wangyunjian wrote: From: Yunjian Wang Cleanup code style issue reported by kernel checkpatch. As follows: * ERROR:CODE_INDENT: code indent should use tabs where possible * ERROR:SPACING: spaces required around that '?' (ctx:VxE) * WARNING:INDENTED_LABEL: labels sh

Re: [dpdk-dev] [PATCH] net/iavf: fix performance drop after port reset

2020-11-12 Thread Zhang, Qi Z
> -Original Message- > From: Rong, Leyi > Sent: Thursday, November 12, 2020 1:52 PM > To: Zhang, Qi Z ; Lu, Wenzhuo > ; Wu, Jingjing ; Xing, Beilei > > Cc: dev@dpdk.org; Rong, Leyi > Subject: [PATCH] net/iavf: fix performance drop after port reset > > Needs to reset rxq->rxrearm_star

Re: [dpdk-dev] [PATCH v2 2/2] net/iavf: fix the RSS error when VF port closed

2020-11-12 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Steve Yang > Sent: Monday, November 9, 2020 2:52 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Xing, Beilei > ; Wu, Jingjing ; Yang, SteveX > > Subject: [dpdk-dev] [PATCH v2 2/2] net/iavf: fix the RSS error when VF port > closed > > Check the

Re: [dpdk-dev] [PATCH] doc: update firmware/driver mapping table for i40e

2020-11-12 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Guo, Jia > Sent: Thursday, November 12, 2020 4:20 PM > To: Wang, ShougangX ; dev@dpdk.org > Cc: Chen, Zhaoyan ; Lin, Xueqin > ; Xing, Beilei ; Wang, > ShougangX > Subject: Re: [dpdk-dev] [PATCH] doc: update firmware/driver mapping table > f

Re: [dpdk-dev] DPDK Release Status Meeting 12/11/2020

2020-11-12 Thread David Marchand
On Thu, Nov 12, 2020 at 12:39 PM Ferruh Yigit wrote: >* In suse build environment, there are some arm and PPC build error > * For arm the RHEL 7 compiler for arm is too old >* Can be possible to disable the failing driver and still test the rest Luca also mentioned an issue on Ce

Re: [dpdk-dev] [PATCH v3] examples/vhost: fix ioat dependency issue

2020-11-12 Thread Bruce Richardson
On Thu, Nov 12, 2020 at 11:29:56AM +, Jiang, Cheng1 wrote: > Hi Bruce, > > > -Original Message- > > From: Bruce Richardson > > Sent: Thursday, November 12, 2020 6:28 PM > > To: David Marchand > > Cc: Jiang, Cheng1 ; Maxime Coquelin > > ; Xia, Chenbo ; > > dev ; Fu, Patrick ; Yang, Yv

Re: [dpdk-dev] [v4]net/hinic: fix coredump when the scondary process using the hinic port.

2020-11-12 Thread Wangxiaoyun (Cloud)
When we complete repair and testing, we will upstream the patch in next release, maybe not keep up with 20.11. 在 2020/11/12 17:26, Ferruh Yigit 写道: On 11/12/2020 2:11 AM, Wangxiaoyun (Cloud) wrote: Hi Ferruh, Align with Qingqing Li, this path will not apply to dpdk master now, some dev_ops ma

Re: [dpdk-dev] [v4]net/hinic: fix coredump when the scondary process using the hinic port.

2020-11-12 Thread Ferruh Yigit
On 11/12/2020 12:30 PM, Wangxiaoyun (Cloud) wrote: < copied the response down, please don't top post > 在 2020/11/12 17:26, Ferruh Yigit 写道: On 11/12/2020 2:11 AM, Wangxiaoyun (Cloud) wrote: Hi Ferruh, Align with Qingqing Li, this path will not apply to dpdk master now, some dev_ops may casu

Re: [dpdk-dev] [PATCH v8 09/14] ci: switch to generic Arm builds

2020-11-12 Thread Juraj Linkeš
> -Original Message- > From: Ruifeng Wang > Sent: Thursday, November 12, 2020 11:37 AM > To: Juraj Linkeš ; Honnappa Nagarahalli > ; bruce.richard...@intel.com; Phil Yang > ; vcchu...@amazon.com; Dharmik Thakkar > ; jerinjac...@gmail.com; > hemant.agra...@nxp.com; Ajit Khaparde (ajit.kha

Re: [dpdk-dev] [PATCH v1 1/1] net/hinic/base: add message check for command channel

2020-11-12 Thread Ferruh Yigit
On 11/11/2020 6:33 AM, Guoyang Zhou wrote: In the command channel, a message may has several fragments, and the several fragments should have same message id. To prevent problems, this check is added. Fixes: 1e4593db1d58 ("net/hinic/base: fix log info for PF command channel") Cc: sta...@dpdk.org

Re: [dpdk-dev] [PATCH 1/1] devtools: reduce build test verbosity

2020-11-12 Thread David Marchand
On Fri, Nov 6, 2020 at 6:29 PM Thomas Monjalon wrote: > > The default verbosity of test-meson-builds.sh is to be quiet. > In order to better apply the verbosity policy, some file descriptors > are open to redirect to stdout or /dev/null accordingly. > > The target variable and meson/ninja commands

Re: [dpdk-dev] [PATCH 1/1] devtools: reduce build test verbosity

2020-11-12 Thread Bruce Richardson
On Fri, Nov 06, 2020 at 06:28:54PM +0100, Thomas Monjalon wrote: > The default verbosity of test-meson-builds.sh is to be quiet. > In order to better apply the verbosity policy, some file descriptors > are open to redirect to stdout or /dev/null accordingly. > > The target variable and meson/ninja

Re: [dpdk-dev] [PATCH v2] ethdev: deprecate shared counters using action attribute

2020-11-12 Thread Ferruh Yigit
On 11/3/2020 2:26 PM, Andrew Rybchenko wrote: A new generic shared actions API may be used to create shared counter. There is no point to keep duplicate COUNT action specific capability to create shared counters. Signed-off-by: Andrew Rybchenko Reviewed-by: Ferruh Yigit --- Cc: Ori Kam Cc: Xu

Re: [dpdk-dev] [PATCH v2] usertools: fix pmdinfo parsing

2020-11-12 Thread David Marchand
On Wed, Nov 4, 2020 at 10:41 AM David Marchand wrote: > > This script inspects an ELF file (binary or shared library) and its > linked dependencies by following DT_NEEDED tags. > So far a simple librte_pmd prefix was used as a filter. > Now that we changed the driver library names, update this heu

Re: [dpdk-dev] [PATCH v5 0/3] support both PIO and MMIO BAR for virtio PMD

2020-11-12 Thread 谢华伟(此时此刻)
On 2020/11/10 20:42, David Marchand wrote: On Tue, Nov 10, 2020 at 1:35 PM 谢华伟(此时此刻) wrote: Previously there are different ways to get port address based on different DPDK uio driver(IGB_UIO/UIO_PCI_GENERIC/VFIO), which is actually not necessary. This patch makes IO/MMIO port map/RW API more

[dpdk-dev] [PATCH] devtools: fix x86-default env when installing

2020-11-12 Thread David Marchand
While testing Thomas patch on this script verbosity, I noticed that we load the x86-default environment after installing this target. I did not see any problem with it, yet we should load corresponding environment before installing a target. Fixes: bd253daa7717 ("devtools: fix test of ninja instal

Re: [dpdk-dev] [PATCH] malloc: cleanup coding style

2020-11-12 Thread wangyunjian
> -Original Message- > From: Burakov, Anatoly [mailto:anatoly.bura...@intel.com] > Sent: Thursday, November 12, 2020 7:40 PM > To: wangyunjian ; dev@dpdk.org > Cc: rsanfo...@gmail.com; Lilijun (Jerry) ; xudingke > ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] malloc: cleanup coding st

Re: [dpdk-dev] [PATCH v4 0/4] improve examples installation

2020-11-12 Thread David Marchand
On Thu, Nov 12, 2020 at 12:38 PM Bruce Richardson wrote: > > My only comment is about vm_power_manager which won't build without > > the internal librte_power header. > > It builds fine with meson, because I guess meson pulls this library > > directory into the include flags of the example, but it

[dpdk-dev] [PATCH] net/mlx5: fix header reformat action hash key

2020-11-12 Thread Suanming Mou
Currently, header reformat action uses the hash list 32-bit key generated in header reformat register function directly. The key will not be recalculated in the hash list function. As the 64-bit key is composed of the 32-bit attributes and 32-bit reformat buffer csum, the hash list function only g

[dpdk-dev] [PATCH v4] examples/vhost: fix ioat dependency issue

2020-11-12 Thread Cheng Jiang
Fix vhost-switch compiling issue when ioat dependency is missing. Change 'RTE_x86' check into 'RTE_RAW_IOAT' check in meson build file. Use 'RTE_RAW_IOAT' to control conditional compiling in source file. Clean some codes. Fixes: abec60e7115d ("examples/vhost: support vhost async data path") Fixes:

Re: [dpdk-dev] [PATCH v3] examples/vhost: fix ioat dependency issue

2020-11-12 Thread Jiang, Cheng1
Submitted v4 patch as per Bruce's suggestion. > -Original Message- > From: Bruce Richardson > Sent: Thursday, November 12, 2020 8:02 PM > To: Jiang, Cheng1 > Cc: David Marchand ; Maxime Coquelin > ; Xia, Chenbo ; > dev ; Fu, Patrick ; Yang, YvonneX > ; Hu, Jiayu > Subject: Re: [dpdk-dev

[dpdk-dev] [PATCH v2 1/1] devtools: fix build test config inheritance from env

2020-11-12 Thread Thomas Monjalon
The variables DPDK_MESON_OPTIONS, PATH, PKG_CONFIG_PATH, CPPFLAGS, CFLAGS and LDFLAGS can be customized in the config file loaded by devtools/load-devel-config at each build. The configuration can be adjusted per target thanks to the value set in the DPDK_TARGET variable. PKG_CONFIG_PATH is specif

Re: [dpdk-dev] [PATCH 1/1] devtools: reduce build test verbosity

2020-11-12 Thread Thomas Monjalon
12/11/2020 14:08, Bruce Richardson: > On Fri, Nov 06, 2020 at 06:28:54PM +0100, Thomas Monjalon wrote: > > The default verbosity of test-meson-builds.sh is to be quiet. > > In order to better apply the verbosity policy, some file descriptors > > are open to redirect to stdout or /dev/null according

Re: [dpdk-dev] [PATCH v2 1/1] devtools: fix build test config inheritance from env

2020-11-12 Thread David Marchand
On Thu, Nov 12, 2020 at 3:22 PM Thomas Monjalon wrote: > > The variables DPDK_MESON_OPTIONS, PATH, PKG_CONFIG_PATH, > CPPFLAGS, CFLAGS and LDFLAGS can be customized in the config file > loaded by devtools/load-devel-config at each build. > The configuration can be adjusted per target thanks to the

Re: [dpdk-dev] [PATCH v2 2/2] mbuf: move pool pointer in first half

2020-11-12 Thread Thomas Monjalon
> > > According to the Technical Board decision > > > (http://mails.dpdk.org/archives/dev/2020-November/191859.html), > > > the mempool pointer in the mbuf struct is moved > > > from the second to the first half. > > > It may increase performance in some cases > > > on systems having 64-byte cache

Re: [dpdk-dev] [PATCH] devtools/test-meson-builds: allow custom set of examples

2020-11-12 Thread David Marchand
On Tue, Nov 10, 2020 at 3:36 PM Thomas Monjalon wrote: > PKG_CONFIG_PATH=../dpdk-build/build-x86-default/meson-private \ > pkg-config --define-prefix --libs-only-L libdpdk > -L/usr/local/lib > > Oh! I am testing on the build directory instead of installed one. > > PKG_CONFIG_PATH=../dpdk-build/bui

[dpdk-dev] [PATCH] pipeline: fix multiple emit pattern detection

2020-11-12 Thread Cristian Dumitrescu
Fix the detection of instruction pattern with multiple emits followed by TX. Once detected, this is one of the instruction patterns that is internally replaced with a single optimized instruction, as long as none of the instructions to be replaced is referenced by a jump instruction. The fix enforc

Re: [dpdk-dev] [PATCH v4 0/4] improve examples installation

2020-11-12 Thread Bruce Richardson
On Thu, Nov 12, 2020 at 02:48:52PM +0100, David Marchand wrote: > On Thu, Nov 12, 2020 at 12:38 PM Bruce Richardson > wrote: > > > My only comment is about vm_power_manager which won't build without > > > the internal librte_power header. > > > It builds fine with meson, because I guess meson pull

Re: [dpdk-dev] [PATCH v4] examples/vhost: fix ioat dependency issue

2020-11-12 Thread Bruce Richardson
On Thu, Nov 12, 2020 at 01:47:54PM +, Cheng Jiang wrote: > Fix vhost-switch compiling issue when ioat dependency is missing. > Change 'RTE_x86' check into 'RTE_RAW_IOAT' check in meson build file. > Use 'RTE_RAW_IOAT' to control conditional compiling in source file. > Clean some codes. > > Fix

Re: [dpdk-dev] [PATCH v2] net/txgbe: return changed to fix gcc compile error

2020-11-12 Thread Ferruh Yigit
On 11/11/2020 3:39 PM, Conor Walsh wrote: When DPDK is compiled with gcc 7.5 with the optimization level set to 1 gcc sees the offset variable in txgbe_ethdev.c as possibly being uninitialised. To correct this the final return statement in txgbe_get_offset_by_id was simplified to return -1. Sign

Re: [dpdk-dev] [dpdk-stable] [PATCH] devtools: fix x86-default env when installing

2020-11-12 Thread Thomas Monjalon
12/11/2020 14:38, David Marchand: > While testing Thomas patch on this script verbosity, I noticed that we > load the x86-default environment after installing this target. > I did not see any problem with it, yet we should load corresponding > environment before installing a target. Reworded first

[dpdk-dev] [PATCH v2 0/2] net/mlx5: fixes for rx queue count calculation

2020-11-12 Thread Maxime Leroy
This patchset provides several bug fixes for rx queue count calculation for mlx5 driver. --- V2: * squash first patch and second patch * fix wrong init of used for compressed cqes Didier Pallard (1): net/mlx5: fix Rx descriptor status returned value Maxime Leroy (1): net/mlx5: fix Rx queue

[dpdk-dev] Eliminate config/rte_config.h?

2020-11-12 Thread David Harton (dharton)
Hi folks, Been experimenting with DPDK 20.11 and the loss of the old "config" hierarchy. I wonder if anyone considered eliminating config/rte_config.h in favor of a config/dpdk_conf that can contain the default values at the start of the file but can be overridden with values later in the f

[dpdk-dev] [PATCH v2 1/2] net/mlx5: fix Rx queue count calculation

2020-11-12 Thread Maxime Leroy
The commit d2d57605522d ("net/mlx5: fix Rx queue count calculation") is uncorrect because the count calculation is wrong for the next cqe: Example: Compressed Set of packets 1 | Compressed Set of packets 2 C | a | e0 | e1 | e2 | e3 | e4 | e5 | C | a | e0 There are 2 compressed set of packets

Re: [dpdk-dev] [PATCH] devtools/test-meson-builds: allow custom set of examples

2020-11-12 Thread Thomas Monjalon
09/11/2020 11:01, David Marchand: > On Tue, Oct 27, 2020 at 6:39 PM Bruce Richardson > wrote: > > > > To test the installation process of DPDK using "ninja install" > > test-meson-builds.sh builds a subset of the examples using "make". To allow > > more flexibility for people testing, allow the se

[dpdk-dev] [PATCH v2 2/2] net/mlx5: fix Rx descriptor status returned value

2020-11-12 Thread Maxime Leroy
From: Didier Pallard One entry may contain several segments, so 'used' must be multiplied by number of segments per entry to properly reflect the queue usage. Fixes: 8788fec1f269 ("net/mlx5: implement descriptor status API") Signed-off-by: Didier Pallard Signed-off-by: Maxime Leroy --- driver

Re: [dpdk-dev] [PATCH 1/4] Revert "net/mlx5: fix Rx queue count calculation"

2020-11-12 Thread Maxime Leroy
Hi Slava, On Wed, Nov 11, 2020 at 8:51 PM Slava Ovsiienko wrote: > > Hi, Maxime > > Thanks a lot for the patch. There is the comment for the entire series. > > [1]_ > > > > First issue, when there are more than 8 CQEs to uncompress, the computation > > done in this commit cannot work. Because

Re: [dpdk-dev] Eliminate config/rte_config.h?

2020-11-12 Thread Bruce Richardson
On Thu, Nov 12, 2020 at 03:39:10PM +, David Harton (dharton) wrote: > Hi folks, > > > > Been experimenting with DPDK 20.11 and the loss of the old "config" > hierarchy. > > > > I wonder if anyone considered eliminating config/rte_config.h in favor of > a config/dpdk_conf that can contain

Re: [dpdk-dev] [PATCH v4] examples/vhost: fix ioat dependency issue

2020-11-12 Thread Jiang, Cheng1
> -Original Message- > From: Bruce Richardson > Sent: Thursday, November 12, 2020 11:02 PM > To: Jiang, Cheng1 > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; > dev@dpdk.org; Fu, Patrick ; Yang, YvonneX > ; david.march...@redhat.com; Hu, Jiayu > > Subject: Re: [PATCH v4] examples/vhos

[dpdk-dev] [PATCH v5] examples/vhost: fix ioat dependency issue

2020-11-12 Thread Cheng Jiang
Fix vhost-switch compiling issue when ioat dependency is missing. Change 'RTE_x86' check into 'RTE_RAW_IOAT' check in meson build file. Use 'RTE_RAW_IOAT' to control conditional compiling in source file. Clean some codes. Fixes: abec60e7115d ("examples/vhost: support vhost async data path") Fixes:

Re: [dpdk-dev] [PATCH v5] examples/vhost: fix ioat dependency issue

2020-11-12 Thread Bruce Richardson
On Thu, Nov 12, 2020 at 03:49:02PM +, Cheng Jiang wrote: > Fix vhost-switch compiling issue when ioat dependency is missing. > Change 'RTE_x86' check into 'RTE_RAW_IOAT' check in meson build file. > Use 'RTE_RAW_IOAT' to control conditional compiling in source file. > Clean some codes. > > Fix

[dpdk-dev] [RFC PATCH] build: allow passing extra config header to build

2020-11-12 Thread Bruce Richardson
To allow per-build override of some settings, without having to change DPDK source-code files, i.e. rte_config.h, we can add an option to allow the user to pass in a file containing their own defines for the build. Signed-off-by: Bruce Richardson --- This is just a quick RFC to show what might be

Re: [dpdk-dev] Eliminate config/rte_config.h?

2020-11-12 Thread Bruce Richardson
On Thu, Nov 12, 2020 at 03:48:20PM +, Bruce Richardson wrote: > On Thu, Nov 12, 2020 at 03:39:10PM +, David Harton (dharton) wrote: > > Hi folks, > > > > > > > > Been experimenting with DPDK 20.11 and the loss of the old "config" > > hierarchy. > > > > > > > > I wonder if anyone consi

[dpdk-dev] [PATCH] doc: support IPsec Multi-buffer lib v0.55

2020-11-12 Thread Pablo de Lara
Updated AESNI MB and AESNI GCM PMD documentation guides with information about the latest Intel IPSec Multi-buffer library supported. Signed-off-by: Pablo de Lara --- doc/guides/cryptodevs/aesni_gcm.rst| 6 +++--- doc/guides/cryptodevs/aesni_mb.rst | 6 +++--- doc/guides/rel_notes/releas

Re: [dpdk-dev] [PATCH v1] eal/arm: fix clang build of native target

2020-11-12 Thread Jerin Jacob
On Thu, Nov 12, 2020 at 4:02 PM Ruifeng Wang wrote: > > When doing Clang build with '-mcpu=native' on N1 platform, build failed > with: > ../lib/librte_eal/arm/include/rte_atomic_64.h:76:39: > error: instruction requires: lse > __ATOMIC128_CAS_OP(__cas_128_release, "caspl") > > This is bec

[dpdk-dev] [PATCH 1/1] devtools: rename build test verbosity variables

2020-11-12 Thread Thomas Monjalon
For consistency with other variables which can be set from the env, TEST_MESON_BUILD_VERBOSE and TEST_MESON_BUILD_VERY_VERBOSE are renamed DPDK_BUILD_TEST_VERBOSE and DPDK_BUILD_TEST_VERY_VERBOSE. The handling of the verbosity level is also moved upper in the script, closer to other initialization

Re: [dpdk-dev] [PATCH 1/1] devtools: rename build test verbosity variables

2020-11-12 Thread Bruce Richardson
On Thu, Nov 12, 2020 at 05:39:01PM +0100, Thomas Monjalon wrote: > For consistency with other variables which can be set from the env, > TEST_MESON_BUILD_VERBOSE and TEST_MESON_BUILD_VERY_VERBOSE > are renamed > DPDK_BUILD_TEST_VERBOSE and DPDK_BUILD_TEST_VERY_VERBOSE. > > The handling of the verb

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd packets dump overlapping

2020-11-12 Thread Ferruh Yigit
On 11/12/2020 8:36 AM, Jiawei Wang wrote: When testpmd enabled the verbosity for the received packets, if two packets was received at the same time, for example, sampling packet and normal packet, the dump output of these packets may be overlapping due to multiple core handled the multiple queues

Re: [dpdk-dev] [PATCH v5] examples/vhost: fix ioat dependency issue

2020-11-12 Thread Maxime Coquelin
On 11/12/20 4:49 PM, Cheng Jiang wrote: > Fix vhost-switch compiling issue when ioat dependency is missing. > Change 'RTE_x86' check into 'RTE_RAW_IOAT' check in meson build file. > Use 'RTE_RAW_IOAT' to control conditional compiling in source file. > Clean some codes. > > Fixes: abec60e7115d (

Re: [dpdk-dev] [PATCH v2] examples/vhost: fix string split error handling issue

2020-11-12 Thread Maxime Coquelin
On 11/11/20 10:08 AM, Cheng Jiang wrote: > Add checking return value of string split function to fix the > coverity issue. > > Fixes: 3a04ecb21420 ("examples/vhost: add async vhost args parsing") > Coverity issue: 363739 > > Signed-off-by: Cheng Jiang > --- > v2: checked args_nr explicitly >

Re: [dpdk-dev] [PATCH v3 1/3] vhost: fix error path when setting memory tables

2020-11-12 Thread Maxime Coquelin
On 11/11/20 7:06 AM, Xueming(Steven) Li wrote: >> @@ -1012,16 +1018,13 @@ vhost_user_set_mem_table(struct virtio_net >> **pdev, struct VhostUserMsg *msg, >> if (memory->nregions > VHOST_MEMORY_MAX_NREGIONS) { >> VHOST_LOG_CONFIG(ERR, >> "too many memory reg

Re: [dpdk-dev] [PATCH v9 00/14] Arm build options rework

2020-11-12 Thread Jerin Jacob
On Wed, Nov 11, 2020 at 6:48 PM Juraj Linkeš wrote: > > The current way of specifying Arm configuration options is insufficient > since we can't identify the SoC we're building for from the MIDR > information. For example, we can't distinguish between N1SDP, Graviton2 > or Ampere Altra. > > Add a

[dpdk-dev] [PATCH] net/af_xdp: fix 32-bit build for older kernels

2020-11-12 Thread Ciara Loftus
'uint64_t' is used to hold pointers in multiple locations in the copy-mode code (used for kernels before 5.4). For a 32-bit build this assumption is wrong and results in build errors. This commit replaces such instances of 'uint64_t' with 'uintptr_t'. While the copy-mode code will now compile for

Re: [dpdk-dev] [PATCH v2 1/2] net/mlx5: fix Rx queue count calculation

2020-11-12 Thread Slava Ovsiienko
> -Original Message- > From: Maxime Leroy > Sent: Thursday, November 12, 2020 17:39 > To: Matan Azrad ; Shahaf Shuler ; > Slava Ovsiienko ; Alexander Kozyrev > > Cc: dev@dpdk.org; NBU-Contact-N?lio Laranjeiro > > Subject: [PATCH v2 1/2] net/mlx5: fix Rx queue count calculation > > The c

Re: [dpdk-dev] [PATCH v4 4/4] examples: skip installing unbuildable examples

2020-11-12 Thread Thomas Monjalon
12/11/2020 10:41, Bruce Richardson: > Rather than just installing all examples, we can use the build checks to > filter out any examples that are missing dependencies or are otherwise > unbuildable on the current system. > > Signed-off-by: Bruce Richardson This patch does not say why unbuildable

Re: [dpdk-dev] [PATCH v3 3/3] vhost: fix fd leak in kick setup

2020-11-12 Thread Maxime Coquelin
On 11/11/20 8:57 AM, Xia, Chenbo wrote: > Hi Xueming & Maxime, > >> -Original Message- >> From: Xueming(Steven) Li >> Sent: Wednesday, November 11, 2020 2:02 PM >> To: Maxime Coquelin ; dev@dpdk.org; Ding, Xuan >> ; step...@networkplumber.org; NBU-Contact-Thomas >> Monjalon ; sta...@dp

Re: [dpdk-dev] [PATCH v1] eal/arm: fix clang build of native target

2020-11-12 Thread Honnappa Nagarahalli
> > When doing Clang build with '-mcpu=native' on N1 platform, build failed > with: > ../lib/librte_eal/arm/include/rte_atomic_64.h:76:39: > error: instruction requires: lse > __ATOMIC128_CAS_OP(__cas_128_release, "caspl") > > This is because native detection for Neoverse N1 was added in

Re: [dpdk-dev] Eliminate config/rte_config.h?

2020-11-12 Thread David Harton (dharton)
> -Original Message- > From: Bruce Richardson > Sent: Thursday, November 12, 2020 11:33 AM > To: David Harton (dharton) > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] Eliminate config/rte_config.h? > > On Thu, Nov 12, 2020 at 03:48:20PM +, Bruce Richardson wrote: > > On Thu, Nov 12, 20

[dpdk-dev] [PATCH v4 0/3] vhost: fix fd an memory leaks

2020-11-12 Thread Maxime Coquelin
This series fixes several leaks in Vhost-user requests handling. Thanks to Xuan Ding from Intel for reporting these issues. Changes in v4: - Fix wrong return value in set_mem_table (Xueming) Changes in v3: - Remove the right closing of fds. (Chenbo) Changes in v2: - Fix typos in commit messages.

[dpdk-dev] [PATCH v4 1/3] vhost: fix error path when setting memory tables

2020-11-12 Thread Maxime Coquelin
If an error is encountered before the memory regions are parsed, the file descriptors for these shared buffers are leaked. This patch fixes this by closing the message file descriptors on error, taking care of avoiding double closing of the file descriptors. guest_pages is also freed, even though

[dpdk-dev] [PATCH v4 3/3] vhost: fix fd leak in kick setup

2020-11-12 Thread Maxime Coquelin
This patch fixes a file descriptor leak which happens in the error path of vhost_user_set_vring_kick(). Fixes: 4796ad63ba1f ("examples/vhost: import userspace vhost application") Cc: sta...@dpdk.org Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- lib/librte_vhost/vhost_user.c | 6 ++

[dpdk-dev] [PATCH v4 2/3] vhost: fix fd leak in dirty logging setup

2020-11-12 Thread Maxime Coquelin
This patch fixes a file descriptor leak which happens in the error path of vhost_user_set_log_base(). Fixes: 4796ad63ba1f ("examples/vhost: import userspace vhost application") Cc: sta...@dpdk.org Reported-by: Xuan Ding Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia Reviewed-by: Xuemin

[dpdk-dev] [PATCH] app/eventdev: fix segfault with incorrect timer adadpters

2020-11-12 Thread pbhagavatula
From: Pavan Nikhilesh Fix SEGFAULT when nb_timer_adapters command line parameter is set to 0. Fixes: 98c6292105d4 ("app/eventdev: add options for event timer adapter") Cc: sta...@dpdk.org Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/evt_options.c | 4 1 file changed, 4 insertions

Re: [dpdk-dev] [PATCH v5] examples/vhost: fix ioat dependency issue

2020-11-12 Thread David Marchand
On Thu, Nov 12, 2020 at 4:58 PM Cheng Jiang wrote: > > Fix vhost-switch compiling issue when ioat dependency is missing. > Change 'RTE_x86' check into 'RTE_RAW_IOAT' check in meson build file. > Use 'RTE_RAW_IOAT' to control conditional compiling in source file. > Clean some codes. > > Fixes: abec

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bnxt: fix incorrect assignment

2020-11-12 Thread Ferruh Yigit
On 11/12/2020 3:29 PM, Ajit Khaparde wrote: From: Mike Baucom Use comparison operator instead of incorrectly using the assignment operator. Coverity issue: 363566 Coverity issue: 363577 Fixes: 42c40f8902f7 ("net/bnxt: consolidate template table processing") Cc: sta...@dpdk.org Signed-off-by:

Re: [dpdk-dev] [PATCH v4 0/4] improve examples installation

2020-11-12 Thread Thomas Monjalon
12/11/2020 10:41, Bruce Richardson: > This patch improves the installation of the examples when "ninja install" is > run. It removes issues with the directory structure being flattened out, and > removes from the install list any examples that are not buildable with built > DPDK code. > > V4: resu

Re: [dpdk-dev] [dpdk-stable] [PATCH] devtools: fix directory filter in forbidden token check

2020-11-12 Thread Thomas Monjalon
10/11/2020 16:40, David Marchand: > checkpatches.sh current complains on a patch [1] adding > ALLOW_EXPERIMENTAL_API in an example while this check is for app, lib > and drivers directories: > > Warning in examples/ethtool/ethtool-app/Makefile: > Using experimental build flag for in-tree compilati

Re: [dpdk-dev] [PATCH v1] build: add Wformat to fix gcc compile error

2020-11-12 Thread Thomas Monjalon
12/11/2020 12:35, Conor Walsh: > On some systems Wformat-nonliteral and Wformat-security could not be > checked without Wformat also being specified. This patch adds Wformat > to config/meson.build > > Signed-off-by: Conor Walsh Please could you provide (in a v2) more informations about the erro

[dpdk-dev] [PATCH] net/bnxt: fix incorrect assignment

2020-11-12 Thread Ajit Khaparde
From: Mike Baucom Use comparison operator instead of incorrectly using the assignment operator. Coverity issue: 363566 Coverity issue: 363577 Fixes: 42c40f8902f7 ("net/bnxt: consolidate template table processing") Cc: sta...@dpdk.org Signed-off-by: Mike Baucom Reviewed-by: Ajit Khaparde ---

  1   2   >