[dpdk-dev] [PATCH v2 0/2] Support PTP for hns3 PMD

2021-03-31 Thread Min Hu (Connor)
This set includes two patches, one patch is to fix cyclomatic complexity, the other patch is to support PTP, but depends on the first patch. So the two forms one set of patches. Min Hu (Connor) (2): net/hns3: fix code check warning net/hns3: support IEEE 1588 PTP doc/guides/nics/features/hns

[dpdk-dev] [PATCH v2 1/2] net/hns3: fix code check warning

2021-03-31 Thread Min Hu (Connor)
This patch fixed cyclomatic complexity about MTU in device configure process. Fixes: 1f5ca0b460cd ("net/hns3: support some device operations") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethdev.c | 61 +- 1 file changed, 3

[dpdk-dev] [PATCH v2 2/2] net/hns3: support IEEE 1588 PTP

2021-03-31 Thread Min Hu (Connor)
Add hns3 support for new ethdev APIs to enable and read IEEE1588/ 802.1AS PTP timestamps. Signed-off-by: Min Hu (Connor) --- doc/guides/nics/features/hns3.ini | 2 + doc/guides/nics/hns3.rst | 1 + doc/guides/rel_notes/release_21_05.rst | 1 + drivers/net/hns3/hns3_cmd.h

[dpdk-dev] [PATCH] mbuf: Fix illegal pointer access to mempool members

2021-03-31 Thread Wenwu Ma
Before accessing the private data of mempool in function rte_pktmbuf_priv_size() and rte_pktmbuf_data_room_size(), it is necessary to determine whether the private data exists, otherwise it will cause heap-buffer-overflow. Signed-off-by: Wenwu Ma --- lib/librte_mbuf/rte_mbuf.h | 6 ++ 1 file

Re: [dpdk-dev] [PATCH] mbuf: Fix illegal pointer access to mempool members

2021-03-31 Thread Jerin Jacob
On Wed, Mar 31, 2021 at 7:19 AM Wenwu Ma wrote: > > Before accessing the private data of mempool in > function rte_pktmbuf_priv_size() and rte_pktmbuf_data_room_size(), > it is necessary to determine whether the private data exists, > otherwise it will cause null pointer access. > > Signed-off-by:

Re: [dpdk-dev] [PATCH v5 0/9] net/mlx5: support SubFunction representor

2021-03-31 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Xueming Li > Sent: Sunday, March 28, 2021 4:48 PM > To: Slava Ovsiienko > Cc: dev@dpdk.org; Xueming(Steven) Li ; Asaf Penso > > Subject: [dpdk-dev] [PATCH v5 0/9] net/mlx5: support SubFunction > representor > > SubFunction [1] is a port

Re: [dpdk-dev] [PATCH] doc: update recommended matching list for i40e

2021-03-31 Thread Xing, Beilei
> -Original Message- > From: Zhang, RobinX > Sent: Tuesday, March 30, 2021 4:44 PM > To: Xing, Beilei ; Guo, Jia > Cc: dev@dpdk.org; Yang, Qiming ; Yang, SteveX > ; Zhang, RobinX > Subject: [PATCH] doc: update recommended matching list for i40e > > As kernel driver 2.13.10 is removed

Re: [dpdk-dev] [PATCH v5 0/9] net/mlx5: support SubFunction representor

2021-03-31 Thread Xueming(Steven) Li
Thanks! >-Original Message- >From: Raslan Darawsheh >Sent: Wednesday, March 31, 2021 3:21 PM >To: Xueming(Steven) Li ; Slava Ovsiienko > >Cc: dev@dpdk.org; Xueming(Steven) Li ; Asaf Penso > >Subject: RE: [dpdk-dev] [PATCH v5 0/9] net/mlx5: support SubFunction >representor > >Hi, > >> -

Re: [dpdk-dev] [PATCH 2/2] net/hns3: support IEEE 1588 PTP

2021-03-31 Thread Thomas Monjalon
31/03/2021 04:35, Min Hu (Connor): > 在 2021/3/30 21:59, Ferruh Yigit 写道: > > On 3/26/2021 8:56 AM, Min Hu (Connor) wrote: > >> Add hns3 support for new ethdev APIs to enable and read IEEE1588/ > >> 802.1AS PTP timestamps. > >> > >> Signed-off-by: Min Hu (Connor) > >> --- a/drivers/net/hns3/hns3_cm

[dpdk-dev] [PATCH 00/13] Add ASO meter support in MLX5 PMD

2021-03-31 Thread Li Zhang
To support more meters and better performance, MLX HW provide ASO flow meter. It can expose millions of ASO flow meter context's in HW. This ASO object can allocate the large bulk meter objects. This patch set implement the ASO flow meter for mlx5 driver. MLX5 PMD driver will be responsible for ASO

[dpdk-dev] [PATCH 01/13] net/mlx5: support three level table walk

2021-03-31 Thread Li Zhang
From: Suanming Mou This commit adds table entry walk for the three level table. Signed-off-by: Suanming Mou --- drivers/net/mlx5/mlx5_utils.h | 90 +++ 1 file changed, 90 insertions(+) diff --git a/drivers/net/mlx5/mlx5_utils.h b/drivers/net/mlx5/mlx5_utils.h i

[dpdk-dev] [PATCH 04/13] net/mlx5: use mask for meter register setting

2021-03-31 Thread Li Zhang
From: Shun Hao ASO meter feature may require to locate the flow context tag action after the ASO action. When color register is shared by meter_id/flow_id, it's like: Bits[0-7] A meter color value set by the HW. Bits[8-31] A flow id and meter id set by SW. Currently the tag action for meter writ

[dpdk-dev] [PATCH 05/13] common/mlx5: add definitions for ASO flow meter

2021-03-31 Thread Li Zhang
This patch adds different PRM definitions, related to ASO flow meter feature, in MLX5 PMD code. Signed-off-by: Li Zhang --- drivers/common/mlx5/mlx5_prm.h | 75 -- 1 file changed, 71 insertions(+), 4 deletions(-) diff --git a/drivers/common/mlx5/mlx5_prm.h b/driv

[dpdk-dev] [PATCH 06/13] common/mlx5: add read ASO flow meter HCA capability

2021-03-31 Thread Li Zhang
Read and store the device capability of FLOW_METER_ASO general object, using the DevX API. Signed-off-by: Li Zhang --- drivers/common/mlx5/mlx5_devx_cmds.c | 14 ++ drivers/common/mlx5/mlx5_devx_cmds.h | 8 2 files changed, 22 insertions(+) diff --git a/drivers/common/mlx5

[dpdk-dev] [PATCH 07/13] common/mlx5: add DevX API to create ASO flow meter object

2021-03-31 Thread Li Zhang
Add DevX API to create ASO flow meter object. Signed-off-by: Li Zhang --- drivers/common/mlx5/mlx5_devx_cmds.c | 54 drivers/common/mlx5/mlx5_devx_cmds.h | 18 +- drivers/common/mlx5/version.map | 1 + 3 files changed, 72 insertions(+), 1 deletion(-) d

[dpdk-dev] [PATCH 10/13] net/mlx5: aso flow meter send WQE and CQE handle

2021-03-31 Thread Li Zhang
ASO flow meter send WQE and CQE handle functions Signed-off-by: Li Zhang --- drivers/net/mlx5/mlx5.h| 4 + drivers/net/mlx5/mlx5_flow_aso.c | 182 + drivers/net/mlx5/mlx5_flow_meter.c | 143 ++- 3 files changed, 274 insertions(+), 5

[dpdk-dev] [PATCH 11/13] net/mlx5: add support of ASO meter action

2021-03-31 Thread Li Zhang
When ASO action is available, use it as the meter action Signed-off-by: Shun Hao Signed-off-by: Li Zhang --- drivers/net/mlx5/linux/mlx5_os.c | 7 ++- drivers/net/mlx5/mlx5.c| 8 +++ drivers/net/mlx5/mlx5.h| 7 ++- drivers/net/mlx5/mlx5_flow.c | 69 +++

[dpdk-dev] [PATCH 09/13] net/mlx5: init/uninit flow meter queue for WQE

2021-03-31 Thread Li Zhang
Init/uninit flow meter SQ for WQE Signed-off-by: Li Zhang --- drivers/net/mlx5/linux/mlx5_os.c | 17 drivers/net/mlx5/meson.build | 2 +- drivers/net/mlx5/mlx5.c | 78 ++- drivers/net/mlx5/mlx5.h | 22 +++

[dpdk-dev] [PATCH 13/13] net/mlx5: allow multiple flow tables on the same level

2021-03-31 Thread Li Zhang
The driver devices support creation of multiple flow tables. Jump action can be used in order to move the packet steering to different flow table. Table 0 is always the root table for packet steering. Jumping between tables may cause endless loops in steering mechanism, that's why each table has l

[dpdk-dev] [PATCH 08/13] net/mlx5: flow meter pool to manage meter object

2021-03-31 Thread Li Zhang
Add ASO flow meter pool to manage meter object Signed-off-by: Li Zhang --- drivers/net/mlx5/mlx5.c| 2 +- drivers/net/mlx5/mlx5.h| 207 - drivers/net/mlx5/mlx5_flow.c | 70 - drivers/net/mlx5/mlx5_flow.h | 196 +++-- drivers/net/mlx5

[dpdk-dev] [PATCH 02/13] net/mlx5: fix meter statistics

2021-03-31 Thread Li Zhang
From: Shun Hao This fixes the meter statistics issue that when using multiple meters, only one meter has stats value. To match the correct meter in policer table, now the meter_id is also used in its match criteria, so only one color and one drop matcher are needed. And both meter_id and flow_id

[dpdk-dev] [PATCH 12/13] net/mlx5: make ASO meter queue thread-safe

2021-03-31 Thread Li Zhang
Synchronize ASO meter queue accesses from different threads using a spinlock. Signed-off-by: Li Zhang --- drivers/net/mlx5/mlx5.h | 1 + drivers/net/mlx5/mlx5_flow_aso.c | 16 +--- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/net/mlx5/mlx5.h b/dri

[dpdk-dev] [PATCH v4 0/4] regex/mlx5: support scattered mbuf

2021-03-31 Thread Suanming Mou
The scattered mbuf was not supported in mlx5 RegEx driver. This patch set adds the support of scattered mbuf by UMR WQE. UMR(User-Mode Memory Registration) WQE can present data buffers scattered within multiple mbufs with single indirect mkey. Take advantage of the UMR WQE, scattered mbuf in one o

[dpdk-dev] [PATCH v4 1/4] common/mlx5: add user memory registration bits

2021-03-31 Thread Suanming Mou
This commit adds the UMR capability bits. Signed-off-by: Suanming Mou Acked-by: Ori Kam --- drivers/common/mlx5/linux/meson.build | 2 ++ drivers/common/mlx5/mlx5_devx_cmds.c | 5 + drivers/common/mlx5/mlx5_devx_cmds.h | 3 +++ 3 files changed, 10 insertions(+) diff --git a/drivers/commo

[dpdk-dev] [PATCH v4 3/4] app/test-regex: support scattered mbuf input

2021-03-31 Thread Suanming Mou
This commits adds the scattered mbuf input support. Signed-off-by: Suanming Mou Acked-by: Ori Kam --- app/test-regex/main.c | 134 +++-- doc/guides/tools/testregex.rst | 3 + 2 files changed, 112 insertions(+), 25 deletions(-) diff --git a/app/test-regex/

[dpdk-dev] [PATCH v4 2/4] regex/mlx5: add data path scattered mbuf process

2021-03-31 Thread Suanming Mou
UMR(User-Mode Memory Registration) WQE can present data buffers scattered within multiple mbufs with single indirect mkey. Take advantage of the UMR WQE, scattered mbuf in one operation can be presented to an indirect mkey. The RegEx which only accepts one mkey can now process the whole scattered m

[dpdk-dev] [PATCH v4 4/4] regex/mlx5: prevent wrong calculation of free sqs in umr mode

2021-03-31 Thread Suanming Mou
From: John Hurley A recent change adds support for scattered mbuf and UMR support for regex. Part of this commit makes the pi and ci counters of the regex_sq a quarter of the length in non umr mode, effectively moving them from 16 bits to 14. The new get_free method casts the difference in pi and

Re: [dpdk-dev] [PATCH v5 7/9] net/mlx5: fix setting VF default MAC through representor

2021-03-31 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Xueming Li > Sent: Sunday, March 28, 2021 4:48 PM > To: Slava Ovsiienko > Cc: dev@dpdk.org; Xueming(Steven) Li ; Asaf Penso > ; Matan Azrad ; Shahaf Shuler > > Subject: [dpdk-dev] [PATCH v5 7/9] net/mlx5: fix setting VF default MAC > thr

Re: [dpdk-dev] [PATCH 1/3] vhost: fix split ring potential buffer overflow

2021-03-31 Thread Xia, Chenbo
> -Original Message- > From: Liu, Yong > Sent: Wednesday, March 31, 2021 2:50 PM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Liu, Yong ; sta...@dpdk.org > Subject: [PATCH 1/3] vhost: fix split ring potential buffer overflow > > In vhost datapath, descriptor's length

Re: [dpdk-dev] [PATCH v5 09/10] eal: add EAL argument for setting thread priority

2021-03-31 Thread Tal Shnaiderman
> Subject: Re: [dpdk-dev] [PATCH v5 09/10] eal: add EAL argument for setting > thread priority > > External email: Use caution opening links or attachments > > > On Mon, 29 Mar 2021 15:40:39 -0700 > Narcisa Ana Maria Vasile wrote: > > > From: Narcisa Vasile > > > > Allow the user to choose th

Re: [dpdk-dev] [PATCH v3 0/5] eal: enable global device syntax by default

2021-03-31 Thread Gaëtan Rivet
On Tue, Mar 30, 2021, at 14:15, Xueming Li wrote: > The new Global Device Syntax [1] is used to identify a device with full > bus, class and driver description, example: > -a bus=pci,addr=82:00.0/class=eth/driver=mlx5,... > > This patchset fixes bugs and enable global device syntax with > backwar

Re: [dpdk-dev] [PATCH] examples/vhost_crypto: remove unused short option

2021-03-31 Thread Xia, Chenbo
> -Original Message- > From: Ibtisam Tariq > Sent: Thursday, February 4, 2021 4:06 PM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Ibtisam Tariq ; Zhang, Roy Fan > > Subject: [PATCH] examples/vhost_crypto: remove unused short option > > Short option "s" was passed t

Re: [dpdk-dev] [PATCH v16 1/3] build: disable/enable drivers in Arm builds

2021-03-31 Thread Juraj Linkeš
> -Original Message- > From: Honnappa Nagarahalli > Sent: Tuesday, March 30, 2021 2:39 AM > To: Jerin Jacob ; Juraj Linkeš > > Cc: Bruce Richardson ; Ruifeng Wang > ; vcchu...@amazon.com; Dharmik Thakkar > ; hemant.agra...@nxp.com; Ajit Khaparde > (ajit.khapa...@broadcom.com) ; > ferruh

Re: [dpdk-dev] [PATCH 21.05] net/virtio: remove duplicate port id from virtio_user

2021-03-31 Thread Xia, Chenbo
> -Original Message- > From: David Marchand > Sent: Tuesday, February 2, 2021 1:46 AM > To: dev@dpdk.org > Cc: Maxime Coquelin ; Xia, Chenbo > > Subject: [PATCH 21.05] net/virtio: remove duplicate port id from virtio_user > > The private virtio_user_dev structure embeds a virtio_hw which

Re: [dpdk-dev] [dpdk-stable] [PATCH] vdpa/mlx5: fix virtq cleaning

2021-03-31 Thread Xia, Chenbo
> -Original Message- > From: stable On Behalf Of Matan Azrad > Sent: Monday, March 1, 2021 6:42 PM > To: dev@dpdk.org > Cc: Maxime Coquelin ; sta...@dpdk.org > Subject: [dpdk-stable] [PATCH] vdpa/mlx5: fix virtq cleaning > > The HW virtq object can be destroyed ether when the device is cl

[dpdk-dev] [PATCH v2] doc: add sampling and mirroring in testpmd guide

2021-03-31 Thread Jiawei Wang
Update documentation for sample action usage in testpmd and show the command line example. Signed-off-by: Jiawei Wang Acked-by: Viacheslav Ovsiienko --- v2: * Update the description. --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 63 + 1 file changed, 63 insertion

Re: [dpdk-dev] Minutes of Technical Board Meeting, 2021-03-10

2021-03-31 Thread Tom Barbette
Le 31-03-21 à 02:44, Honnappa Nagarahalli a écrit : - Ability to tune the values of #defines * Few prominent points discussed - This will result in #ifdefs in the code (for ex: in testpmd) - One option is for all the PMDs to document their configurable #defines in PMD

[dpdk-dev] [PATCH 1/2] ethdev: add packet mode in meter profile structure

2021-03-31 Thread Li Zhang
Currently meter algorithms only supports rate is bytes per second(BPS). Add packet_mode flag in meter profile parameters data structure. So that it can meter traffic by packet per second. When packet_mode is 0, the profile rates and bucket sizes are specified in bytes per second and bytes when pac

[dpdk-dev] [PATCH 0/2] Support PPS(packet per second) on meter

2021-03-31 Thread Li Zhang
Currently meter algorithms only supports rate is bytes per second(BPS). Add packet_mode flag in meter profile parameters data structure. So that it can meter traffic by packet per second. When packet_mode is 0, the profile rates and bucket sizes are specified in bytes per second and bytes when pac

[dpdk-dev] [PATCH 2/2] app/testpmd: add meter profile packet mode option

2021-03-31 Thread Li Zhang
add meter profile packet_mode to the ethernet device. One example: add port meter profile rfc2697 (port_id) (profile_id) (cir) (cbs) (ebs) (packet_mode) Signed-off-by: Li Zhang --- app/test-pmd/cmdline_mtr.c | 40 +++-- doc/guides/testpmd_app_ug/testpmd_funcs.rst

[dpdk-dev] [PATCH v2] build: optional NUMA and cpu counts detection

2021-03-31 Thread Juraj Linkeš
Add an option to automatically discover the host's numa and cpu counts and use those values for a non cross-build. Give users the option to override the per-arch default values or values from cross files by specifying them on the command line with -Dmax_lcores and -Dmax_numa_nodes. Signed-off-by:

Re: [dpdk-dev] [PATCH v16 1/3] build: disable/enable drivers in Arm builds

2021-03-31 Thread Bruce Richardson
On Wed, Mar 31, 2021 at 08:39:57AM +, Juraj Linkeš wrote: > > > > -Original Message- > > From: Honnappa Nagarahalli > > Sent: Tuesday, March 30, 2021 2:39 AM > > To: Jerin Jacob ; Juraj Linkeš > > > > Cc: Bruce Richardson ; Ruifeng Wang > > ; vcchu...@amazon.com; Dharmik Thakkar > >

[dpdk-dev] [PATCH] test/mempool: Fix illegal pointer access in mempool test

2021-03-31 Thread Wenwu Ma
The value of parameter private_data_size of function rte_mempool_create() called in test_mempool() should not be 0, Otherwise, the function rte_pktmbuf_priv_size() called in rte_pktmbuf_init() will cause heap-buffer-overflow. Signed-off-by: Wenwu Ma --- app/test/test_mempool.c | 3 ++- 1 file ch

Re: [dpdk-dev] [PATCH 2/6] net/hns3: fix compiling error for using SVE algorithm

2021-03-31 Thread Ferruh Yigit
On 3/31/2021 1:55 AM, Min Hu (Connor) wrote: 在 2021/3/30 0:10, Ferruh Yigit 写道: On 3/23/2021 1:45 PM, Min Hu (Connor) wrote: From: Huisong Li The 'queue_full_cnt' stats have been encapsulated in 'dfx_stats'. However, the modification in the SVE algorithm is omitted. As a result, the driver

Re: [dpdk-dev] [PATCH v16 1/3] build: disable/enable drivers in Arm builds

2021-03-31 Thread Juraj Linkeš
> -Original Message- > From: Bruce Richardson > Sent: Wednesday, March 31, 2021 11:08 AM > To: Juraj Linkeš > Cc: Honnappa Nagarahalli ; Jerin Jacob > ; Ruifeng Wang ; > vcchu...@amazon.com; Dharmik Thakkar ; > hemant.agra...@nxp.com; Ajit Khaparde (ajit.khapa...@broadcom.com) > ; ferru

[dpdk-dev] [PATCH] net/i40e: add Tx preparation for vector data path

2021-03-31 Thread Leyi Rong
Fill up dev->tx_pkt_prepare to i40e_pkt_prepare when on vector and simple data path selection, as the sanity check is needed ideally. Signed-off-by: Leyi Rong --- drivers/net/i40e/i40e_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_rxtx.c b/drive

[dpdk-dev] [PATCH 0/2] Support meter PPS(packet per second) in MLX5 PMD

2021-03-31 Thread Li Zhang
Currently meter algorithms only supports rate is bytes per second(BPS). Add packet_mode flag in meter profile parameters data structure. So that it can meter traffic by packet per second. Depends-on: series=16002 ("Support PPS(packet per second) on meter") https://patchwork.dpdk.org/project/dpdk/

[dpdk-dev] [PATCH 1/2] common/mlx5: add meter mode definition in PRM file

2021-03-31 Thread Li Zhang
Add meter mode definition in PRM file Signed-off-by: Li Zhang --- drivers/common/mlx5/mlx5_prm.h | 8 1 file changed, 8 insertions(+) diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx5/mlx5_prm.h index 6d6c7f38bb..0bfa607e31 100644 --- a/drivers/common/mlx5/mlx5_prm.h ++

[dpdk-dev] [PATCH 2/2] net/mlx5: support meter PPS profile

2021-03-31 Thread Li Zhang
Currently meter algorithms only supports bytes per second(BPS). Such as Single Rate Three Color Marker (srTCM rfc2697) Add packet_mode flag to support rate is packet per second. So that it can meter traffic by packet per second (PPS). Signed-off-by: Li Zhang --- doc/guides/nics/mlx5.rst

Re: [dpdk-dev] [PATCH 2/2] net/hns3: support IEEE 1588 PTP

2021-03-31 Thread Ferruh Yigit
On 3/31/2021 8:28 AM, Thomas Monjalon wrote: 31/03/2021 04:35, Min Hu (Connor): 在 2021/3/30 21:59, Ferruh Yigit 写道: On 3/26/2021 8:56 AM, Min Hu (Connor) wrote: Add hns3 support for new ethdev APIs to enable and read IEEE1588/ 802.1AS PTP timestamps. Signed-off-by: Min Hu (Connor) --- a/driv

[dpdk-dev] [PATCH v10 0/8] Introduce event vectorization

2021-03-31 Thread pbhagavatula
From: Pavan Nikhilesh In traditional event programming model, events are identified by a flow-id and a uintptr_t. The flow-id uniquely identifies a given event and determines the order of scheduling based on schedule type, the uintptr_t holds a single object. Event devices also support burst mod

[dpdk-dev] [PATCH v10 1/8] eventdev: introduce event vector capability

2021-03-31 Thread pbhagavatula
From: Pavan Nikhilesh Introduce rte_event_vector datastructure which is capable of holding multiple uintptr_t of the same flow thereby allowing applications to vectorize their pipeline and reducing the complexity of pipelining the events across multiple stages. This approach also reduces the sche

[dpdk-dev] [PATCH v10 2/8] eventdev: introduce event vector Rx capability

2021-03-31 Thread pbhagavatula
From: Pavan Nikhilesh Introduce event ethernet Rx adapter event vector capability. If an event eth Rx adapter has the capability of RTE_EVENT_ETH_RX_ADAPTER_CAP_EVENT_VECTOR then a given Rx queue can be configured to enable event vectorization by passing the flag RTE_EVENT_ETH_RX_ADAPTER_QUEUE_E

[dpdk-dev] [PATCH v10 3/8] eventdev: introduce event vector Tx capability

2021-03-31 Thread pbhagavatula
From: Pavan Nikhilesh Introduce event vector transmit capability for event eth tx adapter. The capability indicates that the Tx adapter is capable of transmitting event vectors. When rte_event_vector::union_valid is set, the Tx adapter should transmit all the packets to the rte_event_vector::por

[dpdk-dev] [PATCH v10 4/8] eventdev: add Rx adapter event vector support

2021-03-31 Thread pbhagavatula
From: Pavan Nikhilesh Add event vector support for event eth Rx adapter, the implementation creates vector flows based on port and queue identifier of the received mbufs. The flow id for SW Rx event vectorization will use 12-bits of queue identifier and 8-bits port identifier when custom flow id

[dpdk-dev] [PATCH v10 6/8] app/eventdev: add event vector mode in pipeline test

2021-03-31 Thread pbhagavatula
From: Pavan Nikhilesh Add event vector support in pipeline tests. By default this mode is disabled, it can be enabled by using the option --enable_vector. example: dpdk-test-eventdev -l 7-23 -s 0xff00 -- --prod_type_ethdev --nb_pkts=0 --verbose 2 --test=pipeline_atq --stlist=a

[dpdk-dev] [PATCH v10 5/8] eventdev: add Tx adapter event vector support

2021-03-31 Thread pbhagavatula
From: Pavan Nikhilesh Add event vector support for event eth Tx adapter, the implementation receives events from the single linked queue and based on rte_event_vector::attr_valid transmits the vector of mbufs to a given port, queue pair. Signed-off-by: Pavan Nikhilesh Acked-by: Jay Jayatheertha

[dpdk-dev] [PATCH v10 7/8] doc: announce event Rx adapter config changes

2021-03-31 Thread pbhagavatula
From: Pavan Nikhilesh The Rx adapter event vector configuration will be merged into Rx adapter queue configuration to simplify enabling event vectorization. Signed-off-by: Pavan Nikhilesh Acked-by: Ray Kinsella Acked-by: Jerin Jacob Acked-by: Jay Jayatheerthan --- doc/guides/rel_notes/depre

[dpdk-dev] [dpdk-dev v21.11] [PATCH v10 8/8] eventdev: simplify Rx adapter event vector config

2021-03-31 Thread pbhagavatula
From: Pavan Nikhilesh Include vector configuration into the structure ``rte_event_eth_rx_adapter_queue_conf`` used when configuring rest of the Rx adapter ethernet device Rx queue parameters. This simplifies event vector configuration as it avoids splitting configuration per Rx queue. Signed-off

Re: [dpdk-dev] [PATCH] doc: add sampling and mirroring in testpmd guide

2021-03-31 Thread Ferruh Yigit
On 3/31/2021 7:38 AM, Jiawei(Jonny) Wang wrote: Hi Ferruh, -Original Message- From: Ferruh Yigit Sent: Friday, March 26, 2021 1:11 AM To: Jiawei(Jonny) Wang ; Slava Ovsiienko ; xiaoyun...@intel.com; Ori Kam Cc: dev@dpdk.org; Andrew Rybchenko ; NBU- Contact-Thomas Monjalon Subject: Re

[dpdk-dev] [PATCH v6 0/8] ether: refine debug build option

2021-03-31 Thread Qi Zhang
PMDs use RTE_LIBRTE__DEBUG_RX|TX as build option to wrap data path debug code. As .config has been removed since the meson build, It is not friendly for new DPDK users to notice those debug options. Patch 1/8: introduces new compile options for data path debug in ether layer, PMD can choose to reu

[dpdk-dev] [PATCH v6 1/8] ether: refine debug build option

2021-03-31 Thread Qi Zhang
PMDs use RTE_LIBRTE__DEBUG_RX|TX as build option to wrap data path debug code. As .config has been removed since the meson build, It is not friendly for new DPDK users to notice those debug options. The patch introduces below build options for data path debug, so PMD can choose to reuse them to av

[dpdk-dev] [PATCH v6 2/8] net/fm10k: refine debug build option

2021-03-31 Thread Qi Zhang
1. replace RTE_LIBRTE_FM10K_DEBUG_RX with RTE_ETHDEV_DEBUG_RX. 2. replace RTE_LIBRTE_FM10K_DEBUG_TX whth RTE_ETHDEV_DEBUG_TX. 3. merge RTE_LIBRTE_FM10K_DEBUG_TX_FREE and RTE_LIBRTE_ETHDEV_DEBUG into RTE_ETHDEV_DEBUG_TX Signed-off-by: Qi Zhang --- drivers/net/fm10k/fm10k_ethdev.c | 7 ++-

[dpdk-dev] [PATCH v6 3/8] net/e1000: refine debug build option

2021-03-31 Thread Qi Zhang
1. replace RTE_LIBRTE_E1000_DEBUG_RX with RTE_ETHDEV_DEBUG_RX. 2. replace RTE_LIBRTE_E1000_DEBUG_TX whth RTE_ETHDEV_DEBUG_TX. 3. merge RTE_LIBRTE_E1000_DEBUG_TX_FREE and RTE_LIBRTE_ETHDEV_DEBUG into RTE_ETHDEV_DEBUG_TX Signed-off-by: Qi Zhang --- drivers/net/e1000/e1000_logs.c | 17 --

[dpdk-dev] [PATCH v6 4/8] net/i40e: refine debug build option

2021-03-31 Thread Qi Zhang
1. replace RTE_LIBRTE_I40E_DEBUG_RX with RTE_ETHDEV_DEBUG_RX. 2. replace RTE_LIBRTE_I40E_DEBUG_TX whth RTE_ETHDEV_DEBUG_TX. 3. merge RTE_LIBRTE_I40E_DEBUG_TX_FREE and RTE_LIBRTE_ETHDEV_DEBUG into RTE_ETHDEV_DEBUG_TX Signed-off-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c | 7 ++- driv

[dpdk-dev] [PATCH v6 5/8] net/iavf: refine debug build option

2021-03-31 Thread Qi Zhang
1. replace RTE_LIBRTE_IAVF_DEBUG_RX with RTE_ETHDEV_DEBUG_RX. 2. replace RTE_LIBRTE_IAVF_DEBUG_TX whth RTE_ETHDEV_DEBUG_TX. 3. merge RTE_LIBRTE_IAVF_DEBUG_TX_FREE and RTE_LIBRTE_ETHDEV_DEBUG into RTE_ETHDEV_DEBUG_TX Signed-off-by: Qi Zhang --- drivers/net/iavf/iavf_ethdev.c | 7 ++- driv

[dpdk-dev] [PATCH v6 6/8] net/ice: refine debug build option

2021-03-31 Thread Qi Zhang
1. replace RTE_LIBRTE_ICE_DEBUG_RX with RTE_ETHDEV_DEBUG_RX. 2. replace RTE_LIBRTE_ICE_DEBUG_TX whth RTE_ETHDEV_DEBUG_TX. 3. merge RTE_LIBRTE_ICE_DEBUG_TX_FREE and RTE_LIBRTE_ETHDEV_DEBUG into RTE_LIBRTE_DEBUG_TX Signed-off-by: Qi Zhang --- drivers/net/ice/ice_ethdev.c | 7 ++- drivers/n

[dpdk-dev] [PATCH v6 7/8] net/ixgbe: refine debug build option

2021-03-31 Thread Qi Zhang
1. replace RTE_LIBRTE_IXGBE_DEBUG_RX with RTE_ETHDEV_DEBUG_RX. 2. replace RTE_LIBRTE_IXGBE_DEBUG_TX whth RTE_ETHDEV_DEBUG_TX. 3. merge RTE_LIBRTE_IXGBE_DEBUG_TX_FREE and RTE_LIBRTE_ETHDEV_DEBUG into RTE_ETHDEV_DEBUG_TX Signed-off-by: Qi Zhang --- drivers/net/ixgbe/ixgbe_ethdev.c | 7 +--- dr

[dpdk-dev] [PATCH v6 8/8] net/igc: refine debug build option

2021-03-31 Thread Qi Zhang
1. replace RTE_LIBRTE_IGC_DEBUG_RX with RTE_ETHDEV_DEBUG_RX. 2. replace RTE_LIBRTE_IGC_DEBUG_TX whth RTE_ETHDEV_DEBUG_TX. 3. merge RTE_LIBRTE_ETHDEV_DEBUG into RTE_ETHDEV_DEBUG_TX Signed-off-by: Qi Zhang --- drivers/net/e1000/e1000_logs.c | 1 + drivers/net/igc/igc_logs.h | 4 ++-- drivers/n

[dpdk-dev] [PATCH 04/10] net/hns3: fix lack of rollback after setting PVID failed

2021-03-31 Thread Min Hu (Connor)
From: Chengchang Tang Currently, three hardware operations are involved in setting the PVID. If any operation fails, a failure will be returned. And there may be residual hardware configurations because no rollback is performed. This patch adds rollback operation for setting PVID to avoid residu

[dpdk-dev] [PATCH 09/10] net/hns3: delete redundant blank line

2021-03-31 Thread Min Hu (Connor)
From: Hongbo Zheng Delete redundant blank line in "hns3vf_check_event_cause" to solve the static warning. Fixes: a5475d61fa34 ("net/hns3: support VF") Signed-off-by: Hongbo Zheng Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethdev_vf.c | 1 - 1 file changed, 1 deletion(-) diff -

[dpdk-dev] [PATCH 08/10] net/hns3: support get device version when dump register

2021-03-31 Thread Min Hu (Connor)
From: Chengwen Feng Support get device version which is equal to the firmware version when dump register. Fixes: 936eda25e8da ("net/hns3: support dump register") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_regs.c | 2 ++ 1 file ch

[dpdk-dev] [PATCH 00/10] some bugfixes for hns3 PMD

2021-03-31 Thread Min Hu (Connor)
This set of patches are bugfixes for hns3 PMD. Chengchang Tang (1): net/hns3: fix lack of rollback after setting PVID failed Chengwen Feng (4): net/hns3: fix set default MAC addr fail in bonding of VF net/hns3: fix flow counter not cleared when create net/hns3: fix VF mailbox head field w

[dpdk-dev] [PATCH 05/10] net/hns3: fix flow control exception

2021-03-31 Thread Min Hu (Connor)
From: Huisong Li In multi-TC scenarios, MAC pause is not supported. Otherwise, only TC0 can trigger pause frames, and other TCs cannot trigger pause frames. In this case, flow control does not meet the expectation. Fixes: 62e3ccc2b94c ("net/hns3: support flow control") Cc: sta...@dpdk.org Signe

[dpdk-dev] [PATCH 07/10] net/hns3: fix VF mailbox head field wrong update

2021-03-31 Thread Min Hu (Connor)
From: Chengwen Feng Currently, the VF mailbox synchronization communication is based on three fields: head/tail/lost, when head equals tail plus lost, it means the response is received successfully. The head field indicates the number of requests that are successfully sent. If the request sendin

[dpdk-dev] [PATCH 03/10] net/hns3: fix the FLR miss detection

2021-03-31 Thread Min Hu (Connor)
From: Hongbo Zheng When FLR occurs, the head pointer register of the command queue will be cleared, resulting in abnormal detection of the head pointer register of the command queue. At present, FLR is detected in this way, and the reset recovery process is executed. However, when FLR occurs, th

[dpdk-dev] [PATCH 01/10] net/hns3: fix some function names for copper media type

2021-03-31 Thread Min Hu (Connor)
From: Huisong Li PHY is a common concept for the copper and optical media type interface. There are some inappropriate function names for copper ports, which needs to be adjusted. Fixes: 2e4859f3b362 ("net/hns3: support PF device with copper PHYs") Signed-off-by: Huisong Li Signed-off-by: Min

[dpdk-dev] [PATCH 10/10] net/hns3: fix code style static warning

2021-03-31 Thread Min Hu (Connor)
From: Hongbo Zheng Add one space before the left brace to solve the static warning. Fixes: 4311f7372881 ("net/hns3: support query Rx descriptor status") Signed-off-by: Hongbo Zheng Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[dpdk-dev] [PATCH 02/10] net/hns3: fix set default MAC addr fail in bonding of VF

2021-03-31 Thread Min Hu (Connor)
From: Chengwen Feng When start testpmd with two hns3 VFs(:bd:01.0, :bd:01.7), and then execute the following commands: testpmd> create bonded device 1 0 testpmd> set bonding mac_addr 2 3c:12:34:56:78:9a testpmd> add bonding slave 0 2 testpmd> add bonding sl

[dpdk-dev] [PATCH 06/10] net/hns3: fix flow counter not cleared when create

2021-03-31 Thread Min Hu (Connor)
From: Chengwen Feng User could create flow rules with specified counter by the action of RTE_FLOW_ACTION_TYPE_COUNT, but the counter may retain the original value when create. This patch fix the bug by read the counter when creating the rule because the counter is read-clear. Fixes: fcba820d9b9

[dpdk-dev] [PATCH v2 0/2] add alternative AVX512 offload path

2021-03-31 Thread Leyi Rong
Add alternative Rx/Tx offload path for AVX512, which can support Rx/Tx offload features, like checksum/vlan/RSS/QinQ offload. --- v2: - add "do_offload" parameter to according functions for reducing code duplication. Leyi Rong (2): net/ice: add Tx AVX512 offload path net/ice: add Rx AVX512

[dpdk-dev] [PATCH v2 1/2] net/ice: add Tx AVX512 offload path

2021-03-31 Thread Leyi Rong
Add alternative Tx data path for AVX512 which can support partial Tx offload features, including Tx checksum offload, vlan/QinQ insertion offload. Signed-off-by: Leyi Rong Signed-off-by: Wenzhuo Lu --- drivers/net/ice/ice_rxtx.c| 27 +-- drivers/net/ice/ice_rxtx.h|

[dpdk-dev] [PATCH v2 2/2] net/ice: add Rx AVX512 offload path

2021-03-31 Thread Leyi Rong
Split AVX512 Rx data path into two, one is for basic, the other one can support additional Rx offload features, including Rx checksum offload, Rx vlan offload, RSS offload. Signed-off-by: Leyi Rong Signed-off-by: Wenzhuo Lu --- drivers/net/ice/ice_rxtx.c| 46 +++- drivers/net/ice/i

Re: [dpdk-dev] [PATCH v3 4/5] bus: add device arguments name parsing API

2021-03-31 Thread Thomas Monjalon
The commit log should start by explaining it is adding a callback to the bus drivers for the new devargs syntax. 30/03/2021 14:15, Xueming Li: > To use Global Device Syntax as devargs, name is required for device > management. Context is missing. You mean the argument "name" for the vdev bus? >

Re: [dpdk-dev] [PATCH 2/2] [RFC]: ethdev: manage meter API object handles by the drivers

2021-03-31 Thread Jerin Jacob
On Tue, Mar 30, 2021 at 1:40 AM Matan Azrad wrote: > > Hi Jerin Hi Matan > > Thanks for the review. > PSB > > From: Jerin Jacob > > On Thu, Mar 25, 2021 at 1:51 PM Matan Azrad wrote: > > > > > > Hi Cristian > > > > > > From: Dumitrescu, Cristian > > > > Hi Li and Matan, > > > > > > > > > -

[dpdk-dev] [PATCH v17 0/3] Arm build options rework

2021-03-31 Thread Juraj Linkeš
The current way of specifying Arm configuration options is insufficient since we can't identify the SoC we're building for from the MIDR information. For example, we can't distinguish between N1SDP, Graviton2 or Ampere Altra. We also want to be able to enable/disable which drivers are built withou

[dpdk-dev] [PATCH v17 1/3] build: disable/enable drivers in Arm builds

2021-03-31 Thread Juraj Linkeš
Add support for enabling or disabling drivers for Arm cross build. Do not implement any enable/disable lists yet. Enabling drivers is useful when building for an SoC where we only want to build a few drivers. That way the list won't be too long. Similarly, disabling drivers is useful when we want

[dpdk-dev] [PATCH v17 3/3] config: fix Arm implementer and its SoCs

2021-03-31 Thread Juraj Linkeš
Fix the implementer and part number of DPAA and ARMADA SoCs. The current values of 16 cores and 1 NUMA node don't cover all SoCs from the Arm implementer, e.g. Taishan 2280 has 64 cores and 4 NUMA nodes. Increase these to 64 and 4 to widen the coverage. Add configuration to SoC options where smalle

[dpdk-dev] [PATCH v17 2/3] build: add 'platform' meson option and Arm SoC config

2021-03-31 Thread Juraj Linkeš
Add Arm SoC configuration sets to Arm meson.build and add an arch agnostic meson option, 'platform', to select from these SoC configurations for meson native builds. This is preferable to specifying a cross file when doing aarch64 -> aarch64 builds, since the cross file specifies the toolchain as w

Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API

2021-03-31 Thread Jerin Jacob
On Tue, Mar 30, 2021 at 2:01 AM Matan Azrad wrote: > > Hi Jerin > > Thanks for the review. > PSB > > From: Jerin Jacob > > On Thu, Mar 18, 2021 at 2:28 PM Li Zhang wrote: > > > > > > Currently, the flow meter policy does not support multiple actions per > > > color; also the allowed action types

Re: [dpdk-dev] [PATCH 2/2] net/hns3: support IEEE 1588 PTP

2021-03-31 Thread Min Hu (Connor)
在 2021/3/31 17:26, Ferruh Yigit 写道: On 3/31/2021 8:28 AM, Thomas Monjalon wrote: 31/03/2021 04:35, Min Hu (Connor): 在 2021/3/30 21:59, Ferruh Yigit 写道: On 3/26/2021 8:56 AM, Min Hu (Connor) wrote: Add hns3 support for new ethdev APIs to enable and read IEEE1588/ 802.1AS PTP timestamps. Si

Re: [dpdk-dev] [PATCH v3 6/8] doc: update sample actions support in testpmd guide

2021-03-31 Thread Ferruh Yigit
On 3/17/2021 9:26 AM, Salem Sol wrote: Update documentation for sample action usage in testpmd utilizing rte_flow_action_vxlan_encap and rte_flow_action_nvgre_encap and show the command line example. This patch has dependency to [1], right, can you please confirm it? [1]: https://patches.dpd

Re: [dpdk-dev] [PATCH v3 1/8] app/testpmd: store VXLAN/NVGRE encap data globally

2021-03-31 Thread Ferruh Yigit
On 3/17/2021 9:26 AM, Salem Sol wrote: From: Jiawei Wang With the current code the VXLAN/NVGRE parsing routine stored the configuration of the header on stack, this might lead to overwriting the data on the stack. This patch stores the external data of vxlan and nvgre encap into global data as

Re: [dpdk-dev] [PATCH v3 8/8] doc: update dpdk 21.05 release notes

2021-03-31 Thread Ferruh Yigit
On 3/17/2021 9:26 AM, Salem Sol wrote: Update release notes for dpdk 21.05 to include the new Mellanox driver's support for VXLAN and NVGRE encap as sample actions. Signed-off-by: Salem Sol --- doc/guides/rel_notes/release_21_05.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/d

Re: [dpdk-dev] [PATCH v4] build: add platform meson option

2021-03-31 Thread Juraj Linkeš
Bruce, what do you think of the patch now? Do we need to add/change anything else, like documentation? One thing to note is that we're changing the default behavior in this patch from machine=native to machine=generic (or more accurately, to cpu_instruction_set=generic). Do we want to do that?

Re: [dpdk-dev] [PATCH v4] build: add platform meson option

2021-03-31 Thread Juraj Linkeš
> -Original Message- > From: Juraj Linkeš > Sent: Wednesday, March 31, 2021 2:17 PM > To: Juraj Linkeš ; tho...@monjalon.net; > david.march...@redhat.com; bruce.richard...@intel.com; > honnappa.nagaraha...@arm.com > Cc: dev@dpdk.org > Subject: RE: [PATCH v4] build: add platform meson opt

Re: [dpdk-dev] [PATCH v1] net/iavf: implement power management API

2021-03-31 Thread Ferruh Yigit
On 3/11/2021 1:37 PM, Burakov, Anatoly wrote: On 11-Mar-21 11:55 AM, David Hunt wrote: Implement support for the power management API by implementing a `get_monitor_addr` function that will return an address of an RX ring's status bit. This patch is basically a cut-and-paste of the changes alre

Re: [dpdk-dev] [PATCH v4] build: add platform meson option

2021-03-31 Thread Bruce Richardson
On Wed, Mar 31, 2021 at 12:16:59PM +, Juraj Linkeš wrote: > Bruce, what do you think of the patch now? Do we need to add/change anything > else, like documentation? > > One thing to note is that we're changing the default behavior in this patch > from machine=native to machine=generic (or mo

Re: [dpdk-dev] [PATCH v2 0/6] modify field action enhancements

2021-03-31 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Wednesday, March 24, 2021 5:05 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Slava Ovsiienko > ; Matan Azrad ; Ori Kam > > Subject: [PATCH v2 0/6] modify field action enhancements > > Various fixes/improvements for RTE MODIFY_F

[dpdk-dev] [PATCH] examples/pipeline: add newline to error messages

2021-03-31 Thread Cristian Dumitrescu
Add newline to some error messages that were missing it. Signed-off-by: Cristian Dumitrescu --- examples/pipeline/cli.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c index 9d7d69d34..ef47febaa 100644 --- a/examples/pip

  1   2   >