[dpdk-dev] [PATCH v6 12/17] pci: add a helper for device name

2016-07-15 Thread Shreyansh jain
On Thursday 14 July 2016 10:25 PM, Jan Viktorin wrote: > On Tue, 12 Jul 2016 11:31:17 +0530 > Shreyansh Jain wrote: > >> eal is a better place than crypto / ethdev for naming resources. > > s/for naming/to name/ OK. > > What is meant by "resources" h

[dpdk-dev] [PATCH v6 13/17] pci: add a helper to update a device

2016-07-15 Thread Shreyansh jain
On Thursday 14 July 2016 10:31 PM, Jan Viktorin wrote: > On Tue, 12 Jul 2016 11:31:18 +0530 > Shreyansh Jain wrote: > >> This helper updates a pci device object with latest information it can >> find. >> It will be used mainly for hotplug code. >> >> Signe

[dpdk-dev] [PATCH v6 15/17] eal: add hotplug operations for pci and vdev

2016-07-15 Thread Shreyansh jain
On Thursday 14 July 2016 10:20 PM, Jan Viktorin wrote: > On Tue, 12 Jul 2016 11:31:20 +0530 > Shreyansh Jain wrote: > >> Hotplug which deals with resources should come from the layer that already >> handles them, i.e. EAL. >> >> For both attach and detach ope

[dpdk-dev] [PATCH v6 16/17] ethdev: convert to eal hotplug

2016-07-15 Thread Shreyansh jain
On Thursday 14 July 2016 10:21 PM, Jan Viktorin wrote: > On Tue, 12 Jul 2016 11:31:21 +0530 > Shreyansh Jain wrote: > >> Remove bus logic from ethdev hotplug by using eal for this. >> >> Current api is preserved: >> - the last port that has

[dpdk-dev] [PATCH v6 05/17] eal: introduce init macros

2016-07-15 Thread Shreyansh jain
On Thursday 14 July 2016 09:27 PM, Jan Viktorin wrote: > On Thu, 14 Jul 2016 10:57:55 +0530 > Shreyansh jain wrote: > >> Hi Jan, >> >> On Wednesday 13 July 2016 11:04 PM, Jan Viktorin wrote: >>> On Wed, 13 Jul 2016 11:20:43 +0200 >>> Jan

[dpdk-dev] [PATCH v6 12/17] pci: add a helper for device name

2016-07-15 Thread Shreyansh Jain
On Friday 15 July 2016 03:09 PM, Shreyansh jain wrote: > On Thursday 14 July 2016 10:25 PM, Jan Viktorin wrote: >> On Tue, 12 Jul 2016 11:31:17 +0530 >> Shreyansh Jain wrote: >> >>> eal is a better place than crypto / ethdev for naming resources. >> >> s/

[dpdk-dev] [PATCH] doc: Fix incorrect mempool ops register macro name

2016-07-18 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- doc/guides/prog_guide/mempool_lib.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/prog_guide/mempool_lib.rst b/doc/guides/prog_guide/mempool_lib.rst index 5946675..ffdc109 100644 --- a/doc/guides/prog_guide/mempool_lib.rst

[dpdk-dev] PCIe Hot Insert/Remove Support

2016-11-02 Thread Shreyansh Jain
Hello Ben, Apologies for joining this discussion late. On 10/24/2016 11:46 PM, Walker, Benjamin wrote: > Hi all, > > My name is Ben Walker and I'm the technical lead for SPDK (it's like DPDK, but > for storage devices). SPDK relies on DPDK only for the base functionality in > the > EAL - memory

[dpdk-dev] [PATCH] pci: Don't call probe callback if driver already loaded.

2016-11-02 Thread Shreyansh Jain
On 10/26/2016 3:20 AM, Ben Walker wrote: > If the user asks to probe multiple times, the probe > callback should only be called on devices that don't have > a driver already loaded. > > This is useful if a driver is registered after the > execution of a program has started and the list of devices

[dpdk-dev] [PATCH v7 00/21] Introduce SoC device/driver framework for EAL

2016-11-09 Thread Shreyansh Jain
u have given offline/IRC etc.) I was beginning to wonder that probably only Jan and me were the ones interested in this. Ironically, I felt that being EAL changes, a lot of people would come and be critic of it - giving an opportunity to get it widely accepted. > > 2016-10-28 17:

[dpdk-dev] [PATCH v7 03/21] eal/linux: generalize PCI kernel unbinding driver to EAL

2016-11-10 Thread Shreyansh Jain
Hello Jianbo, Thanks a lot for your time in commenting this. My comments inline (as well as on other similar mails). On Thursday 10 November 2016 07:54 AM, Jianbo Liu wrote: > On 28 October 2016 at 20:26, Shreyansh Jain wrote: >> From: Jan Viktorin >> >> Genera

[dpdk-dev] [PATCH v7 06/21] eal/soc: introduce very essential SoC infra definitions

2016-11-10 Thread Shreyansh Jain
On Thursday 10 November 2016 09:39 AM, Jianbo Liu wrote: > On 28 October 2016 at 20:26, Shreyansh Jain wrote: >> From: Jan Viktorin >> >> Define initial structures and functions for the SoC infrastructure. >> This patch supports only a very minimal function

[dpdk-dev] [PATCH v7 08/21] eal/soc: implement SoC device list and dump

2016-11-10 Thread Shreyansh Jain
On Thursday 10 November 2016 08:36 AM, Jianbo Liu wrote: > On 28 October 2016 at 20:26, Shreyansh Jain wrote: >> From: Jan Viktorin >> >> SoC devices would be linked in a separate list (from PCI). This is used for >> probe function. >> A helper for dumping the d

[dpdk-dev] [PATCH v7 11/21] eal/soc: implement probing of drivers

2016-11-10 Thread Shreyansh Jain
On Thursday 10 November 2016 09:00 AM, Jianbo Liu wrote: > On 28 October 2016 at 20:26, Shreyansh Jain wrote: >> Each SoC PMD registers a set of callback for scanning its own bus/infra and >> matching devices to drivers when probe is called. >> This patch introduces the i

[dpdk-dev] Clarification for eth_driver changes

2016-11-10 Thread Shreyansh Jain
Hello David, list, I need some help and clarification regarding some changes I am doing to cleanup the EAL code. There are some changes which should be done for eth_driver/rte_eth_device structures: 1. most obvious, eth_driver should be renamed to rte_eth_driver. 2. eth_driver currently has

[dpdk-dev] Clarification for eth_driver changes

2016-11-10 Thread Shreyansh Jain
On Thursday 10 November 2016 01:21 PM, Jianbo Liu wrote: > On 10 November 2016 at 15:26, Shreyansh Jain > wrote: >> Hello David, list, >> >> I need some help and clarification regarding some changes I am doing to >> cleanup the EAL code. >> >> T

[dpdk-dev] Clarification for eth_driver changes

2016-11-10 Thread Shreyansh Jain
On Thursday 10 November 2016 01:33 PM, Thomas Monjalon wrote: > 2016-11-10 15:51, Jianbo Liu: >> On 10 November 2016 at 15:26, Shreyansh Jain >> wrote: >>> This is what the current outline of eth_driver is: >>> >>> +

[dpdk-dev] [PATCH v7 11/21] eal/soc: implement probing of drivers

2016-11-10 Thread Shreyansh Jain
On Thursday 10 November 2016 01:11 PM, Jianbo Liu wrote: > On 10 November 2016 at 14:10, Shreyansh Jain > wrote: >> On Thursday 10 November 2016 09:00 AM, Jianbo Liu wrote: >>> >>> On 28 October 2016 at 20:26, Shreyansh Jain >>> wrote: >>>

[dpdk-dev] Clarification for eth_driver changes

2016-11-10 Thread Shreyansh Jain
Hello David, On Thursday 10 November 2016 01:46 PM, David Marchand wrote: > Hello Shreyansh, > > On Thu, Nov 10, 2016 at 8:26 AM, Shreyansh Jain > wrote: >> I need some help and clarification regarding some changes I am doing to >> cleanup the EAL code. >> >>

[dpdk-dev] [PATCH] doc: announce API and ABI changes for librte_eal

2016-11-10 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- doc/guides/rel_notes/deprecation.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 1a9e1ae..2af2476 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc

[dpdk-dev] [PATCH v7 11/21] eal/soc: implement probing of drivers

2016-11-11 Thread Shreyansh Jain
On Thursday 10 November 2016 02:56 PM, Thomas Monjalon wrote: > 2016-11-10 14:40, Shreyansh Jain: >> On Thursday 10 November 2016 01:11 PM, Jianbo Liu wrote: >>> On 10 November 2016 at 14:10, Shreyansh Jain >>> wrote: >>>> On Thursday 10 November 2016 09:0

[dpdk-dev] [PATCH] doc: add sub-repositories information

2016-11-11 Thread Shreyansh Jain
Hello Ferruh, Trivial comment/suggestion: On Thursday 10 November 2016 10:57 PM, Ferruh Yigit wrote: > DPDK switched to main and sub-repositories approach, this patch > documents new approach and updates development process according. > > Signed-off-by: Ferruh Yigit > --- >

[dpdk-dev] [PATCH v1] doc: fix release notes for 16.11

2016-11-11 Thread Shreyansh Jain
vice naming functions have been generalized from ethdev and cryptodev > to EAL. ``rte_eal_pci_device_name`` has been introduced for obtaining > unique device name from PCI Domain-BDF description. If it is possible to have a Reviewed-by for a particular part of a patch: Reviewed-by: Shreyansh Jain

[dpdk-dev] Clarification for eth_driver changes

2016-11-12 Thread Shreyansh Jain
Hello Ferruh, (Please ignore if line wrappings are not correct. Using a possibly unconfigured mail client). > -Original Message- > From: Ferruh Yigit [mailto:ferruh.yigit at intel.com] > Sent: Saturday, November 12, 2016 12:46 AM > To: Shreyansh Jain ; David Marchand

[dpdk-dev] Clarification for eth_driver changes

2016-11-16 Thread Shreyansh Jain
On Monday 14 November 2016 11:08 PM, Ferruh Yigit wrote: [...] > What I was thinking is: > > rte_device/driver are not abstract classes. > > rte_bus device/driver is an abstract class and any bus inherited from > this class. > rte_func device/driver is and abstract class and eth/crypto inherited >

[dpdk-dev] [RFC PATCH 0/6] Restructure EAL device model for bus support

2016-11-17 Thread Shreyansh Jain
rt of 17.02 roadmap. [1] http://dpdk.org/ml/archives/dev/2016-November/050186.html Jan Viktorin (1): eal: define container macro Shreyansh Jain (5): eal: introduce bus-device-driver structure bus: add bus driver layer eal/common: handle bus abstraction for device/driver objects eal: suppor

[dpdk-dev] [RFC PATCH 1/6] eal: define container macro

2016-11-17 Thread Shreyansh Jain
From: Jan Viktorin <vikto...@rehivetech.com> Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/include/rte_common.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/lib/librte_eal/common/include/rte_common.h b/lib/librte_eal/

[dpdk-dev] [RFC PATCH 2/6] eal: introduce bus-device-driver structure

2016-11-17 Thread Shreyansh Jain
bus || | | |+-+| / / +---+ Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/include/rte_bus.h | 243 lib/librte_eal/common/include/rte_dev.h | 36 ++--- 2 files chan

[dpdk-dev] [RFC PATCH 3/6] bus: add bus driver layer

2016-11-17 Thread Shreyansh Jain
- no work on this has been done yet. Signed-off-by: Shreyansh Jain --- bus/Makefile | 36 bus/pci/Makefile | 37 bus/pci/linuxapp/pci_bus.c | 418 + bus/pci/linuxapp/pci_bus.h | 55 ++ 4 files changed, 546

[dpdk-dev] [RFC PATCH 4/6] eal/common: handle bus abstraction for device/driver objects

2016-11-17 Thread Shreyansh Jain
, for example when added a new device (hotplugging). At present rte_driver has the probe hook. This should be wrapped around some API at the bus level so that bus can search through multiple drivers associated with it for calling probe. Signed-off-by: Shreyansh Jain --- lib/librte_eal/common

[dpdk-dev] [RFC PATCH 5/6] eal: supporting bus model in init process

2016-11-17 Thread Shreyansh Jain
all the operations for a PCI device, whether binding to a driver or mmap, be moved to PCI bus code base? All of that is not relevant for a bus, but then having multiple implementation areas for a common sub-system (PCI, here) is also not a nice thing. Signed-off-by: Shreyansh Jain

[dpdk-dev] [RFC PATCH 6/6] eal: removing eth_driver

2016-11-17 Thread Shreyansh Jain
d to extraction relvant xxx type, container_of would have to be used. Signed-off-by: Shreyansh Jain --- drivers/net/ixgbe/ixgbe_ethdev.c | 49 +--- lib/librte_ether/rte_ethdev.c| 36 + lib/librte_ether/rte_ethdev.h| 6

[dpdk-dev] [RFC PATCH 2/6] eal: introduce bus-device-driver structure

2016-11-17 Thread Shreyansh Jain
Hello Jan, Thanks for comments. Replies inline. On Thursday 17 November 2016 04:49 PM, Jan Blunck wrote: > On Thu, Nov 17, 2016 at 6:30 AM, Shreyansh Jain > wrote: >> A device is connected to a bus and services by a driver associated with >> the bus. It is responsibility of t

[dpdk-dev] [RFC PATCH 1/6] eal: define container macro

2016-11-17 Thread Shreyansh Jain
On Thursday 17 November 2016 05:36 PM, Jan Blunck wrote: > On Thu, Nov 17, 2016 at 6:30 AM, Shreyansh Jain > wrote: >> From: Jan Viktorin >> >> Signed-off-by: Jan Viktorin >> Signed-off-by: Shreyansh Jain >> --- >> lib/librte_eal/common/include/rte_c

[dpdk-dev] [RFC PATCH 0/6] Restructure EAL device model for bus support

2016-11-17 Thread Shreyansh Jain
On Thursday 17 November 2016 05:25 PM, Jan Blunck wrote: > On Thu, Nov 17, 2016 at 6:29 AM, Shreyansh Jain > wrote: >> DPDK has been inherently a PCI inclined framework. Because of this, the >> design of device tree (or list) within DPDK is also PCI inclined. A non-PCI >

[dpdk-dev] [RFC PATCH 6/6] eal: removing eth_driver

2016-11-18 Thread Shreyansh Jain
sorry for delay in responding; somehow I didn't notice this email. On Thursday 17 November 2016 06:23 PM, Jan Blunck wrote: > On Thu, Nov 17, 2016 at 6:30 AM, Shreyansh Jain > wrote: >> This patch demonstrates how eth_driver can be replaced with appropriate >> changes for r

[dpdk-dev] [PATCH] eal: postpone vdev initialization

2016-11-21 Thread Shreyansh Jain
On Sunday 20 November 2016 01:30 PM, Jerin Jacob wrote: > Some platform like octeontx may use pci and > vdev based combined device to represent a logical > dpdk functional device.In such case, postponing the > vdev initialization after pci device > initialization will provide the better view of >

[dpdk-dev] [PATCH 0/4] libeventdev API and northbound implementation

2016-11-22 Thread Shreyansh Jain
On Tuesday 22 November 2016 07:30 AM, Yuanhan Liu wrote: > On Sat, Nov 19, 2016 at 12:57:15AM +0530, Jerin Jacob wrote: >> On Fri, Nov 18, 2016 at 04:04:29PM +, Bruce Richardson wrote: >>> +Thomas >>> >>> On Fri, Nov 18, 2016 at 03:25:18PM +, Bruce Richardson wrote: On Fri, Nov 18,

[dpdk-dev] [PATCH v2 1/8] eal: define container_of macro

2016-11-22 Thread Shreyansh Jain
On Monday 21 November 2016 10:25 PM, Jan Blunck wrote: > This macro is based on Jan Viktorin's original patch but also checks the > type of the passed pointer against the type of the member. > > Signed-off-by: Jan Viktorin > Signed-off-by: Shreyansh Jain > [jblunck at infra

[dpdk-dev] [PATCH v2 3/8] drivers: Use ETH_DEV_PCI_DEV() helper

2016-11-22 Thread Shreyansh Jain
On Monday 21 November 2016 10:25 PM, Jan Blunck wrote: > The drivers should not directly access the rte_eth_dev->pci_dev but use > a macro instead. This is a preparation for replacing the pci_dev with > a struct rte_device member in the future. > > Signed-off-by: Jan Blunck > --- >

[dpdk-dev] [PATCH v2 1/8] eal: define container_of macro

2016-11-22 Thread Shreyansh Jain
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, November 22, 2016 3:50 PM > To: Shreyansh Jain ; Jan Blunck > > Cc: dev at dpdk.org; david.marchand at 6wind.com; Jan Viktorin > > Subject: Re: [dpdk-dev] [P

[dpdk-dev] [PATCH v2 1/8] eal: define container_of macro

2016-11-22 Thread Shreyansh Jain
> -Original Message- > From: Jan Viktorin [mailto:viktorin at rehivetech.com] > Sent: Tuesday, November 22, 2016 6:03 PM > To: Shreyansh Jain > Cc: Thomas Monjalon ; Jan Blunck > ; dev at dpdk.org; david.marchand at 6wind.com > Subject: Re: [dpdk-dev] [PATC

[dpdk-dev] [RFC PATCH 0/6] Restructure EAL device model for bus support

2016-11-23 Thread Shreyansh Jain
I should have replied to this earlier, apologies. On Sunday 20 November 2016 09:00 PM, David Marchand wrote: > On Thu, Nov 17, 2016 at 6:29 AM, Shreyansh Jain > wrote: >> DPDK has been inherently a PCI inclined framework. Because of this, the >> design of device tree (or

[dpdk-dev] [PATCH v2 1/7] pci: If a driver's probe function fails, unmap resources.

2016-11-25 Thread Shreyansh Jain
> + if (ret) { > dev->driver = NULL; > + if (dr->drv_flags & RTE_PCI_DRV_NEED_MAPPING) > + rte_eal_pci_unmap_device(dev); > + } > > return ret; > } > Acked-by: Shreyansh Jain

[dpdk-dev] [PATCH v2 2/7] pci: Separate detaching ethernet ports from PCI devices

2016-11-25 Thread Shreyansh Jain
On Thursday 24 November 2016 01:37 AM, Ben Walker wrote: > Attaching and detaching ethernet ports from an application > is not the same thing as physically removing a PCI device, > so clarify the flags indicating support. All PCI devices > are assumed to be physically removable, so no flag is >

[dpdk-dev] [PATCH v2 3/7] pci: Pass rte_pci_addr to functions instead of separate args

2016-11-25 Thread Shreyansh Jain
>d_name, sizeof(e->d_name), ) > != 0) > continue; > > snprintf(dirname, sizeof(dirname), "%s/%s", > pci_get_sysfs_path(), e->d_name); > - if (pci_scan_one(dirname, domain, bus, devid, function) < 0) > + if (pci_scan_one(dirname, ) < 0) > goto error; > } > closedir(dir); > + > return 0; > > error: > This is much more cleaner than passing all the BDF entries. Except the above unnecessary new line: Acked-by: Shreyansh Jain

[dpdk-dev] [PATCH v2 4/7] pci: rte_eal_pci_scan now handles removal of PCI devices

2016-11-25 Thread Shreyansh Jain
Hi Ben, On Thursday 24 November 2016 01:37 AM, Ben Walker wrote: > rte_eal_pci_scan can be called repeatedly to re-scan the PCI > bus. If a device was removed from the system, the associated > driver will automatically be unloaded. > > Signed-off-by: Ben Walker > --- [...] While reviewing, I

[dpdk-dev] [PATCH v2 6/7] pci: Combine rte_eal_pci_scan and rte_eal_pci_probe

2016-11-25 Thread Shreyansh Jain
On Thursday 24 November 2016 01:37 AM, Ben Walker wrote: > Two functions is both confusing and unnecessary. Previously, > rte_eal_pci_scan populated an internal list of devices by > scanning sysfs. Then, rte_eal_pci_probe would match registered > drivers to that internal list. These are not really

[dpdk-dev] [PATCH v1 0/4] Generalize PCI specific EAL function/structures

2016-10-03 Thread Shreyansh Jain
Hi David, On Friday 30 September 2016 09:01 PM, David Marchand wrote: > On Tue, Sep 27, 2016 at 4:12 PM, Shreyansh Jain > wrote: >> (I rebased these over HEAD 7b3c4f3) >> >> These patches were initially part of Jan's original series on SoC >> Framework ([1],

[dpdk-dev] [PATCH v11 07/24] driver: probe/remove common wrappers for PCI drivers

2016-10-04 Thread Shreyansh Jain
On Monday 03 October 2016 07:51 PM, Thomas Monjalon wrote: > 2016-09-20 18:11, Shreyansh Jain: >> --- a/lib/librte_ether/rte_ethdev.h >> +++ b/lib/librte_ether/rte_ethdev.h >> @@ -4372,6 +4372,19 @@ rte_eth_dev_get_port_by_name(const char *name, >>

[dpdk-dev] [PATCH v11 00/24] Introducing rte_driver/rte_device generalization

2016-10-04 Thread Shreyansh Jain
Hi Thomas, On Monday 03 October 2016 07:58 PM, Thomas Monjalon wrote: > Applied, thanks everybody for the great (re)work! Thanks! > > 2016-09-20 18:11, Shreyansh Jain: >> Future Work/Pending: >> === >> - Presently eth_driver, rte_eth_dev are no

[dpdk-dev] [PATCH v11 00/24] Introducing rte_driver/rte_device generalization

2016-10-05 Thread Shreyansh Jain
Hi Thomas, On Tuesday 04 October 2016 01:12 PM, Thomas Monjalon wrote: > 2016-10-04 12:21, Shreyansh Jain: >> Hi Thomas, >> >> On Monday 03 October 2016 07:58 PM, Thomas Monjalon wrote: >>> Applied, thanks everybody for the great (re)work! >> >> Tha

[dpdk-dev] [PATCH v1 0/4] Generalize PCI specific EAL function/structures

2016-10-06 Thread Shreyansh Jain
Hi Thomas, On Monday 03 October 2016 07:06 PM, Thomas Monjalon wrote: > 2016-10-03 11:07, Shreyansh Jain: >> Hi David, >> >> On Friday 30 September 2016 09:01 PM, David Marchand wrote: >>> On Tue, Sep 27, 2016 at 4:12 PM, Shreyansh Jain >>> wrote:

[dpdk-dev] [PATCH] eal/vdev: rename vdev driver init/uninit to probe/remove

2016-10-06 Thread Shreyansh Jain
Inline with PCI probe and remove, VDEV probe and remove hooks provide a uniform naming. PCI probe represents scan and driver initialization. For VDEV, it will represent argument parsing and initialization. Signed-off-by: Shreyansh Jain --- drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 12

[dpdk-dev] [PATCH] net/virtio: add missing driver name

2016-10-07 Thread Shreyansh Jain
d_virtio_map, > .drv_flags = RTE_PCI_DRV_DETACHABLE, > .probe = rte_eth_dev_pci_probe, > Indeed. For MLX4/5 and Virtio, DRIVER_REGISTER_* is not being used which takes this 'name'. In this case, it was missed. Acked-by: Shreyansh Jain

[dpdk-dev] [PATCH 1/3] eal/drivers: prefix driver REGISTER macros with EAL

2016-10-07 Thread Shreyansh Jain
DRIVER_REGISTER_PCI -> EAL_REGISTER_PCI DRIVER_REGISTER_PCI_TABLE -> EAL_REGISTER_PCI_TABLE Signed-off-by: Shreyansh Jain --- doc/guides/prog_guide/dev_kit_build_system.rst | 2 +- drivers/crypto/qat/rte_qat_cryptodev.c | 4 ++-- drivers/net/bnx2x/bnx2x_ethdev.c

[dpdk-dev] [PATCH 2/3] eal/drivers: prefix VDEV driver REGISTER macro with EAL

2016-10-07 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 2 +- drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 2 +- drivers/crypto/kasumi/rte_kasumi_pmd.c | 2 +- drivers/crypto/null/null_crypto_pmd.c | 2 +- drivers/crypto/snow3g/rte_snow3g_pmd.c | 2 +- drivers

[dpdk-dev] [PATCH 3/3] eal/drivers: prefix driver param REGISTER macro with EAL

2016-10-07 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 2 +- drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 2 +- drivers/crypto/kasumi/rte_kasumi_pmd.c | 2 +- drivers/crypto/null/null_crypto_pmd.c | 2 +- drivers/crypto/snow3g/rte_snow3g_pmd.c | 2 +- drivers

[dpdk-dev] [PATCH 1/3] eal/drivers: prefix driver REGISTER macros with EAL

2016-10-07 Thread Shreyansh Jain
Hi David, Thomas, On Friday 07 October 2016 07:03 PM, Shreyansh Jain wrote: > DRIVER_REGISTER_PCI -> EAL_REGISTER_PCI > DRIVER_REGISTER_PCI_TABLE -> EAL_REGISTER_PCI_TABLE > > Signed-off-by: Shreyansh Jain > --- > doc/guides/prog_guide/dev_kit_build_system.rst | 2

[dpdk-dev] [PATCH 1/3] eal/drivers: prefix driver REGISTER macros with EAL

2016-10-08 Thread Shreyansh Jain
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, October 07, 2016 7:15 PM > To: Shreyansh Jain > Cc: david.marchand at 6wind.com; dev at dpdk.org > Subject: Re: [PATCH 1/3] eal/drivers: prefix driver REGISTER macros wit

[dpdk-dev] [PATCH 1/3] eal/drivers: prefix driver REGISTER macros with EAL

2016-10-08 Thread Shreyansh Jain
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, October 07, 2016 7:22 PM > To: Shreyansh Jain > Cc: david.marchand at 6wind.com; dev at dpdk.org > Subject: Re: [PATCH 1/3] eal/drivers: prefix driver REGIST

[dpdk-dev] [PATCH 1/3] eal/drivers: prefix driver REGISTER macros with EAL

2016-10-08 Thread Shreyansh Jain
Hi Neil, > -Original Message- > From: Neil Horman [mailto:nhorman at tuxdriver.com] > Sent: Friday, October 07, 2016 7:48 PM > To: Thomas Monjalon > Cc: Shreyansh Jain ; david.marchand at 6wind.com; > dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/3] eal/d

[dpdk-dev] [PATCH v1] drivers: prefix driver REGISTER macro with RTE EAL

2016-10-09 Thread Shreyansh Jain
AM_STRING -> RTE_PMD_REGISTER_PARAM_STRING DRIVER_EXPORT_* -> RTE_PMD_EXPORT_* Fix PMDINFOGEN tool to look for exact matches of RTE_PMD_REGISTER_PCI and RTE_PMD_REGISTER_VDEV. Signed-off-by: Shreyansh Jain -- Changes since v0: - expand replacement to DRIVER_EXPORT_* - merge all changes into single commit - c

[dpdk-dev] [PATCH v1] drivers: prefix driver REGISTER macro with RTE EAL

2016-10-09 Thread Shreyansh Jain
On 10/8/2016 11:31 PM, Shreyansh Jain wrote: > All macros related to driver registeration renamed from DRIVER_* > to RTE_PMD_* > > This includes: > > DRIVER_REGISTER_PCI -> RTE_PMD_REGISTER_PCI > DRIVER_REGISTER_PCI_TABLE -> RTE_PMD_REGISTER_PCI_TA

[dpdk-dev] [PATCH v2] drivers: prefix driver REGISTER macro with RTE PMD

2016-10-09 Thread Shreyansh Jain
AM_STRING -> RTE_PMD_REGISTER_PARAM_STRING DRIVER_EXPORT_* -> RTE_PMD_EXPORT_* Fix PMDINFOGEN tool to look for exact matches of RTE_PMD_REGISTER_PCI and RTE_PMD_REGISTER_VDEV. Signed-off-by: Shreyansh Jain -- Changes since v1: - Fix patch headline Changes since v0: - expand replacement to DRIVER_EXPORT_* - me

[dpdk-dev] [PATCH v2] drivers: prefix driver REGISTER macro with RTE PMD

2016-10-09 Thread Shreyansh Jain
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Sunday, October 09, 2016 1:52 AM > To: Shreyansh Jain > Cc: david.marchand at 6wind.com; dev at dpdk.org; nhorman at tuxdriver.com > Subject: Re: [PATCH v2] driv

[dpdk-dev] [PATCH v2] drivers: prefix driver REGISTER macro with RTE PMD

2016-10-10 Thread Shreyansh Jain
On Monday 10 October 2016 01:20 AM, Thomas Monjalon wrote: > 2016-10-09 15:12, Shreyansh Jain: >> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] >>> 2016-10-08 23:35, Shreyansh Jain: >>>> +PMDINFO_TO_O = if grep -E 'RTE_PMD_REGISTER_PCI\([0-9a-zA-Z,_\.

[dpdk-dev] [PATCH v2] drivers: prefix driver REGISTER macro with RTE PMD

2016-10-10 Thread Shreyansh Jain
On Monday 10 October 2016 10:41 AM, Shreyansh Jain wrote: > On Monday 10 October 2016 01:20 AM, Thomas Monjalon wrote: >> 2016-10-09 15:12, Shreyansh Jain: >>> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] >>>> 2016-10-08 23:35, Shreyansh Jain: &g

[dpdk-dev] [PATCH v3] drivers: prefix driver REGISTER macro with RTE PMD

2016-10-10 Thread Shreyansh Jain
AM_STRING -> RTE_PMD_REGISTER_PARAM_STRING DRIVER_EXPORT_* -> RTE_PMD_EXPORT_* Fix PMDINFOGEN tool to look for matches of RTE_PMD_REGISTER_*. Signed-off-by: Shreyansh Jain -- Changes since v2: - Rebase over master - revert PMDINFO grep pattern Changes since v1: - Fix patch headline Changes since v0: - exp

[dpdk-dev] [PATCH 1/3] eal/drivers: prefix driver REGISTER macros with EAL

2016-10-11 Thread Shreyansh Jain
On Monday 10 October 2016 06:26 PM, Neil Horman wrote: > On Sat, Oct 08, 2016 at 01:00:59PM +0000, Shreyansh Jain wrote: >> Hi Thomas, >> >>> -Original Message- >>> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] >>> Sent: Friday, Octob

[dpdk-dev] [PATCH v1 0/4] Generalize PCI specific EAL function/structures

2016-10-13 Thread Shreyansh Jain
Hi David, On Friday 30 September 2016 09:01 PM, David Marchand wrote: > On Tue, Sep 27, 2016 at 4:12 PM, Shreyansh Jain > wrote: >> (I rebased these over HEAD 7b3c4f3) >> >> These patches were initially part of Jan's original series on SoC >> Framework ([1],

[dpdk-dev] [PATCH v7 00/17] Prepare for rte_device / rte_driver

2016-08-01 Thread Shreyansh Jain
tch (patch 5 of initial series) has been dropped for now, we can do this once vdev drivers have been converted David Marchand, Shreyansh Jain (17): pci: no need for dynamic tailq init crypto: no need for a crypto pmd type drivers: align pci driver definitions eal: remove duplicat

[dpdk-dev] [PATCH v7 01/17] pci: no need for dynamic tailq init

2016-08-01 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- lib/librte_eal/bsdapp/eal/eal_pci.c| 3 --- lib/librte_eal/common/eal_common_pci.c | 6 -- lib/librte_eal/linuxapp/eal/eal_pci.c | 3 --- 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c b/lib/librte_eal

[dpdk-dev] [PATCH v7 02/17] crypto: no need for a crypto pmd type

2016-08-01 Thread Shreyansh Jain
This information is not used and just adds noise. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c | 8 +++- lib/librte_cryptodev/rte_cryptodev.h | 2 -- lib/librte_cryptodev/rte_cryptodev_pmd.h | 3 +-- 3 files changed, 4

[dpdk-dev] [PATCH v7 03/17] drivers: align pci driver definitions

2016-08-01 Thread Shreyansh Jain
Pure coding style, but it might make it easier later if we want to move fields in rte_cryptodev_driver and eth_driver structures. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- drivers/crypto/qat/rte_qat_cryptodev.c | 2 +- drivers/net/ena/ena_ethdev.c | 2

[dpdk-dev] [PATCH v7 04/17] eal: remove duplicate function declaration

2016-08-01 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/eal_private.h | 7 --- lib/librte_eal/linuxapp/eal/eal.c | 1 + 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/lib/librte_eal/common/eal_private.h b/lib/librte_eal/common/eal_private.h index 857dc3e..06a68f6 100644

[dpdk-dev] [PATCH v7 05/17] eal: introduce init macros

2016-08-01 Thread Shreyansh Jain
Introduce a RTE_INIT macro used to mark an init function as a constructor. Current eal macros have been converted to use this (no functional impact). DRIVER_REGISTER_PCI is added as a helper for pci drivers. Suggested-by: Jan Viktorin Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain

[dpdk-dev] [PATCH v7 06/17] crypto: export init/uninit common wrappers for pci drivers

2016-08-01 Thread Shreyansh Jain
Preparing for getting rid of rte_cryptodev_driver, here are two wrappers that can be used by pci drivers that assume a 1 to 1 association between pci resource and upper interface. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c

[dpdk-dev] [PATCH v7 07/17] ethdev: export init/uninit common wrappers for pci drivers

2016-08-01 Thread Shreyansh Jain
Preparing for getting rid of eth_drv, here are two wrappers that can be used by pci drivers that assume a 1 to 1 association between pci resource and upper interface. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_ether/rte_ethdev.c | 14 +++--- lib

[dpdk-dev] [PATCH v7 08/17] drivers: convert all pdev drivers as pci drivers

2016-08-01 Thread Shreyansh Jain
t modified - they continue to use PMD_REGISTER_DRIVER. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- drivers/crypto/qat/rte_qat_cryptodev.c | 16 +++- drivers/net/bnx2x/bnx2x_ethdev.c| 34 +--- drivers/net/bnxt/bnxt_ethdev.c

[dpdk-dev] [PATCH v7 10/17] ethdev: get rid of eth driver register callback

2016-08-01 Thread Shreyansh Jain
Now that all pdev are pci drivers, we don't need to register ethdev drivers through a dedicated channel. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_ether/rte_ethdev.c | 22 -- lib/librte_ether/rte_ethdev.h | 12 2 files changed

[dpdk-dev] [PATCH v7 11/17] eal/linux: move back interrupt thread init before setting affinity

2016-08-01 Thread Shreyansh Jain
Marchand Tested-by: Rahul Lakkireddy Signed-off-by: Shreyansh Jain --- lib/librte_eal/linuxapp/eal/eal.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c index fe9c704..259a7e4 100644 --- a/lib

[dpdk-dev] [PATCH v7 12/17] pci: add a helper for device name

2016-08-01 Thread Shreyansh Jain
Eal is a better place than crypto / ethdev to name devices. Add a helper in eal and make use of it in crypto / ethdev. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c| 27 --- lib/librte_eal/common/include

[dpdk-dev] [PATCH v7 13/17] pci: add a helper to update a device

2016-08-01 Thread Shreyansh Jain
This helper updates a pci device object with latest information it can find. It will be used mainly for hotplug code. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_eal/bsdapp/eal/eal_pci.c | 49 +++ lib/librte_eal/common

[dpdk-dev] [PATCH v7 14/17] ethdev: do not scan all pci devices on attach

2016-08-01 Thread Shreyansh Jain
No need to scan all devices, we only need to update the device being attached. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/eal_common_pci.c | 11 --- lib/librte_ether/rte_ethdev.c | 3 --- 2 files changed, 8 insertions(+), 6 deletions

[dpdk-dev] [PATCH v7 15/17] eal: add hotplug operations for pci and vdev

2016-08-01 Thread Shreyansh Jain
Hotplug invocations, which deals with devices, should come from the layer that already handles them, i.e. EAL. For both attach and detach operations, 'name' is used to select the bus that will handle the request. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_eal

[dpdk-dev] [PATCH v7 16/17] ethdev: convert to eal hotplug

2016-08-01 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- lib/librte_ether/rte_ethdev.c | 208 +++--- 1 file changed, 34 insertions(+), 174 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index fdeac86..86c9d1a 100644 --- a/lib/librte_ether

[dpdk-dev] [PATCH v7 17/17] ethdev: get rid of device type

2016-08-01 Thread Shreyansh Jain
Now that hotplug has been moved to eal, there is no reason to keep the device type in this layer. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- app/test/virtual_pmd.c| 2 +- drivers/net/af_packet/rte_eth_af_packet.c | 2 +- drivers/net/bonding

[dpdk-dev] [PATCH v7 09/17] crypto: get rid of crypto driver register callback

2016-08-01 Thread Shreyansh Jain
Now that all pdev are pci drivers, we don't need to register crypto drivers through a dedicated channel. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c | 22 --- lib/librte_cryptodev/rte_cryptodev_pmd.h | 30

[dpdk-dev] [PATCH v6 05/17] eal: introduce init macros

2016-08-01 Thread Shreyansh Jain
Hi Jan, On Saturday 30 July 2016 01:44 PM, Jan Viktorin wrote: > On Thu, 28 Jul 2016 15:06:10 +0530 > Shreyansh Jain wrote: > >> Hi Jan, >> >> On Friday 15 July 2016 04:18 PM, Shreyansh jain wrote: >>> On Thursday 14 July 2016 09:27 PM, Jan Viktorin wrote:

[dpdk-dev] [PATCH] doc: Fix incorrect comment line

2016-08-17 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/eal_private.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_private.h b/lib/librte_eal/common/eal_private.h index 857dc3e..940ec18 100644 --- a/lib/librte_eal/common/eal_private.h +++ b/lib

[dpdk-dev] [PATCH 0/5] i40e: vector poll-mode driver on ARM64

2016-08-24 Thread Shreyansh Jain
Hi Thomas, On Wednesday 24 August 2016 04:19 PM, Thomas Monjalon wrote: > 2016-08-24 15:23, Jianbo Liu: >> This patch set is to implement i40e vector PMD on ARM64. > > Thanks for extending ARM support. > > The current NIC support status is: > % git grep -l 'ARM.*=.*Y' doc/guides/nics/features/ >

[dpdk-dev] [PATCH v8 00/25] Introducing rte_driver/rte_device generalization

2016-08-26 Thread Shreyansh Jain
en split into smaller pieces - RTE_INIT macro has been added, but in the end, I am not sure it is useful - device type has been removed from ethdev, as it was used only by hotplug - getting rid of pmd type in eal patch (patch 5 of initial series) has been dropped for now, we can do this once vdev dri

[dpdk-dev] [PATCH v8 01/25] eal: define macro container_of

2016-08-26 Thread Shreyansh Jain
Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/include/rte_common.h | 16 1 file changed, 16 insertions(+) diff --git a/lib/librte_eal/common/include/rte_common.h b/lib/librte_eal/common/include/rte_common.h index 332f2a4..a9b6792 100644

[dpdk-dev] [PATCH v8 03/25] pci: no need for dynamic tailq init

2016-08-26 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- lib/librte_eal/bsdapp/eal/eal_pci.c| 3 --- lib/librte_eal/common/eal_common_pci.c | 6 -- lib/librte_eal/linuxapp/eal/eal_pci.c | 3 --- 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c b/lib/librte_eal

[dpdk-dev] [PATCH v8 02/25] eal: remove duplicate function declaration

2016-08-26 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/eal_private.h | 7 --- lib/librte_eal/linuxapp/eal/eal.c | 1 + 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/lib/librte_eal/common/eal_private.h b/lib/librte_eal/common/eal_private.h index 19f7535..ca1aec6 100644

[dpdk-dev] [PATCH v8 04/25] crypto: no need for a crypto pmd type

2016-08-26 Thread Shreyansh Jain
This information is not used and just adds noise. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c | 8 +++- lib/librte_cryptodev/rte_cryptodev.h | 2 -- lib/librte_cryptodev/rte_cryptodev_pmd.h | 3 +-- 3 files changed, 4

[dpdk-dev] [PATCH v8 05/25] drivers: align pci driver definitions

2016-08-26 Thread Shreyansh Jain
Pure coding style, but it might make it easier later if we want to move fields in rte_cryptodev_driver and eth_driver structures. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- drivers/crypto/qat/rte_qat_cryptodev.c | 2 +- drivers/net/ena/ena_ethdev.c | 2

[dpdk-dev] [PATCH v8 06/25] eal: introduce init macros

2016-08-26 Thread Shreyansh Jain
Introduce a RTE_INIT macro used to mark an init function as a constructor. Current eal macros have been converted to use this (no functional impact). DRIVER_REGISTER_PCI is added as a helper for pci drivers. Suggested-by: Jan Viktorin Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain

[dpdk-dev] [PATCH v8 07/25] driver: init/uninit common wrappers for PCI drivers

2016-08-26 Thread Shreyansh Jain
crypto and ethdev drivers aligned to PCI probe/remove. Existing handlers for init/uninit can be easily reused for this. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c | 16 lib/librte_cryptodev/rte_cryptodev_pmd.h

<    1   2   3   4   5   >