On Thursday 14 July 2016 10:25 PM, Jan Viktorin wrote:
> On Tue, 12 Jul 2016 11:31:17 +0530
> Shreyansh Jain wrote:
>
>> eal is a better place than crypto / ethdev for naming resources.
>
> s/for naming/to name/
OK.
>
> What is meant by "resources" h
On Thursday 14 July 2016 10:31 PM, Jan Viktorin wrote:
> On Tue, 12 Jul 2016 11:31:18 +0530
> Shreyansh Jain wrote:
>
>> This helper updates a pci device object with latest information it can
>> find.
>> It will be used mainly for hotplug code.
>>
>> Signe
On Thursday 14 July 2016 10:20 PM, Jan Viktorin wrote:
> On Tue, 12 Jul 2016 11:31:20 +0530
> Shreyansh Jain wrote:
>
>> Hotplug which deals with resources should come from the layer that already
>> handles them, i.e. EAL.
>>
>> For both attach and detach ope
On Thursday 14 July 2016 10:21 PM, Jan Viktorin wrote:
> On Tue, 12 Jul 2016 11:31:21 +0530
> Shreyansh Jain wrote:
>
>> Remove bus logic from ethdev hotplug by using eal for this.
>>
>> Current api is preserved:
>> - the last port that has
On Thursday 14 July 2016 09:27 PM, Jan Viktorin wrote:
> On Thu, 14 Jul 2016 10:57:55 +0530
> Shreyansh jain wrote:
>
>> Hi Jan,
>>
>> On Wednesday 13 July 2016 11:04 PM, Jan Viktorin wrote:
>>> On Wed, 13 Jul 2016 11:20:43 +0200
>>> Jan
On Friday 15 July 2016 03:09 PM, Shreyansh jain wrote:
> On Thursday 14 July 2016 10:25 PM, Jan Viktorin wrote:
>> On Tue, 12 Jul 2016 11:31:17 +0530
>> Shreyansh Jain wrote:
>>
>>> eal is a better place than crypto / ethdev for naming resources.
>>
>> s/
Signed-off-by: Shreyansh Jain
---
doc/guides/prog_guide/mempool_lib.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/prog_guide/mempool_lib.rst
b/doc/guides/prog_guide/mempool_lib.rst
index 5946675..ffdc109 100644
--- a/doc/guides/prog_guide/mempool_lib.rst
Hello Ben,
Apologies for joining this discussion late.
On 10/24/2016 11:46 PM, Walker, Benjamin wrote:
> Hi all,
>
> My name is Ben Walker and I'm the technical lead for SPDK (it's like DPDK, but
> for storage devices). SPDK relies on DPDK only for the base functionality in
> the
> EAL - memory
On 10/26/2016 3:20 AM, Ben Walker wrote:
> If the user asks to probe multiple times, the probe
> callback should only be called on devices that don't have
> a driver already loaded.
>
> This is useful if a driver is registered after the
> execution of a program has started and the list of devices
u have given
offline/IRC etc.)
I was beginning to wonder that probably only Jan and me were the ones
interested in this. Ironically, I felt that being EAL changes, a lot of
people would come and be critic of it - giving an opportunity to get it
widely accepted.
>
> 2016-10-28 17:
Hello Jianbo,
Thanks a lot for your time in commenting this. My comments inline (as
well as on other similar mails).
On Thursday 10 November 2016 07:54 AM, Jianbo Liu wrote:
> On 28 October 2016 at 20:26, Shreyansh Jain wrote:
>> From: Jan Viktorin
>>
>> Genera
On Thursday 10 November 2016 09:39 AM, Jianbo Liu wrote:
> On 28 October 2016 at 20:26, Shreyansh Jain wrote:
>> From: Jan Viktorin
>>
>> Define initial structures and functions for the SoC infrastructure.
>> This patch supports only a very minimal function
On Thursday 10 November 2016 08:36 AM, Jianbo Liu wrote:
> On 28 October 2016 at 20:26, Shreyansh Jain wrote:
>> From: Jan Viktorin
>>
>> SoC devices would be linked in a separate list (from PCI). This is used for
>> probe function.
>> A helper for dumping the d
On Thursday 10 November 2016 09:00 AM, Jianbo Liu wrote:
> On 28 October 2016 at 20:26, Shreyansh Jain wrote:
>> Each SoC PMD registers a set of callback for scanning its own bus/infra and
>> matching devices to drivers when probe is called.
>> This patch introduces the i
Hello David, list,
I need some help and clarification regarding some changes I am doing to
cleanup the EAL code.
There are some changes which should be done for
eth_driver/rte_eth_device structures:
1. most obvious, eth_driver should be renamed to rte_eth_driver.
2. eth_driver currently has
On Thursday 10 November 2016 01:21 PM, Jianbo Liu wrote:
> On 10 November 2016 at 15:26, Shreyansh Jain
> wrote:
>> Hello David, list,
>>
>> I need some help and clarification regarding some changes I am doing to
>> cleanup the EAL code.
>>
>> T
On Thursday 10 November 2016 01:33 PM, Thomas Monjalon wrote:
> 2016-11-10 15:51, Jianbo Liu:
>> On 10 November 2016 at 15:26, Shreyansh Jain
>> wrote:
>>> This is what the current outline of eth_driver is:
>>>
>>> +
On Thursday 10 November 2016 01:11 PM, Jianbo Liu wrote:
> On 10 November 2016 at 14:10, Shreyansh Jain
> wrote:
>> On Thursday 10 November 2016 09:00 AM, Jianbo Liu wrote:
>>>
>>> On 28 October 2016 at 20:26, Shreyansh Jain
>>> wrote:
>>>
Hello David,
On Thursday 10 November 2016 01:46 PM, David Marchand wrote:
> Hello Shreyansh,
>
> On Thu, Nov 10, 2016 at 8:26 AM, Shreyansh Jain
> wrote:
>> I need some help and clarification regarding some changes I am doing to
>> cleanup the EAL code.
>>
>>
Signed-off-by: Shreyansh Jain
---
doc/guides/rel_notes/deprecation.rst | 10 ++
1 file changed, 10 insertions(+)
diff --git a/doc/guides/rel_notes/deprecation.rst
b/doc/guides/rel_notes/deprecation.rst
index 1a9e1ae..2af2476 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc
On Thursday 10 November 2016 02:56 PM, Thomas Monjalon wrote:
> 2016-11-10 14:40, Shreyansh Jain:
>> On Thursday 10 November 2016 01:11 PM, Jianbo Liu wrote:
>>> On 10 November 2016 at 14:10, Shreyansh Jain
>>> wrote:
>>>> On Thursday 10 November 2016 09:0
Hello Ferruh,
Trivial comment/suggestion:
On Thursday 10 November 2016 10:57 PM, Ferruh Yigit wrote:
> DPDK switched to main and sub-repositories approach, this patch
> documents new approach and updates development process according.
>
> Signed-off-by: Ferruh Yigit
> ---
>
vice naming functions have been generalized from ethdev and cryptodev
> to EAL. ``rte_eal_pci_device_name`` has been introduced for obtaining
> unique device name from PCI Domain-BDF description.
If it is possible to have a Reviewed-by for a particular part of a patch:
Reviewed-by: Shreyansh Jain
Hello Ferruh,
(Please ignore if line wrappings are not correct. Using a possibly
unconfigured mail client).
> -Original Message-
> From: Ferruh Yigit [mailto:ferruh.yigit at intel.com]
> Sent: Saturday, November 12, 2016 12:46 AM
> To: Shreyansh Jain ; David Marchand
On Monday 14 November 2016 11:08 PM, Ferruh Yigit wrote:
[...]
> What I was thinking is:
>
> rte_device/driver are not abstract classes.
>
> rte_bus device/driver is an abstract class and any bus inherited from
> this class.
> rte_func device/driver is and abstract class and eth/crypto inherited
>
rt of 17.02 roadmap.
[1] http://dpdk.org/ml/archives/dev/2016-November/050186.html
Jan Viktorin (1):
eal: define container macro
Shreyansh Jain (5):
eal: introduce bus-device-driver structure
bus: add bus driver layer
eal/common: handle bus abstraction for device/driver objects
eal: suppor
From: Jan Viktorin <vikto...@rehivetech.com>
Signed-off-by: Jan Viktorin
Signed-off-by: Shreyansh Jain
---
lib/librte_eal/common/include/rte_common.h | 18 ++
1 file changed, 18 insertions(+)
diff --git a/lib/librte_eal/common/include/rte_common.h
b/lib/librte_eal/
bus ||
| | |+-+|
/ / +---+
Signed-off-by: Shreyansh Jain
---
lib/librte_eal/common/include/rte_bus.h | 243
lib/librte_eal/common/include/rte_dev.h | 36 ++---
2 files chan
- no work on this
has been done yet.
Signed-off-by: Shreyansh Jain
---
bus/Makefile | 36
bus/pci/Makefile | 37
bus/pci/linuxapp/pci_bus.c | 418 +
bus/pci/linuxapp/pci_bus.h | 55 ++
4 files changed, 546
,
for example when added a new device (hotplugging). At present
rte_driver has the probe hook. This should be wrapped around some API
at the bus level so that bus can search through multiple drivers
associated with it for calling probe.
Signed-off-by: Shreyansh Jain
---
lib/librte_eal/common
all the operations for a PCI device, whether binding to a driver
or mmap, be moved to PCI bus code base? All of that is not relevant for
a bus, but then having multiple implementation areas for a common
sub-system (PCI, here) is also not a nice thing.
Signed-off-by: Shreyansh Jain
d to extraction relvant xxx type,
container_of would have to be used.
Signed-off-by: Shreyansh Jain
---
drivers/net/ixgbe/ixgbe_ethdev.c | 49 +---
lib/librte_ether/rte_ethdev.c| 36 +
lib/librte_ether/rte_ethdev.h| 6
Hello Jan,
Thanks for comments. Replies inline.
On Thursday 17 November 2016 04:49 PM, Jan Blunck wrote:
> On Thu, Nov 17, 2016 at 6:30 AM, Shreyansh Jain
> wrote:
>> A device is connected to a bus and services by a driver associated with
>> the bus. It is responsibility of t
On Thursday 17 November 2016 05:36 PM, Jan Blunck wrote:
> On Thu, Nov 17, 2016 at 6:30 AM, Shreyansh Jain
> wrote:
>> From: Jan Viktorin
>>
>> Signed-off-by: Jan Viktorin
>> Signed-off-by: Shreyansh Jain
>> ---
>> lib/librte_eal/common/include/rte_c
On Thursday 17 November 2016 05:25 PM, Jan Blunck wrote:
> On Thu, Nov 17, 2016 at 6:29 AM, Shreyansh Jain
> wrote:
>> DPDK has been inherently a PCI inclined framework. Because of this, the
>> design of device tree (or list) within DPDK is also PCI inclined. A non-PCI
>
sorry for delay in responding; somehow I didn't notice this email.
On Thursday 17 November 2016 06:23 PM, Jan Blunck wrote:
> On Thu, Nov 17, 2016 at 6:30 AM, Shreyansh Jain
> wrote:
>> This patch demonstrates how eth_driver can be replaced with appropriate
>> changes for r
On Sunday 20 November 2016 01:30 PM, Jerin Jacob wrote:
> Some platform like octeontx may use pci and
> vdev based combined device to represent a logical
> dpdk functional device.In such case, postponing the
> vdev initialization after pci device
> initialization will provide the better view of
>
On Tuesday 22 November 2016 07:30 AM, Yuanhan Liu wrote:
> On Sat, Nov 19, 2016 at 12:57:15AM +0530, Jerin Jacob wrote:
>> On Fri, Nov 18, 2016 at 04:04:29PM +, Bruce Richardson wrote:
>>> +Thomas
>>>
>>> On Fri, Nov 18, 2016 at 03:25:18PM +, Bruce Richardson wrote:
On Fri, Nov 18,
On Monday 21 November 2016 10:25 PM, Jan Blunck wrote:
> This macro is based on Jan Viktorin's original patch but also checks the
> type of the passed pointer against the type of the member.
>
> Signed-off-by: Jan Viktorin
> Signed-off-by: Shreyansh Jain
> [jblunck at infra
On Monday 21 November 2016 10:25 PM, Jan Blunck wrote:
> The drivers should not directly access the rte_eth_dev->pci_dev but use
> a macro instead. This is a preparation for replacing the pci_dev with
> a struct rte_device member in the future.
>
> Signed-off-by: Jan Blunck
> ---
>
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Tuesday, November 22, 2016 3:50 PM
> To: Shreyansh Jain ; Jan Blunck
>
> Cc: dev at dpdk.org; david.marchand at 6wind.com; Jan Viktorin
>
> Subject: Re: [dpdk-dev] [P
> -Original Message-
> From: Jan Viktorin [mailto:viktorin at rehivetech.com]
> Sent: Tuesday, November 22, 2016 6:03 PM
> To: Shreyansh Jain
> Cc: Thomas Monjalon ; Jan Blunck
> ; dev at dpdk.org; david.marchand at 6wind.com
> Subject: Re: [dpdk-dev] [PATC
I should have replied to this earlier, apologies.
On Sunday 20 November 2016 09:00 PM, David Marchand wrote:
> On Thu, Nov 17, 2016 at 6:29 AM, Shreyansh Jain
> wrote:
>> DPDK has been inherently a PCI inclined framework. Because of this, the
>> design of device tree (or
> + if (ret) {
> dev->driver = NULL;
> + if (dr->drv_flags & RTE_PCI_DRV_NEED_MAPPING)
> + rte_eal_pci_unmap_device(dev);
> + }
>
> return ret;
> }
>
Acked-by: Shreyansh Jain
On Thursday 24 November 2016 01:37 AM, Ben Walker wrote:
> Attaching and detaching ethernet ports from an application
> is not the same thing as physically removing a PCI device,
> so clarify the flags indicating support. All PCI devices
> are assumed to be physically removable, so no flag is
>
>d_name, sizeof(e->d_name), )
> != 0)
> continue;
>
> snprintf(dirname, sizeof(dirname), "%s/%s",
> pci_get_sysfs_path(), e->d_name);
> - if (pci_scan_one(dirname, domain, bus, devid, function) < 0)
> + if (pci_scan_one(dirname, ) < 0)
> goto error;
> }
> closedir(dir);
> +
> return 0;
>
> error:
>
This is much more cleaner than passing all the BDF entries.
Except the above unnecessary new line:
Acked-by: Shreyansh Jain
Hi Ben,
On Thursday 24 November 2016 01:37 AM, Ben Walker wrote:
> rte_eal_pci_scan can be called repeatedly to re-scan the PCI
> bus. If a device was removed from the system, the associated
> driver will automatically be unloaded.
>
> Signed-off-by: Ben Walker
> ---
[...]
While reviewing, I
On Thursday 24 November 2016 01:37 AM, Ben Walker wrote:
> Two functions is both confusing and unnecessary. Previously,
> rte_eal_pci_scan populated an internal list of devices by
> scanning sysfs. Then, rte_eal_pci_probe would match registered
> drivers to that internal list. These are not really
Hi David,
On Friday 30 September 2016 09:01 PM, David Marchand wrote:
> On Tue, Sep 27, 2016 at 4:12 PM, Shreyansh Jain
> wrote:
>> (I rebased these over HEAD 7b3c4f3)
>>
>> These patches were initially part of Jan's original series on SoC
>> Framework ([1],
On Monday 03 October 2016 07:51 PM, Thomas Monjalon wrote:
> 2016-09-20 18:11, Shreyansh Jain:
>> --- a/lib/librte_ether/rte_ethdev.h
>> +++ b/lib/librte_ether/rte_ethdev.h
>> @@ -4372,6 +4372,19 @@ rte_eth_dev_get_port_by_name(const char *name,
>>
Hi Thomas,
On Monday 03 October 2016 07:58 PM, Thomas Monjalon wrote:
> Applied, thanks everybody for the great (re)work!
Thanks!
>
> 2016-09-20 18:11, Shreyansh Jain:
>> Future Work/Pending:
>> ===
>> - Presently eth_driver, rte_eth_dev are no
Hi Thomas,
On Tuesday 04 October 2016 01:12 PM, Thomas Monjalon wrote:
> 2016-10-04 12:21, Shreyansh Jain:
>> Hi Thomas,
>>
>> On Monday 03 October 2016 07:58 PM, Thomas Monjalon wrote:
>>> Applied, thanks everybody for the great (re)work!
>>
>> Tha
Hi Thomas,
On Monday 03 October 2016 07:06 PM, Thomas Monjalon wrote:
> 2016-10-03 11:07, Shreyansh Jain:
>> Hi David,
>>
>> On Friday 30 September 2016 09:01 PM, David Marchand wrote:
>>> On Tue, Sep 27, 2016 at 4:12 PM, Shreyansh Jain
>>> wrote:
Inline with PCI probe and remove, VDEV probe and remove hooks provide
a uniform naming.
PCI probe represents scan and driver initialization. For VDEV, it will
represent argument parsing and initialization.
Signed-off-by: Shreyansh Jain
---
drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 12
d_virtio_map,
> .drv_flags = RTE_PCI_DRV_DETACHABLE,
> .probe = rte_eth_dev_pci_probe,
>
Indeed. For MLX4/5 and Virtio, DRIVER_REGISTER_* is not being used which
takes this 'name'. In this case, it was missed.
Acked-by: Shreyansh Jain
DRIVER_REGISTER_PCI -> EAL_REGISTER_PCI
DRIVER_REGISTER_PCI_TABLE -> EAL_REGISTER_PCI_TABLE
Signed-off-by: Shreyansh Jain
---
doc/guides/prog_guide/dev_kit_build_system.rst | 2 +-
drivers/crypto/qat/rte_qat_cryptodev.c | 4 ++--
drivers/net/bnx2x/bnx2x_ethdev.c
Signed-off-by: Shreyansh Jain
---
drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 2 +-
drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 2 +-
drivers/crypto/kasumi/rte_kasumi_pmd.c | 2 +-
drivers/crypto/null/null_crypto_pmd.c | 2 +-
drivers/crypto/snow3g/rte_snow3g_pmd.c | 2 +-
drivers
Signed-off-by: Shreyansh Jain
---
drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 2 +-
drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 2 +-
drivers/crypto/kasumi/rte_kasumi_pmd.c | 2 +-
drivers/crypto/null/null_crypto_pmd.c | 2 +-
drivers/crypto/snow3g/rte_snow3g_pmd.c | 2 +-
drivers
Hi David, Thomas,
On Friday 07 October 2016 07:03 PM, Shreyansh Jain wrote:
> DRIVER_REGISTER_PCI -> EAL_REGISTER_PCI
> DRIVER_REGISTER_PCI_TABLE -> EAL_REGISTER_PCI_TABLE
>
> Signed-off-by: Shreyansh Jain
> ---
> doc/guides/prog_guide/dev_kit_build_system.rst | 2
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Friday, October 07, 2016 7:15 PM
> To: Shreyansh Jain
> Cc: david.marchand at 6wind.com; dev at dpdk.org
> Subject: Re: [PATCH 1/3] eal/drivers: prefix driver REGISTER macros wit
Hi Thomas,
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Friday, October 07, 2016 7:22 PM
> To: Shreyansh Jain
> Cc: david.marchand at 6wind.com; dev at dpdk.org
> Subject: Re: [PATCH 1/3] eal/drivers: prefix driver REGIST
Hi Neil,
> -Original Message-
> From: Neil Horman [mailto:nhorman at tuxdriver.com]
> Sent: Friday, October 07, 2016 7:48 PM
> To: Thomas Monjalon
> Cc: Shreyansh Jain ; david.marchand at 6wind.com;
> dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 1/3] eal/d
AM_STRING -> RTE_PMD_REGISTER_PARAM_STRING
DRIVER_EXPORT_* -> RTE_PMD_EXPORT_*
Fix PMDINFOGEN tool to look for exact matches of RTE_PMD_REGISTER_PCI and
RTE_PMD_REGISTER_VDEV.
Signed-off-by: Shreyansh Jain
--
Changes since v0:
- expand replacement to DRIVER_EXPORT_*
- merge all changes into single commit
- c
On 10/8/2016 11:31 PM, Shreyansh Jain wrote:
> All macros related to driver registeration renamed from DRIVER_*
> to RTE_PMD_*
>
> This includes:
>
> DRIVER_REGISTER_PCI -> RTE_PMD_REGISTER_PCI
> DRIVER_REGISTER_PCI_TABLE -> RTE_PMD_REGISTER_PCI_TA
AM_STRING -> RTE_PMD_REGISTER_PARAM_STRING
DRIVER_EXPORT_* -> RTE_PMD_EXPORT_*
Fix PMDINFOGEN tool to look for exact matches of RTE_PMD_REGISTER_PCI and
RTE_PMD_REGISTER_VDEV.
Signed-off-by: Shreyansh Jain
--
Changes since v1:
- Fix patch headline
Changes since v0:
- expand replacement to DRIVER_EXPORT_*
- me
Hi Thomas,
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Sunday, October 09, 2016 1:52 AM
> To: Shreyansh Jain
> Cc: david.marchand at 6wind.com; dev at dpdk.org; nhorman at tuxdriver.com
> Subject: Re: [PATCH v2] driv
On Monday 10 October 2016 01:20 AM, Thomas Monjalon wrote:
> 2016-10-09 15:12, Shreyansh Jain:
>> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
>>> 2016-10-08 23:35, Shreyansh Jain:
>>>> +PMDINFO_TO_O = if grep -E 'RTE_PMD_REGISTER_PCI\([0-9a-zA-Z,_\.
On Monday 10 October 2016 10:41 AM, Shreyansh Jain wrote:
> On Monday 10 October 2016 01:20 AM, Thomas Monjalon wrote:
>> 2016-10-09 15:12, Shreyansh Jain:
>>> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
>>>> 2016-10-08 23:35, Shreyansh Jain:
&g
AM_STRING -> RTE_PMD_REGISTER_PARAM_STRING
DRIVER_EXPORT_* -> RTE_PMD_EXPORT_*
Fix PMDINFOGEN tool to look for matches of RTE_PMD_REGISTER_*.
Signed-off-by: Shreyansh Jain
--
Changes since v2:
- Rebase over master
- revert PMDINFO grep pattern
Changes since v1:
- Fix patch headline
Changes since v0:
- exp
On Monday 10 October 2016 06:26 PM, Neil Horman wrote:
> On Sat, Oct 08, 2016 at 01:00:59PM +0000, Shreyansh Jain wrote:
>> Hi Thomas,
>>
>>> -Original Message-
>>> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
>>> Sent: Friday, Octob
Hi David,
On Friday 30 September 2016 09:01 PM, David Marchand wrote:
> On Tue, Sep 27, 2016 at 4:12 PM, Shreyansh Jain
> wrote:
>> (I rebased these over HEAD 7b3c4f3)
>>
>> These patches were initially part of Jan's original series on SoC
>> Framework ([1],
tch (patch 5 of initial series) has been
dropped for now, we can do this once vdev drivers have been converted
David Marchand, Shreyansh Jain (17):
pci: no need for dynamic tailq init
crypto: no need for a crypto pmd type
drivers: align pci driver definitions
eal: remove duplicat
Signed-off-by: Shreyansh Jain
---
lib/librte_eal/bsdapp/eal/eal_pci.c| 3 ---
lib/librte_eal/common/eal_common_pci.c | 6 --
lib/librte_eal/linuxapp/eal/eal_pci.c | 3 ---
3 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c
b/lib/librte_eal
This information is not used and just adds noise.
Signed-off-by: David Marchand
Signed-off-by: Shreyansh Jain
---
lib/librte_cryptodev/rte_cryptodev.c | 8 +++-
lib/librte_cryptodev/rte_cryptodev.h | 2 --
lib/librte_cryptodev/rte_cryptodev_pmd.h | 3 +--
3 files changed, 4
Pure coding style, but it might make it easier later if we want to move
fields in rte_cryptodev_driver and eth_driver structures.
Signed-off-by: David Marchand
Signed-off-by: Shreyansh Jain
---
drivers/crypto/qat/rte_qat_cryptodev.c | 2 +-
drivers/net/ena/ena_ethdev.c | 2
Signed-off-by: Shreyansh Jain
---
lib/librte_eal/common/eal_private.h | 7 ---
lib/librte_eal/linuxapp/eal/eal.c | 1 +
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/lib/librte_eal/common/eal_private.h
b/lib/librte_eal/common/eal_private.h
index 857dc3e..06a68f6 100644
Introduce a RTE_INIT macro used to mark an init function as a constructor.
Current eal macros have been converted to use this (no functional impact).
DRIVER_REGISTER_PCI is added as a helper for pci drivers.
Suggested-by: Jan Viktorin
Signed-off-by: David Marchand
Signed-off-by: Shreyansh Jain
Preparing for getting rid of rte_cryptodev_driver, here are two wrappers
that can be used by pci drivers that assume a 1 to 1 association between
pci resource and upper interface.
Signed-off-by: David Marchand
Signed-off-by: Shreyansh Jain
---
lib/librte_cryptodev/rte_cryptodev.c
Preparing for getting rid of eth_drv, here are two wrappers that can be
used by pci drivers that assume a 1 to 1 association between pci resource and
upper interface.
Signed-off-by: David Marchand
Signed-off-by: Shreyansh Jain
---
lib/librte_ether/rte_ethdev.c | 14 +++---
lib
t modified - they continue to use PMD_REGISTER_DRIVER.
Signed-off-by: David Marchand
Signed-off-by: Shreyansh Jain
---
drivers/crypto/qat/rte_qat_cryptodev.c | 16 +++-
drivers/net/bnx2x/bnx2x_ethdev.c| 34 +---
drivers/net/bnxt/bnxt_ethdev.c
Now that all pdev are pci drivers, we don't need to register ethdev drivers
through a dedicated channel.
Signed-off-by: David Marchand
Signed-off-by: Shreyansh Jain
---
lib/librte_ether/rte_ethdev.c | 22 --
lib/librte_ether/rte_ethdev.h | 12
2 files changed
Marchand
Tested-by: Rahul Lakkireddy
Signed-off-by: Shreyansh Jain
---
lib/librte_eal/linuxapp/eal/eal.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/librte_eal/linuxapp/eal/eal.c
b/lib/librte_eal/linuxapp/eal/eal.c
index fe9c704..259a7e4 100644
--- a/lib
Eal is a better place than crypto / ethdev to name devices.
Add a helper in eal and make use of it in crypto / ethdev.
Signed-off-by: David Marchand
Signed-off-by: Shreyansh Jain
---
lib/librte_cryptodev/rte_cryptodev.c| 27 ---
lib/librte_eal/common/include
This helper updates a pci device object with latest information it can
find.
It will be used mainly for hotplug code.
Signed-off-by: David Marchand
Signed-off-by: Shreyansh Jain
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 49 +++
lib/librte_eal/common
No need to scan all devices, we only need to update the device being
attached.
Signed-off-by: David Marchand
Signed-off-by: Shreyansh Jain
---
lib/librte_eal/common/eal_common_pci.c | 11 ---
lib/librte_ether/rte_ethdev.c | 3 ---
2 files changed, 8 insertions(+), 6 deletions
Hotplug invocations, which deals with devices, should come from the layer that
already handles them, i.e. EAL.
For both attach and detach operations, 'name' is used to select the bus
that will handle the request.
Signed-off-by: David Marchand
Signed-off-by: Shreyansh Jain
---
lib/librte_eal
Signed-off-by: Shreyansh Jain
---
lib/librte_ether/rte_ethdev.c | 208 +++---
1 file changed, 34 insertions(+), 174 deletions(-)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index fdeac86..86c9d1a 100644
--- a/lib/librte_ether
Now that hotplug has been moved to eal, there is no reason to keep the device
type in this layer.
Signed-off-by: David Marchand
Signed-off-by: Shreyansh Jain
---
app/test/virtual_pmd.c| 2 +-
drivers/net/af_packet/rte_eth_af_packet.c | 2 +-
drivers/net/bonding
Now that all pdev are pci drivers, we don't need to register crypto drivers
through a dedicated channel.
Signed-off-by: David Marchand
Signed-off-by: Shreyansh Jain
---
lib/librte_cryptodev/rte_cryptodev.c | 22 ---
lib/librte_cryptodev/rte_cryptodev_pmd.h | 30
Hi Jan,
On Saturday 30 July 2016 01:44 PM, Jan Viktorin wrote:
> On Thu, 28 Jul 2016 15:06:10 +0530
> Shreyansh Jain wrote:
>
>> Hi Jan,
>>
>> On Friday 15 July 2016 04:18 PM, Shreyansh jain wrote:
>>> On Thursday 14 July 2016 09:27 PM, Jan Viktorin wrote:
Signed-off-by: Shreyansh Jain
---
lib/librte_eal/common/eal_private.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/eal_private.h
b/lib/librte_eal/common/eal_private.h
index 857dc3e..940ec18 100644
--- a/lib/librte_eal/common/eal_private.h
+++ b/lib
Hi Thomas,
On Wednesday 24 August 2016 04:19 PM, Thomas Monjalon wrote:
> 2016-08-24 15:23, Jianbo Liu:
>> This patch set is to implement i40e vector PMD on ARM64.
>
> Thanks for extending ARM support.
>
> The current NIC support status is:
> % git grep -l 'ARM.*=.*Y' doc/guides/nics/features/
>
en split into smaller pieces
- RTE_INIT macro has been added, but in the end, I am not sure it is useful
- device type has been removed from ethdev, as it was used only by hotplug
- getting rid of pmd type in eal patch (patch 5 of initial series) has been
dropped for now, we can do this once vdev dri
Signed-off-by: Jan Viktorin
Signed-off-by: Shreyansh Jain
---
lib/librte_eal/common/include/rte_common.h | 16
1 file changed, 16 insertions(+)
diff --git a/lib/librte_eal/common/include/rte_common.h
b/lib/librte_eal/common/include/rte_common.h
index 332f2a4..a9b6792 100644
Signed-off-by: Shreyansh Jain
---
lib/librte_eal/bsdapp/eal/eal_pci.c| 3 ---
lib/librte_eal/common/eal_common_pci.c | 6 --
lib/librte_eal/linuxapp/eal/eal_pci.c | 3 ---
3 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c
b/lib/librte_eal
Signed-off-by: Shreyansh Jain
---
lib/librte_eal/common/eal_private.h | 7 ---
lib/librte_eal/linuxapp/eal/eal.c | 1 +
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/lib/librte_eal/common/eal_private.h
b/lib/librte_eal/common/eal_private.h
index 19f7535..ca1aec6 100644
This information is not used and just adds noise.
Signed-off-by: David Marchand
Signed-off-by: Shreyansh Jain
---
lib/librte_cryptodev/rte_cryptodev.c | 8 +++-
lib/librte_cryptodev/rte_cryptodev.h | 2 --
lib/librte_cryptodev/rte_cryptodev_pmd.h | 3 +--
3 files changed, 4
Pure coding style, but it might make it easier later if we want to move
fields in rte_cryptodev_driver and eth_driver structures.
Signed-off-by: David Marchand
Signed-off-by: Shreyansh Jain
---
drivers/crypto/qat/rte_qat_cryptodev.c | 2 +-
drivers/net/ena/ena_ethdev.c | 2
Introduce a RTE_INIT macro used to mark an init function as a constructor.
Current eal macros have been converted to use this (no functional impact).
DRIVER_REGISTER_PCI is added as a helper for pci drivers.
Suggested-by: Jan Viktorin
Signed-off-by: David Marchand
Signed-off-by: Shreyansh Jain
crypto and ethdev drivers aligned to PCI probe/remove. Existing handlers for
init/uninit can be easily reused for this.
Signed-off-by: David Marchand
Signed-off-by: Shreyansh Jain
---
lib/librte_cryptodev/rte_cryptodev.c | 16
lib/librte_cryptodev/rte_cryptodev_pmd.h
101 - 200 of 448 matches
Mail list logo
