Review Request 38662: DRILL-3807: [Regression] Query with equality join and a FALSE condition fails to plan

2015-09-22 Thread Sean Hsuan-Yi Chu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38662/ --- Review request for drill, Aman Sinha and Jinfeng Ni. Bugs: DRILL-3807 https

Re: Improved JIRA process

2015-09-22 Thread Aman Sinha
+1 On Tue, Sep 22, 2015 at 7:35 PM, Kamesh wrote: > +1 on this proposal. > > On Wed, Sep 23, 2015 at 7:28 AM, Edmon Begoli wrote: > > > Got it. Makes sense. > > > > On Tue, Sep 22, 2015 at 9:42 PM, Jacques Nadeau > > wrote: > > > > > On (3), my thought is that they plan on commencing in the ne

[GitHub] drill pull request: DRILL-1065: Support for ALTER ... RESET statem...

2015-09-22 Thread sudheeshkatkam
Github user sudheeshkatkam commented on the pull request: https://github.com/apache/drill/pull/159#issuecomment-142477062 (commenting here and not on the commit) There are various ```getOption(...)``` convenient methods in the OptionManager interface with typed validators as p

Re: Improved JIRA process

2015-09-22 Thread Kamesh
+1 on this proposal. On Wed, Sep 23, 2015 at 7:28 AM, Edmon Begoli wrote: > Got it. Makes sense. > > On Tue, Sep 22, 2015 at 9:42 PM, Jacques Nadeau > wrote: > > > On (3), my thought is that they plan on commencing in the next couple > > weeks, (not that they have to complete by then). The fix

Re: Improved JIRA process

2015-09-22 Thread Edmon Begoli
Got it. Makes sense. On Tue, Sep 22, 2015 at 9:42 PM, Jacques Nadeau wrote: > On (3), my thought is that they plan on commencing in the next couple > weeks, (not that they have to complete by then). The fix for tag tells > others how long they it will take. If someone wants it faster, they shoul

Re: Improved JIRA process

2015-09-22 Thread Jacques Nadeau
On (3), my thought is that they plan on commencing in the next couple weeks, (not that they have to complete by then). The fix for tag tells others how long they it will take. If someone wants it faster, they should chime in to help out. -- Jacques Nadeau CTO and Co-Founder, Dremio On Tue, Sep 22

[jira] [Created] (DRILL-3825) Metadata Caching + Impersonation : A count(*) query can bypass security checks

2015-09-22 Thread Rahul Challapalli (JIRA)
Rahul Challapalli created DRILL-3825: Summary: Metadata Caching + Impersonation : A count(*) query can bypass security checks Key: DRILL-3825 URL: https://issues.apache.org/jira/browse/DRILL-3825

Re: Improved JIRA process

2015-09-22 Thread Edmon Begoli
Sounds good to me. I would only comment that we should probably relax item 3 to tie the commitment to the release schedule. There might be issues that cannot be worked on within few weeks, but are good to keep planned for the future few releases ahead. On Tue, Sep 22, 2015 at 9:05 PM, Jacques Nad

Re: Improved JIRA process

2015-09-22 Thread Andrew
I think it's a great idea. Big plus one. Sent from my iPhone > On Sep 22, 2015, at 6:05 PM, Jacques Nadeau wrote: > > Hey Everybody, > > As more and more people are starting to work on JIRAs, I'd like to propose > a new process around jira assignment, targeting, etc. This way people will > be

Improved JIRA process

2015-09-22 Thread Jacques Nadeau
Hey Everybody, As more and more people are starting to work on JIRAs, I'd like to propose a new process around jira assignment, targeting, etc. This way people will be able to more easily identify available issues for pick up and general development intentions. I propose the following: 1. We

Re: The meaning/intent of the following methods - JSON storage format - part 1

2015-09-22 Thread Jacques Nadeau
31: I think that is the default behavior of Eclipse when it generates a hashcode for a class that has no properties. -- Jacques Nadeau CTO and Co-Founder, Dremio On Tue, Sep 22, 2015 at 5:00 PM, Ted Dunning wrote: > Actually, returning a constant from a hashCode function is pretty goofy. > > I

Re: Refresh Table Metadata : Cache file owner

2015-09-22 Thread rahul challapalli
I agree that this is the desirable behavior. Just wanted to confirm it. On Mon, Sep 21, 2015 at 10:10 PM, Neeraja Rentachintala < nrentachint...@maprtech.com> wrote: > yes, having Drill process being the owner of the metadata cache makes sense > since the goal of the cache is to speed up planning

[jira] [Created] (DRILL-3824) Cancelling the "refresh table metadata" command does not cancel it on the drillbit

2015-09-22 Thread Rahul Challapalli (JIRA)
Rahul Challapalli created DRILL-3824: Summary: Cancelling the "refresh table metadata" command does not cancel it on the drillbit Key: DRILL-3824 URL: https://issues.apache.org/jira/browse/DRILL-3824

[jira] [Created] (DRILL-3823) Exception when grouping by case expression and columns array

2015-09-22 Thread Victoria Markman (JIRA)
Victoria Markman created DRILL-3823: --- Summary: Exception when grouping by case expression and columns array Key: DRILL-3823 URL: https://issues.apache.org/jira/browse/DRILL-3823 Project: Apache Dril

Re: The meaning/intent of the following methods - JSON storage format - part 1

2015-09-22 Thread Ted Dunning
Actually, returning a constant from a hashCode function is pretty goofy. In the String implementation 31 is a *factor*. On Tue, Sep 22, 2015 at 4:25 PM, Jinfeng Ni wrote: > For question 5, this link [1] probably explains why 31 is used: > > > [1] > http://stackoverflow.com/questions/299304/wh

[GitHub] drill pull request: DRILL-1065: Support for ALTER ... RESET statem...

2015-09-22 Thread jacques-n
Github user jacques-n commented on the pull request: https://github.com/apache/drill/pull/159#issuecomment-142454472 Let's fix this as part of the patch. Since we don't actually support EXEC (as far as I can remember), let's make this work nicely by removing it as a reserved word. (I

Re: Review Request 38359: DRILL-3201: Add authentication and authorization to Drill Web client

2015-09-22 Thread Jacques Nadeau
> On Sept. 22, 2015, 3:41 p.m., Jacques Nadeau wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/RestServerHelper.java, > > line 190 > > > > > > If you permissions annotations on the Login/

Re: The meaning/intent of the following methods - JSON storage format - part 1

2015-09-22 Thread Jinfeng Ni
For question 5, this link [1] probably explains why 31 is used: [1] http://stackoverflow.com/questions/299304/why-does-javas-hashcode-in-string-use-31-as-a-multiplier On Tue, Sep 22, 2015 at 10:05 AM, Abdel Hakim Deneche wrote: > Question 3: > I would assume getWriterOperatorType() has a simi

[jira] [Created] (DRILL-3822) PathScanner fails to find jdbc-all's drill-module.conf in SQuirreL

2015-09-22 Thread Krystal (JIRA)
Krystal created DRILL-3822: -- Summary: PathScanner fails to find jdbc-all's drill-module.conf in SQuirreL Key: DRILL-3822 URL: https://issues.apache.org/jira/browse/DRILL-3822 Project: Apache Drill

[jira] [Created] (DRILL-3821) refresh table metadata command is updating the cache every single time

2015-09-22 Thread Rahul Challapalli (JIRA)
Rahul Challapalli created DRILL-3821: Summary: refresh table metadata command is updating the cache every single time Key: DRILL-3821 URL: https://issues.apache.org/jira/browse/DRILL-3821 Project:

Re: Who is coming to Strata NYC?

2015-09-22 Thread Tomer Shiran
Strata is next week. Looking forward to seeing many of you in person. If you haven't already added your name to the list, and you will be in town on Tuesday evening, please go ahead and do that. Time: Tuesday 7pm Location: Pio Pio, 604 10th Ave b/t 44th St & 43rd St Hell's Kitchen, Midtown West O

[GitHub] drill pull request: Update 2014-12-09-running-sql-queries-on-amazo...

2015-09-22 Thread StevenMPhillips
GitHub user StevenMPhillips opened a pull request: https://github.com/apache/drill/pull/164 Update 2014-12-09-running-sql-queries-on-amazon-s3.md You can merge this pull request into a Git repository by running: $ git pull https://github.com/StevenMPhillips/drill patch-1 Alte

Apache Drill Developer Hangout Tuesday September 22, 2015 - Minutes

2015-09-22 Thread Chris Westin
Attendees: Chris Westin, Edmon Bergoli, Sudheesh Katkam, Daniel Barclay, Jinfeng Ni, Venki Korukanti, Julien Le Dem (*) Edmon has outstanding requests on mailing lists - 1. plug-in for reading excel files - 2. plug-in to read EDI files Venki offered some suggestions re using the format plug-in to

[GitHub] drill pull request: DRILL-3811: AtomicRemainder incorrectly accoun...

2015-09-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/163 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Created] (DRILL-3820) Nested Directories : Metadata Cache in a directory stores information from sub-directories as well creating security issues

2015-09-22 Thread Rahul Challapalli (JIRA)
Rahul Challapalli created DRILL-3820: Summary: Nested Directories : Metadata Cache in a directory stores information from sub-directories as well creating security issues Key: DRILL-3820 URL: https://issues.ap

Re: Review Request 38359: DRILL-3201: Add authentication and authorization to Drill Web client

2015-09-22 Thread Venki Korukanti
> On Sept. 22, 2015, 8:41 a.m., Jacques Nadeau wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/RestServerHelper.java, > > line 190 > > > > > > If you permissions annotations on the Login/

Re: The meaning/intent of the following methods - JSON storage format - part 1

2015-09-22 Thread Abdel Hakim Deneche
Question 3: I would assume getWriterOperatorType() has a similar meaning to getReaderOperatorType() but it's not used anywhere in Drill. That would explain why JsonFormatPlugin throws an UnsupportedOperationException Question 4: supportsPushDown() is about "projection" push down and not filter pus

Drill community hangout starting in about 20 minutes (10am PST)

2015-09-22 Thread Chris Westin
Join us here: https://plus.google.com/hangouts/_/event/ci4rdiju8bv04a64efj5fedd0lc

[GitHub] drill pull request: DRILL-3811: AtomicRemainder incorrectly accoun...

2015-09-22 Thread cwestin
Github user cwestin commented on a diff in the pull request: https://github.com/apache/drill/pull/163#discussion_r40109454 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/memory/AtomicRemainder.java --- @@ -76,16 +74,17 @@ public void setLimit(long limit) {

[GitHub] drill pull request: DRILL-1065: Support for ALTER ... RESET statem...

2015-09-22 Thread sudheeshkatkam
Github user sudheeshkatkam commented on the pull request: https://github.com/apache/drill/pull/159#issuecomment-142342234 We use "exec" as the first part of many option names (e.g. ```exec.min_hash_table_size```), and unfortunately, "exec" is a keyword, and the parser throws an error

Re: Review Request 38359: DRILL-3201: Add authentication and authorization to Drill Web client

2015-09-22 Thread Jacques Nadeau
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38359/#review7 --- exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/Rest

[GitHub] drill pull request: DRILL-1065: Support for ALTER ... RESET statem...

2015-09-22 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/159#discussion_r40101930 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/CompoundIdentifierConverter.java --- @@ -107,7 +117,7 @@ public SqlNode

[GitHub] drill pull request: DRILL-1065: Support for ALTER ... RESET statem...

2015-09-22 Thread jacques-n
Github user jacques-n commented on the pull request: https://github.com/apache/drill/pull/159#issuecomment-142325962 As an aside, I'm really excited about this commit. Should make things much easier for end users. We should probably create a new jira to update the docs to remove escap

[GitHub] drill pull request: DRILL-1065: Support for ALTER ... RESET statem...

2015-09-22 Thread jacques-n
Github user jacques-n commented on a diff in the pull request: https://github.com/apache/drill/pull/159#discussion_r40101415 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/CompoundIdentifierConverter.java --- @@ -107,7 +117,7 @@ public SqlNode visi

[jira] [Created] (DRILL-3819) Remove redundant filter for files start with "."

2015-09-22 Thread Mehant Baid (JIRA)
Mehant Baid created DRILL-3819: -- Summary: Remove redundant filter for files start with "." Key: DRILL-3819 URL: https://issues.apache.org/jira/browse/DRILL-3819 Project: Apache Drill Issue Type:

[jira] [Resolved] (DRILL-2424) Ignore hidden files in directory path

2015-09-22 Thread Mehant Baid (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-2424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mehant Baid resolved DRILL-2424. Resolution: Duplicate Assignee: Mehant Baid (was: Steven Phillips) > Ignore hidden files in d

[jira] [Created] (DRILL-3818) NPE when DISTINCT and GROUP BY is used in avro or json

2015-09-22 Thread Philip Deegan (JIRA)
Philip Deegan created DRILL-3818: Summary: NPE when DISTINCT and GROUP BY is used in avro or json Key: DRILL-3818 URL: https://issues.apache.org/jira/browse/DRILL-3818 Project: Apache Drill I