[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53544668 --- Diff: logical/src/main/java/org/apache/drill/common/expression/DumbLogicalExpression.java --- @@ -0,0 +1,60 @@ +/** + * Licensed to the Apa

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53544612 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/Checker.java --- @@ -20,11 +20,24 @@ import org.apache.calcite.sql.SqlCall

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53543354 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/annotations/FunctionTemplate.java --- @@ -55,12 +55,19 @@ FunctionScope

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53543118 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFuncHolder.java --- @@ -264,22 +265,43 @@ public boolean isFieldReader(int i)

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53543109 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFuncHolder.java --- @@ -264,22 +265,43 @@ public boolean isFieldReader(int i)

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53543104 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/annotations/FunctionTemplate.java --- @@ -55,12 +55,19 @@ FunctionScope

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread hsuanyi
Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53541919 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillConstExecutor.java --- @@ -98,11 +98,37 @@ // - CHAR, SYMBOL

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread hsuanyi
Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53541240 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DummyConvertFrom.java --- @@ -32,6 +34,8 @@ @FunctionTemplate(name = "conv

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread hsuanyi
Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53541208 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java --- @@ -92,38 +94,46 @@ public DrillFunctionRegistry(ScanResul

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread hsuanyi
Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53541152 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/annotations/FunctionTemplate.java --- @@ -75,7 +82,7 @@ NULL_IF_NULL; }

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread hsuanyi
Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53540918 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DummyConvertFrom.java --- @@ -32,6 +34,8 @@ @FunctionTemplate(name = "conv

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53540420 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java --- @@ -0,0 +1,196 @@ +/** + * Licensed to the Apac

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53540182 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java --- @@ -0,0 +1,196 @@ +/** + * Licensed to the Apac

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53540001 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java --- @@ -0,0 +1,196 @@ +/** + * Licensed to the Apac

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53539694 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java --- @@ -0,0 +1,196 @@ +/** + * Licensed to the Apac

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread hsuanyi
Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53539514 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/resolver/FunctionResolver.java --- @@ -23,8 +23,11 @@ import org.apache.drill.common.express

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53539261 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java --- @@ -0,0 +1,196 @@ +/** + * Licensed to the Apac

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53538957 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java --- @@ -0,0 +1,196 @@ +/** + * Licensed to the

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53538950 --- Diff: logical/src/main/java/org/apache/drill/common/expression/visitors/ExprVisitor.java --- @@ -43,30 +43,61 @@ import org.apache.drill.commo

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53538945 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/FunctionIterator.java --- @@ -0,0 +1,77 @@ +/** + * Licensed to the Apac

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53538706 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/resolver/FunctionResolver.java --- @@ -23,8 +23,11 @@ import org.apache.drill.common.

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53538435 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillExtractConvertlet.java --- @@ -51,17 +53,38 @@ public RexNode convertCall

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53538446 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillOperatorTable.java --- @@ -45,17 +95,27 @@ public DrillOperatorTable(Fun

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53538444 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillOperatorTable.java --- @@ -26,17 +63,30 @@ import org.apache.calcite

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53538419 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillCalciteSqlAggFunctionWrapper.java --- @@ -0,0 +1,205 @@ +/** + *

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53538421 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillCalciteSqlFunctionWrapper.java --- @@ -0,0 +1,212 @@ +/** + * Lic

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53538425 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillCalciteSqlFunctionWrapper.java --- @@ -0,0 +1,212 @@ +/** + * Lic

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53538433 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillCalciteSqlWrapper.java --- @@ -0,0 +1,24 @@ +/** + * Licensed to

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53538428 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillCalciteSqlOperatorWrapper.java --- @@ -0,0 +1,187 @@ +/** + * Lic

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53538415 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillCalciteSqlAggFunctionWrapper.java --- @@ -0,0 +1,205 @@ +/** + *

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53538429 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillCalciteSqlOperatorWrapper.java --- @@ -0,0 +1,187 @@ +/** + * Lic

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53537811 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DummyConvertTo.java --- @@ -32,6 +34,8 @@ @FunctionTemplate(name = "conv

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53538246 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/annotations/FunctionTemplate.java --- @@ -109,6 +116,16 @@ public int getValue() {

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53537856 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DummyFlatten.java --- @@ -32,6 +34,7 @@ @FunctionTemplate(name = "flatte

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53537609 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DummyConvertFrom.java --- @@ -32,6 +34,8 @@ @FunctionTemplate(name = "co

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread hsuanyi
Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53537367 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFuncHolder.java --- @@ -264,7 +265,24 @@ public boolean isFieldReader(int i) {

[GitHub] drill pull request: DRILL-4416: quote path separator for cross pla...

2016-02-19 Thread adeneche
Github user adeneche commented on the pull request: https://github.com/apache/drill/pull/385#issuecomment-186464365 +1, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53537102 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillConstExecutor.java --- @@ -98,11 +98,37 @@ // - CHAR,

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53537111 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillConstExecutor.java --- @@ -98,11 +98,37 @@ // - CHAR,

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53537107 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillConstExecutor.java --- @@ -98,11 +98,37 @@ // - CHAR,

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53537087 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java --- @@ -92,38 +94,46 @@ public DrillFunctionRegistry(Sc

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53537084 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/annotations/FunctionTemplate.java --- @@ -75,7 +82,7 @@ NULL_IF_NULL;

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53537095 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java --- @@ -38,6 +39,9 @@ import com.google.c

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53537030 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DummyConvertFrom.java --- @@ -32,6 +34,8 @@ @FunctionTemplate(name = "co

[GitHub] drill pull request: DRILL-4416: quote path separator for cross pla...

2016-02-19 Thread hnfgns
GitHub user hnfgns opened a pull request: https://github.com/apache/drill/pull/385 DRILL-4416: quote path separator for cross platform compatibility You can merge this pull request into a Git repository by running: $ git pull https://github.com/hnfgns/incubator-drill DRILL-441

[jira] [Created] (DRILL-4416) Quote path separator for windows

2016-02-19 Thread Hanifi Gunes (JIRA)
Hanifi Gunes created DRILL-4416: --- Summary: Quote path separator for windows Key: DRILL-4416 URL: https://issues.apache.org/jira/browse/DRILL-4416 Project: Apache Drill Issue Type: Bug

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread hsuanyi
Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53536850 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java --- @@ -17,40 +17,42 @@ */ package org.apache.drill

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53536574 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java --- @@ -17,40 +17,42 @@ */ package org.apache.dri

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53536497 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlOperator.java --- @@ -18,69 +18,81 @@ package org.apache.drill.e

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread hsuanyi
Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53533767 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java --- @@ -17,40 +17,42 @@ */ package org.apache.drill

[GitHub] drill pull request: DRILL-4287: During initial DrillTable creation...

2016-02-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/376 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread hsuanyi
Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53533306 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFuncHolder.java --- @@ -264,7 +265,24 @@ public boolean isFieldReader(int i) {

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread hsuanyi
Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53533236 --- Diff: exec/java-exec/src/main/codegen/templates/DateIntervalFunctionTemplates/Extract.java --- @@ -31,6 +31,48 @@ public class ${className} {

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread hsuanyi
Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53533100 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctions.java --- @@ -216,6 +217,20 @@ public void eval() { }

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53529398 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java --- @@ -17,40 +17,42 @@ */ package org.apache.dri

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53528079 --- Diff: exec/java-exec/src/main/codegen/templates/DateIntervalFunctionTemplates/Extract.java --- @@ -31,6 +31,48 @@ public class ${className} {

Re: Move master to 1.6.0-SNAPSHOT?

2016-02-19 Thread Aditya
Thanks Jason! On Fri, Feb 19, 2016 at 1:59 PM, Jason Altekruse wrote: > Just pushed the version change. Will do it as soon as I create a release > branch in the future. > > On Fri, Feb 19, 2016 at 1:47 PM, Jason Altekruse > wrote: > >> Agreed, running the build for a sanity check and will push

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53527480 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFuncHolder.java --- @@ -264,7 +265,24 @@ public boolean isFieldReader(int i) {

Re: [DISCUSS] New Feature: Drill Client Impersonation

2016-02-19 Thread Keys Botzum
This is a great feature to add to Drill and I'm excited to see design on it starting. The ability for an intermediate server that is likely already authenticating end users, to send end user identity down to Drill adds a key element into an end to end secure design by enabling Drill and the bac

Re: Optimizing SUM(1) query

2016-02-19 Thread Andries Engelbrecht
What are you trying to do in Tableau that generates these queries? Do you have the actual full query that is being generated? Tableau has a number of customization features, wonder if it is possible to optimize those settings to avoid this issue. --Andries > On Feb 19, 2016, at 10:16 AM, Sudi

Re: Move master to 1.6.0-SNAPSHOT?

2016-02-19 Thread Jason Altekruse
Just pushed the version change. Will do it as soon as I create a release branch in the future. On Fri, Feb 19, 2016 at 1:47 PM, Jason Altekruse wrote: > Agreed, running the build for a sanity check and will push when it > completes. > > On Fri, Feb 19, 2016 at 1:31 PM, Aditya wrote: > >> In my

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread hnfgns
Github user hnfgns commented on the pull request: https://github.com/apache/drill/pull/377#issuecomment-186424169 As a general reminder, we should use a more descriptive commit message. It is useful to understand what this patch is about just by looking at the commit message. --- If

[DISCUSS] New Feature: Drill Client Impersonation

2016-02-19 Thread Sudheesh Katkam
Hey y’all, I plan to work on DRILL-4281 : support for inbound/client impersonation. Please review the design document , which is open for comments. There is also a

Re: Move master to 1.6.0-SNAPSHOT?

2016-02-19 Thread Jason Altekruse
Agreed, running the build for a sanity check and will push when it completes. On Fri, Feb 19, 2016 at 1:31 PM, Aditya wrote: > In my opinion this should be done as the next commit on the master branch > as soon a release branch is created. > > This avoids maven artifacts from one branch pollutin

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53522848 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctions.java --- @@ -216,6 +217,20 @@ public void eval() { }

Re: Move master to 1.6.0-SNAPSHOT?

2016-02-19 Thread Aditya
In my opinion this should be done as the next commit on the master branch as soon a release branch is created. This avoids maven artifacts from one branch polluting another. We should definitely do it now. aditya... On Fri, Feb 19, 2016 at 10:37 AM, Abhishek Girish wrote: > Hey Jason, > > Sho

Re: Optimizing SUM(1) query

2016-02-19 Thread Julian Hyde
PS I did recall correctly: https://issues.apache.org/jira/browse/HIVE-6192. But it's not implemented using Calcite, sadly. On Fri, Feb 19, 2016 at 12:11 PM, Julian Hyde wrote: > And indeed COUNT(*) is equivalent to COUNT(1). COUNT(*) is the same as > COUNT(e) where e is any not-null value. > > I

Re: Optimizing SUM(1) query

2016-02-19 Thread Julian Hyde
And indeed COUNT(*) is equivalent to COUNT(1). COUNT(*) is the same as COUNT(e) where e is any not-null value. I would argue that SUM(1) should be optimized to COUNT(*). Or, generalizing a bit, that SUM(c) should be optimized to COUNT(*) * c. IIRC, Hive performs that optimization. It's a bit tric

Re: Optimizing SUM(1) query

2016-02-19 Thread Aman Sinha
For #records, why would tableau generate sum(1) instead of count(1) ? Drill does not have specific optimization for sum(1). It does have optimization for count for Parquet data. Aman On Fri, Feb 19, 2016 at 10:16 AM, Sudip Mukherjee wrote: > Hi, > > Have anyone tried optimizing SUM(1) query i

[jira] [Created] (DRILL-4415) Minimum parallelization width not respected in group scans

2016-02-19 Thread MinJi Kim (JIRA)
MinJi Kim created DRILL-4415: Summary: Minimum parallelization width not respected in group scans Key: DRILL-4415 URL: https://issues.apache.org/jira/browse/DRILL-4415 Project: Apache Drill Issue

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread hsuanyi
Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53500132 --- Diff: pom.xml --- @@ -1278,7 +1278,7 @@ org.apache.calcite calcite-core -1.4.0-drill-r10

[GitHub] drill pull request: Drill 4372 for review

2016-02-19 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/377#discussion_r53499889 --- Diff: pom.xml --- @@ -1278,7 +1278,7 @@ org.apache.calcite calcite-core -1.4.0-drill-r10

Move master to 1.6.0-SNAPSHOT?

2016-02-19 Thread Abhishek Girish
Hey Jason, Should we update the version info? I built from master and it still shows up as 1.5.0-SNAPSHOT Thanks, Abhishek

Optimizing SUM(1) query

2016-02-19 Thread Sudip Mukherjee
Hi, Have anyone tried optimizing SUM(1) query in drill? Or is it implemented? Getting these query while using Tableau. Mostly probably it is trying to figure out NUMBER_OF_RECORDS. Thanks, Sudip ***Legal Disclaimer*** "This communication may con

Re: Client Load-balancing and Session Stickiness

2016-02-19 Thread Parth Chandra
With a client connection pool, there is no good (and easy) way to provide session stickiness. We could try to introduce the idea of a cluster wide session, but that is going to be hairy. Th other option, localizing it to a client is for the client to maintain session settings and setting them expl

[GitHub] drill pull request: DRILL-4392: Fix CTAS partition to remove one u...

2016-02-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/383 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] drill pull request: DRILL-4392: Fix CTAS partition to remove one u...

2016-02-19 Thread jinfengni
Github user jinfengni commented on the pull request: https://github.com/apache/drill/pull/383#issuecomment-186332099 Right. The planner could not remove that internal field by projection removal, since Writer operator has to use that field. It's the writer's job to exclude that field

[GitHub] drill pull request: DRILL-4346: Handle NumberFormatException when ...

2016-02-19 Thread vdiravka
GitHub user vdiravka opened a pull request: https://github.com/apache/drill/pull/384 DRILL-4346: Handle NumberFormatException when casting empty string to int in hbase/maprdb - Made replacing of functions casting for nullable input varbinary and var16char types are working (in Cast