[GitHub] drill pull request #997: DRILL-5582: C++ Client: [Threat Modeling] Drillbit ...

2017-10-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/997#discussion_r145319769 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -518,6 +518,22 @@ bool DrillClientImpl::clientNeedsEncryption(const

[GitHub] drill pull request #997: DRILL-5582: C++ Client: [Threat Modeling] Drillbit ...

2017-10-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/997#discussion_r145319760 --- Diff: contrib/native/client/src/clientlib/saslAuthenticatorImpl.cpp --- @@ -145,6 +145,8 @@ int SaslAuthenticatorImpl::init(const std::vector& mechanisms,

[GitHub] drill issue #999: DRILL-5881:Java Client: [Threat Modeling] Drillbit may be ...

2017-10-17 Thread sohami
Github user sohami commented on the issue: https://github.com/apache/drill/pull/999 @parthchandra - Please help to review this PR. I have added new unit tests for the change and made sure all the existing test's are also passing. ---

[GitHub] drill pull request #997: DRILL-5582: C++ Client: [Threat Modeling] Drillbit ...

2017-10-17 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/997#discussion_r145317288 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -595,6 +611,12 @@ connectionStatus_t

[GitHub] drill pull request #997: DRILL-5582: C++ Client: [Threat Modeling] Drillbit ...

2017-10-17 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/997#discussion_r145317403 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -595,6 +611,12 @@ connectionStatus_t

[GitHub] drill pull request #999: DRILL-5881:Java Client: [Threat Modeling] Drillbit ...

2017-10-17 Thread sohami
GitHub user sohami opened a pull request: https://github.com/apache/drill/pull/999 DRILL-5881:Java Client: [Threat Modeling] Drillbit may be spoofed by … …an attacker and this may lead to data being written to the attacker's target instead of Drillbit You can merge this pull

[GitHub] drill pull request #998: DRILL-5887: Display process user/groups info in Dri...

2017-10-17 Thread prasadns14
GitHub user prasadns14 opened a pull request: https://github.com/apache/drill/pull/998 DRILL-5887: Display process user/groups info in Drill UI Display process user and process user groups in Drill UI @paul-rogers please review You can merge this pull request into a Git

[GitHub] drill issue #991: DRILL-5876: Remove netty-tcnative dependency from java-exe...

2017-10-17 Thread parthchandra
Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/991 @vrozov per your other tests, this is still broken for eclipse. So it seems that the best bet is to comment out the dependency and the os extension. Developers needing to debug, will need to

[GitHub] drill pull request #991: DRILL-5876: Remove netty-tcnative dependency from j...

2017-10-17 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/991#discussion_r145291048 --- Diff: exec/java-exec/pom.xml --- @@ -22,7 +22,10 @@ 1.8-rev1 + --- End diff -- Please uncomment (should

[GitHub] drill pull request #991: DRILL-5876: Remove netty-tcnative dependency from j...

2017-10-17 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/991#discussion_r145289493 --- Diff: exec/java-exec/pom.xml --- @@ -693,6 +699,19 @@ + + openssl + + +

[GitHub] drill pull request #991: DRILL-5876: Remove netty-tcnative dependency from j...

2017-10-17 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/991#discussion_r145288182 --- Diff: exec/java-exec/pom.xml --- @@ -701,18 +707,21 @@ - -kr.motd.maven -os-maven-plugin -

[jira] [Created] (DRILL-5887) Display process user/ groups in Drill UI

2017-10-17 Thread Prasad Nagaraj Subramanya (JIRA)
Prasad Nagaraj Subramanya created DRILL-5887: Summary: Display process user/ groups in Drill UI Key: DRILL-5887 URL: https://issues.apache.org/jira/browse/DRILL-5887 Project: Apache Drill

[GitHub] drill pull request #997: DRILL-5582: C++ Client: [Threat Modeling] Drillbit ...

2017-10-17 Thread bitblender
GitHub user bitblender opened a pull request: https://github.com/apache/drill/pull/997 DRILL-5582: C++ Client: [Threat Modeling] Drillbit may be spoofed by … …an attacker and this may lead to data being written to the attacker's target instead of Drillbit You can merge this

[jira] [Resolved] (DRILL-5804) External Sort times out, may be infinite loop

2017-10-17 Thread Robert Hou (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-5804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Hou resolved DRILL-5804. --- Resolution: Fixed > External Sort times out, may be infinite loop >

[jira] [Created] (DRILL-5886) Operators should create batch sizes that the next operator can consume to avoid OOM

2017-10-17 Thread Robert Hou (JIRA)
Robert Hou created DRILL-5886: - Summary: Operators should create batch sizes that the next operator can consume to avoid OOM Key: DRILL-5886 URL: https://issues.apache.org/jira/browse/DRILL-5886 Project:

[jira] [Created] (DRILL-5885) Drill consumes 2x memory when sorting and reading a spilled batch from disk.

2017-10-17 Thread Robert Hou (JIRA)
Robert Hou created DRILL-5885: - Summary: Drill consumes 2x memory when sorting and reading a spilled batch from disk. Key: DRILL-5885 URL: https://issues.apache.org/jira/browse/DRILL-5885 Project: Apache

[GitHub] drill pull request #996: DRILL-5878: TableNotFound exception is being report...

2017-10-17 Thread HanumathRao
Github user HanumathRao commented on a diff in the pull request: https://github.com/apache/drill/pull/996#discussion_r145268123 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java --- @@ -481,6 +485,19 @@ public RelOptTableImpl

Drill Questions (Developer)

2017-10-17 Thread Max Orelus
Hi, I'm not exactly sure which mail listing I'm suppose to ask these developer questions on, so sorry if there is any inconvenience. I'm developing a web application that relies on Drill as its main search/querying functionality. I've gone through the documentation, but there's a couple things

[GitHub] drill pull request #996: DRILL-5878: TableNotFound exception is being report...

2017-10-17 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/996#discussion_r145231215 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java --- @@ -481,6 +485,19 @@ public RelOptTableImpl

RE: log flooded by "date values definitively CORRECT"

2017-10-17 Thread Kunal Khatua
Ouch! Looks like a logger was left behind in DEBUG mode. Can you manually turn that off? More memory would help in this case, because it seems that the foreman node is the one running out of heap space as it goes through the metadata for all the files. Is there a reason you are generating so

[GitHub] drill issue #970: DRILL-5832: Migrate OperatorFixture to use SystemOptionMan...

2017-10-17 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/970 There is a funny thing about the way Drill works. I can review your changes and commit them as soon as I provide a +1. My changes must wait until another committer to find time in their very busy

log flooded by "date values definitively CORRECT"

2017-10-17 Thread François Méthot
Hi again, I am running into an issue on a query done on 760 000 parquet files stored in HDFS. We are using Drill 1.10, 8GB heap, 20GB direct mem. Drill runs with debug log enabled all the time. The query is standard select on 8 fields from hdfs.`/path` where this = that For about an

[GitHub] drill issue #970: DRILL-5832: Migrate OperatorFixture to use SystemOptionMan...

2017-10-17 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/970 @paul-rogers Some of the changes I am making on top of https://github.com/apache/drill/pull/978/ as part of DRILL-5730 will likely conflict with this change. When do you think this could make it in?

[GitHub] drill issue #936: DRILL-5772: Add unit tests to indicate how utf-8 support c...

2017-10-17 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/936 @paul-rogers agree with you that charsets used in saffron properties should be defaulted in Drill to `UTF-8` since Drill can read UTF-8 data and it's strange that it would fail by

[GitHub] drill pull request #971: Drill-5834 Add Networking Functions

2017-10-17 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/971#discussion_r145080845 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/NetworkFunctions.java --- @@ -0,0 +1,619 @@ +/* + * Licensed to

[GitHub] drill pull request #971: Drill-5834 Add Networking Functions

2017-10-17 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/971#discussion_r145078505 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/NetworkFunctions.java --- @@ -0,0 +1,668 @@ +/** + * Licensed to

[GitHub] drill pull request #971: Drill-5834 Add Networking Functions

2017-10-17 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/971#discussion_r145078865 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/NetworkFunctions.java --- @@ -0,0 +1,619 @@ +/* + * Licensed to

[GitHub] drill issue #976: DRILL-5797: Choose parquet reader from read columns

2017-10-17 Thread dprofeta
Github user dprofeta commented on the issue: https://github.com/apache/drill/pull/976 I updated the javadoc with Paul remarks. ---

[jira] [Created] (DRILL-5884) Encode dot characters and other special characters in identifiers

2017-10-17 Thread second88 (JIRA)
second88 created DRILL-5884: --- Summary: Encode dot characters and other special characters in identifiers Key: DRILL-5884 URL: https://issues.apache.org/jira/browse/DRILL-5884 Project: Apache Drill