Github user akumarb2010 commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r150376586
--- Diff:
contrib/storage-kafka/src/test/java/org/apache/drill/exec/store/kafka/cluster/EmbeddedZKQuorum.java
---
@@ -0,0 +1,83 @@
+/**
--- End
Github user akumarb2010 commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r150376174
--- Diff: contrib/storage-kafka/README.md ---
@@ -0,0 +1,230 @@
+# Drill Kafka Plugin
+
+Drill kafka storage plugin allows you to perform inte
Github user ilooner commented on the issue:
https://github.com/apache/drill/pull/984
After squashing the commits and rebasing I noticed the windows functional
tests were failing. The issue was caused by replacing the '/' constant in
FileUtils (now renamed to DrillFileUtils) in **Class
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/1026
Further, is the extra option to `convertFromJSON` really needed? Can't we
just accept `NaN` and `Infinity` by default?
Consider. If the option is off by default, users without `NaN` or
`
Github user ppadma commented on the issue:
https://github.com/apache/drill/pull/1030
@arina-ielchiieva I have a question. If the splits for a file are spread
across multiple fragments, does this logic work ?
---
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/1023
For commit, let's do this:
* With luck, Arina will commit two PRs this week that may conflict: PR
#970, and PR #978.
* Tim should rebase this PR on top of those changes once they are
Github user prasadns14 commented on a diff in the pull request:
https://github.com/apache/drill/pull/1033#discussion_r150364771
--- Diff: exec/java-exec/src/main/codegen/includes/parserImpls.ftl ---
@@ -215,11 +215,12 @@ SqlNode SqlDropView() :
/**
* Parses a CTAS o
Github user Agirish commented on a diff in the pull request:
https://github.com/apache/drill/pull/1033#discussion_r150364581
--- Diff: exec/java-exec/src/main/codegen/includes/parserImpls.ftl ---
@@ -215,11 +215,12 @@ SqlNode SqlDropView() :
/**
* Parses a CTAS or C
GitHub user prasadns14 opened a pull request:
https://github.com/apache/drill/pull/1033
DRILL-5952: Implement "CREATE TABLE IF NOT EXISTS"
1) Addedsupport for CREATE TABLE
2) Added unit tests for the same
@paul-rogers please review
You can merge this pull request in
Prasad Nagaraj Subramanya created DRILL-5952:
Summary: Implement "CREATE TABLE IF NOT EXISTS"
Key: DRILL-5952
URL: https://issues.apache.org/jira/browse/DRILL-5952
Project: Apache Drill
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1026#discussion_r150359565
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/JsonConvertFrom.java
---
@@ -91,4 +92,60 @@ public void eval(){
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1026#discussion_r150361681
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestJsonNonNumerics.java
---
@@ -0,0 +1,167 @@
+/*
+* License
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1026#discussion_r150359510
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/JsonConvertFrom.java
---
@@ -91,4 +92,60 @@ public void eval(){
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1026#discussion_r150360192
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -502,6 +502,8 @@ drill.exec.options: {
store.format: "parquet",
sto
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1026#discussion_r150359992
--- Diff:
contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoRecordReader.java
---
@@ -73,6 +73,7 @@
private final MongoS
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1026#discussion_r150359452
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/JsonConvertFrom.java
---
@@ -76,7 +77,7 @@ public void eval(){
@
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1026#discussion_r150360424
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestJsonNonNumerics.java
---
@@ -0,0 +1,167 @@
+/*
+* License
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1026#discussion_r150359353
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/JsonConvertFrom.java
---
@@ -50,7 +51,7 @@ private JsonConvertFrom(){}
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1026#discussion_r150360309
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -502,6 +502,8 @@ drill.exec.options: {
store.format: "parquet",
sto
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1026#discussion_r150360262
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -502,6 +502,8 @@ drill.exec.options: {
store.format: "parquet",
sto
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1026#discussion_r150359625
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/JsonConvertTo.java
---
@@ -90,7 +91,71 @@ public void eval(){
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1026#discussion_r150360475
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestJsonNonNumerics.java
---
@@ -0,0 +1,167 @@
+/*
+* License
Github user ilooner commented on the issue:
https://github.com/apache/drill/pull/1023
*Note for batch committer:* Please do not squash the two commits in this
PR. Please see the discussion on **pom.xml** for details.
---
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1023#discussion_r150348155
--- Diff: pom.xml ---
@@ -442,7 +442,7 @@
-Dorg.apache.drill.exec.server.Drillbit.system_options="org.apache.drill.exec.compile.ClassTransf
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1023#discussion_r150345195
--- Diff: pom.xml ---
@@ -442,7 +442,7 @@
-Dorg.apache.drill.exec.server.Drillbit.system_options="org.apache.drill.exec.compile.ClassT
Github user ilooner commented on the issue:
https://github.com/apache/drill/pull/1014
@paul-rogers Thanks for the explanation. Your explanation is in sync with
Arina's descriptions in the ticket and with the code changes. The only point of
confusion I have now is with regards to the C
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/1023#discussion_r150339444
--- Diff: pom.xml ---
@@ -442,7 +442,7 @@
-Dorg.apache.drill.exec.server.Drillbit.system_options="org.apache.drill.exec.compile.ClassTrans
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1023#discussion_r150336286
--- Diff: pom.xml ---
@@ -442,7 +442,7 @@
-Dorg.apache.drill.exec.server.Drillbit.system_options="org.apache.drill.exec.compile.ClassT
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/1025#discussion_r150335985
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java
---
@@ -795,6 +788,8 @@ private void g
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1025#discussion_r150331389
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java
---
@@ -795,6 +788,8 @@ private void generat
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/1025#discussion_r150329246
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java
---
@@ -795,6 +788,8 @@ private void g
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/1023#discussion_r150327067
--- Diff: pom.xml ---
@@ -442,7 +442,7 @@
-Dorg.apache.drill.exec.server.Drillbit.system_options="org.apache.drill.exec.compile.ClassTrans
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1025#discussion_r150326663
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java
---
@@ -177,11 +177,11 @@ public IterOutcome
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1023#discussion_r150322554
--- Diff: pom.xml ---
@@ -442,7 +442,7 @@
-Dorg.apache.drill.exec.server.Drillbit.system_options="org.apache.drill.exec.compile.ClassTransf
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/1014
@ilooner, there are two phases of issues. The problem is in the planner,
but we've been talking about serialization out to the workers.
Here, we can learn from the work Arina did with dyn
Github user amansinha100 commented on the issue:
https://github.com/apache/drill/pull/1025
+1 with a minor comment. In the commit message and JIRA it would be
better to say 'code inspection' instead of code review which may be
interpreted to mean the normal code review process.
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/1025#discussion_r150310556
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java
---
@@ -177,11 +177,11 @@ public IterO
Github user ilooner commented on the issue:
https://github.com/apache/drill/pull/1014
@paul-rogers I follow your explanation except for the last paragraph.
The Drill UI let's me update storage plugins and their formatters at
runtime (at least on my laptop) by going to **Storag
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/1023#discussion_r150302692
--- Diff: pom.xml ---
@@ -442,7 +442,7 @@
-Dorg.apache.drill.exec.server.Drillbit.system_options="org.apache.drill.exec.compile.ClassTrans
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/914#discussion_r149764036
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/writer/BaseScalarWriter.java
---
@@ -0,0 +1,264 @@
+/*
+ * Licensed to
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/914#discussion_r149765040
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/record/MaterializedField.java
---
@@ -168,6 +174,58 @@ public boolean equals(Object obj) {
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/914#discussion_r149758695
--- Diff: exec/vector/src/main/codegen/templates/ColumnAccessors.java ---
@@ -191,141 +180,268 @@ public void bind(RowIndex vectorIndex, ValueVector
vect
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/914#discussion_r149759147
--- Diff: exec/vector/src/main/codegen/templates/ColumnAccessors.java ---
@@ -191,141 +180,268 @@ public void bind(RowIndex vectorIndex, ValueVector
vect
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/914#discussion_r149760234
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/rowSet/test/RowSetTest.java
---
@@ -19,420 +19,648 @@
import static org.junit.As
Saurabh Mahapatra created DRILL-5951:
Summary: Transaction Support (CRUD) operations on HBase and MongoDB
Key: DRILL-5951
URL: https://issues.apache.org/jira/browse/DRILL-5951
Project: Apache Drill
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1023#discussion_r150259975
--- Diff: pom.xml ---
@@ -442,7 +442,7 @@
-Dorg.apache.drill.exec.server.Drillbit.system_options="org.apache.drill.exec.compile.ClassTransf
46 matches
Mail list logo
