[GitHub] drill issue #1190: DRILL-5937: ExecConstants: changed comment, timeout defau...

2018-03-27 Thread pushpendra-jaiswal-90
Github user pushpendra-jaiswal-90 commented on the issue: https://github.com/apache/drill/pull/1190 @vrozov @vdiravka Could you please review this? ---

Kafka Plugin Filter Pushdown Design Proposal

2018-03-27 Thread Abhishek Ravi
Hi All, I'm planning to add Filter Pushdown feature for Kafka Plugin ( https://issues.apache.org/jira/browse/DRILL-5977). I have come up with an initial draft capturing details about the implementation for this feature. ​ Kafka Plugin Filter Pushdown Design Proposal

[GitHub] drill issue #1161: DRILL-6230: Extend row set readers to handle hyper vector...

2018-03-27 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/1161 @ppadma , any partial comments that I can start to take a look at? There are still a number of PRs in this chain and it would be great if we could keep things ticking along... Thanks! ---

[GitHub] drill pull request #1179: DRILL-6254: IllegalArgumentException: the requeste...

2018-03-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1179#discussion_r177619465 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java --- @@ -237,7 +237,10 @@ protected IterOutcom

[GitHub] drill pull request #1181: DRILL-6284: Add operator metrics for batch sizing ...

2018-03-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1181#discussion_r177617185 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java --- @@ -99,6 +100,22 @@ private void clear()

[GitHub] drill pull request #1181: DRILL-6284: Add operator metrics for batch sizing ...

2018-03-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1181#discussion_r177617922 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractRecordBatchMemoryManager.java --- @@ -29,6 +29,50 @@ private int outg

[GitHub] drill pull request #1181: DRILL-6284: Add operator metrics for batch sizing ...

2018-03-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1181#discussion_r177617262 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java --- @@ -99,6 +100,22 @@ private void clear()

[GitHub] drill pull request #1181: DRILL-6284: Add operator metrics for batch sizing ...

2018-03-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1181#discussion_r177617387 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java --- @@ -463,4 +488,20 @@ protected boolean se

[GitHub] drill pull request #1181: DRILL-6284: Add operator metrics for batch sizing ...

2018-03-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1181#discussion_r177617131 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java --- @@ -99,6 +100,22 @@ private void clear()

[GitHub] drill pull request #1181: DRILL-6284: Add operator metrics for batch sizing ...

2018-03-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1181#discussion_r177617860 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractRecordBatchMemoryManager.java --- @@ -29,6 +29,50 @@ private int outg

[GitHub] drill pull request #1181: DRILL-6284: Add operator metrics for batch sizing ...

2018-03-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1181#discussion_r177616893 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java --- @@ -99,6 +100,22 @@ private void clear()

[GitHub] drill pull request #1181: DRILL-6284: Add operator metrics for batch sizing ...

2018-03-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1181#discussion_r177617047 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java --- @@ -99,6 +100,22 @@ private void clear()

[GitHub] drill issue #1105: DRILL-6125: Fix possible memory leak when query is finish...

2018-03-27 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1105 @arina-ielchiieva Please review. ---

[GitHub] drill pull request #1185: DRILL-6288: Upgrade org.javassist:javassist and or...

2018-03-27 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1185#discussion_r177499603 --- Diff: exec/jdbc-all/pom.xml --- @@ -559,7 +559,7 @@ This is likely due to you adding new dependencies to a java-exec and no

[GitHub] drill issue #1189: DRILL-6282: Excluding io.dropwizard.metrics dependencies

2018-03-27 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1189 @vdiravka right, check the first link, the new `groupId` for `com.codahale.metrics` is `io.dropwizard.metrics`, so all new versions will be deployed using the new `groupId`. ---

[GitHub] drill issue #1190: DRILL-5937: ExecConstants: changed comment, timeout defau...

2018-03-27 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1190 +1 ---

[jira] [Created] (DRILL-6294) Update Calcite version to 1.16.0

2018-03-27 Thread Volodymyr Vysotskyi (JIRA)
Volodymyr Vysotskyi created DRILL-6294: -- Summary: Update Calcite version to 1.16.0 Key: DRILL-6294 URL: https://issues.apache.org/jira/browse/DRILL-6294 Project: Apache Drill Issue Type:

[GitHub] drill issue #1190: DRILL-5937: ExecConstants: changed comment, timeout defau...

2018-03-27 Thread pushpendra-jaiswal-90
Github user pushpendra-jaiswal-90 commented on the issue: https://github.com/apache/drill/pull/1190 @arina-ielchiieva I have removed comment. ---

[GitHub] drill pull request #1190: DRILL-5937: ExecConstants: changed comment, timeou...

2018-03-27 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1190#discussion_r177385544 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -557,8 +557,7 @@ private ExecConstants() { public stat

[GitHub] drill issue #1189: DRILL-6282: Excluding io.dropwizard.metrics dependencies

2018-03-27 Thread vdiravka
Github user vdiravka commented on the issue: https://github.com/apache/drill/pull/1189 @vrozov I understand what you mean: `com.codahale` isn't updated for a long time https://mvnrepository.com/artifact/com.codahale.metrics/metrics-core, but `io.dropwizard.metrics` is updated

[GitHub] drill issue #1190: DRILL-5937: ExecConstants: changed comment, timeout defau...

2018-03-27 Thread pushpendra-jaiswal-90
Github user pushpendra-jaiswal-90 commented on the issue: https://github.com/apache/drill/pull/1190 @arina-ielchiieva I have done the changes. Could you please review? ---