[GitHub] kkhatua commented on a change in pull request #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI

2018-07-12 Thread GitBox
kkhatua commented on a change in pull request #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI URL: https://github.com/apache/drill/pull/1379#discussion_r202257580 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryWrapper.java

[GitHub] kkhatua commented on a change in pull request #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI

2018-07-12 Thread GitBox
kkhatua commented on a change in pull request #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI URL: https://github.com/apache/drill/pull/1379#discussion_r202251468 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryWrapper.java

[GitHub] sohami commented on a change in pull request #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI

2018-07-12 Thread GitBox
sohami commented on a change in pull request #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI URL: https://github.com/apache/drill/pull/1379#discussion_r202250119 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryWrapper.java

[GitHub] sohami commented on issue #1307: DRILL-6473: Upgrade Drill 1.14 with Hive 2.3 for mapr profile

2018-07-12 Thread GitBox
sohami commented on issue #1307: DRILL-6473: Upgrade Drill 1.14 with Hive 2.3 for mapr profile URL: https://github.com/apache/drill/pull/1307#issuecomment-404718050 @arina-ielchiieva / @vdiravka - From the comments and changes looks like this change is ready to merge but there is no ready-

[jira] [Resolved] (DRILL-6586) Add SSL Hostname verification with zookeeper connection mode support

2018-07-12 Thread Sorabh Hamirwasia (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-6586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sorabh Hamirwasia resolved DRILL-6586. -- Resolution: Fixed Fix Version/s: 1.14.0 > Add SSL Hostname verification with zoo

[jira] [Resolved] (DRILL-6587) Add support for custom SSL CTX Options

2018-07-12 Thread Sorabh Hamirwasia (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-6587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sorabh Hamirwasia resolved DRILL-6587. -- Resolution: Fixed Fix Version/s: 1.14.0 > Add support for custom SSL CTX Options

[GitHub] sohami closed pull request #1378: DRILL-6601 LageFileCompilation testProject times out

2018-07-12 Thread GitBox
sohami closed pull request #1378: DRILL-6601 LageFileCompilation testProject times out URL: https://github.com/apache/drill/pull/1378 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a f

[GitHub] sohami closed pull request #1364: DRILL-6559: Travis timing out

2018-07-12 Thread GitBox
sohami closed pull request #1364: DRILL-6559: Travis timing out URL: https://github.com/apache/drill/pull/1364 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (fro

[GitHub] sohami closed pull request #1377: DRILL-6596: Fix fillEmpties and set methods for Nullable variable length

2018-07-12 Thread GitBox
sohami closed pull request #1377: DRILL-6596: Fix fillEmpties and set methods for Nullable variable length URL: https://github.com/apache/drill/pull/1377 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provena

[GitHub] sohami closed pull request #1375: DRILL-6594: Data batches for Project operator are not being split properly and exceed the maximum specified

2018-07-12 Thread GitBox
sohami closed pull request #1375: DRILL-6594: Data batches for Project operator are not being split properly and exceed the maximum specified URL: https://github.com/apache/drill/pull/1375 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is disp

[GitHub] sohami closed pull request #1366: [DRILL-6581] C++ Client SSL Implementation Fixes/Improvements

2018-07-12 Thread GitBox
sohami closed pull request #1366: [DRILL-6581] C++ Client SSL Implementation Fixes/Improvements URL: https://github.com/apache/drill/pull/1366 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As th

[GitHub] sohami closed pull request #1374: DRILL-6542 : IndexOutOfBoundsException for multilevel lateral queries…

2018-07-12 Thread GitBox
sohami closed pull request #1374: DRILL-6542 : IndexOutOfBoundsException for multilevel lateral queries… URL: https://github.com/apache/drill/pull/1374 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenanc

[GitHub] sohami closed pull request #1348: DRILL-6346: Create an Official Drill Docker Container

2018-07-12 Thread GitBox
sohami closed pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] sohami closed pull request #1361: DRILL-6579: Added sanity checks to the Parquet reader to avoid infini…

2018-07-12 Thread GitBox
sohami closed pull request #1361: DRILL-6579: Added sanity checks to the Parquet reader to avoid infini… URL: https://github.com/apache/drill/pull/1361 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenanc

[GitHub] sohami closed pull request #1376: DRILL-6592: Unnest record batch size is called too frequently

2018-07-12 Thread GitBox
sohami closed pull request #1376: DRILL-6592: Unnest record batch size is called too frequently URL: https://github.com/apache/drill/pull/1376 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As th

[GitHub] sohami closed pull request #1360: DRILL-6578: Handle query cancellation in Parquet reader

2018-07-12 Thread GitBox
sohami closed pull request #1360: DRILL-6578: Handle query cancellation in Parquet reader URL: https://github.com/apache/drill/pull/1360 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] sohami closed pull request #1355: DRILL-6560: Enhanced the batch statistics logging enablement

2018-07-12 Thread GitBox
sohami closed pull request #1355: DRILL-6560: Enhanced the batch statistics logging enablement URL: https://github.com/apache/drill/pull/1355 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As thi

[GitHub] sohami commented on issue #1367: DRILL-6585: PartitionSender clones vectors, but shares field metdata

2018-07-12 Thread GitBox
sohami commented on issue #1367: DRILL-6585: PartitionSender clones vectors, but shares field metdata URL: https://github.com/apache/drill/pull/1367#issuecomment-404713253 @paul-rogers - I have couple of questions related to this change and your last comment: 1) I don't understand what

Re: [DISCUSS] 1.14.0 release

2018-07-12 Thread Boaz Ben-Zvi
  We are getting close to a Release Candidate, though some issues are still pending, and we need to make decisions soon. Soliciting opinions -- which of the following issues should be considered a RELEASE BLOCKER for 1.14: = OPEN == OPEN - DRILL-6453 : TPCDS query 72 is Hanging (on a

[GitHub] ilooner edited a comment on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths)

2018-07-12 Thread GitBox
ilooner edited a comment on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336#issuecomment-404696194 @vvysotskyi @arina-ielchiieva I have updated the PR.

[GitHub] ilooner commented on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths)

2018-07-12 Thread GitBox
ilooner commented on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336#issuecomment-404696194 @vvysotskyi @arina-ielchiieva I have updated the PR. I foun

Re: Metadata management improvement

2018-07-12 Thread Parth Chandra
I believe Vitalii is actively looking at a more robust metadata store strategy for Drill and in the long term we would want to move all metadata to the new store. I don't think we would want to maintain a TTL for the metadata store so introducing one now would mean that we might break backward comp

[GitHub] sohami commented on a change in pull request #1374: DRILL-6542 : IndexOutOfBoundsException for multilevel lateral queries…

2018-07-12 Thread GitBox
sohami commented on a change in pull request #1374: DRILL-6542 : IndexOutOfBoundsException for multilevel lateral queries… URL: https://github.com/apache/drill/pull/1374#discussion_r202218606 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/Unne

[GitHub] kkhatua commented on issue #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI

2018-07-12 Thread GitBox
kkhatua commented on issue #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI URL: https://github.com/apache/drill/pull/1379#issuecomment-404691245 @arina-ielchiieva / @sohami could you please review this? (Thanks for finding the bug and giving pointers to the fix)

[GitHub] kkhatua opened a new pull request #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI

2018-07-12 Thread GitBox
kkhatua opened a new pull request #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI URL: https://github.com/apache/drill/pull/1379 When query fails on Web UI result page no error is shown, only "No result found." This was because DRILL-6477 (PR #1309) switched to

[jira] [Created] (DRILL-6605) Query does not return any rows

2018-07-12 Thread Robert Hou (JIRA)
Robert Hou created DRILL-6605: - Summary: Query does not return any rows Key: DRILL-6605 URL: https://issues.apache.org/jira/browse/DRILL-6605 Project: Apache Drill Issue Type: Bug Compo

[GitHub] Ben-Zvi commented on issue #1373: DRILL-6517: Hash-Join: If not OK, exit early from prefetchFirstBatchFromBothSides

2018-07-12 Thread GitBox
Ben-Zvi commented on issue #1373: DRILL-6517: Hash-Join: If not OK, exit early from prefetchFirstBatchFromBothSides URL: https://github.com/apache/drill/pull/1373#issuecomment-404679309 @ilooner please review. Latest changes: Applied suggestion from @ppadma (call *update()* inside *sniffNo

[GitHub] sachouche commented on issue #1361: DRILL-6579: Added sanity checks to the Parquet reader to avoid infini…

2018-07-12 Thread GitBox
sachouche commented on issue #1361: DRILL-6579: Added sanity checks to the Parquet reader to avoid infini… URL: https://github.com/apache/drill/pull/1361#issuecomment-404663922 @vrozov Made the requested modifications. Th

[jira] [Created] (DRILL-6604) Upgrade Drill Hive client to Hive3.0 version

2018-07-12 Thread Vitalii Diravka (JIRA)
Vitalii Diravka created DRILL-6604: -- Summary: Upgrade Drill Hive client to Hive3.0 version Key: DRILL-6604 URL: https://issues.apache.org/jira/browse/DRILL-6604 Project: Apache Drill Issue T

[jira] [Created] (DRILL-6603) Query does not return enough rows

2018-07-12 Thread Robert Hou (JIRA)
Robert Hou created DRILL-6603: - Summary: Query does not return enough rows Key: DRILL-6603 URL: https://issues.apache.org/jira/browse/DRILL-6603 Project: Apache Drill Issue Type: Bug Co

[GitHub] bitblender commented on issue #1244: DRILL-6373: Refactor Result Set Loader for Union, List support

2018-07-12 Thread GitBox
bitblender commented on issue #1244: DRILL-6373: Refactor Result Set Loader for Union, List support URL: https://github.com/apache/drill/pull/1244#issuecomment-404660067 @vrozov @paul-rogers I have started a test run. Will update the PR once it is done. ---

[GitHub] vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-07-12 Thread GitBox
vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r202187352 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetIsPredicate.java ##

[GitHub] vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-07-12 Thread GitBox
vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r202168766 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetIsPredicate.java ##

[GitHub] parthchandra commented on a change in pull request #1376: DRILL-6592: Unnest record batch size is called too frequently

2018-07-12 Thread GitBox
parthchandra commented on a change in pull request #1376: DRILL-6592: Unnest record batch size is called too frequently URL: https://github.com/apache/drill/pull/1376#discussion_r202167818 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestR

[GitHub] kkhatua commented on issue #1371: DRILL-6588: Make Sys tables of nullable datatypes

2018-07-12 Thread GitBox
kkhatua commented on issue #1371: DRILL-6588: Make Sys tables of nullable datatypes URL: https://github.com/apache/drill/pull/1371#issuecomment-404638107 @arina-ielchiieva / @paul-rogers Done the final changes. This is an a

[jira] [Created] (DRILL-6602) Drill query cancellation should log the originator

2018-07-12 Thread Khurram Faraaz (JIRA)
Khurram Faraaz created DRILL-6602: - Summary: Drill query cancellation should log the originator Key: DRILL-6602 URL: https://issues.apache.org/jira/browse/DRILL-6602 Project: Apache Drill Iss

[GitHub] Agirish edited a comment on issue #1348: DRILL-6346: Create an Official Drill Docker Container

2018-07-12 Thread GitBox
Agirish edited a comment on issue #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#issuecomment-404605233 I've created DRILL-6600, DRILL-6599, DRILL-6598 & DRILL-6597 to track the enhancements. And I've also squashed my commits.

[GitHub] bitblender opened a new pull request #1378: DRILL-6601 LageFileCompilation testProject times out

2018-07-12 Thread GitBox
bitblender opened a new pull request #1378: DRILL-6601 LageFileCompilation testProject times out URL: https://github.com/apache/drill/pull/1378 Changing NUM_PROJECT_TEST_COLUMNS to the original 5K value. This number will still stress the constant pool constraints that have to be honored in

[jira] [Created] (DRILL-6601) LageFileCompilation testProject times out

2018-07-12 Thread Karthikeyan Manivannan (JIRA)
Karthikeyan Manivannan created DRILL-6601: - Summary: LageFileCompilation testProject times out Key: DRILL-6601 URL: https://issues.apache.org/jira/browse/DRILL-6601 Project: Apache Drill

[GitHub] Agirish commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container

2018-07-12 Thread GitBox
Agirish commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#issuecomment-404605233 I've created DRILL-6600, DRILL-6599, DRILL-6598 & DRILL-6597 to track the enhancements. @arina-ielchiieva, thanks for your r

[jira] [Created] (DRILL-6600) Create Docker Official Repository for Drill

2018-07-12 Thread Abhishek Girish (JIRA)
Abhishek Girish created DRILL-6600: -- Summary: Create Docker Official Repository for Drill Key: DRILL-6600 URL: https://issues.apache.org/jira/browse/DRILL-6600 Project: Apache Drill Issue Ty

[GitHub] arina-ielchiieva edited a comment on issue #1348: DRILL-6346: Create an Official Drill Docker Container

2018-07-12 Thread GitBox
arina-ielchiieva edited a comment on issue #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#issuecomment-404604656 +1, LGTM. Please don't forget to create a follow up Jira for the enhancements. You might also want to squash the

[jira] [Created] (DRILL-6599) Setup continuous integration for Drill builds on Docker Hub

2018-07-12 Thread Abhishek Girish (JIRA)
Abhishek Girish created DRILL-6599: -- Summary: Setup continuous integration for Drill builds on Docker Hub Key: DRILL-6599 URL: https://issues.apache.org/jira/browse/DRILL-6599 Project: Apache Drill

[GitHub] arina-ielchiieva commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container

2018-07-12 Thread GitBox
arina-ielchiieva commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#issuecomment-404604656 +1, LGTM. Please don't forget to create a follow up Jira for the enhancements. ---

[jira] [Created] (DRILL-6598) Add support for Drill on Kubernetes

2018-07-12 Thread Abhishek Girish (JIRA)
Abhishek Girish created DRILL-6598: -- Summary: Add support for Drill on Kubernetes Key: DRILL-6598 URL: https://issues.apache.org/jira/browse/DRILL-6598 Project: Apache Drill Issue Type: Impr

[jira] [Created] (DRILL-6597) Update Docker image and documentation to support Drill in distributed mode

2018-07-12 Thread Abhishek Girish (JIRA)
Abhishek Girish created DRILL-6597: -- Summary: Update Docker image and documentation to support Drill in distributed mode Key: DRILL-6597 URL: https://issues.apache.org/jira/browse/DRILL-6597 Project:

[GitHub] arina-ielchiieva commented on issue #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-07-12 Thread GitBox
arina-ielchiieva commented on issue #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#issuecomment-404602471 @jbimbert thanks for making the changes, +1 from me. Let's wait for @vrozov approval as well. ---

[GitHub] arina-ielchiieva commented on issue #1233: Updated with links to previous releases

2018-07-12 Thread GitBox
arina-ielchiieva commented on issue #1233: Updated with links to previous releases URL: https://github.com/apache/drill/pull/1233#issuecomment-404601810 @kkhatua any update on this? This is an automated message from the Apach

[GitHub] Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

2018-07-12 Thread GitBox
Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r202128699 ## File path: docs/dev/Docker.md ## @@ -0,0 +1,73 @@ +# How to build, publish and run a Apache Dr

[GitHub] arina-ielchiieva commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

2018-07-12 Thread GitBox
arina-ielchiieva commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r202126105 ## File path: docs/dev/Docker.md ## @@ -0,0 +1,73 @@ +# How to build, publish and run a

[GitHub] Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

2018-07-12 Thread GitBox
Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r202119176 ## File path: docs/dev/Docker.md ## @@ -0,0 +1,73 @@ +# How to build, publish and run a Apache Dr

[GitHub] vrozov commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it

2018-07-12 Thread GitBox
vrozov commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it URL: https://github.com/apache/drill/pull/1264#discussion_r202113450 ## File path: drill-shaded/drill-shaded-guava/pom.xml ## @@ -0,0 +1,76 @@ + + +http://maven.apache.org/PO

[GitHub] vrozov commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it

2018-07-12 Thread GitBox
vrozov commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it URL: https://github.com/apache/drill/pull/1264#discussion_r202112894 ## File path: drill-shaded/drill-shaded-guava/pom.xml ## @@ -0,0 +1,76 @@ + + +http://maven.apache.org/PO

[GitHub] vrozov commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it

2018-07-12 Thread GitBox
vrozov commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it URL: https://github.com/apache/drill/pull/1264#discussion_r202114338 ## File path: drill-shaded/drill-shaded-guava/pom.xml ## @@ -0,0 +1,76 @@ + + +http://maven.apache.org/PO

[GitHub] vrozov commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it

2018-07-12 Thread GitBox
vrozov commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it URL: https://github.com/apache/drill/pull/1264#discussion_r202111451 ## File path: drill-shaded/guava-shaded/pom.xml ## @@ -0,0 +1,86 @@ + + +http://maven.apache.org/POM/4.0.

[GitHub] sohami commented on a change in pull request #1376: DRILL-6592: Unnest record batch size is called too frequently

2018-07-12 Thread GitBox
sohami commented on a change in pull request #1376: DRILL-6592: Unnest record batch size is called too frequently URL: https://github.com/apache/drill/pull/1376#discussion_r202090727 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestRecordB

[jira] [Resolved] (DRILL-4742) Using convert_from timestamp_impala gives a random error

2018-07-12 Thread Vitalii Diravka (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vitalii Diravka resolved DRILL-4742. Resolution: Cannot Reproduce Assignee: Vitalii Diravka > Using convert_from timestamp

[jira] [Resolved] (DRILL-5495) convert_from function on top of int96 data results in ArrayIndexOutOfBoundsException

2018-07-12 Thread Vitalii Diravka (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-5495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vitalii Diravka resolved DRILL-5495. Resolution: Cannot Reproduce Assignee: Vitalii Diravka Fix Version/s: 1.15.0

[jira] [Resolved] (DRILL-4337) Drill fails to read INT96 fields from hive generated parquet files

2018-07-12 Thread Vitalii Diravka (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-4337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vitalii Diravka resolved DRILL-4337. Resolution: Cannot Reproduce It isn't reproduced for me anymore. Reading parquet file with

Re: Metadata management improvement

2018-07-12 Thread Joel Pfaff
Hello, Thanks for the feedback. The logic I had in mind was to add the TTL, as a refresh_interval field in the root metadata file. At each query, the current time would be compared to the addition of the modification time of the root metadata file and the refresh_interval. If the current time is

[GitHub] jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-07-12 Thread GitBox
jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r202068577 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetIsPredicate.java

[GitHub] jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-07-12 Thread GitBox
jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r202062943 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetFilterPush

Re: Metadata management improvement

2018-07-12 Thread Vitalii Diravka
Hi Joel, Sounds reasonable. But if Drill checks this TTL property from metadata cache file for every query and for every file instead of file timestamp, it will not give the benefit. I suppose we can add this TTL property to only root metadata cache file and check it only once per query. Could yo

[GitHub] jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-07-12 Thread GitBox
jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r202062739 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/RangeExprEvaluator.java

[GitHub] jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-07-12 Thread GitBox
jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r202062839 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetPushDownFilter

[GitHub] jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-07-12 Thread GitBox
jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r202062690 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetIsPredicate.java

[GitHub] jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-07-12 Thread GitBox
jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r202062611 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetIsPredicate.java

[GitHub] jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-07-12 Thread GitBox
jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r202062367 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetBooleanPredicate.j

[GitHub] jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-07-12 Thread GitBox
jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r202062367 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetBooleanPredicate.j

[GitHub] jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-07-12 Thread GitBox
jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r202062305 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetBooleanPredicate.j

[GitHub] jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-07-12 Thread GitBox
jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r202062305 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetBooleanPredicate.j

[GitHub] arina-ielchiieva commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-07-12 Thread GitBox
arina-ielchiieva commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r202050648 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetBooleanPre

[GitHub] arina-ielchiieva commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-07-12 Thread GitBox
arina-ielchiieva commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r202050566 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetBooleanPre

[GitHub] arina-ielchiieva commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-07-12 Thread GitBox
arina-ielchiieva commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r202051781 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetPushDo

[GitHub] arina-ielchiieva commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-07-12 Thread GitBox
arina-ielchiieva commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r202051164 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetIsPredicat

[GitHub] arina-ielchiieva commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-07-12 Thread GitBox
arina-ielchiieva commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r202051511 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/RangeExprEvaluato

[GitHub] arina-ielchiieva commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-07-12 Thread GitBox
arina-ielchiieva commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r202052538 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetFi

[GitHub] arina-ielchiieva commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-07-12 Thread GitBox
arina-ielchiieva commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r202051025 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetIsPredicat

[GitHub] vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-07-12 Thread GitBox
vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r202049567 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetIsPredicate.java ##

[GitHub] vrozov commented on issue #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-07-12 Thread GitBox
vrozov commented on issue #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#issuecomment-404524244 @jbimbert Drill usually - puts a single space between `if` and `(` or between `switch` and `(`. - use single space only

Metadata management improvement

2018-07-12 Thread Joel Pfaff
Hello, Today, on a table for which we have created statistics (through the REFRESH TABLE METADATA command), Drill validates the timestamp of every files or directory involved in the scan. If the timestamps of the files are greater than the one of the metadata file, then a re-regeneration of the

[GitHub] arina-ielchiieva commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

2018-07-12 Thread GitBox
arina-ielchiieva commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r202019289 ## File path: docs/dev/Docker.md ## @@ -0,0 +1,73 @@ +# How to build, publish and run a

[GitHub] arina-ielchiieva commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container

2018-07-12 Thread GitBox
arina-ielchiieva commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#issuecomment-404499562 To summarize in this Jira we are aiming to add docker support only for Drill in embedded mode. @Agirish 1. Please cr

[GitHub] arina-ielchiieva commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

2018-07-12 Thread GitBox
arina-ielchiieva commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r202019289 ## File path: docs/dev/Docker.md ## @@ -0,0 +1,73 @@ +# How to build, publish and run a

[GitHub] jbimbert commented on issue #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-07-12 Thread GitBox
jbimbert commented on issue #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#issuecomment-404465852 Checkstyle passed on modifications. ParquetRGFilterEvaluator.java now compliant with checkstyle.

[GitHub] arina-ielchiieva commented on a change in pull request #1371: DRILL-6588: Make Sys tables of nullable datatypes

2018-07-12 Thread GitBox
arina-ielchiieva commented on a change in pull request #1371: DRILL-6588: Make Sys tables of nullable datatypes URL: https://github.com/apache/drill/pull/1371#discussion_r201946174 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/BitToUserConnectionIterato

[GitHub] arina-ielchiieva commented on a change in pull request #1371: DRILL-6588: Make Sys tables of nullable datatypes

2018-07-12 Thread GitBox
arina-ielchiieva commented on a change in pull request #1371: DRILL-6588: Make Sys tables of nullable datatypes URL: https://github.com/apache/drill/pull/1371#discussion_r201945843 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pojo/PojoDataType.java ##

[GitHub] arina-ielchiieva commented on a change in pull request #1371: DRILL-6588: Make Sys tables of nullable datatypes

2018-07-12 Thread GitBox
arina-ielchiieva commented on a change in pull request #1371: DRILL-6588: Make Sys tables of nullable datatypes URL: https://github.com/apache/drill/pull/1371#discussion_r201948032 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/RecordDataType.java #

[GitHub] arina-ielchiieva commented on a change in pull request #1371: DRILL-6588: Make Sys tables of nullable datatypes

2018-07-12 Thread GitBox
arina-ielchiieva commented on a change in pull request #1371: DRILL-6588: Make Sys tables of nullable datatypes URL: https://github.com/apache/drill/pull/1371#discussion_r201946028 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pojo/PojoDataType.java ##

Re: DRILL-6104 Question

2018-07-12 Thread Arina Yelchiyeva
Hi Charles, looked at your PR, it still needs many things to address. Merging code without addressing those issues, might be not the best idea. Kind regards, Arina On Thu, Jul 12, 2018 at 5:37 AM Charles Givre wrote: > Hi Paul, > Regarding the regex/log reader for Drill, since there are a lot

[GitHub] arina-ielchiieva commented on a change in pull request #1114: DRILL-6104: Added Logfile Reader

2018-07-12 Thread GitBox
arina-ielchiieva commented on a change in pull request #1114: DRILL-6104: Added Logfile Reader URL: https://github.com/apache/drill/pull/1114#discussion_r201941944 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogFormatField.java ## @@ -0,0 +1

[GitHub] arina-ielchiieva commented on a change in pull request #1114: DRILL-6104: Added Logfile Reader

2018-07-12 Thread GitBox
arina-ielchiieva commented on a change in pull request #1114: DRILL-6104: Added Logfile Reader URL: https://github.com/apache/drill/pull/1114#discussion_r201943034 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogFormatPlugin.java ## @@ -0,0 +

[GitHub] arina-ielchiieva commented on a change in pull request #1114: DRILL-6104: Added Logfile Reader

2018-07-12 Thread GitBox
arina-ielchiieva commented on a change in pull request #1114: DRILL-6104: Added Logfile Reader URL: https://github.com/apache/drill/pull/1114#discussion_r201943472 ## File path: src/main/resources/checkstyle-config.xml ## @@ -30,7 +30,7 @@ - +

[GitHub] arina-ielchiieva commented on a change in pull request #1114: DRILL-6104: Added Logfile Reader

2018-07-12 Thread GitBox
arina-ielchiieva commented on a change in pull request #1114: DRILL-6104: Added Logfile Reader URL: https://github.com/apache/drill/pull/1114#discussion_r201942156 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogFormatPlugin.java ## @@ -0,0 +

[GitHub] arina-ielchiieva commented on a change in pull request #1114: DRILL-6104: Added Logfile Reader

2018-07-12 Thread GitBox
arina-ielchiieva commented on a change in pull request #1114: DRILL-6104: Added Logfile Reader URL: https://github.com/apache/drill/pull/1114#discussion_r201941488 ## File path: contrib/native/client/patches/zookeeper-3.4.6-x64.patch ## @@ -1,163 +0,0 @@ -From 64697ddd8a90

[GitHub] arina-ielchiieva commented on a change in pull request #1114: DRILL-6104: Added Logfile Reader

2018-07-12 Thread GitBox
arina-ielchiieva commented on a change in pull request #1114: DRILL-6104: Added Logfile Reader URL: https://github.com/apache/drill/pull/1114#discussion_r201941882 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogFormatConfig.java ## @@ -0,0 +

[GitHub] arina-ielchiieva commented on a change in pull request #1114: DRILL-6104: Added Logfile Reader

2018-07-12 Thread GitBox
arina-ielchiieva commented on a change in pull request #1114: DRILL-6104: Added Logfile Reader URL: https://github.com/apache/drill/pull/1114#discussion_r201943172 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogRecordReader.java ## @@ -0,0 +

[GitHub] jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-07-12 Thread GitBox
jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r201930585 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetIsPredicate.java

[GitHub] jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-07-12 Thread GitBox
jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r201930585 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetIsPredicate.java