[GitHub] jbimbert commented on issue #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-07-27 Thread GitBox
jbimbert commented on issue #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#issuecomment-408335196 @vrozov Hello, please review this PR. Best regards This is an

[GitHub] arina-ielchiieva commented on issue #1404: DRILL-6639: Exception happens while displaying operator profiles for …

2018-07-27 Thread GitBox
arina-ielchiieva commented on issue #1404: DRILL-6639: Exception happens while displaying operator profiles for … URL: https://github.com/apache/drill/pull/1404#issuecomment-408341136 @vdiravka adding operators names into proto fixes part of the issue. Query profile page should be displaye

[GitHub] vdiravka commented on issue #1404: DRILL-6639: Exception happens while displaying operator profiles for …

2018-07-27 Thread GitBox
vdiravka commented on issue #1404: DRILL-6639: Exception happens while displaying operator profiles for … URL: https://github.com/apache/drill/pull/1404#issuecomment-408372180 @arina-ielchiieva The operator type was always (in earlier Drill versions) null, if operator doesn't exist in prot

[jira] [Created] (DRILL-6641) TestConvertCountToDirectScan.ensureCorrectCountWithMissingStatistics() test fails randomly

2018-07-27 Thread Volodymyr Vysotskyi (JIRA)
Volodymyr Vysotskyi created DRILL-6641: -- Summary: TestConvertCountToDirectScan.ensureCorrectCountWithMissingStatistics() test fails randomly Key: DRILL-6641 URL: https://issues.apache.org/jira/browse/DRILL-6

[GitHub] arina-ielchiieva commented on issue #1404: DRILL-6639: Exception happens while displaying operator profiles for …

2018-07-27 Thread GitBox
arina-ielchiieva commented on issue #1404: DRILL-6639: Exception happens while displaying operator profiles for … URL: https://github.com/apache/drill/pull/1404#issuecomment-408391805 @vdiravka I think upgrade protobuf upgrade is a good idea but definitely not in the time of the release. I

[GitHub] vvysotskyi opened a new pull request #1406: DRILL-6641: Fix columnValueCounts in ParquetGroupScanStatistics when ParquetGroupScan has RowGroupInfo without column statistics

2018-07-27 Thread GitBox
vvysotskyi opened a new pull request #1406: DRILL-6641: Fix columnValueCounts in ParquetGroupScanStatistics when ParquetGroupScan has RowGroupInfo without column statistics URL: https://github.com/apache/drill/pull/1406 Thi

[GitHub] vvysotskyi commented on issue #1406: DRILL-6641: Fix columnValueCounts in ParquetGroupScanStatistics when ParquetGroupScan has RowGroupInfo without column statistics

2018-07-27 Thread GitBox
vvysotskyi commented on issue #1406: DRILL-6641: Fix columnValueCounts in ParquetGroupScanStatistics when ParquetGroupScan has RowGroupInfo without column statistics URL: https://github.com/apache/drill/pull/1406#issuecomment-408394838 @arina-ielchiieva, could you please review this PR? -

[GitHub] arina-ielchiieva commented on a change in pull request #1406: DRILL-6641: Fix columnValueCounts in ParquetGroupScanStatistics when ParquetGroupScan has RowGroupInfo without column statistics

2018-07-27 Thread GitBox
arina-ielchiieva commented on a change in pull request #1406: DRILL-6641: Fix columnValueCounts in ParquetGroupScanStatistics when ParquetGroupScan has RowGroupInfo without column statistics URL: https://github.com/apache/drill/pull/1406#discussion_r205748264 ## File path: exec/ja

[jira] [Created] (DRILL-6642) Upgrade protocol-buffers version

2018-07-27 Thread Vitalii Diravka (JIRA)
Vitalii Diravka created DRILL-6642: -- Summary: Upgrade protocol-buffers version Key: DRILL-6642 URL: https://issues.apache.org/jira/browse/DRILL-6642 Project: Apache Drill Issue Type: Bug

[GitHub] arina-ielchiieva commented on issue #1403: DRILL-6634: Add udf module under contrib directory and move some udfs into it

2018-07-27 Thread GitBox
arina-ielchiieva commented on issue #1403: DRILL-6634: Add udf module under contrib directory and move some udfs into it URL: https://github.com/apache/drill/pull/1403#issuecomment-408399020 @paul-rogers not sure to which issue you are referring to, never heard about it. Anyway new udf mod

[GitHub] vdiravka commented on issue #1404: DRILL-6639: Exception happens while displaying operator profiles for …

2018-07-27 Thread GitBox
vdiravka commented on issue #1404: DRILL-6639: Exception happens while displaying operator profiles for … URL: https://github.com/apache/drill/pull/1404#issuecomment-408404328 @arina-ielchiieva Done. It is a right step, since we already have [the logic for undefined operators](https://git

[GitHub] arina-ielchiieva commented on a change in pull request #1404: DRILL-6639: Exception happens while displaying operator profiles for …

2018-07-27 Thread GitBox
arina-ielchiieva commented on a change in pull request #1404: DRILL-6639: Exception happens while displaying operator profiles for … URL: https://github.com/apache/drill/pull/1404#discussion_r205757465 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/pro

[GitHub] arina-ielchiieva commented on issue #1404: DRILL-6639: Exception happens while displaying operator profiles for …

2018-07-27 Thread GitBox
arina-ielchiieva commented on issue #1404: DRILL-6639: Exception happens while displaying operator profiles for … URL: https://github.com/apache/drill/pull/1404#issuecomment-408406341 @vdiravka could you please also check children of `EasyFormatPlugin` for missing operator types: `public i

[GitHub] arina-ielchiieva edited a comment on issue #1404: DRILL-6639: Exception happens while displaying operator profiles for …

2018-07-27 Thread GitBox
arina-ielchiieva edited a comment on issue #1404: DRILL-6639: Exception happens while displaying operator profiles for … URL: https://github.com/apache/drill/pull/1404#issuecomment-408406341 @vdiravka could you please also check children of `EasyFormatPlugin` for missing operator types: `p

[GitHub] vvysotskyi commented on a change in pull request #1406: DRILL-6641: Fix columnValueCounts in ParquetGroupScanStatistics when ParquetGroupScan has RowGroupInfo without column statistics

2018-07-27 Thread GitBox
vvysotskyi commented on a change in pull request #1406: DRILL-6641: Fix columnValueCounts in ParquetGroupScanStatistics when ParquetGroupScan has RowGroupInfo without column statistics URL: https://github.com/apache/drill/pull/1406#discussion_r205766709 ## File path: exec/java-exe

[GitHub] arina-ielchiieva commented on issue #1406: DRILL-6641: Fix columnValueCounts in ParquetGroupScanStatistics when ParquetGroupScan has RowGroupInfo without column statistics

2018-07-27 Thread GitBox
arina-ielchiieva commented on issue #1406: DRILL-6641: Fix columnValueCounts in ParquetGroupScanStatistics when ParquetGroupScan has RowGroupInfo without column statistics URL: https://github.com/apache/drill/pull/1406#issuecomment-408416290 +1, LGTM. -

[jira] [Created] (DRILL-6643) OperatorType for Values and IteratorValidator

2018-07-27 Thread Vitalii Diravka (JIRA)
Vitalii Diravka created DRILL-6643: -- Summary: OperatorType for Values and IteratorValidator Key: DRILL-6643 URL: https://issues.apache.org/jira/browse/DRILL-6643 Project: Apache Drill Issue

[GitHub] vdiravka commented on a change in pull request #1404: DRILL-6639: Exception happens while displaying operator profiles for …

2018-07-27 Thread GitBox
vdiravka commented on a change in pull request #1404: DRILL-6639: Exception happens while displaying operator profiles for … URL: https://github.com/apache/drill/pull/1404#discussion_r205791526 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/Ope

[GitHub] vrozov commented on issue #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-07-27 Thread GitBox
vrozov commented on issue #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#issuecomment-408445612 @jbimbert Please fix merge/rebase issue. This is an automated m

[GitHub] arina-ielchiieva commented on issue #1404: DRILL-6639: Exception happens while displaying operator profiles for …

2018-07-27 Thread GitBox
arina-ielchiieva commented on issue #1404: DRILL-6639: Exception happens while displaying operator profiles for … URL: https://github.com/apache/drill/pull/1404#issuecomment-408465350 +1, LGTM. This is an automated message fr

[GitHub] ppadma commented on a change in pull request #1395: DRILL-6629 BitVector split and transfer does not work correctly for transfer length < 8

2018-07-27 Thread GitBox
ppadma commented on a change in pull request #1395: DRILL-6629 BitVector split and transfer does not work correctly for transfer length < 8 URL: https://github.com/apache/drill/pull/1395#discussion_r205824915 ## File path: exec/vector/src/main/java/org/apache/drill/exec/vector/BitV

[GitHub] vrozov commented on a change in pull request #1406: DRILL-6641: Fix columnValueCounts in ParquetGroupScanStatistics when ParquetGroupScan has RowGroupInfo without column statistics

2018-07-27 Thread GitBox
vrozov commented on a change in pull request #1406: DRILL-6641: Fix columnValueCounts in ParquetGroupScanStatistics when ParquetGroupScan has RowGroupInfo without column statistics URL: https://github.com/apache/drill/pull/1406#discussion_r205825339 ## File path: exec/java-exec/sr

[GitHub] HanumathRao commented on issue #1405: DRILL-6640: Modifying DotDrillUtil implementation to avoid using globStatus calls

2018-07-27 Thread GitBox
HanumathRao commented on issue #1405: DRILL-6640: Modifying DotDrillUtil implementation to avoid using globStatus calls URL: https://github.com/apache/drill/pull/1405#issuecomment-408479643 @kr-arjun There seems to be some test failures. Can you verify if these test failures are because of

[GitHub] vvysotskyi commented on a change in pull request #1406: DRILL-6641: Fix columnValueCounts in ParquetGroupScanStatistics when ParquetGroupScan has RowGroupInfo without column statistics

2018-07-27 Thread GitBox
vvysotskyi commented on a change in pull request #1406: DRILL-6641: Fix columnValueCounts in ParquetGroupScanStatistics when ParquetGroupScan has RowGroupInfo without column statistics URL: https://github.com/apache/drill/pull/1406#discussion_r205838330 ## File path: exec/java-exe

[GitHub] sohami commented on a change in pull request #1404: DRILL-6639: Exception happens while displaying operator profiles for …

2018-07-27 Thread GitBox
sohami commented on a change in pull request #1404: DRILL-6639: Exception happens while displaying operator profiles for … URL: https://github.com/apache/drill/pull/1404#discussion_r205852168 ## File path: protocol/src/main/java/org/apache/drill/exec/proto/beans/CoreOperatorType.ja

[GitHub] arina-ielchiieva commented on a change in pull request #1404: DRILL-6639: Exception happens while displaying operator profiles for …

2018-07-27 Thread GitBox
arina-ielchiieva commented on a change in pull request #1404: DRILL-6639: Exception happens while displaying operator profiles for … URL: https://github.com/apache/drill/pull/1404#discussion_r205864556 ## File path: protocol/src/main/java/org/apache/drill/exec/proto/beans/CoreOpera

[GitHub] sohami commented on a change in pull request #1399: DRILL-6631: Streaming agg causes queries with Lateral and Unnest to r…

2018-07-27 Thread GitBox
sohami commented on a change in pull request #1399: DRILL-6631: Streaming agg causes queries with Lateral and Unnest to r… URL: https://github.com/apache/drill/pull/1399#discussion_r205867203 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/agg/TestStr

[GitHub] sohami commented on a change in pull request #1399: DRILL-6631: Streaming agg causes queries with Lateral and Unnest to r…

2018-07-27 Thread GitBox
sohami commented on a change in pull request #1399: DRILL-6631: Streaming agg causes queries with Lateral and Unnest to r… URL: https://github.com/apache/drill/pull/1399#discussion_r205867007 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/S

Re: [VOTE] Apache Drill release 1.14.0 - RC0

2018-07-27 Thread Boaz Ben-Zvi
   OK -- opinions seem to concur that this issue is a blocker. So cancelling RC0 now I'll merge PR #1404 into the 1.14.0 branch (how nice - similar numbers :-) and start producing RC1 ..     Thanks,     Boaz On 7/26/18 8:32 PM, Abhishek Girish wrote: Looks like a blocker for the r

[GitHub] kr-arjun commented on issue #1405: DRILL-6640: Modifying DotDrillUtil implementation to avoid using globStatus calls

2018-07-27 Thread GitBox
kr-arjun commented on issue #1405: DRILL-6640: Modifying DotDrillUtil implementation to avoid using globStatus calls URL: https://github.com/apache/drill/pull/1405#issuecomment-408518541 @HanumathRao I have fixed the test failures. Could you please review now. -

[jira] [Created] (DRILL-6644) In Some Cases The HashJoin Memory Calculator Over Reserves Memory

2018-07-27 Thread Timothy Farkas (JIRA)
Timothy Farkas created DRILL-6644: - Summary: In Some Cases The HashJoin Memory Calculator Over Reserves Memory Key: DRILL-6644 URL: https://issues.apache.org/jira/browse/DRILL-6644 Project: Apache Dri

[GitHub] parthchandra commented on a change in pull request #1399: DRILL-6631: Streaming agg causes queries with Lateral and Unnest to r…

2018-07-27 Thread GitBox
parthchandra commented on a change in pull request #1399: DRILL-6631: Streaming agg causes queries with Lateral and Unnest to r… URL: https://github.com/apache/drill/pull/1399#discussion_r205893800 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggre

[GitHub] parthchandra commented on a change in pull request #1401: DRILL-6616: Batch Processing for Lateral/Unnest

2018-07-27 Thread GitBox
parthchandra commented on a change in pull request #1401: DRILL-6616: Batch Processing for Lateral/Unnest URL: https://github.com/apache/drill/pull/1401#discussion_r205897124 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestImpl.java

[GitHub] parthchandra commented on a change in pull request #1401: DRILL-6616: Batch Processing for Lateral/Unnest

2018-07-27 Thread GitBox
parthchandra commented on a change in pull request #1401: DRILL-6616: Batch Processing for Lateral/Unnest URL: https://github.com/apache/drill/pull/1401#discussion_r205896496 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestImpl.java

[GitHub] parthchandra commented on a change in pull request #1401: DRILL-6616: Batch Processing for Lateral/Unnest

2018-07-27 Thread GitBox
parthchandra commented on a change in pull request #1401: DRILL-6616: Batch Processing for Lateral/Unnest URL: https://github.com/apache/drill/pull/1401#discussion_r205897581 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestImpl.java

[GitHub] parthchandra commented on a change in pull request #1401: DRILL-6616: Batch Processing for Lateral/Unnest

2018-07-27 Thread GitBox
parthchandra commented on a change in pull request #1401: DRILL-6616: Batch Processing for Lateral/Unnest URL: https://github.com/apache/drill/pull/1401#discussion_r205898475 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestRecordBatch.jav

[GitHub] parthchandra commented on a change in pull request #1401: DRILL-6616: Batch Processing for Lateral/Unnest

2018-07-27 Thread GitBox
parthchandra commented on a change in pull request #1401: DRILL-6616: Batch Processing for Lateral/Unnest URL: https://github.com/apache/drill/pull/1401#discussion_r205896326 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestImpl.java

[GitHub] parthchandra commented on a change in pull request #1401: DRILL-6616: Batch Processing for Lateral/Unnest

2018-07-27 Thread GitBox
parthchandra commented on a change in pull request #1401: DRILL-6616: Batch Processing for Lateral/Unnest URL: https://github.com/apache/drill/pull/1401#discussion_r205903322 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/LateralJoinPOP.java #

[jira] [Created] (DRILL-6645) Transform TopN in Lateral Unnest pipeline to Sort and Limit.

2018-07-27 Thread Hanumath Rao Maduri (JIRA)
Hanumath Rao Maduri created DRILL-6645: -- Summary: Transform TopN in Lateral Unnest pipeline to Sort and Limit. Key: DRILL-6645 URL: https://issues.apache.org/jira/browse/DRILL-6645 Project: Apach

[jira] [Created] (DRILL-6646) HashJoin Memory Calculator Over Reserves Memory For HashTables

2018-07-27 Thread Timothy Farkas (JIRA)
Timothy Farkas created DRILL-6646: - Summary: HashJoin Memory Calculator Over Reserves Memory For HashTables Key: DRILL-6646 URL: https://issues.apache.org/jira/browse/DRILL-6646 Project: Apache Drill

[GitHub] amansinha100 commented on a change in pull request #1401: DRILL-6616: Batch Processing for Lateral/Unnest

2018-07-27 Thread GitBox
amansinha100 commented on a change in pull request #1401: DRILL-6616: Batch Processing for Lateral/Unnest URL: https://github.com/apache/drill/pull/1401#discussion_r205916300 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/FilterPrel.java

[GitHub] amansinha100 commented on a change in pull request #1401: DRILL-6616: Batch Processing for Lateral/Unnest

2018-07-27 Thread GitBox
amansinha100 commented on a change in pull request #1401: DRILL-6616: Batch Processing for Lateral/Unnest URL: https://github.com/apache/drill/pull/1401#discussion_r205916658 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/FilterPrel.java

[GitHub] amansinha100 commented on a change in pull request #1401: DRILL-6616: Batch Processing for Lateral/Unnest

2018-07-27 Thread GitBox
amansinha100 commented on a change in pull request #1401: DRILL-6616: Batch Processing for Lateral/Unnest URL: https://github.com/apache/drill/pull/1401#discussion_r205918553 ## File path: contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcPrel.java ##

[GitHub] amansinha100 commented on a change in pull request #1401: DRILL-6616: Batch Processing for Lateral/Unnest

2018-07-27 Thread GitBox
amansinha100 commented on a change in pull request #1401: DRILL-6616: Batch Processing for Lateral/Unnest URL: https://github.com/apache/drill/pull/1401#discussion_r205915503 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/LateralJoinPOP.java #

[GitHub] amansinha100 commented on a change in pull request #1401: DRILL-6616: Batch Processing for Lateral/Unnest

2018-07-27 Thread GitBox
amansinha100 commented on a change in pull request #1401: DRILL-6616: Batch Processing for Lateral/Unnest URL: https://github.com/apache/drill/pull/1401#discussion_r205919958 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java #

[VOTE] Apache Drill release 1.14.0 - RC1

2018-07-27 Thread Boaz Ben-Zvi
 Hi Drillers,     Proposing the *second* Release Candidate (RC1) for the Apache Drill, version 1.14.0 . This RC1 includes 234 committed Jiras [1]. Thanks to all the Drill developers who works hard and contributed to this release. The RC1 tarballs are hosted at [2] , and the Maven artifacts

[GitHub] Ben-Zvi commented on a change in pull request #1399: DRILL-6631: Streaming agg causes queries with Lateral and Unnest to r…

2018-07-27 Thread GitBox
Ben-Zvi commented on a change in pull request #1399: DRILL-6631: Streaming agg causes queries with Lateral and Unnest to r… URL: https://github.com/apache/drill/pull/1399#discussion_r205921657 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/

[GitHub] Ben-Zvi commented on a change in pull request #1399: DRILL-6631: Streaming agg causes queries with Lateral and Unnest to r…

2018-07-27 Thread GitBox
Ben-Zvi commented on a change in pull request #1399: DRILL-6631: Streaming agg causes queries with Lateral and Unnest to r… URL: https://github.com/apache/drill/pull/1399#discussion_r205921415 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/

[GitHub] HanumathRao opened a new pull request #1407: PartitionLimit changes for Lateral and Unnest.

2018-07-27 Thread GitBox
HanumathRao opened a new pull request #1407: PartitionLimit changes for Lateral and Unnest. URL: https://github.com/apache/drill/pull/1407 This PR includes some commits which are not part of PartitionLimit fix. Please ignore those commits. Here are the list of commits to be ignored. DRI

[GitHub] vrozov commented on a change in pull request #1406: DRILL-6641: Fix columnValueCounts in ParquetGroupScanStatistics when ParquetGroupScan has RowGroupInfo without column statistics

2018-07-27 Thread GitBox
vrozov commented on a change in pull request #1406: DRILL-6641: Fix columnValueCounts in ParquetGroupScanStatistics when ParquetGroupScan has RowGroupInfo without column statistics URL: https://github.com/apache/drill/pull/1406#discussion_r205933181 ## File path: exec/java-exec/sr