[GitHub] [drill] paul-rogers commented on issue #1867: DRILL-7358: Fix COUNT(*) for empty text files

2019-10-05 Thread GitBox
paul-rogers commented on issue #1867: DRILL-7358: Fix COUNT(*) for empty text files URL: https://github.com/apache/drill/pull/1867#issuecomment-538706729 @arina-ielchiieva, please review. This is an automated message from

[GitHub] [drill] paul-rogers opened a new pull request #1867: DRILL-7358: Fix COUNT(*) for empty text files

2019-10-05 Thread GitBox
paul-rogers opened a new pull request #1867: DRILL-7358: Fix COUNT(*) for empty text files URL: https://github.com/apache/drill/pull/1867 Fixes a subtle error when a text file has a header (and so has a schema), but is in a COUNT(*) query, so that no columns are projected. Ensures

[GitHub] [drill] paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF

2019-10-05 Thread GitBox
paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF URL: https://github.com/apache/drill/pull/1862#discussion_r331764842 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapBatchReader.java ##

[GitHub] [drill] paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF

2019-10-05 Thread GitBox
paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF URL: https://github.com/apache/drill/pull/1862#discussion_r331764819 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapBatchReader.java ##

[GitHub] [drill] paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF

2019-10-05 Thread GitBox
paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF URL: https://github.com/apache/drill/pull/1862#discussion_r331764799 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapBatchReader.java ##

[GitHub] [drill] paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF

2019-10-05 Thread GitBox
paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF URL: https://github.com/apache/drill/pull/1862#discussion_r331765043 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapBatchReader.java ##

[GitHub] [drill] paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF

2019-10-05 Thread GitBox
paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF URL: https://github.com/apache/drill/pull/1862#discussion_r328425702 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapBatchReader.java ##

[GitHub] [drill] paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF

2019-10-05 Thread GitBox
paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF URL: https://github.com/apache/drill/pull/1862#discussion_r331765065 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapBatchReader.java ##

[GitHub] [drill] paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF

2019-10-05 Thread GitBox
paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF URL: https://github.com/apache/drill/pull/1862#discussion_r331764935 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapBatchReader.java ##

[GitHub] [drill] paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF

2019-10-05 Thread GitBox
paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF URL: https://github.com/apache/drill/pull/1862#discussion_r331765111 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapFormatPlugin.java ##

[GitHub] [drill] paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF

2019-10-05 Thread GitBox
paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF URL: https://github.com/apache/drill/pull/1862#discussion_r328425281 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapBatchReader.java ##

[GitHub] [drill] paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF

2019-10-05 Thread GitBox
paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF URL: https://github.com/apache/drill/pull/1862#discussion_r331767130 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/schema/Schema.java ##

[GitHub] [drill] paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF

2019-10-05 Thread GitBox
paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF URL: https://github.com/apache/drill/pull/1862#discussion_r328425343 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapBatchReader.java ##

[GitHub] [drill] paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF

2019-10-05 Thread GitBox
paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF URL: https://github.com/apache/drill/pull/1862#discussion_r331764958 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapBatchReader.java ##

[GitHub] [drill] paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF

2019-10-05 Thread GitBox
paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF URL: https://github.com/apache/drill/pull/1862#discussion_r331764812 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapBatchReader.java ##

[GitHub] [drill] paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF

2019-10-05 Thread GitBox
paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF URL: https://github.com/apache/drill/pull/1862#discussion_r331767252 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/schema/Schema.java ##

[GitHub] [drill] paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF

2019-10-05 Thread GitBox
paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF URL: https://github.com/apache/drill/pull/1862#discussion_r331767234 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/schema/Schema.java ##

[GitHub] [drill] paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF

2019-10-05 Thread GitBox
paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF URL: https://github.com/apache/drill/pull/1862#discussion_r331765097 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapFormatConfig.java ##

[GitHub] [drill] paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF

2019-10-05 Thread GitBox
paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF URL: https://github.com/apache/drill/pull/1862#discussion_r331765083 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapFormatConfig.java ##

[GitHub] [drill] paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF

2019-10-05 Thread GitBox
paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF URL: https://github.com/apache/drill/pull/1862#discussion_r331767121 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapFormatPlugin.java ##

[GitHub] [drill] paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF

2019-10-05 Thread GitBox
paul-rogers commented on a change in pull request #1862: DRILL-7385: Convert PCAP Format Plugin to EVF URL: https://github.com/apache/drill/pull/1862#discussion_r331767290 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/store/pcap/TestPcapRecordReader.java

[jira] [Resolved] (DRILL-5914) CSV (text) reader fails to parse quoted newlines in trailing fields

2019-10-05 Thread Paul Rogers (Jira)
[ https://issues.apache.org/jira/browse/DRILL-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Rogers resolved DRILL-5914. Resolution: Fixed This issue was fixed as part of the "Complaint text reader V3" project. The