vdiravka commented on code in PR #2568:
URL: https://github.com/apache/drill/pull/2568#discussion_r891397926
##
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java:
##
@@ -46,7 +51,9 @@ public class ProjectRecordBatch extends
Abstrac
cgivre commented on code in PR #2568:
URL: https://github.com/apache/drill/pull/2568#discussion_r891397014
##
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java:
##
@@ -46,7 +51,9 @@ public class ProjectRecordBatch extends
AbstractS
jnturton commented on code in PR #2568:
URL: https://github.com/apache/drill/pull/2568#discussion_r891124891
##
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java:
##
@@ -46,7 +51,9 @@ public class ProjectRecordBatch extends
Abstrac
cgivre merged PR #2568:
URL: https://github.com/apache/drill/pull/2568
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
cgivre commented on code in PR #2567:
URL: https://github.com/apache/drill/pull/2567#discussion_r891318837
##
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/JsonConvertFrom.java:
##
@@ -32,37 +30,45 @@
import org.apache.drill.exec.expr.holders.NullableVarC
cgivre commented on code in PR #2567:
URL: https://github.com/apache/drill/pull/2567#discussion_r891318837
##
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/JsonConvertFrom.java:
##
@@ -32,37 +30,45 @@
import org.apache.drill.exec.expr.holders.NullableVarC
vdiravka commented on code in PR #2567:
URL: https://github.com/apache/drill/pull/2567#discussion_r891297158
##
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/JsonConvertFrom.java:
##
@@ -32,37 +30,45 @@
import org.apache.drill.exec.expr.holders.NullableVa
vdiravka commented on PR #2568:
URL: https://github.com/apache/drill/pull/2568#issuecomment-1148729328
Added minor fix for `TestHttpPlugin.testSlowResponse` test. Looks like
sometimes the `mockwebserver` can return `DATA_READ ERROR: Read timed out`
instead of `DATA_READ ERROR: timeout`:
cgivre merged PR #2570:
URL: https://github.com/apache/drill/pull/2570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
vdiravka commented on code in PR #2568:
URL: https://github.com/apache/drill/pull/2568#discussion_r891201812
##
contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpHelperFunctions.java:
##
@@ -75,9 +75,6 @@ public void eval() {
// as an approximat
vdiravka commented on code in PR #2568:
URL: https://github.com/apache/drill/pull/2568#discussion_r891201812
##
contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpHelperFunctions.java:
##
@@ -75,9 +75,6 @@ public void eval() {
// as an approximat
cgivre commented on code in PR #2568:
URL: https://github.com/apache/drill/pull/2568#discussion_r891145801
##
contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpHelperFunctions.java:
##
@@ -75,9 +75,6 @@ public void eval() {
// as an approximatio
jnturton commented on PR #2568:
URL: https://github.com/apache/drill/pull/2568#issuecomment-1148560258
> I've checked the rebase onto latest master fixed
`TestDrillSpnegoAuthenticator` locally. So it can be ignored for the review of
this PR
Yes `TestDrillSpnegoAuthenticator` does work lo
vdiravka commented on PR #2568:
URL: https://github.com/apache/drill/pull/2568#issuecomment-1148554376
> The JDK 8 test failure is the result of me not appreciating the flakiness
of TestDrillSpnegoAuthenticator. I'll disable it again soon.
I've checked the rebase onto latest master fi
jnturton commented on PR #2568:
URL: https://github.com/apache/drill/pull/2568#issuecomment-1148553607
I have a question relating to the earlier PR #2566 for this conversion.
`JsonLoaderImpl` acquired a new `fromString` method, but it only needed to do
that to accommodate the String returne
jnturton commented on PR #2568:
URL: https://github.com/apache/drill/pull/2568#issuecomment-1148513297
The JDK 8 test failure is the result of me not appreciating the flakiness of
TestDrillSpnegoAuthenticator. I'll disable it again soon.
--
This is an automated message from the Apache Git
jnturton commented on code in PR #2570:
URL: https://github.com/apache/drill/pull/2570#discussion_r890219980
##
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/config/JsonConfigOptions.java:
##
@@ -0,0 +1,219 @@
+/*
+ * Licensed to the Apache Software Foundati
17 matches
Mail list logo
