[GitHub] [drill] vdiravka commented on a diff in pull request #2571: DRILL-8244: HTTP_Request Not Passing Down Config Variables

2022-06-09 Thread GitBox
vdiravka commented on code in PR #2571: URL: https://github.com/apache/drill/pull/2571#discussion_r894210913 ## contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpHelperFunctions.java: ## @@ -153,10 +149,15 @@ public void setup() { drillbitCont

[GitHub] [drill] vdiravka commented on a diff in pull request #2571: DRILL-8244: HTTP_Request Not Passing Down Config Variables

2022-06-09 Thread GitBox
vdiravka commented on code in PR #2571: URL: https://github.com/apache/drill/pull/2571#discussion_r893211946 ## contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpHelperFunctions.java: ## @@ -153,10 +149,15 @@ public void setup() { drillbitCont

[GitHub] [drill] Leon-WTF merged pull request #2464: DRILL-8132: Improvement of RPC

2022-06-09 Thread GitBox
Leon-WTF merged PR #2464: URL: https://github.com/apache/drill/pull/2464 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.or

[GitHub] [drill] Leon-WTF commented on pull request #2464: DRILL-8132: Improvement of RPC

2022-06-09 Thread GitBox
Leon-WTF commented on PR #2464: URL: https://github.com/apache/drill/pull/2464#issuecomment-1151109198 > LGTM. +1 @Leon-WTF Could you please do a rebase on the master branch? done -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [drill] cgivre commented on a diff in pull request #2571: DRILL-8244: HTTP_Request Not Passing Down Config Variables

2022-06-09 Thread GitBox
cgivre commented on code in PR #2571: URL: https://github.com/apache/drill/pull/2571#discussion_r893386350 ## contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpHelperFunctions.java: ## @@ -153,10 +149,15 @@ public void setup() { drillbitContex

[GitHub] [drill] vdiravka commented on a diff in pull request #2571: DRILL-8244: HTTP_Request Not Passing Down Config Variables

2022-06-09 Thread GitBox
vdiravka commented on code in PR #2571: URL: https://github.com/apache/drill/pull/2571#discussion_r893211946 ## contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpHelperFunctions.java: ## @@ -153,10 +149,15 @@ public void setup() { drillbitCont