[GitHub] [drill] lgtm-com[bot] commented on pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

lgtm-com[bot] commented on PR #2585: URL: https://github.com/apache/drill/pull/2585#issuecomment-1175251199 This pull request **introduces 12 alerts** when merging 2817ce22e2e3e7374b77b957bfb16f64370bef1e into 1189e25beb311306ccdef0d13c210b6db19285d9 - [view on LGTM.com](https://lgtm.com/p

[GitHub] [drill] github-code-scanning[bot] commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

github-code-scanning[bot] commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r913978697 ## contrib/storage-googlesheets/src/main/java/org/apache/drill/exec/store/googlesheets/utils/GoogleSheetsUtils.java: ## @@ -0,0 +1,534 @@ +/* + * License

[GitHub] [drill] vvysotskyi commented on a diff in pull request #2583: DRILL-8182: File scan nodes not differentiated by format config

vvysotskyi commented on code in PR #2583: URL: https://github.com/apache/drill/pull/2583#discussion_r913963349 ## exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillTableSelection.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [drill] cgivre opened a new pull request, #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre opened a new pull request, #2585: URL: https://github.com/apache/drill/pull/2585 # [DRILL-8235](https://issues.apache.org/jira/browse/DRILL-8235): Add Storage Plugin for Google Sheets ## Description Google Sheets is a very commonly used data source among business users. Pr

[GitHub] [drill] jnturton commented on pull request #2582: [Minor Update] Try and reduce the vm crash on fork

jnturton commented on PR #2582: URL: https://github.com/apache/drill/pull/2582#issuecomment-1175030561 Hi @luocooong, please see if the changes in the following patch might allow keep the SNPEGO tests enabled. They correct copy-and-paste errors I found causing conflicting directory use.

[GitHub] [drill] kingswanwho commented on pull request #2584: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2

kingswanwho commented on PR #2584: URL: https://github.com/apache/drill/pull/2584#issuecomment-1174814533 tra > Okay, I did indeed not do a proper job of backporting DRILL-8227 / #2551. Please may you add a new commit to your PR with a commit message like > > ``` > DRILL-822

[GitHub] [drill] jnturton commented on pull request #2584: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2

jnturton commented on PR #2584: URL: https://github.com/apache/drill/pull/2584#issuecomment-1174759621 Okay, I did indeed not do proper job of backporting DRILL-8227 / #2551. Please may you add a new commit to your PR with a commit message like ``` DRILL-8227: JConnect and jTDS JDB

[GitHub] [drill] jnturton commented on pull request #2584: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2

jnturton commented on PR #2584: URL: https://github.com/apache/drill/pull/2584#issuecomment-1174696968 > > #2516 > > Hi James, #2516 introduces the new Authmode, and TestJdbcPluginWithMSSQL.java uses this new feature, maybe we could backport this feature to branch 1.20, so the compil