[GitHub] [drill] pjfanning commented on pull request #2628: Bump hadoop-common from 3.2.3 to 3.2.4

2022-08-22 Thread GitBox
pjfanning commented on PR #2628: URL: https://github.com/apache/drill/pull/2628#issuecomment-1223110739 replaced by https://github.com/apache/drill/pull/2630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [drill] pjfanning opened a new pull request, #2630: [DRILL-8282] hadoop 3.2.4 (cve)

2022-08-22 Thread GitBox
pjfanning opened a new pull request, #2630: URL: https://github.com/apache/drill/pull/2630 ## Description There is a CVE fix in hadoop 3.2.4 ## Documentation (Please describe user-visible changes similar to what should appear in the Drill documentation.) ## Testing

[GitHub] [drill] dependabot[bot] opened a new pull request, #2629: Bump postgresql from 42.3.3 to 42.4.1 in /contrib/storage-jdbc

2022-08-22 Thread GitBox
dependabot[bot] opened a new pull request, #2629: URL: https://github.com/apache/drill/pull/2629 Bumps [postgresql](https://github.com/pgjdbc/pgjdbc) from 42.3.3 to 42.4.1. Release notes Sourced from https://github.com/pgjdbc/pgjdbc/releases;>postgresql's releases. 42.4.0

[GitHub] [drill] dependabot[bot] opened a new pull request, #2628: Bump hadoop-common from 3.2.3 to 3.2.4

2022-08-22 Thread GitBox
dependabot[bot] opened a new pull request, #2628: URL: https://github.com/apache/drill/pull/2628 Bumps hadoop-common from 3.2.3 to 3.2.4. [![Dependabot compatibility

[GitHub] [drill] jnturton commented on issue #2623: There are not enough rules to produce a node with desired properties

2022-08-22 Thread GitBox
jnturton commented on issue #2623: URL: https://github.com/apache/drill/issues/2623#issuecomment-1222035987 Thanks, you've definitely provided enough high quality information for us to promote this to a Jira issue. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [drill] yaozhu commented on issue #2623: There are not enough rules to produce a node with desired properties

2022-08-22 Thread GitBox
yaozhu commented on issue #2623: URL: https://github.com/apache/drill/issues/2623#issuecomment-1221964781 > > I have create table xxx in mysql client terminal directly and just run sql on drill client。 The same sql run in mysql client and got a correct result set ,but drill not。 It bother

[GitHub] [drill] jnturton merged pull request #2627: DRILL-8281: Info schema LIKE with ESCAPE push down bug

2022-08-21 Thread GitBox
jnturton merged PR #2627: URL: https://github.com/apache/drill/pull/2627 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] jnturton commented on issue #2623: There are not enough rules to produce a node with desired properties

2022-08-21 Thread GitBox
jnturton commented on issue #2623: URL: https://github.com/apache/drill/issues/2623#issuecomment-1221765691 > I have create table xxx in mysql client terminal directly and just run sql on drill client。 The same sql run in mysql client and got a correct result set ,but drill not。 It bother

[GitHub] [drill] yaozhu commented on issue #2623: There are not enough rules to produce a node with desired properties

2022-08-21 Thread GitBox
yaozhu commented on issue #2623: URL: https://github.com/apache/drill/issues/2623#issuecomment-1221665356 > This looks like an invalid query. Unless you ran this and selected a default schema first, it is necessary to specify what storage plugin you are creating a table in. IE: > >

[GitHub] [drill] jnturton opened a new pull request, #2627: DRILL-8281: Info schema LIKE with ESCAPE push down bug

2022-08-19 Thread GitBox
jnturton opened a new pull request, #2627: URL: https://github.com/apache/drill/pull/2627 # [DRILL-8281](https://issues.apache.org/jira/browse/DRILL-8281): Info schema LIKE with ESCAPE push down bug ## Description [DRILL-8057](https://issues.apache.org/jira/browse/DRILL-8057)

[GitHub] [drill] guihui123456 closed issue #2587: Unexpected exception during fragment initialization: ELASTICSEARCH != NONE

2022-08-18 Thread GitBox
guihui123456 closed issue #2587: Unexpected exception during fragment initialization: ELASTICSEARCH != NONE URL: https://github.com/apache/drill/issues/2587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [drill] guihui123456 commented on issue #2587: Unexpected exception during fragment initialization: ELASTICSEARCH != NONE

2022-08-18 Thread GitBox
guihui123456 commented on issue #2587: URL: https://github.com/apache/drill/issues/2587#issuecomment-1220181923 > @guihui123456 We are about to merge a significant pull request which updates Calcite to the latest version. I would be curious as to whether this solves this. @cgivre

[GitHub] [drill] jnturton closed issue #2626: Date function is not working with mongo storage plugin

2022-08-17 Thread GitBox
jnturton closed issue #2626: Date function is not working with mongo storage plugin URL: https://github.com/apache/drill/issues/2626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [drill] raj-s-gouda commented on issue #2626: Date function is not working with mongo storage plugin

2022-08-17 Thread GitBox
raj-s-gouda commented on issue #2626: URL: https://github.com/apache/drill/issues/2626#issuecomment-1218405360 SELECT CAST('2010-01-01' AS DATE) . This is working. Thanks for the quick response. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [drill] cgivre commented on issue #2626: Date function is not working with mongo storage plugin

2022-08-17 Thread GitBox
cgivre commented on issue #2626: URL: https://github.com/apache/drill/issues/2626#issuecomment-1218354886 I'm with @jnturton . I'm surprised that ever worked. Try: ``` SELECT CAST('2010-01-01' AS DATE) ```. Alternatively, we could easily implement that... -- This is an

[GitHub] [drill] raj-s-gouda commented on issue #2626: Date function is not working with mongo storage plugin

2022-08-17 Thread GitBox
raj-s-gouda commented on issue #2626: URL: https://github.com/apache/drill/issues/2626#issuecomment-1218353177 https://drill.apache.org/docs/date-time-and-timestamp/ Date function was working in 1.17.0 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [drill] cgivre merged pull request #2625: DRILL-8280: Cannot ANALYZE files containing non-ASCII column names

2022-08-17 Thread GitBox
cgivre merged PR #2625: URL: https://github.com/apache/drill/pull/2625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] jnturton commented on issue #2626: Date function is not working with mongo storage plugin

2022-08-17 Thread GitBox
jnturton commented on issue #2626: URL: https://github.com/apache/drill/issues/2626#issuecomment-1218285387 Does Drill have a SQL function called `DATE`? I don't think so 樂. If not then I wonder why this ever worked... On 2022/08/17 18:31, raj-s-gouda wrote: > > Running

[GitHub] [drill] raj-s-gouda commented on issue #2626: Date function is not working with mongo storage plugin

2022-08-17 Thread GitBox
raj-s-gouda commented on issue #2626: URL: https://github.com/apache/drill/issues/2626#issuecomment-1218256302 There are few more queries which are failing, attached log for reference [DrillErrors-1.20.2.log](https://github.com/apache/drill/files/9364659/DrillErrors-1.20.2.log) --

[GitHub] [drill] raj-s-gouda opened a new issue, #2626: Date function is not working with mongo storage plugin

2022-08-17 Thread GitBox
raj-s-gouda opened a new issue, #2626: URL: https://github.com/apache/drill/issues/2626 Running below query on MongoDB using mongo storage plugin (with Drill 1.20.2) fails with error: SELECT `Name` , `DATE`(`UpdatedBy`) FROM

[GitHub] [drill] jnturton opened a new pull request, #2625: DRILL-8280: Cannot ANALYZE files containing non-ASCII column names

2022-08-17 Thread GitBox
jnturton opened a new pull request, #2625: URL: https://github.com/apache/drill/pull/2625 # [DRILL-8280](https://issues.apache.org/jira/browse/DRILL-8280): Cannot ANALYZE files containing non-ASCII column names ## Description The merge_schema function in SchemaFunctions is

[GitHub] [drill] vvysotskyi merged pull request #2624: DRILL-8279: Rename skip tests property to match maven-surefire property name

2022-08-16 Thread GitBox
vvysotskyi merged PR #2624: URL: https://github.com/apache/drill/pull/2624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill-site] jnturton merged pull request #32: [DOC UPDATE] Update doc to sync with DRILL-8269

2022-08-16 Thread GitBox
jnturton merged PR #32: URL: https://github.com/apache/drill-site/pull/32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill-site] kingswanwho commented on pull request #32: [DOC UPDATE] Update doc to sync with DRILL-8269

2022-08-16 Thread GitBox
kingswanwho commented on PR #32: URL: https://github.com/apache/drill-site/pull/32#issuecomment-1216724827 > Thanks for this! I've offered a few small suggestions related to language. Hi James, your suggestions are really helpful! I have changed them all as you suggested -- This

[GitHub] [drill] luocooong closed pull request #2215: DRILL-7916: Support new plugin installation on the running system

2022-08-16 Thread GitBox
luocooong closed pull request #2215: DRILL-7916: Support new plugin installation on the running system URL: https://github.com/apache/drill/pull/2215 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [drill] luocooong closed issue #2576: An extra cancel button exists on the UI

2022-08-16 Thread GitBox
luocooong closed issue #2576: An extra cancel button exists on the UI URL: https://github.com/apache/drill/issues/2576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [drill] luocooong closed issue #2233: [Notice] welcome the ideas and contribution with next release 1.20.0

2022-08-16 Thread GitBox
luocooong closed issue #2233: [Notice] welcome the ideas and contribution with next release 1.20.0 URL: https://github.com/apache/drill/issues/2233 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [drill] luocooong closed issue #2439: Update the copyright year [for newcomers]

2022-08-16 Thread GitBox
luocooong closed issue #2439: Update the copyright year [for newcomers] URL: https://github.com/apache/drill/issues/2439 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [drill] luocooong closed issue #2438: Update the Slack site [for newcomers]

2022-08-16 Thread GitBox
luocooong closed issue #2438: Update the Slack site [for newcomers] URL: https://github.com/apache/drill/issues/2438 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [drill] vvysotskyi commented on pull request #2622: DRILL-8279: Use thick Phoenix driver

2022-08-16 Thread GitBox
vvysotskyi commented on PR #2622: URL: https://github.com/apache/drill/pull/2622#issuecomment-1216459627 @luocooong, sorry, I didn't aim to outspeak overbearing, I just wanted to express my thoughts on why I didn't start a discussion on the mailing list. If you have ideas on how to

[GitHub] [drill] vvysotskyi opened a new pull request, #2624: DRILL-8279: Rename skip tests property to match maven-surefire property name

2022-08-16 Thread GitBox
vvysotskyi opened a new pull request, #2624: URL: https://github.com/apache/drill/pull/2624 # [DRILL-8279](https://issues.apache.org/jira/browse/DRILL-8279): Rename skip tests property to match maven-surefire property name ## Description Renamed property to skip tests to since

[GitHub] [drill] luocooong commented on pull request #2622: DRILL-8279: Use thick Phoenix driver

2022-08-16 Thread GitBox
luocooong commented on PR #2622: URL: https://github.com/apache/drill/pull/2622#issuecomment-1216419739 Sorry, I cannot accept the above overbearing statement. I don't want to argue any more about this pull request, because that pull request was actually merged, so the right to speak is

[GitHub] [drill] vvysotskyi commented on pull request #2622: DRILL-8279: Use thick Phoenix driver

2022-08-16 Thread GitBox
vvysotskyi commented on PR #2622: URL: https://github.com/apache/drill/pull/2622#issuecomment-1216406330 @luocooong, at least I know several people that were already affected by this classpath issue, so it was the reason for fixing it quickly. Jira ticket was created `14 Aug 14:36

[GitHub] [drill] luocooong commented on pull request #2622: DRILL-8279: Use thick Phoenix driver

2022-08-16 Thread GitBox
luocooong commented on PR #2622: URL: https://github.com/apache/drill/pull/2622#issuecomment-1216372092 It was a real disappointment today. As Java developers, all path conflicts will be solved in a way, but we chose one of the worst results. What are we doing in such a hurry?

[GitHub] [drill] vvysotskyi commented on pull request #2622: DRILL-8279: Use thick Phoenix driver

2022-08-16 Thread GitBox
vvysotskyi commented on PR #2622: URL: https://github.com/apache/drill/pull/2622#issuecomment-1216365721 @luocooong, Drill plugins are still pluggable, so you can provide your own implementations if you need. Phoenix official connectors [1] for such big data tools like Spark, Hive

[GitHub] [drill] jnturton commented on pull request #2622: DRILL-8279: Use thick Phoenix driver

2022-08-16 Thread GitBox
jnturton commented on PR #2622: URL: https://github.com/apache/drill/pull/2622#issuecomment-1216343681 @luocooong let's see if we can offer storage plugins for both thick and thin drivers then? The classpath conflict bug in the thin driver is very serious, even if you have not yet been

[GitHub] [drill-site] jnturton commented on a diff in pull request #32: [DOC UPDATE] Update doc to sync with DRILL-8269

2022-08-16 Thread GitBox
jnturton commented on code in PR #32: URL: https://github.com/apache/drill-site/pull/32#discussion_r946497802 ## _docs/en/performance-tuning/070-monitoring-metrics.md: ## @@ -35,14 +35,41 @@ In `$DRILL_HOME/conf/drill-env.sh`, set the `drill.metrics.jmx.enabled` option t

[GitHub] [drill] luocooong commented on pull request #2622: DRILL-8279: Use thick Phoenix driver

2022-08-16 Thread GitBox
luocooong commented on PR #2622: URL: https://github.com/apache/drill/pull/2622#issuecomment-1216295980 **_Holy cow, that's unbelievable !_** Why did this get approved without production experience? Why do we need to force use of fat clients? There are ways to resolve package

[GitHub] [drill] jnturton commented on issue #2595: Unexpected behavior with Cassandra connector

2022-08-16 Thread GitBox
jnturton commented on issue #2595: URL: https://github.com/apache/drill/issues/2595#issuecomment-1216292882 @CarusoGuillaume he'll be referring to the snaphot builds from the master branch. Look for Docker Hub tags starting with "master" -- This is an automated message from the Apache

[GitHub] [drill] vvysotskyi merged pull request #2622: DRILL-8279: Use thick Phoenix driver

2022-08-16 Thread GitBox
vvysotskyi merged PR #2622: URL: https://github.com/apache/drill/pull/2622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] vvysotskyi commented on pull request #2622: DRILL-8279: Use thick Phoenix driver

2022-08-16 Thread GitBox
vvysotskyi commented on PR #2622: URL: https://github.com/apache/drill/pull/2622#issuecomment-1216258491 I agree that this change should be backported, since classpath issue might affect any user, even if user doesn't use Phoenix at all. -- This is an automated message from the Apache

[GitHub] [drill] CarusoGuillaume commented on issue #2595: Unexpected behavior with Cassandra connector

2022-08-16 Thread GitBox
CarusoGuillaume commented on issue #2595: URL: https://github.com/apache/drill/issues/2595#issuecomment-1216235037 @cgivre Is the update available for docker ? The `latest` tag pulls the 1.20.2 version. And in this version, it still performs a full table scan when using a cassandra

[GitHub] [drill] jnturton commented on pull request #2622: DRILL-8279: Use thick Phoenix driver

2022-08-16 Thread GitBox
jnturton commented on PR #2622: URL: https://github.com/apache/drill/pull/2622#issuecomment-1216187000 > Was there an agreement as to whether we should backport this to 1.20? Not yet. For my part I'm supportive of backporting because I don't like the idea of a classloader time bomb

[GitHub] [drill] cgivre commented on pull request #2622: DRILL-8279: Use thick Phoenix driver

2022-08-15 Thread GitBox
cgivre commented on PR #2622: URL: https://github.com/apache/drill/pull/2622#issuecomment-1216074207 Was there an agreement as to whether we should backport this to 1.20? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [drill] vvysotskyi commented on a diff in pull request #2622: DRILL-8279: Use thick Phoenix driver

2022-08-15 Thread GitBox
vvysotskyi commented on code in PR #2622: URL: https://github.com/apache/drill/pull/2622#discussion_r946147460 ## contrib/storage-phoenix/pom.xml: ## @@ -353,6 +381,9 @@ hadoop-2 + +true Review Comment: For some reason CI tests fail with

[GitHub] [drill] cgivre commented on a diff in pull request #2622: DRILL-8279: Use thick Phoenix driver

2022-08-15 Thread GitBox
cgivre commented on code in PR #2622: URL: https://github.com/apache/drill/pull/2622#discussion_r946110147 ## contrib/storage-phoenix/pom.xml: ## @@ -353,6 +381,9 @@ hadoop-2 + +true Review Comment: See here:

[GitHub] [drill] cgivre merged pull request #2618: DRILL-8276: Add Support for User Translation for Splunk Plugin

2022-08-15 Thread GitBox
cgivre merged PR #2618: URL: https://github.com/apache/drill/pull/2618 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] cgivre commented on pull request #2618: DRILL-8276: Add Support for User Translation for Splunk Plugin

2022-08-15 Thread GitBox
cgivre commented on PR #2618: URL: https://github.com/apache/drill/pull/2618#issuecomment-1215003395 @jnturton Thanks for the review. I revised the unit tests and added an additional test to verify that a query will fail with invalid credentials. I also fixed the LGTM alert. -- This

[GitHub] [drill] cgivre commented on a diff in pull request #2618: DRILL-8276: Add Support for User Translation for Splunk Plugin

2022-08-15 Thread GitBox
cgivre commented on code in PR #2618: URL: https://github.com/apache/drill/pull/2618#discussion_r945720672 ## contrib/storage-splunk/src/test/java/org/apache/drill/exec/store/splunk/TestSplunkUserTranslation.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software

[GitHub] [drill] cgivre commented on a diff in pull request #2618: DRILL-8276: Add Support for User Translation for Splunk Plugin

2022-08-15 Thread GitBox
cgivre commented on code in PR #2618: URL: https://github.com/apache/drill/pull/2618#discussion_r945701382 ## contrib/storage-splunk/src/main/java/org/apache/drill/exec/store/splunk/SplunkGroupScan.java: ## @@ -50,17 +54,20 @@ public class SplunkGroupScan extends

[GitHub] [drill] jnturton commented on a diff in pull request #2622: DRILL-8279: Use thick Phoenix driver

2022-08-15 Thread GitBox
jnturton commented on code in PR #2622: URL: https://github.com/apache/drill/pull/2622#discussion_r945557835 ## contrib/storage-phoenix/README.md: ## @@ -83,11 +83,11 @@ Tips : Configurations : 1. Enable [Drill User

[GitHub] [drill] jnturton commented on pull request #2622: DRILL-8279: Use thick Phoenix driver

2022-08-15 Thread GitBox
jnturton commented on PR #2622: URL: https://github.com/apache/drill/pull/2622#issuecomment-1214844957 @vvysotskyi even though we've only seen this Avatica conflict affect Drill master after the Calcite upgrade was merged, do I understand correctly that it also lies latent the 1.20 branch?

[GitHub] [drill] jnturton commented on a diff in pull request #2618: DRILL-8276: Add Support for User Translation for Splunk Plugin

2022-08-15 Thread GitBox
jnturton commented on code in PR #2618: URL: https://github.com/apache/drill/pull/2618#discussion_r945514482 ## contrib/storage-splunk/src/main/java/org/apache/drill/exec/store/splunk/SplunkGroupScan.java: ## @@ -50,17 +54,20 @@ public class SplunkGroupScan extends

[GitHub] [drill] cgivre commented on issue #2588: Run error when executing a query which contains right join

2022-08-14 Thread GitBox
cgivre commented on issue #2588: URL: https://github.com/apache/drill/issues/2588#issuecomment-1214559453 @guihui123456 Can you please try with the current master? We updated Calcite and I'm curious as to whether this fixes the issue. -- This is an automated message from the Apache Git

[GitHub] [drill] cgivre commented on issue #2595: Unexpected behavior with Cassandra connector

2022-08-14 Thread GitBox
cgivre commented on issue #2595: URL: https://github.com/apache/drill/issues/2595#issuecomment-1214559054 @CarusoGuillaume Thanks for reporting this. One thing... we recently merged a PR which updated the Drill query planner and likely includes updates to the Cassandra adapter. I'd be

[GitHub] [drill] cgivre commented on issue #2623: There are not enough rules to produce a node with desired properties

2022-08-14 Thread GitBox
cgivre commented on issue #2623: URL: https://github.com/apache/drill/issues/2623#issuecomment-1214558608 This looks like an invalid query. Unless you ran this and selected a default schema first, it is necessary to specify what storage plugin you are creating a table in. IE: ```

[GitHub] [drill] yaozhu opened a new issue, #2623: There are not enough rules to produce a node with desired properties

2022-08-14 Thread GitBox
yaozhu opened a new issue, #2623: URL: https://github.com/apache/drill/issues/2623 **Describe the bug** The drill report a exception since a query running, report msg:There are not enough rules to produce a node with desired properties **To Reproduce** CREATE TABLE ORDERS (

[GitHub] [drill] Z0ltrix commented on pull request #2622: DRILL-8279: Use thick Phoenix driver

2022-08-14 Thread GitBox
Z0ltrix commented on PR #2622: URL: https://github.com/apache/drill/pull/2622#issuecomment-1214445771 Wow @vvysotskyi great work! I'm so excited to see this in the real environment. Regards -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [drill] vvysotskyi opened a new pull request, #2622: DRILL-8279: Use thick Phoenix driver

2022-08-14 Thread GitBox
vvysotskyi opened a new pull request, #2622: URL: https://github.com/apache/drill/pull/2622 # [DRILL-8279](https://issues.apache.org/jira/browse/DRILL-8279): Use thick Phoenix driver ## Description `phoenix-queryserver-client` shades Avatica classes, so it causes issues when

[GitHub] [drill] jnturton commented on pull request #2618: DRILL-8276: Add Support for User Translation for Splunk Plugin

2022-08-14 Thread GitBox
jnturton commented on PR #2618: URL: https://github.com/apache/drill/pull/2618#issuecomment-1214356297 > I'm not too concerned because we know Drill runs on ARM, and the use case here would be for a user to connect to a remote Splunk installation. I see it the same way, I just want

[GitHub] [drill] cgivre commented on pull request #2618: DRILL-8276: Add Support for User Translation for Splunk Plugin

2022-08-14 Thread GitBox
cgivre commented on PR #2618: URL: https://github.com/apache/drill/pull/2618#issuecomment-1214351323 > It looks like no attempt was made to run the Splunk tests on ARM. Perhaps this is because we separated out the running of the SlowTest category? @luocooong, do we run any SlowTests on

[GitHub] [drill] jnturton commented on pull request #2618: DRILL-8276: Add Support for User Translation for Splunk Plugin

2022-08-14 Thread GitBox
jnturton commented on PR #2618: URL: https://github.com/apache/drill/pull/2618#issuecomment-1214292480 It looks like no attempt was made to run the Splunk tests on ARM. Perhaps this is because we separated out the running of the SlowTest category? @luocooong, do we run any SlowTests on

[GitHub] [drill] lgtm-com[bot] commented on pull request #2618: DRILL-8276: Add Support for User Translation for Splunk Plugin

2022-08-13 Thread GitBox
lgtm-com[bot] commented on PR #2618: URL: https://github.com/apache/drill/pull/2618#issuecomment-1214283823 This pull request **introduces 1 alert** when merging 64b9c3cd42528cae534f071aa29861af5781f74b into 51fbdbe7d586f6e8a8137680ee7ccd738ced - [view on

[GitHub] [drill] cgivre commented on pull request #2618: DRILL-8276: Add Support for User Translation for Splunk Plugin

2022-08-13 Thread GitBox
cgivre commented on PR #2618: URL: https://github.com/apache/drill/pull/2618#issuecomment-1214273941 @jnturton This PR is now ready for review. As a note, I couldn't get this to work on my Mac M1 due to the lack of a ARM Docker Container for Splunk. Not sure how the Travis CI checks are

[GitHub] [drill] jnturton merged pull request #2621: DRILL-8278: The period character '.' is broken in SQL LIKE patterns

2022-08-13 Thread GitBox
jnturton merged PR #2621: URL: https://github.com/apache/drill/pull/2621 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] jnturton merged pull request #2619: DRILL-8277: Publish SNAPSHOT artifacts to the Apache snapshots repo from CI

2022-08-12 Thread GitBox
jnturton merged PR #2619: URL: https://github.com/apache/drill/pull/2619 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] jnturton commented on pull request #2619: DRILL-8277: Publish SNAPSHOT artifacts to the Apache snapshots repo from CI

2022-08-12 Thread GitBox
jnturton commented on PR #2619: URL: https://github.com/apache/drill/pull/2619#issuecomment-1213044226 @vvysotskyi GitHub secrets are not visible to PRs so the new snapshot artifact deployment workflow cannot run successfully here. Therefore, please review the following workflow run which

[GitHub] [drill] jnturton opened a new pull request, #2621: DRILL-8278: The period character '.' is broken in SQL LIKE patterns

2022-08-12 Thread GitBox
jnturton opened a new pull request, #2621: URL: https://github.com/apache/drill/pull/2621 # [DRILL-8278](https://issues.apache.org/jira/browse/DRILL-8278): The period character '.' is broken in SQL LIKE patterns ## Description The '.' character is added to the

[GitHub] [drill] cgivre commented on pull request #2596: DRILL-8259: Supports advanced HBase persistence storage options

2022-08-11 Thread GitBox
cgivre commented on PR #2596: URL: https://github.com/apache/drill/pull/2596#issuecomment-1212670725 @Z0ltrix Would you mind doing a formal review on this PR? @luocooong asked me but I don't really have enough experience with HBase to comment intelligently on this. If you're already

[GitHub] [drill] cgivre merged pull request #2620: DRILL-8273: Complex typed columns cannot be made implicit (extend unit tests)

2022-08-11 Thread GitBox
cgivre merged PR #2620: URL: https://github.com/apache/drill/pull/2620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] jnturton commented on pull request #2620: DRILL-8273: Complex typed columns cannot be made implicit (extend unit tests)

2022-08-11 Thread GitBox
jnturton commented on PR #2620: URL: https://github.com/apache/drill/pull/2620#issuecomment-1211995361 @cgivre PrimitiveColumnMetadata handles many data types and gets tested by the scalar INT case. DynamicColumn is the one that I can see which remains untested in wildcard projections but

[GitHub] [drill] jnturton opened a new pull request, #2620: DRILL-8273: Complex typed columns cannot be made implicit (extend unit tests)

2022-08-11 Thread GitBox
jnturton opened a new pull request, #2620: URL: https://github.com/apache/drill/pull/2620 # [DRILL-8273](https://issues.apache.org/jira/browse/DRILL-8273): Complex typed columns cannot be made implicit (extend unit tests) ## Description The first PR (#2615) did not cover all

[GitHub] [drill] jnturton commented on pull request #2619: DRILL-8227: Publish SNAPSHOT artifacts to the Apache snapshots repo from CI

2022-08-10 Thread GitBox
jnturton commented on PR #2619: URL: https://github.com/apache/drill/pull/2619#issuecomment-1210684135 > If this overly eager optimisation and it is preferred to move the snapshot artifact publishing out to its own job (which is probably more clearly reported on here in the GH web UI) then

[GitHub] [drill] jnturton commented on pull request #2619: DRILL-8227: Publish SNAPSHOT artifacts to the Apache snapshots repo from CI

2022-08-10 Thread GitBox
jnturton commented on PR #2619: URL: https://github.com/apache/drill/pull/2619#issuecomment-1210622825 The reason that the snapshot artifact publishing is run inside the existing checkstyle and protobufs jobs is an attempt at efficiency. Maven will not need to rebuild all the Drill

[GitHub] [drill] jnturton opened a new pull request, #2619: DRILL-8227: Publish SNAPSHOT artifacts to the Apache snapshots repo from CI

2022-08-10 Thread GitBox
jnturton opened a new pull request, #2619: URL: https://github.com/apache/drill/pull/2619 # [DRILL-8227](https://issues.apache.org/jira/browse/DRILL-8227): Publish SNAPSHOT artifacts to the Apache snapshots repo from CI ## Description It is possible to publish snapshot artifiacts

[GitHub] [drill] lgtm-com[bot] commented on pull request #2618: DRILL-8276: Add Support for User Translation for Splunk Plugin

2022-08-09 Thread GitBox
lgtm-com[bot] commented on PR #2618: URL: https://github.com/apache/drill/pull/2618#issuecomment-1209998222 This pull request **introduces 1 alert** when merging 778538064eb16f8d449b2f32b876b67ec2e19f5b into 6263f713891ddfbef547abf6dbd65bf12d1edf5d - [view on

[GitHub] [drill-site] kingswanwho opened a new pull request, #32: [DOC UPDATE] Update doc to sync with DRILL-8269

2022-08-08 Thread GitBox
kingswanwho opened a new pull request, #32: URL: https://github.com/apache/drill-site/pull/32 # [DOC UPDATE] Update doc to sync with DRILL-8269 ## Description According to the change of PR https://github.com/apache/drill/pull/2611, update the corresponding doc

[GitHub] [drill] vvysotskyi merged pull request #2602: DRILL-7523: Update Calcite to 1.31.0

2022-08-07 Thread GitBox
vvysotskyi merged PR #2602: URL: https://github.com/apache/drill/pull/2602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] cgivre opened a new pull request, #2618: DRILL-8276: Add Support for User Translation for Splunk Plugin

2022-08-07 Thread GitBox
cgivre opened a new pull request, #2618: URL: https://github.com/apache/drill/pull/2618 # [DRILL-8276](https://issues.apache.org/jira/browse/DRILL-8276): Add Support for User Translation for Splunk Plugin ## Description Adds support for user translation in the Splunk plugin. This

[GitHub] [drill] luocooong opened a new pull request, #2617: DRILL-8275: Prevent the JDBC Client to create error path in Zookeeper

2022-08-05 Thread GitBox
luocooong opened a new pull request, #2617: URL: https://github.com/apache/drill/pull/2617 # [DRILL-8275](https://issues.apache.org/jira/browse/DRILL-8275): Prevent the JDBC Client to create error path in Zookeeper ## Description Use the ZK style on the connection string and the

[GitHub] [drill] vvysotskyi commented on a diff in pull request #2602: DRILL-7523: Update Calcite to 1.31.0

2022-08-03 Thread GitBox
vvysotskyi commented on code in PR #2602: URL: https://github.com/apache/drill/pull/2602#discussion_r936273407 ## exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlSelectBuilder.java: ## @@ -90,8 +91,14 @@ public SqlSelectBuilder fetch(SqlNode fetch) {

[GitHub] [drill] cgivre commented on a diff in pull request #2602: DRILL-7523: Update Calcite to 1.31.0

2022-08-02 Thread GitBox
cgivre commented on code in PR #2602: URL: https://github.com/apache/drill/pull/2602#discussion_r936171984 ## exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlSelectBuilder.java: ## @@ -90,8 +91,14 @@ public SqlSelectBuilder fetch(SqlNode fetch) { return

[GitHub] [drill] vvysotskyi commented on pull request #2602: DRILL-7523: Update Calcite to 1.31.0

2022-08-02 Thread GitBox
vvysotskyi commented on PR #2602: URL: https://github.com/apache/drill/pull/2602#issuecomment-1203168678 Now it has the latest official released Calcite (and Avativa) version, so it is ready for review. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [drill] jnturton commented on pull request #2615: DRILL-8273: Complex typed columns cannot be made implicit

2022-07-31 Thread GitBox
jnturton commented on PR #2615: URL: https://github.com/apache/drill/pull/2615#issuecomment-1200704890 Nice to see you @paul-rogers! I did expand [TestTupleProjection.java](https://github.com/apache/drill/pull/2615/files#diff-cacd24c51a19207bf60b8bd8aa9d13b729043cceb2187eb5b4368a855f95e67c)

[GitHub] [drill] paul-rogers commented on pull request #2615: DRILL-8273: Complex typed columns cannot be made implicit

2022-07-31 Thread GitBox
paul-rogers commented on PR #2615: URL: https://github.com/apache/drill/pull/2615#issuecomment-1200668136 Jumping in a bit late to this one. It is generally a good idea to include unit tests with all changes. Can we add such tests in a subsequent PR? Since implicit columns affect

[GitHub] [drill] jnturton merged pull request #2616: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2 Phase 3

2022-07-31 Thread GitBox
jnturton merged PR #2616: URL: https://github.com/apache/drill/pull/2616 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] kingswanwho opened a new pull request, #2616: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2 Phase 3

2022-07-31 Thread GitBox
kingswanwho opened a new pull request, #2616: URL: https://github.com/apache/drill/pull/2616 # [BACKPORT-TO-STABLE] Bugfix Release 1.20.2 Phase 3 ## Description Merged serveral backport-to-stable commits to new bugfix release 1.20.2, which includes: *

[GitHub] [drill] jnturton merged pull request #2615: DRILL-8273: Complex typed columns cannot be made implicit

2022-07-31 Thread GitBox
jnturton merged PR #2615: URL: https://github.com/apache/drill/pull/2615 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] jnturton merged pull request #2610: DRILL-8268: Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

2022-07-30 Thread GitBox
jnturton merged PR #2610: URL: https://github.com/apache/drill/pull/2610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] jnturton commented on a diff in pull request #2610: DRILL-8268: Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

2022-07-29 Thread GitBox
jnturton commented on code in PR #2610: URL: https://github.com/apache/drill/pull/2610#discussion_r933186066 ## exec/jdbc-all/pom.xml: ## @@ -329,8 +386,6 @@ io.protostuff:* - ${calcite.groupId}:calcite-core Review

[GitHub] [drill] jnturton commented on pull request #2610: DRILL-8268: Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

2022-07-29 Thread GitBox
jnturton commented on PR #2610: URL: https://github.com/apache/drill/pull/2610#issuecomment-1199209490 @vvysotskyi JDBC clients tested after new exclusions: sqlline 1.12 SquirrelSQL 4.40 DBeaver 22.0.2 installed as an Eclipse plugin All tests had htpasswd authentication

[GitHub] [drill] vvysotskyi commented on a diff in pull request #2610: DRILL-8268: Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

2022-07-29 Thread GitBox
vvysotskyi commented on code in PR #2610: URL: https://github.com/apache/drill/pull/2610#discussion_r933069130 ## exec/jdbc-all/pom.xml: ## @@ -206,6 +231,38 @@ io.swagger.core.v3 swagger-jaxrs2-servlet-initializer-v2 + +

[GitHub] [drill] jnturton commented on a diff in pull request #2610: DRILL-8268: Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

2022-07-29 Thread GitBox
jnturton commented on code in PR #2610: URL: https://github.com/apache/drill/pull/2610#discussion_r932977164 ## exec/jdbc-all/pom.xml: ## @@ -1230,7 +1230,7 @@ hadoop-2 -5040 +5280 Review Comment: Always :-) -- This is an

[GitHub] [drill] jnturton commented on a diff in pull request #2610: DRILL-8268: Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

2022-07-28 Thread GitBox
jnturton commented on code in PR #2610: URL: https://github.com/apache/drill/pull/2610#discussion_r932878062 ## exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/sequencefile/SequenceFileBatchReader.java: ## @@ -154,6 +153,19 @@ public boolean next() {

[GitHub] [drill] vvysotskyi commented on a diff in pull request #2610: DRILL-8268: Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

2022-07-28 Thread GitBox
vvysotskyi commented on code in PR #2610: URL: https://github.com/apache/drill/pull/2610#discussion_r932494153 ## exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/sequencefile/SequenceFileBatchReader.java: ## @@ -154,6 +153,19 @@ public boolean next() {

[GitHub] [drill] jnturton opened a new pull request, #2615: DRILL-8273: Complex typed columns cannot be made implicit

2022-07-28 Thread GitBox
jnturton opened a new pull request, #2615: URL: https://github.com/apache/drill/pull/2615 # [DRILL-8273](https://issues.apache.org/jira/browse/DRILL-8273): Complex typed columns cannot be made implicit ## Description A number of column metadata implementations drop column

[GitHub] [drill] jnturton commented on pull request #2610: DRILL-8268: Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

2022-07-28 Thread GitBox
jnturton commented on PR #2610: URL: https://github.com/apache/drill/pull/2610#issuecomment-1197713664 @luocooong @vvysotskyi there was a lot of noise in the pom.xml diff. I've now redone the changes to it to remove that. -- This is an automated message from the Apache Git Service. To

[GitHub] [drill] cgivre commented on pull request #2612: DRILL-8271: Make Storage and Format Config Case Insensitive

2022-07-27 Thread GitBox
cgivre commented on PR #2612: URL: https://github.com/apache/drill/pull/2612#issuecomment-1197561466 > @cgivre Hi. Some configurations require case-sensitive keys to be passed to a plugin, such as JDBC's properties. Will this change be compatible? I believe so. If this is in an

[GitHub] [drill] ankane commented on issue #2614: Missing 1.20.1 Release

2022-07-27 Thread GitBox
ankane commented on issue #2614: URL: https://github.com/apache/drill/issues/2614#issuecomment-1197235849 Thanks @jnturton -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [drill] jnturton commented on pull request #2610: DRILL-8268: Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

2022-07-27 Thread GitBox
jnturton commented on PR #2610: URL: https://github.com/apache/drill/pull/2610#issuecomment-1196632952 @luocooong @vvysotskyi, so the Kerberos unit tests that we recently got working and enabled for the default-hadoop profile (#2592) remain flaky in the new hadoop-2 CI profile. I've just

<    2   3   4   5   6   7   8   9   10   11   >