Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/581#discussion_r95887742
--- Diff:
logical/src/main/java/org/apache/drill/common/expression/fn/JodaDateValidator.java
---
@@ -0,0 +1,216 @@
+/*
+* Licensed to the Apache
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/581#discussion_r95880960
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/testing/TestDateConversions.java
---
@@ -0,0 +1,200 @@
+/*
+* Licensed to
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/581#discussion_r95864621
--- Diff:
exec/java-exec/src/main/codegen/templates/DateIntervalFunctionTemplates/SqlToDateTypeFunctions.java
---
@@ -0,0 +1,77
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/696#discussion_r96048977
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/bson/TestBsonRecordReader.java
---
@@ -103,6 +103,17 @@ public void testStringType
Congrats! Nice job!
- Paul
> On Jan 14, 2017, at 5:52 AM, Nagarajan Chinnasamy
> wrote:
>
> Success :) I could invoke SESSION_ID without parenthesis. Following did the
> trick:
>
> 1. In DrillSqlOperator, overriding getSyntax method to return
> SqlSyntax.FUNCTION_ID
> 2. In DrillOperatorTable
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r96509598
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SchemaUtilites.java
---
@@ -177,4 +186,34 @@ public static AbstractSchema
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/710#discussion_r96739079
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/QueryBuilder.java ---
@@ -0,0 +1,314 @@
+/*
+ * Licensed to the Apache Software
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/710
Rebased onto master. Pulled in additional changes from development branch
that have accumulated in the three weeks that this PR has worked its way though
the process. See the description in the
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/710#discussion_r96928159
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/QueryBuilder.java ---
@@ -49,6 +57,107 @@
public class QueryBuilder
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/710#discussion_r96924435
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/LogFixture.java ---
@@ -0,0 +1,255 @@
+/*
+ * Licensed to the Apache Software
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/710#discussion_r96927306
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/QueryBuilder.java ---
@@ -49,6 +57,107 @@
public class QueryBuilder
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/710
Rebased on master, resolved conflict and squashed commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Hi Charles,
The Varchar column can hold any length of data. We’ve recently been working on
tests that have columns up to 8K in length.
The one caveat is that, when working with data larger than 256 bytes, you must
be extremely careful in your reader. The out-of-box text reader will always
read
varChar(fieldName).writeVarChar(0, stringLength, buffer);
}
On Jan 26, 2017, at 20:20, Paul Rogers
mailto:prog...@mapr.com>> wrote:
Hi Charles,
The Varchar column can hold any length of data. We’ve recently been working on
tests that have columns up to 8K in length.
The one caveat is tha
; charless-mbp-2.fios-router.home:31010] (state=,code=0)
>
>
>
>
>> On Jan 26, 2017, at 23:08, Paul Rogers wrote:
>>
>> Hi Charles,
>>
>> Very cool plugin!
>>
>> My knowledge in this area is a bit sketchy… That said, the problem appears
e docs, that would be great.
> Thanks,
> — Charles
>
>
>
>> On Jan 27, 2017, at 02:11, Paul Rogers wrote:
>>
>> Looks like I gave you advice that as a bit off. The function you want is
>> either:
>>
>> this.buffer = fragmentContext.getMa
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99040069
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/BatchGroup.java
---
@@ -0,0 +1,334 @@
+/*
+ * Licensed
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99181890
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java
---
@@ -0,0 +1,1321
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99037775
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/BatchGroup.java
---
@@ -0,0 +1,334 @@
+/*
+ * Licensed
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99037413
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -63,13 +63,29 @@
String SPOOLING_BUFFER_DELETE
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99065293
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/CopierHolder.java
---
@@ -0,0 +1,294 @@
+/*
+ * Licensed
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99235897
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java
---
@@ -0,0 +1,1321
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99065219
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/CopierHolder.java
---
@@ -0,0 +1,294 @@
+/*
+ * Licensed
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99066331
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/CopierHolder.java
---
@@ -0,0 +1,294 @@
+/*
+ * Licensed
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99193890
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java
---
@@ -0,0 +1,1321
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99194009
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java
---
@@ -0,0 +1,1321
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99194543
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java
---
@@ -0,0 +1,1321
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99234976
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java
---
@@ -0,0 +1,1321
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99182115
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java
---
@@ -0,0 +1,1321
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99194920
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java
---
@@ -0,0 +1,1321
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99067830
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java
---
@@ -0,0 +1,1321
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99067231
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java
---
@@ -0,0 +1,1321
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99197052
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java
---
@@ -0,0 +1,1321
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99067046
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java
---
@@ -0,0 +1,1321
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99066052
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/CopierHolder.java
---
@@ -0,0 +1,294 @@
+/*
+ * Licensed
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99236335
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java
---
@@ -0,0 +1,1321
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99189185
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java
---
@@ -0,0 +1,1321
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99065195
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/CopierHolder.java
---
@@ -0,0 +1,294 @@
+/*
+ * Licensed
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99236749
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java
---
@@ -0,0 +1,1321
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99184602
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java
---
@@ -0,0 +1,1321
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99195103
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java
---
@@ -0,0 +1,1321
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99066218
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/CopierHolder.java
---
@@ -0,0 +1,294 @@
+/*
+ * Licensed
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99039840
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/BatchGroup.java
---
@@ -0,0 +1,334 @@
+/*
+ * Licensed
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99238315
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java
---
@@ -0,0 +1,1321
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99065262
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/CopierHolder.java
---
@@ -0,0 +1,294 @@
+/*
+ * Licensed
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99237065
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java
---
@@ -0,0 +1,1321
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99065931
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/CopierHolder.java
---
@@ -0,0 +1,294 @@
+/*
+ * Licensed
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99193167
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java
---
@@ -0,0 +1,1321
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99239035
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java
---
@@ -0,0 +1,1321
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/739#discussion_r99385729
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/TableBuilder.java
---
@@ -78,29 +93,8 @@ public void appendTime(final
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/739#discussion_r99385390
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/TableBuilder.java
---
@@ -56,6 +47,30 @@ public TableBuilder(final
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/739#discussion_r99385089
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/TableBuilder.java
---
@@ -56,6 +47,30 @@ public TableBuilder(final
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/739#discussion_r99384748
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/TableBuilder.java
---
@@ -56,6 +47,30 @@ public TableBuilder(final
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/739#discussion_r99385541
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/TableBuilder.java
---
@@ -56,6 +47,30 @@ public TableBuilder(final
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/738#discussion_r99386366
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -77,12 +77,14 @@
*/
public
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/736#discussion_r99388535
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java
---
@@ -527,5 +529,31 @@ public RelOptTableImpl getTable(final
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/736#discussion_r99387926
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java
---
@@ -527,5 +529,31 @@ public RelOptTableImpl getTable(final
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/731#discussion_r99389277
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java ---
@@ -278,7 +277,7 @@ public boolean setSessionOption(String name
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/729
Please rename PR to standard format:
```
DRILL-1328: Some textual description
```
For us novices, "r4" is a bit of a terse description of the purpose of this
PR...
-
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r99393478
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java ---
@@ -77,6 +78,7 @@
private final SchemaTreeProvider
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r99391270
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -390,4 +391,15 @@
String DYNAMIC_UDF_SUPPORT_ENABLED
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r99391697
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/ContextInformation.java
---
@@ -28,12 +28,14 @@
private final String
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r99390401
--- Diff: exec/java-exec/src/main/codegen/data/Parser.tdd ---
@@ -39,7 +39,13 @@
"METADATA",
"DATABASE",
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r99391822
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/ContextInformation.java
---
@@ -63,4 +65,11 @@ public long getQueryStartTime
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r99392948
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/dotdrill/DotDrillUtil.java
---
@@ -30,6 +32,9 @@
static final org.slf4j.Logger logger
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r99392086
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java ---
@@ -245,6 +245,16 @@ public SchemaPlus getRootSchema
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r99390012
--- Diff: exec/java-exec/pom.xml ---
@@ -410,6 +410,11 @@
joda-time
2.9
+
+ com.clearspring.analytics
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r99392582
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java ---
@@ -392,6 +402,11 @@ public String getQueryUserName
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r99391067
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -390,4 +391,15 @@
String DYNAMIC_UDF_SUPPORT_ENABLED
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r99393301
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java ---
@@ -61,6 +61,7 @@
// in fragment contexts
public class
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r99393723
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java ---
@@ -283,4 +286,18 @@ public void close() throws Exception
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/724
Hi David,
Thanks much for the fix! Is there a JIRA entry for this fix? If not, please
go ahead and create one. Then, rename the PR to:
```
DRILL-: DBC proxy driver: Do not put
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/702#discussion_r99396637
--- Diff:
contrib/storage-mongo/src/test/java/org/apache/drill/exec/store/mongo/MongoTestSuit.java
---
@@ -234,15 +240,17 @@ private static void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/702#discussion_r99396951
--- Diff:
contrib/storage-mongo/src/test/java/org/apache/drill/exec/store/mongo/TestTableGenerator.java
---
@@ -58,7 +59,16 @@ public static void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/738#discussion_r99439263
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -77,12 +77,14 @@
*/
public
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/731#discussion_r99439632
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java ---
@@ -278,7 +277,7 @@ public boolean setSessionOption(String name
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/717
Build failure related to the slf4j library in the build process itself.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/701
Thank you for the very clear explanation. It is now obvious that the
original lazy init design relied on the "found/not found" semantics of a simple
name match: no ambiguity there. Howe
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/701
As I understand it, the issues are these:
* When parsing/planning a query, function references are ambiguous.
* If a function x() simply does not exist at all, we get a clear signal
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/741#discussion_r99451485
--- Diff:
contrib/storage-mongo/src/test/java/org/apache/drill/exec/store/mongo/MongoTestSuit.java
---
@@ -234,15 +243,25 @@ private static void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/741#discussion_r99451419
--- Diff:
contrib/storage-mongo/src/test/java/org/apache/drill/exec/store/mongo/MongoTestSuit.java
---
@@ -234,15 +243,25 @@ private static void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/741#discussion_r99451363
--- Diff:
contrib/storage-mongo/src/test/java/org/apache/drill/exec/store/mongo/MongoTestSuit.java
---
@@ -204,16 +209,20 @@ private static void cleanup
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/717
Rebased on latest master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/701#discussion_r99454038
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java
---
@@ -140,27 +142,39 @@ public void register
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/701#discussion_r99454556
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java
---
@@ -260,76 +293,101 @@ public
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/701#discussion_r99649785
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java
---
@@ -260,76 +293,101 @@ public
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/701#discussion_r99650496
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java
---
@@ -50,13 +47,56 @@
private DrillSqlWorker
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/701#discussion_r99454180
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java
---
@@ -178,22 +192,41 @@ private String
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/701#discussion_r99650129
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java
---
@@ -50,13 +47,56 @@
private DrillSqlWorker
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/701
It seems that the concept of overloading, is, itself, ambiguous. If I
define a function `foo(long)`, but call it with an `int`, we won't get an exact
match, will we? So, on every call we&#
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/701#discussion_r99649541
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java
---
@@ -260,76 +293,101 @@ public
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/742#discussion_r99684283
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java
---
@@ -163,11 +165,18 @@ public String
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99250032
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/SpillSet.java
---
@@ -0,0 +1,261 @@
+/*
+ * Licensed to
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99245869
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/InMemorySorter.java
---
@@ -0,0 +1,121
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99246244
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/InMemorySorter.java
---
@@ -0,0 +1,121
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99247699
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/PriorityQueueCopier.java
---
@@ -0,0 +1,43
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99246595
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/MSortTemplate.java
---
@@ -0,0 +1,237
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99246295
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/InMemorySorter.java
---
@@ -0,0 +1,121
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99247477
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/OperatorCodeGenerator.java
---
@@ -0,0 +1,271
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r99250103
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -177,13 +177,47 @@ drill.exec: {
sort: {
purge.threshold : 1000
601 - 700 of 1788 matches
Mail list logo
