GitHub user ssriniva123 opened a pull request:
https://github.com/apache/drill/pull/518
DRILL-4653.json - Malformed JSON should not stop the entire query from
progressing
https://issues.apache.org/jira/browse/DRILL-4653
- The default is to stop processing as is today when J
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r67267273
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader.java
---
@@ -64,6 +64,8 @@
private final boolean ena
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r67267511
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader.java
---
@@ -217,11 +228,11 @@ public int next() {
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r67388118
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader.java
---
@@ -39,6 +40,7 @@
import org.apache.drill.exe
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r67389073
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -135,6 +135,9 @@
BooleanValidator JSON_EXTENDED_TYPES = new
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r67389362
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader.java
---
@@ -189,39 +194,37 @@ private long currentRecordNu
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r67389726
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader.java
---
@@ -189,39 +194,37 @@ private long currentRecordNu
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r67389956
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/json/TestJsonRecordReader.java
---
@@ -116,6 +117,7 @@ public void testMixedNumberType
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r67389846
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader.java
---
@@ -189,39 +194,37 @@ private long currentRecordNu
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r67390506
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/json/TestJsonRecordReader.java
---
@@ -179,4 +181,28 @@ public void testNestedFilter()
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r67390934
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/json/TestJsonRecordReader.java
---
@@ -116,6 +117,7 @@ public void testMixedNumberType
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r67426381
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader.java
---
@@ -189,39 +191,33 @@ private long currentRecordNu
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r67426795
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/json/TestJsonRecordReader.java
---
@@ -179,4 +180,43 @@ public void testNestedFilter()
Github user ssriniva123 commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r67431369
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader.java
---
@@ -189,39 +191,33 @@ private long currentRecordNum
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r70863798
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java
---
@@ -110,21 +118,29 @@ public void ensureAtLeastOneField
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r70872218
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/json/TestJsonRecordReader.java
---
@@ -56,11 +57,19 @@ public void trySimpleQueryWithLi
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r70879473
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/json/TestJsonRecordReader.java
---
@@ -159,64 +164,91 @@ public void drill_3353() throw
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r70879554
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/json/TestJsonRecordReader.java
---
@@ -159,64 +164,91 @@ public void drill_3353() throw
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r78475862
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JsonProcessor.java
---
@@ -30,6 +30,8 @@
public static enum Read
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/518
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Thanks chunhui-shi .
Is there a recommended way to test for count of results of a query?
On Thu, Jul 14, 2016 at 1:41 PM, chunhui-shi wrote:
> Github user chunhui-shi commented on a diff in the pull request:
>
> https://github.com/apache/drill/pull/518#discussion_r70879554
>
> --- Diff
21 matches
Mail list logo
