[GitHub] drill pull request #600: DRILL-4373: Drill and Hive have incompatible timest...

2016-09-30 Thread vdiravka
GitHub user vdiravka opened a pull request: https://github.com/apache/drill/pull/600 DRILL-4373: Drill and Hive have incompatible timestamp representations in parquet - added sys/sess option "store.parquet.int96_as_timestamp"; - added int96 to timestamp converter for both reader

[GitHub] drill pull request #600: DRILL-4373: Drill and Hive have incompatible timest...

2016-10-06 Thread bitblender
Github user bitblender commented on a diff in the pull request: https://github.com/apache/drill/pull/600#discussion_r82314071 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderUtility.java --- @@ -45,4 +53,34 @@ public static int getIntFromLEB

[GitHub] drill pull request #600: DRILL-4373: Drill and Hive have incompatible timest...

2016-10-13 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/600#discussion_r83281827 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -132,6 +132,8 @@ OptionValidator PARQUET_VECTOR_FILL_CHECK_T

[GitHub] drill pull request #600: DRILL-4373: Drill and Hive have incompatible timest...

2016-10-13 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/600#discussion_r83284350 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java --- @@ -754,15 +764,45 @@ public void testImpala

[GitHub] drill pull request #600: DRILL-4373: Drill and Hive have incompatible timest...

2016-10-17 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/600#discussion_r83710133 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java --- @@ -754,15 +764,45 @@ public void testImpalaParq

[GitHub] drill pull request #600: DRILL-4373: Drill and Hive have incompatible timest...

2016-10-17 Thread bitblender
Github user bitblender commented on a diff in the pull request: https://github.com/apache/drill/pull/600#discussion_r83761501 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderUtility.java --- @@ -45,4 +53,34 @@ public static int getIntFromLEB

[GitHub] drill pull request #600: DRILL-4373: Drill and Hive have incompatible timest...

2016-10-18 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/600#discussion_r83853471 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderUtility.java --- @@ -45,4 +53,34 @@ public static int getIntFromLEByt

[GitHub] drill pull request #600: DRILL-4373: Drill and Hive have incompatible timest...

2016-10-18 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/600#discussion_r83853146 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -132,6 +132,8 @@ OptionValidator PARQUET_VECTOR_FILL_CHECK_THRES

[GitHub] drill pull request #600: DRILL-4373: Drill and Hive have incompatible timest...

2016-10-18 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/600#discussion_r83852721 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java --- @@ -899,18 +883,21 @@ public void testLastPageOn

[GitHub] drill pull request #600: DRILL-4373: Drill and Hive have incompatible timest...

2016-10-18 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/600#discussion_r83908798 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java --- @@ -739,30 +739,54 @@ public void runTestAnd

[GitHub] drill pull request #600: DRILL-4373: Drill and Hive have incompatible timest...

2016-10-26 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/600#discussion_r85124582 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java --- @@ -739,30 +739,54 @@ public void runTestAndVali

[GitHub] drill pull request #600: DRILL-4373: Drill and Hive have incompatible timest...

2016-10-27 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/600#discussion_r85449218 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java --- @@ -739,30 +741,76 @@ public void runTestAnd

[GitHub] drill pull request #600: DRILL-4373: Drill and Hive have incompatible timest...

2016-10-28 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/600#discussion_r85522267 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java --- @@ -739,30 +741,76 @@ public void runTestAndVali