jnturton merged PR #2515:
URL: https://github.com/apache/drill/pull/2515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.or
jnturton commented on code in PR #2515:
URL: https://github.com/apache/drill/pull/2515#discussion_r1446231938
##
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java:
##
@@ -171,107 +168,109 @@ public HDF5ReaderConfig(HDF5FormatPlugin plugin
cgivre commented on PR #2515:
URL: https://github.com/apache/drill/pull/2515#issuecomment-1888037847
> Did the recent EVF revisions allow the tests for this PR to pass? Is there
anything that is still missing? Also, did the excitement over my botched merge
settle down and are we good now?
paul-rogers commented on PR #2515:
URL: https://github.com/apache/drill/pull/2515#issuecomment-1887901054
Did the recent EVF revisions allow the tests for this PR to pass? Is there
anything that is still missing? Also, did the excitement over my botched merge
settle down and are we good now
jnturton commented on PR #2515:
URL: https://github.com/apache/drill/pull/2515#issuecomment-1886695348
> @paul-rogers I attempted to fix. I kind of suck at git, so I think it's
more or less correct now, but there was probably a better way to do this.
Just workng through the review com
cgivre commented on PR #2515:
URL: https://github.com/apache/drill/pull/2515#issuecomment-1885044910
@jnturton I did as you suggested. Would you mind please taking a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
my
fork and now suggest
```
git reset --hard origin/master
git pull --rebase https://github.com/jnturton/drill.git 8188-hdf5-evf2
git push --force # to luocooong's fork
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
jnturton commented on PR #2515:
URL: https://github.com/apache/drill/pull/2515#issuecomment-1882389703
> @paul-rogers I attempted to fix. I kind of suck at git, so I think it's
more or less correct now, but there was probably a better way to do this.
I think you still want something l
cgivre commented on PR #2515:
URL: https://github.com/apache/drill/pull/2515#issuecomment-1882377677
@paul-rogers I attempted to fix. I kind of suck at git, so I think it's
more or less correct now, but there was probably a better way to do this.
--
This is an automated message from the
paul-rogers commented on PR #2515:
URL: https://github.com/apache/drill/pull/2515#issuecomment-1882246203
It seems you did this work on top of the master with my unsquashed commits.
When you try to push, those commits come along for the ride. I think you should
grab the latest master, then
cgivre commented on PR #2515:
URL: https://github.com/apache/drill/pull/2515#issuecomment-1882168615
I think I hosed the version control somehow This PR should only modify a
few files in the HDF5 reader.
--
This is an automated message from the Apache Git Service.
To respond to the
cgivre commented on PR #2515:
URL: https://github.com/apache/drill/pull/2515#issuecomment-1300548353
Hey @luocooong @paul-rogers I hope all is well. I wanted to check in on
this PR to see where we are. At this point, nearly all the other format
plugins have been converted to EVF V2.
jnturton merged PR #2672:
URL: https://github.com/apache/drill/pull/2672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.or
jnturton commented on PR #2515:
URL: https://github.com/apache/drill/pull/2515#issuecomment-1180116018
Converted to draft to prevent merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
luocooong commented on PR #2515:
URL: https://github.com/apache/drill/pull/2515#issuecomment-1138051837
Hi @cgivre Thank you for paying attention to this PR.
The pull request cannot be merged now, and Paul is going to re-review the V2
section code. and we're going to fix the bugs above fr
cgivre commented on PR #2515:
URL: https://github.com/apache/drill/pull/2515#issuecomment-1138029864
Hi @luocooong Thank you for this PR. Where are we in terms of getting it
merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
luocooong commented on PR #2515:
URL: https://github.com/apache/drill/pull/2515#issuecomment-1108226622
> Found the bug. It is in `ColumnBuilder` which seems to be missing code to
handle an unprojected repeated list. This bug then caused the other "bugs" that
we discussed in the review: tho
paul-rogers commented on PR #2515:
URL: https://github.com/apache/drill/pull/2515#issuecomment-1108207457
Found the bug. It is in `ColumnBuilder` which seems to be missing code to
handle an unprojected repeated list. This bug then caused the other "bugs" that
we discussed in the review: tho
paul-rogers commented on PR #2515:
URL: https://github.com/apache/drill/pull/2515#issuecomment-1102092604
This PR is getting a bit complex with the bug or two that this PR uncovered.
Iexplain a bit about how EVF2 works. There are two case: wildcard projection
(SELECT *) and explicit project
paul-rogers commented on code in PR #2515:
URL: https://github.com/apache/drill/pull/2515#discussion_r852601292
##
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java:
##
@@ -171,107 +164,104 @@ public HDF5ReaderConfig(HDF5FormatPlugin plugin
luocooong commented on code in PR #2515:
URL: https://github.com/apache/drill/pull/2515#discussion_r851626806
##
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/v3/schema/ScanSchemaResolver.java:
##
@@ -189,7 +189,7 @@ private void insertColumn(ColumnMetada
luocooong commented on code in PR #2515:
URL: https://github.com/apache/drill/pull/2515#discussion_r851627884
##
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/v3/schema/MutableTupleSchema.java:
##
@@ -173,7 +173,7 @@ public ColumnHandle insert(int posn, C
luocooong commented on code in PR #2515:
URL: https://github.com/apache/drill/pull/2515#discussion_r851627022
##
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/scan/v3/TestScanOuputSchema.java:
##
@@ -327,4 +375,50 @@ public void
testStrictProvidedSchemaWithWi
luocooong commented on code in PR #2515:
URL: https://github.com/apache/drill/pull/2515#discussion_r851626806
##
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/v3/schema/ScanSchemaResolver.java:
##
@@ -189,7 +189,7 @@ private void insertColumn(ColumnMetada
luocooong commented on code in PR #2515:
URL: https://github.com/apache/drill/pull/2515#discussion_r851624724
##
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java:
##
@@ -171,107 +168,109 @@ public HDF5ReaderConfig(HDF5FormatPlugin plugin
luocooong commented on code in PR #2515:
URL: https://github.com/apache/drill/pull/2515#discussion_r851623857
##
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java:
##
@@ -410,8 +390,22 @@ public boolean next() {
return true
luocooong commented on code in PR #2515:
URL: https://github.com/apache/drill/pull/2515#discussion_r851623334
##
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java:
##
@@ -410,8 +390,22 @@ public boolean next() {
return true
luocooong commented on code in PR #2515:
URL: https://github.com/apache/drill/pull/2515#discussion_r851623209
##
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java:
##
@@ -171,107 +168,109 @@ public HDF5ReaderConfig(HDF5FormatPlugin plugin
luocooong commented on code in PR #2515:
URL: https://github.com/apache/drill/pull/2515#discussion_r851623187
##
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java:
##
@@ -171,107 +168,109 @@ public HDF5ReaderConfig(HDF5FormatPlugin plugin
luocooong commented on code in PR #2515:
URL: https://github.com/apache/drill/pull/2515#discussion_r851623160
##
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java:
##
@@ -171,107 +168,109 @@ public HDF5ReaderConfig(HDF5FormatPlugin plugin
paul-rogers commented on code in PR #2515:
URL: https://github.com/apache/drill/pull/2515#discussion_r849083600
##
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java:
##
@@ -171,107 +168,109 @@ public HDF5ReaderConfig(HDF5FormatPlugin plugin
luocooong opened a new pull request, #2515:
URL: https://github.com/apache/drill/pull/2515
# [DRILL-8188](https://issues.apache.org/jira/browse/DRILL-8188): Convert
HDF5 format to EVF2
## Description
Use EVF V2 instead of old V1.
Included two bug fixes with the V2 framework
Cong Luo created DRILL-8188:
---
Summary: Convert HDF5 format to EVF2
Key: DRILL-8188
URL: https://issues.apache.org/jira/browse/DRILL-8188
Project: Apache Drill
Issue Type: Improvement
Affects
[
https://issues.apache.org/jira/browse/DRILL-7991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles Givre resolved DRILL-7991.
--
Resolution: Done
> Add Configuration Option to HDF5 Reader to Skip Prev
cgivre merged pull request #2302:
URL: https://github.com/apache/drill/pull/2302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@d
cgivre opened a new pull request #2302:
URL: https://github.com/apache/drill/pull/2302
# [DRILL-7991](https://issues.apache.org/jira/browse/DRILL-7991): Add
Configuration Option to HDF5 Reader to Skip Preview
## Description
When viewing HDF5 metadata, Drill will render a
Charles Givre created DRILL-7991:
Summary: Add Configuration Option to HDF5 Reader to Skip Preview
Key: DRILL-7991
URL: https://issues.apache.org/jira/browse/DRILL-7991
Project: Apache Drill
[
https://issues.apache.org/jira/browse/DRILL-7894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cong Luo resolved DRILL-7894.
-
Reviewer: Cong Luo
Resolution: Fixed
> Large Attributes Crash HDF5 Rea
cgivre merged pull request #2196:
URL: https://github.com/apache/drill/pull/2196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please co
cgivre opened a new pull request #2196:
URL: https://github.com/apache/drill/pull/2196
# [DRILL-7894](https://issues.apache.org/jira/browse/DRILL-7894): Large
Attributes Crash HDF5 Reader
## Description
This PR fixes a minor issue with Drill's HDF5 reader. The jhdf5 reader
Charles Givre created DRILL-7894:
Summary: Large Attributes Crash HDF5 Reader
Key: DRILL-7894
URL: https://issues.apache.org/jira/browse/DRILL-7894
Project: Apache Drill
Issue Type: Bug
[
https://issues.apache.org/jira/browse/DRILL-7858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cong Luo resolved DRILL-7858.
-
Reviewer: Igor Guzenko
Resolution: Fixed
> Drill Crashes with Certain HDF5 Fi
[
https://issues.apache.org/jira/browse/DRILL-7885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cong Luo resolved DRILL-7885.
-
Reviewer: Cong Luo
Resolution: Fixed
> HDF5 Plugin not resolving li
cgivre merged pull request #2190:
URL: https://github.com/apache/drill/pull/2190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please co
cgivre commented on a change in pull request #2190:
URL: https://github.com/apache/drill/pull/2190#discussion_r598274963
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java
##
@@ -448,26 +462,33 @@ private void
luocooong commented on a change in pull request #2190:
URL: https://github.com/apache/drill/pull/2190#discussion_r598220863
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java
##
@@ -448,26 +462,33 @@ private void
cgivre opened a new pull request #2190:
URL: https://github.com/apache/drill/pull/2190
# [DRILL-7885](https://issues.apache.org/jira/browse/DRILL-7885): HDF5
Plugin not resolving links
## Description
This minor PR fixes a few minor issues with the HDF5 reader. The reader
was
Charles Givre created DRILL-7885:
Summary: HDF5 Plugin not resolving links
Key: DRILL-7885
URL: https://issues.apache.org/jira/browse/DRILL-7885
Project: Apache Drill
Issue Type: Bug
cgivre merged pull request #2164:
URL: https://github.com/apache/drill/pull/2164
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jamesmudd commented on a change in pull request #2164:
URL: https://github.com/apache/drill/pull/2164#discussion_r584348367
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java
##
@@ -237,37 +242,37 @@ public boolean open
cgivre commented on pull request #2164:
URL: https://github.com/apache/drill/pull/2164#issuecomment-787467802
@jamesmudd
I made some last minute changes. Could you take a last look and approve if
you're ok with it? Thanks for your all your wokr on the jhdf5 library!!
--
cgivre commented on a change in pull request #2164:
URL: https://github.com/apache/drill/pull/2164#discussion_r584312136
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java
##
@@ -323,53 +328,20 @@ private void openFile
cgivre commented on a change in pull request #2164:
URL: https://github.com/apache/drill/pull/2164#discussion_r584311978
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java
##
@@ -323,53 +328,20 @@ private void openFile
jamesmudd commented on a change in pull request #2164:
URL: https://github.com/apache/drill/pull/2164#discussion_r584244957
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java
##
@@ -323,53 +328,20 @@ private void openFile
cgivre commented on a change in pull request #2164:
URL: https://github.com/apache/drill/pull/2164#discussion_r584211789
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java
##
@@ -237,37 +242,37 @@ public boolean open
cgivre commented on a change in pull request #2164:
URL: https://github.com/apache/drill/pull/2164#discussion_r584211603
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java
##
@@ -323,53 +328,20 @@ private void openFile
jamesmudd commented on a change in pull request #2164:
URL: https://github.com/apache/drill/pull/2164#discussion_r583883430
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java
##
@@ -323,53 +328,20 @@ private void openFile
cgivre commented on a change in pull request #2164:
URL: https://github.com/apache/drill/pull/2164#discussion_r582491028
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java
##
@@ -323,53 +328,20 @@ private void openFile
cgivre commented on a change in pull request #2164:
URL: https://github.com/apache/drill/pull/2164#discussion_r582487354
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java
##
@@ -198,27 +203,27 @@ public boolean open
cgivre commented on a change in pull request #2164:
URL: https://github.com/apache/drill/pull/2164#discussion_r582486398
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5Utils.java
##
@@ -265,4 +185,126 @@ public static String
jamesmudd commented on a change in pull request #2164:
URL: https://github.com/apache/drill/pull/2164#discussion_r582255769
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java
##
@@ -198,27 +203,27 @@ public boolean open
jamesmudd commented on pull request #2164:
URL: https://github.com/apache/drill/pull/2164#issuecomment-783729537
Yes I can take a look. Glad to see `jhdf` is working for you.
This is an automated message from the Apache Git
cgivre commented on pull request #2164:
URL: https://github.com/apache/drill/pull/2164#issuecomment-783587149
This PR is ready for review. @jamesmudd, would you be willing to take a
look? I know you don't know Drill all that well, but I'd like to know if I'm
using your library as effecti
cgivre opened a new pull request #2164:
URL: https://github.com/apache/drill/pull/2164
# [DRILL-7858](https://issues.apache.org/jira/browse/DRILL-7858): PR Title
## Description
Certain HDF5 files, when queried with Drill cause memory leaks due to the
underlying C library
Charles Givre created DRILL-7858:
Summary: Drill Crashes with Certain HDF5 Files
Key: DRILL-7858
URL: https://issues.apache.org/jira/browse/DRILL-7858
Project: Apache Drill
Issue Type: Bug
arina-ielchiieva merged pull request #1978: DRILL-7578: HDF5 Metadata Queries
Fail with Large Files
URL: https://github.com/apache/drill/pull/1978
This is an automated message from the Apache Git Service.
To respond to the
cgivre commented on issue #1978: DRILL-7578: HDF5 Metadata Queries Fail with
Large Files
URL: https://github.com/apache/drill/pull/1978#issuecomment-591972210
@arina-ielchiieva @paul-rogers
Thanks for the review!
Rebased and squashed
arina-ielchiieva commented on issue #1978: DRILL-7578: HDF5 Metadata Queries
Fail with Large Files
URL: https://github.com/apache/drill/pull/1978#issuecomment-591961582
@cgivre please squash the commits and rebase on the latest master. Thanks
paul-rogers commented on a change in pull request #1978: DRILL-7578: HDF5
Metadata Queries Fail with Large Files
URL: https://github.com/apache/drill/pull/1978#discussion_r384933724
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5
cgivre commented on a change in pull request #1978: DRILL-7578: HDF5 Metadata
Queries Fail with Large Files
URL: https://github.com/apache/drill/pull/1978#discussion_r384902654
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java
cgivre commented on a change in pull request #1978: DRILL-7578: HDF5 Metadata
Queries Fail with Large Files
URL: https://github.com/apache/drill/pull/1978#discussion_r384901864
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java
cgivre commented on a change in pull request #1978: DRILL-7578: HDF5 Metadata
Queries Fail with Large Files
URL: https://github.com/apache/drill/pull/1978#discussion_r384901864
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java
cgivre commented on a change in pull request #1978: DRILL-7578: HDF5 Metadata
Queries Fail with Large Files
URL: https://github.com/apache/drill/pull/1978#discussion_r384900801
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java
cgivre commented on a change in pull request #1978: DRILL-7578: HDF5 Metadata
Queries Fail with Large Files
URL: https://github.com/apache/drill/pull/1978#discussion_r384899948
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java
cgivre commented on a change in pull request #1978: DRILL-7578: HDF5 Metadata
Queries Fail with Large Files
URL: https://github.com/apache/drill/pull/1978#discussion_r384895214
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java
cgivre commented on a change in pull request #1978: DRILL-7578: HDF5 Metadata
Queries Fail with Large Files
URL: https://github.com/apache/drill/pull/1978#discussion_r384895142
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java
cgivre commented on a change in pull request #1978: DRILL-7578: HDF5 Metadata
Queries Fail with Large Files
URL: https://github.com/apache/drill/pull/1978#discussion_r384894022
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java
paul-rogers commented on a change in pull request #1978: DRILL-7578: HDF5
Metadata Queries Fail with Large Files
URL: https://github.com/apache/drill/pull/1978#discussion_r384866829
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5
paul-rogers commented on a change in pull request #1978: DRILL-7578: HDF5
Metadata Queries Fail with Large Files
URL: https://github.com/apache/drill/pull/1978#discussion_r384867611
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5
paul-rogers commented on a change in pull request #1978: DRILL-7578: HDF5
Metadata Queries Fail with Large Files
URL: https://github.com/apache/drill/pull/1978#discussion_r384868211
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5
paul-rogers commented on a change in pull request #1978: DRILL-7578: HDF5
Metadata Queries Fail with Large Files
URL: https://github.com/apache/drill/pull/1978#discussion_r384868442
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5
paul-rogers commented on a change in pull request #1978: DRILL-7578: HDF5
Metadata Queries Fail with Large Files
URL: https://github.com/apache/drill/pull/1978#discussion_r384868605
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5
paul-rogers commented on a change in pull request #1978: DRILL-7578: HDF5
Metadata Queries Fail with Large Files
URL: https://github.com/apache/drill/pull/1978#discussion_r384867259
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5
cgivre commented on issue #1978: DRILL-7578: HDF5 Metadata Queries Fail with
Large Files
URL: https://github.com/apache/drill/pull/1978#issuecomment-591427930
@paul-rogers Do you approve of this PR?
This is an automated
arina-ielchiieva edited a comment on issue #1978: DRILL-7578: HDF5 Metadata
Queries Fail with Large Files
URL: https://github.com/apache/drill/pull/1978#issuecomment-591410602
@cgivre don't see @paul-rogers approval, so we should wait for it
arina-ielchiieva commented on issue #1978: DRILL-7578: HDF5 Metadata Queries
Fail with Large Files
URL: https://github.com/apache/drill/pull/1978#issuecomment-591410602
@cgivre don't see that @paul-rogers approval, so we should wait for it
cgivre commented on issue #1978: DRILL-7578: HDF5 Metadata Queries Fail with
Large Files
URL: https://github.com/apache/drill/pull/1978#issuecomment-591408854
@arina-ielchiieva Can we merge this PR now? Thx
This is an
cgivre commented on a change in pull request #1978: DRILL-7578: HDF5 Metadata
Queries Fail with Large Files
URL: https://github.com/apache/drill/pull/1978#discussion_r383950814
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java
arina-ielchiieva commented on a change in pull request #1978: DRILL-7578: HDF5
Metadata Queries Fail with Large Files
URL: https://github.com/apache/drill/pull/1978#discussion_r383948346
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5
cgivre commented on issue #1978: DRILL-7578: HDF5 Metadata Queries Fail with
Large Files
URL: https://github.com/apache/drill/pull/1978#issuecomment-590913914
> Nit: `toString`method will be called anyway, so no need to indicate it.
@arina-ielchiieva
Which line are you referring
cgivre commented on a change in pull request #1978: DRILL-7578: HDF5 Metadata
Queries Fail with Large Files
URL: https://github.com/apache/drill/pull/1978#discussion_r383929781
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java
cgivre commented on a change in pull request #1978: DRILL-7578: HDF5 Metadata
Queries Fail with Large Files
URL: https://github.com/apache/drill/pull/1978#discussion_r383929709
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java
cgivre commented on a change in pull request #1978: DRILL-7578: HDF5 Metadata
Queries Fail with Large Files
URL: https://github.com/apache/drill/pull/1978#discussion_r383929588
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java
cgivre commented on a change in pull request #1978: DRILL-7578: HDF5 Metadata
Queries Fail with Large Files
URL: https://github.com/apache/drill/pull/1978#discussion_r383929237
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java
cgivre commented on a change in pull request #1978: DRILL-7578: HDF5 Metadata
Queries Fail with Large Files
URL: https://github.com/apache/drill/pull/1978#discussion_r383929404
##
File path:
contrib/format-hdf5/src/test/java/org/apache/drill/exec/store/hdf5/TestHDF5Format.java
cgivre commented on a change in pull request #1978: DRILL-7578: HDF5 Metadata
Queries Fail with Large Files
URL: https://github.com/apache/drill/pull/1978#discussion_r383928859
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java
cgivre commented on a change in pull request #1978: DRILL-7578: HDF5 Metadata
Queries Fail with Large Files
URL: https://github.com/apache/drill/pull/1978#discussion_r383928727
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java
arina-ielchiieva commented on a change in pull request #1978: DRILL-7578: HDF5
Metadata Queries Fail with Large Files
URL: https://github.com/apache/drill/pull/1978#discussion_r383909824
##
File path:
contrib/format-hdf5/src/test/java/org/apache/drill/exec/store/hdf5
arina-ielchiieva commented on a change in pull request #1978: DRILL-7578: HDF5
Metadata Queries Fail with Large Files
URL: https://github.com/apache/drill/pull/1978#discussion_r383908163
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5
arina-ielchiieva commented on a change in pull request #1978: DRILL-7578: HDF5
Metadata Queries Fail with Large Files
URL: https://github.com/apache/drill/pull/1978#discussion_r383911924
##
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5
1 - 100 of 452 matches
Mail list logo
