Re: Time for the 1.6 Release

Done - Version in master branch updated to 1.7.0-SNAPSHOT On Thu, Mar 10, 2016 at 4:46 PM, Jacques Nadeau wrote: > You want to roll forward the current branch to 1.7.0-SNAPSHOT so we can > continue developing/merging stuff? > > -- > Jacques Nadeau > CTO and Co-Founder,

Re: Time for the 1.6 Release

You want to roll forward the current branch to 1.7.0-SNAPSHOT so we can continue developing/merging stuff? -- Jacques Nadeau CTO and Co-Founder, Dremio On Thu, Mar 10, 2016 at 4:09 PM, Parth Chandra wrote: > Hi guys, > > I've created the 1.6.0 branch and will be rolling

Re: Time for the 1.6 Release

Hi guys, I've created the 1.6.0 branch and will be rolling out the first release candidate as soon as I get the go ahead from the QA team, in the next couple of hours. Thanks Parth On Thu, Mar 10, 2016 at 3:20 PM, Parth Chandra wrote: > It is usually not a good idea

Re: Time for the 1.6 Release

It is usually not a good idea to try to rush in a patch at the last minute. One of the reasons for having monthly releases is so people don't have to wait too long for fixes and developers don't rush fixes in. QA is almost done with their validation, so I'm afraid this might have to go into the

Re: Time for the 1.6 Release

thank you On Thu, Mar 10, 2016 at 9:19 PM, Jason Altekruse wrote: > I hadn't actually tested out the patch, what I had said was that I could > add a flag to make avro files behave like parquet and JSON, without schema > validation. The patch made it so the behavior of

Re: Time for the 1.6 Release

I hadn't actually tested out the patch, what I had said was that I could add a flag to make avro files behave like parquet and JSON, without schema validation. The patch made it so the behavior of directories would be different from that of individual files, removing the schema validation. I tried

Re: Time for the 1.6 Release

Hi, This issue is still unresolved: https://issues.apache.org/jira/browse/DRILL-4120 It would mean a great deal to us if it was. The solution is, as I understood Jason and Jacques, ready and only needs to be merged. Regards, -Stefán On Thu, Mar 10, 2016 at 3:50 AM, Parth Chandra

Re: Time for the 1.6 Release

You are correct, it was, sorry. On Thu, Mar 10, 2016 at 9:02 AM, Abdel Hakim Deneche wrote: > Hey Stefán, I just left a comment in the JIRA. I think the issue is related > to the double quotes. > > On Thu, Mar 10, 2016 at 9:55 AM, Stefán Baxter

Re: Time for the 1.6 Release

Hey Stefán, I just left a comment in the JIRA. I think the issue is related to the double quotes. On Thu, Mar 10, 2016 at 9:55 AM, Stefán Baxter wrote: > Hi, > > I noticed that using the IN operator with a sub structure has stopped > working: > > select s.client_ip.ip

Re: Time for the 1.6 Release

Hi, I noticed that using the IN operator with a sub structure has stopped working: select s.client_ip.ip from dfs.asa.`/processed/venuepoint/transactions` as s where s.client_ip.ip in ("unknown") limit 2; Error: PARSE ERROR: Encountered "\"" at line 1, column 103. Was expecting one of: ... SQL

Re: Time for the 1.6 Release

Okay we are down to the final one - DRILL-4482 - Avro no longer selects data correctly from a sub-structure.(Jason) Note that MapR QA team is going to start testing 1.6 snapshot now before I roll out the release candidate. DRILL-4482 can be merged in later as it is not likely to affect the

Re: Time for the 1.6 Release

OK, let's leave it out then. On Tue, Mar 8, 2016 at 9:25 AM, Jason Altekruse wrote: > To be honest I was expecting a longer review cycle so I hadn't run the unit > tests before posting it for review. There were only very minor functional > changes, so I wasn't thinking

Re: Time for the 1.6 Release

Sounds good Jason. Let's finalize this in the hangout. Do you have the expected plans for the failing tests? If so can you update those and put in a pull request and we'll merge and run the tests. Any reason for the operator test framework to be punted? You have a +1 to merge it. On Mon, Mar 7,

Re: Time for the 1.6 Release

We should update the expected results (i.e. the expected query plan in this case) and not mark them as Failing. We do not have a Failing test directory today. If we are sure the expected query plans for these tests are incorrect (today), we should go ahead and update the expected results files

Re: Time for the 1.6 Release

The train is about to leave :). I'd like to propose a cutoff for tomorrow 5 pm. (This will be a full week after the initial mail so plenty of time for everyone to get their issues aired.) Here are the open items (that I am aware of) - Waiting to be merged DRILL-4483/pr 411 (Fix text plan

Re: Time for the 1.6 Release

4474 is actually revealing a few invalid tests in the Regression suite that test for the current incorrect plans. The fix should be included in the release, but I will post a PR on the regression suite to update the tests before I push it. On Mon, Mar 7, 2016 at 4:44 PM, Steven Phillips

Re: Time for the 1.6 Release

DRILL-4486 is a pretty simple fix. Without it, currently some regex queries will fail. I think we should include it in the release. https://github.com/apache/drill/pull/412 On Mon, Mar 7, 2016 at 2:15 PM, Jason Altekruse wrote: > There is a small test issue with

Re: Time for the 1.6 Release

There is a small test issue with some of the refactoring that accompanied the operator unit tests. These don't change any user-facing behavior, so I don't think it really needs to get into the release. I will be working to merge them into master after we cut the release branch. The change to

Re: Time for the 1.6 Release

WebUI profile issue: this is a regression cause by refactoring of Calcite integration code (DRILL-4465) which sets the text plan only if debug is enabled. Will submit a patch soon. On Mon, Mar 7, 2016 at 1:29 PM, Sudheesh Katkam wrote: > Thanks for clarifying Jacques. > >

Re: Time for the 1.6 Release

It is in 1.4.0 On Mon, Mar 7, 2016 at 11:35 AM, Zelaine Fong wrote: > Vicky, > > Per our discussion today, let us know if this issue also exists in 1.4. > From the discussion, it sounds like this is not a recent regression. > > -- Zelaine > > On Mon, Mar 7, 2016 at 10:44 AM,

Re: Time for the 1.6 Release

Thanks for clarifying Jacques. I haven’t looked into the fix for DRILL-4384; I reopened it because the description mentioned “visualized plan” section is (also) empty. Thank you, Sudheesh > On Mar 7, 2016, at 1:08 PM, Jacques Nadeau wrote: > > The new bug (currently filed

Re: Time for the 1.6 Release

The new bug (currently filed under DRILL-4384) is a completely different bug than the original (original one has to do with profile metrics, this has to do with plan text). I try to look at it tonight if noone can get to it sooner. -- Jacques Nadeau CTO and Co-Founder, Dremio On Mon, Mar 7,

Re: Time for the 1.6 Release

DRILL-4384 is a blocker for the release though On Mon, Mar 7, 2016 at 12:01 PM, Sudheesh Katkam wrote: > I reopened DRILL-4384 > (blocker); it is assigned to Jacques. > > On the latest master, the visualized and physical

Re: Time for the 1.6 Release

I'm inclined to go ahead with the release unless DRILL-4477 is a regression. On Mon, Mar 7, 2016 at 11:39 AM, Jason Altekruse wrote: > I don't know if there are any specific time constraints for getting out the > release, but I'm inclined to go with Vicky on

Re: Time for the 1.6 Release

I reopened DRILL-4384 (blocker); it is assigned to Jacques. On the latest master, the visualized and physical plan tabs on web UI are empty. Thank you, Sudheesh > On Mar 7, 2016, at 11:39 AM, Jason Altekruse wrote: >

Re: Time for the 1.6 Release

I don't know if there are any specific time constraints for getting out the release, but I'm inclined to go with Vicky on DRILL-4477, at least some investigation into the scope of a fix would be good. I think it's reasonably big problem whether it's a regression or not. On Mon, Mar 7, 2016 at

Re: Time for the 1.6 Release

Hakim, Yes, we'll include this in the release. -- Zelaine On Mon, Mar 7, 2016 at 9:31 AM, Abdel Hakim Deneche wrote: > If we still have time, I would like to include DRILL-4457 [1], it's a wrong > results issue, I already have a fix and it's passing all tests, I am just

Re: Time for the 1.6 Release

Vicky, Per our discussion today, let us know if this issue also exists in 1.4. >From the discussion, it sounds like this is not a recent regression. -- Zelaine On Mon, Mar 7, 2016 at 10:44 AM, Vicky Markman wrote: > DRILL-4477 is a really bad bug and should be fixed in

Re: Time for the 1.6 Release

Just merged DRILL-4457 into master. Thanks On Mon, Mar 7, 2016 at 7:44 PM, Vicky Markman wrote: > DRILL-4477 is a really bad bug and should be fixed in 1.6 > > On Mon, Mar 7, 2016 at 9:40 AM, Jason Altekruse > wrote: > > > Hakim, > > > > The

Re: Time for the 1.6 Release

Hakim, The patch looks good, I just gave you a +1. I will be merging the operator unit tests today, I would recommend checking it out for writing tests like this in future commits. - Jason On Mon, Mar 7, 2016 at 9:31 AM, Abdel Hakim Deneche wrote: > If we still have

Re: Time for the 1.6 Release

If we still have time, I would like to include DRILL-4457 [1], it's a wrong results issue, I already have a fix and it's passing all tests, I am just waiting for a review [2] [1] https://issues.apache.org/jira/browse/DRILL-4457 [2] https://github.com/apache/drill/pull/410 On Mon, Mar 7, 2016 at

Re: Time for the 1.6 Release

Hi guys, I'm still waiting for the following to be reviewed/merged by today. DRILL-4437 (and others)/pr 394 (Operator unit test framework). Waiting to be merged (Jason) DRILL-4372/pr 377(?) (Drill Operators and Functions should correctly expose their types within Calcite.) - (Jinfeng to review)

Re: Time for the 1.6 Release

DRILL-4375/pr 402 - reviewed. On Sun, Mar 6, 2016 at 12:48 AM, Stefán Baxter wrote: > Please review this and then consider as a potential blocker: > > https://issues.apache.org/jira/browse/DRILL-4482 > > > > On Sat, Mar 5, 2016 at 3:15 AM, Parth Chandra

Re: Time for the 1.6 Release

Please review this and then consider as a potential blocker: https://issues.apache.org/jira/browse/DRILL-4482 On Sat, Mar 5, 2016 at 3:15 AM, Parth Chandra wrote: > Okay here's the list of JIRA's pending. It looks like we need to get some > more time to get the PRs still

Re: Time for the 1.6 Release

Okay here's the list of JIRA's pending. It looks like we need to get some more time to get the PRs still under review merged, so I'll wait over the weekend. It looks like the PRs that no reviewers assigned in the list below may not make it into the release. Thanks Committed for 1.6 -

Re: Time for the 1.6 Release

Awesome. Thanks Chun! On Mar 4, 2016 5:51 PM, "Chun Chang" wrote: > Jacques submitted a PR for fixing the failed baselines. I've merged them > into automation master and confirmed the failed tests are all passing now. > Thanks. > > -Chun > > > On Thu, Mar 3, 2016 at 10:48

Re: Time for the 1.6 Release

Jacques submitted a PR for fixing the failed baselines. I've merged them into automation master and confirmed the failed tests are all passing now. Thanks. -Chun On Thu, Mar 3, 2016 at 10:48 PM, Jacques Nadeau wrote: > I think we need to include DRILL-4467 >

Re: Time for the 1.6 Release

I think we need to include DRILL-4467 . I think it is a one line patch and it provides unpredictable plans at a minimum but may also present invalid result. Still need to think through the second half. I've seen this plan instability in some of my

Re: Time for the 1.6 Release

Updated list (I'll follow up with the folks named here separately) - Committed for 1.6 - DRILL-4384 - Query profile is missing important information on WebUi - Merged DRILL-3488/pr 388 (Java 1.8 support) - Merged. DRILL-4410/pr 380 (listvector should initiatlize bits...) - Merged DRILL-4383/pr

Re: Time for the 1.6 Release

Right. My mistake. Thanks, Jacques, for reviewing. On Thu, Mar 3, 2016 at 9:08 PM, Zelaine Fong wrote: > DRILL-4281/pr 400 (Drill should support inbound impersonation) (Sudheesh to > review) > > Sudheesh is the fixer of DRILL-4281, so I don't think he can be the > reviewer

Re: Time for the 1.6 Release

I've been reviewing 4281. It's really close to ready. -- Jacques Nadeau CTO and Co-Founder, Dremio On Thu, Mar 3, 2016 at 9:08 PM, Zelaine Fong wrote: > DRILL-4281/pr 400 (Drill should support inbound impersonation) (Sudheesh to > review) > > Sudheesh is the fixer of

Re: Time for the 1.6 Release

DRILL-4281/pr 400 (Drill should support inbound impersonation) (Sudheesh to review) Sudheesh is the fixer of DRILL-4281, so I don't think he can be the reviewer :). -- Zelaine On Thu, Mar 3, 2016 at 6:30 PM, Parth Chandra wrote: > Here's an updated list with names of

Re: Time for the 1.6 Release

Yes. I noticed the comment after I sent out the email. Removing it from the list. On Thu, Mar 3, 2016 at 7:02 PM, Hanifi Gunes wrote: > DRILL-4416 is going to make it to 1.7. The patch causes a leak and I will > look into it once I make some time but 1.6 is too early. > >

Re: Time for the 1.6 Release

DRILL-4416 is going to make it to 1.7. The patch causes a leak and I will look into it once I make some time but 1.6 is too early. On Thu, Mar 3, 2016 at 6:30 PM, Parth Chandra wrote: > Here's an updated list with names of reviewers added. If anyone else is > reviewing the

Re: Time for the 1.6 Release

Here's an updated list with names of reviewers added. If anyone else is reviewing the open PRs please let me know. Some PRs have owners names that I will follow up with. Jason, I've included your JIRA in the list. Committed for 1.6 - DRILL-4384 - Query profile is missing important information

Re: Time for the 1.6 Release

I have updated the PR for the parquet date corruption issue that didn't make it into 1.5. https://github.com/apache/drill/pull/341 https://issues.apache.org/jira/browse/DRILL-4203 If this can get reviewed, I think it would be good to get into the release. Any takers? On Wed, Mar 2, 2016 at

Re: Time for the 1.6 Release

I just realized that we didn't merge the broken profile patch (thanks Vicki). We should get it merged as well. DRILL-4384 -- Jacques Nadeau CTO and Co-Founder, Dremio On Wed, Mar 2, 2016 at 10:46 AM, Jason Altekruse wrote: > I should have merged this sooner but we

Re: Time for the 1.6 Release

I should have merged this sooner but we will need this patch that I had applied to the 1.5 release branch. The change is small and fixes a build problem that only appears when running the maven release profile. https://github.com/apache/drill/pull/402 On Wed, Mar 2, 2016 at 9:28 AM, Jinfeng Ni

Re: Time for the 1.6 Release

Hi John, I think patch for DRILL-2517 has been merged to the apache master branch. Have you tried your query on the latest master branch? In DRILL-2517, I posted some performance number for 117k small parquet files. The patch did show improvement. Before DRILL-3996 is resolved, for now if your

Re: Time for the 1.6 Release

I've posted DRILL-4465 for review (Calcite integration cleanup) and would like to include it in the release if others are amenable. As I mentioned, it isn't a functional change but does set the groundwork for my work on moving off a Calcite fork. It also seems like the following pull requests are

RE: Time for the 1.6 Release

Chandra [mailto:par...@apache.org] Sent: Tuesday, March 01, 2016 8:04 PM To: dev Subject: Time for the 1.6 Release Hello everyone, It's time to start looking into the 1.6 release. Can all the folks working on open issues let me know if there are any JIRAs you would like to get into the release

Re: Time for the 1.6 Release

Fair point, sorry. Please at least include these: - https://issues.apache.org/jira/browse/DRILL-4441 - https://issues.apache.org/jira/browse/DRILL-4120 - Avro schema validation prevents directory pruning when schema is eveolving - Did not find this one in Jira but the schema

Re: Time for the 1.6 Release

Stefán - It may help to list some here, especially ones you are aware of, in a priority order and describe how it's a blocker. (Maybe some can be addressed right away, but others could wait til 1.7 etc) John On Wed, Mar 2, 2016 at 6:26 AM, Stefán Baxter wrote: >

Re: Time for the 1.6 Release

Hi, Can you please (pretty please with sugar on top) add the tickets involved in proper (Yes, please excuse the language) Avro support - Stefán On Wed, Mar 2, 2016 at 12:23 PM, John Omernik wrote: > I'd like to request drill-2517 be added as a bandaid for the planning >

Re: Time for the 1.6 Release

I'd like to request drill-2517 be added as a bandaid for the planning issues when there are lots of directories of parquet files. This issue is really hurting drill adoption for me in my org. Thanks, John On Tuesday, March 1, 2016, Edmon Begoli wrote: > May I please ask

Re: Time for the 1.6 Release

May I please ask to give this issue the attention for 1.6: https://issues.apache.org/jira/plugins/servlet/mobile#issue/DRILL-3149 I will try to suggest a patch. Given my time constraints I might not be able to submit a complete, unit tested code but at least I will try to submit a snippet that

Time for the 1.6 Release

Hello everyone, It's time to start looking into the 1.6 release. Can all the folks working on open issues let me know if there are any JIRAs you would like to get into the release? I know of the following - *DRILL-4281 *- Drill should support inbound impersonation. Pull request expected