[GitHub] drill pull request: DRILL-3724 - added javadoc for core classes fo...

2015-09-14 Thread ebegoli
Github user ebegoli closed the pull request at: https://github.com/apache/drill/pull/139 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] drill pull request: DRILL-3724 - added javadoc for core classes fo...

2015-09-14 Thread ebegoli
Github user ebegoli commented on the pull request: https://github.com/apache/drill/pull/139#issuecomment-140044982 Closing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

Design and Implementation Question - related to DRILL-3738

2015-09-14 Thread Edmon Begoli
I want to implement a support for Excel files, both .xls and .xlsx, through Apache POI which will give me access to Java objects including column names, column values and it will expose the set of types supports. (I recorded this issue here: https://issues.apache.org/jira/browse/DRILL-3738) In ot

Re: Drill- Query execution plan

2015-09-14 Thread Abdel Hakim Deneche
Hi Sudip, Did you include an image in your email ? unfortunately, Drill's mailing list doesn't allow any attachments, so we are not able to see the image On Sun, Sep 13, 2015 at 10:51 PM, Sudip Mukherjee wrote: > Hi, > > Need some help understanding the below steps of a query execution. The > b

[jira] [Created] (DRILL-3776) count(*) from empty text file does not return 0

2015-09-14 Thread Sean Hsuan-Yi Chu (JIRA)
Sean Hsuan-Yi Chu created DRILL-3776: Summary: count(*) from empty text file does not return 0 Key: DRILL-3776 URL: https://issues.apache.org/jira/browse/DRILL-3776 Project: Apache Drill

[jira] [Created] (DRILL-3777) Better to Upgrade mongodb java driver version.

2015-09-14 Thread Bhallamudi Venkata Siva Kamesh (JIRA)
Bhallamudi Venkata Siva Kamesh created DRILL-3777: - Summary: Better to Upgrade mongodb java driver version. Key: DRILL-3777 URL: https://issues.apache.org/jira/browse/DRILL-3777 Project

Review Request 38359: DRILL-3201: Add authentication and authorization to Drill Web client

2015-09-14 Thread Venki Korukanti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38359/ --- Review request for drill, Jacques Nadeau and Jason Altekruse. Repository: drill

Re: Review Request 38359: DRILL-3201: Add authentication and authorization to Drill Web client

2015-09-14 Thread Venki Korukanti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38359/ --- (Updated Sept. 14, 2015, 10:43 a.m.) Review request for drill, Jacques Nadeau a

[jira] [Created] (DRILL-3778) Finish skipped part of DRILL-3160 (making JDBC Javadoc available)

2015-09-14 Thread Daniel Barclay (Drill) (JIRA)
Daniel Barclay (Drill) created DRILL-3778: - Summary: Finish skipped part of DRILL-3160 (making JDBC Javadoc available) Key: DRILL-3778 URL: https://issues.apache.org/jira/browse/DRILL-3778 Pro

[jira] [Created] (DRILL-3779) NPE during mergeAndSpill operation of external sort

2015-09-14 Thread Aman Sinha (JIRA)
Aman Sinha created DRILL-3779: - Summary: NPE during mergeAndSpill operation of external sort Key: DRILL-3779 URL: https://issues.apache.org/jira/browse/DRILL-3779 Project: Apache Drill Issue Type

classpath scanning in Drill

2015-09-14 Thread Julien Le Dem
As mentioned at the last Drill sync up I've been working on classpath scanning. I'm centralizing scanning and moving the scan for drill provided implementations at build time. I'm making it use more bytecode inspection and less reflection to make it faster as well. I'm also simplifying a bit. Chatt

[jira] [Created] (DRILL-3780) storage plugin configurations in ZooKeeper need to be secured

2015-09-14 Thread Kristine Hahn (JIRA)
Kristine Hahn created DRILL-3780: Summary: storage plugin configurations in ZooKeeper need to be secured Key: DRILL-3780 URL: https://issues.apache.org/jira/browse/DRILL-3780 Project: Apache Drill

[jira] [Resolved] (DRILL-3617) Apply "shading" to JDBC-all Jar file to avoid version conflicts

2015-09-14 Thread Daniel Barclay (Drill) (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-3617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Barclay (Drill) resolved DRILL-3617. --- Resolution: Fixed Fixed by fix for DRILL-3589. > Apply "shading" to JDBC-all

[jira] [Resolved] (DRILL-3502) JDBC driver can cause conflicts

2015-09-14 Thread Daniel Barclay (Drill) (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-3502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Barclay (Drill) resolved DRILL-3502. --- Resolution: Fixed Fixed by fix for DRILL-3589. > JDBC driver can cause confli

[jira] [Created] (DRILL-3781) Using CURRENT_DATE in a group by throws a column not found error for hive tables and csv files

2015-09-14 Thread Rahul Challapalli (JIRA)
Rahul Challapalli created DRILL-3781: Summary: Using CURRENT_DATE in a group by throws a column not found error for hive tables and csv files Key: DRILL-3781 URL: https://issues.apache.org/jira/browse/DRILL-37

[GitHub] drill pull request: Upgrade to guava 18.0

2015-09-14 Thread aleph-zero
GitHub user aleph-zero opened a pull request: https://github.com/apache/drill/pull/157 Upgrade to guava 18.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/aleph-zero/drill issues/DRILL-3581 Alternatively you can review and app

[GitHub] drill pull request: Upgrade to guava 18.0

2015-09-14 Thread adeneche
Github user adeneche commented on a diff in the pull request: https://github.com/apache/drill/pull/157#discussion_r39440832 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataConnectionCreator.java --- @@ -66,8 +67,8 @@ public DataTunnel getTunnel(DrillbitEn

[GitHub] drill pull request: Upgrade to guava 18.0

2015-09-14 Thread adeneche
Github user adeneche commented on a diff in the pull request: https://github.com/apache/drill/pull/157#discussion_r39441171 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java --- @@ -279,7 +279,10 @@ public ProtobufLengthDecoder getDecoder(Buffer

[GitHub] drill pull request: Upgrade to guava 18.0

2015-09-14 Thread adeneche
Github user adeneche commented on a diff in the pull request: https://github.com/apache/drill/pull/157#discussion_r39441217 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataClientConnection.java --- @@ -84,8 +85,8 @@ public boolean equals(Object obj) {

[GitHub] drill pull request: Upgrade to guava 18.0

2015-09-14 Thread adeneche
Github user adeneche commented on a diff in the pull request: https://github.com/apache/drill/pull/157#discussion_r39441721 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControllerImpl.java --- @@ -60,11 +62,13 @@ public ControlTunnel getTunnel(DrillbitE

[jira] [Resolved] (DRILL-3535) Drop table support

2015-09-14 Thread Mehant Baid (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-3535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mehant Baid resolved DRILL-3535. Resolution: Fixed Fixed in 2a191847154203871454b229d8ef322766aa9ee4 > Drop table support >

[GitHub] drill pull request: Upgrade to guava 18.0

2015-09-14 Thread adeneche
Github user adeneche commented on a diff in the pull request: https://github.com/apache/drill/pull/157#discussion_r39442552 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlConnection.java --- @@ -110,7 +110,9 @@ public boolean equals(Object obj) {

[GitHub] drill pull request: Upgrade to guava 18.0

2015-09-14 Thread adeneche
Github user adeneche commented on a diff in the pull request: https://github.com/apache/drill/pull/157#discussion_r39442995 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ImplCreator.java --- @@ -74,7 +74,7 @@ public static RootExec getExec(FragmentCont

[GitHub] drill pull request: Upgrade to guava 18.0

2015-09-14 Thread adeneche
Github user adeneche commented on a diff in the pull request: https://github.com/apache/drill/pull/157#discussion_r39443036 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/sort/SortTemplate.java --- @@ -47,7 +47,7 @@ public void setup(FragmentContext con

[GitHub] drill pull request: Upgrade to guava 18.0

2015-09-14 Thread adeneche
Github user adeneche commented on a diff in the pull request: https://github.com/apache/drill/pull/157#discussion_r3944 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/SpoolingRawBatchBuffer.java --- @@ -376,7 +376,7 @@ public long getBodySize() {

[GitHub] drill pull request: Upgrade to guava 18.0

2015-09-14 Thread adeneche
Github user adeneche commented on a diff in the pull request: https://github.com/apache/drill/pull/157#discussion_r39443344 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/SpoolingRawBatchBuffer.java --- @@ -423,7 +423,7 @@ public void readFromStream() thro

[GitHub] drill pull request: Upgrade to guava 18.0

2015-09-14 Thread adeneche
Github user adeneche commented on the pull request: https://github.com/apache/drill/pull/157#issuecomment-140199698 can you please create a JIRA for this as well ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] drill pull request: DRILL-3778: Add missed part of DRILL-3160 (mak...

2015-09-14 Thread dsbos
GitHub user dsbos opened a pull request: https://github.com/apache/drill/pull/158 DRILL-3778: Add missed part of DRILL-3160 (making JDBC Javadoc available). Main: Configured Javadoc generation (title, package groups, version in headers). Added link to JDBC page in Drill docum

[GitHub] drill pull request: Upgrade to guava 18.0

2015-09-14 Thread aleph-zero
Github user aleph-zero commented on a diff in the pull request: https://github.com/apache/drill/pull/157#discussion_r39450581 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataConnectionCreator.java --- @@ -66,8 +67,8 @@ public DataTunnel getTunnel(Drillbit

[GitHub] drill pull request: Upgrade to guava 18.0

2015-09-14 Thread aleph-zero
Github user aleph-zero commented on a diff in the pull request: https://github.com/apache/drill/pull/157#discussion_r39450763 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java --- @@ -279,7 +279,10 @@ public ProtobufLengthDecoder getDecoder(Buff

[GitHub] drill pull request: Upgrade to guava 18.0

2015-09-14 Thread aleph-zero
Github user aleph-zero commented on a diff in the pull request: https://github.com/apache/drill/pull/157#discussion_r39450918 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataClientConnection.java --- @@ -84,8 +85,8 @@ public boolean equals(Object obj) {

[GitHub] drill pull request: Upgrade to guava 18.0

2015-09-14 Thread aleph-zero
Github user aleph-zero commented on a diff in the pull request: https://github.com/apache/drill/pull/157#discussion_r39451226 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControllerImpl.java --- @@ -60,11 +62,13 @@ public ControlTunnel getTunnel(Drillbi

[GitHub] drill pull request: Upgrade to guava 18.0

2015-09-14 Thread aleph-zero
Github user aleph-zero commented on a diff in the pull request: https://github.com/apache/drill/pull/157#discussion_r39451513 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlConnection.java --- @@ -110,7 +110,9 @@ public boolean equals(Object obj) {

[GitHub] drill pull request: Upgrade to guava 18.0

2015-09-14 Thread aleph-zero
Github user aleph-zero commented on a diff in the pull request: https://github.com/apache/drill/pull/157#discussion_r39451754 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/sort/SortTemplate.java --- @@ -47,7 +47,7 @@ public void setup(FragmentContext c

[GitHub] drill pull request: Upgrade to guava 18.0

2015-09-14 Thread aleph-zero
Github user aleph-zero commented on a diff in the pull request: https://github.com/apache/drill/pull/157#discussion_r39451914 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ImplCreator.java --- @@ -74,7 +74,7 @@ public static RootExec getExec(FragmentCo

[GitHub] drill pull request: Upgrade to guava 18.0

2015-09-14 Thread aleph-zero
Github user aleph-zero commented on a diff in the pull request: https://github.com/apache/drill/pull/157#discussion_r39451874 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/SpoolingRawBatchBuffer.java --- @@ -376,7 +376,7 @@ public long getBodySize() {

[GitHub] drill pull request: Upgrade to guava 18.0

2015-09-14 Thread aleph-zero
Github user aleph-zero commented on a diff in the pull request: https://github.com/apache/drill/pull/157#discussion_r39451937 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/SpoolingRawBatchBuffer.java --- @@ -423,7 +423,7 @@ public void readFromStream() th

STRING_BINARY's intended function?

2015-09-14 Thread Daniel Barclay
Is STRING_BINARY supposed to map all bytes or only certain bytes to hexadecimal? Daniel -- Daniel Barclay MapR Technologies

Re: Review Request 37893: DRILL-3718: TSV reader fails when "" appears

2015-09-14 Thread Sean Hsuan-Yi Chu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37893/ --- (Updated Sept. 14, 2015, 10:52 p.m.) Review request for drill, Jacques Nadeau a

Drill data types correspondence table

2015-09-14 Thread Daniel Barclay
For those who didn't see earlier drafts, here's a spreadsheet showing the correspondence between various kinds/levels of types in Drill (e.g., SQL data type names vs. Calcite Java enumerations vs. RPC-level Protobuf enumerations): Drill Data Types Correspondence Table

[GitHub] drill pull request: DRILL-3735: For partition pruning divide up th...

2015-09-14 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/156#discussion_r39463605 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java --- @@ -176,81 +177,103 @@ protected void doOnMatc

[GitHub] drill pull request: DRILL-3735: For partition pruning divide up th...

2015-09-14 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/156#discussion_r39463695 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java --- @@ -168,6 +168,7 @@ protected void doOnMatch(R

[jira] [Resolved] (DRILL-3045) Drill is not partition pruning due to internal off-heap memory limit for planning phase

2015-09-14 Thread Mehant Baid (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mehant Baid resolved DRILL-3045. Resolution: Fixed Fixed in dfa47da669dc2455389151c4e4071d405030c7a9 > Drill is not partition prunin

[GitHub] drill pull request: DRILL-3735: For partition pruning divide up th...

2015-09-14 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/156#discussion_r39464031 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java --- @@ -176,81 +177,103 @@ protected void doOnMatc

[jira] [Resolved] (DRILL-1146) JSON schema change cause query fail/sqline hang

2015-09-14 Thread Khurram Faraaz (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Khurram Faraaz resolved DRILL-1146. --- Resolution: Fixed > JSON schema change cause query fail/sqline hang >

[jira] [Created] (DRILL-3782) Upgrade HPPC library to latest version

2015-09-14 Thread Andrew (JIRA)
Andrew created DRILL-3782: - Summary: Upgrade HPPC library to latest version Key: DRILL-3782 URL: https://issues.apache.org/jira/browse/DRILL-3782 Project: Apache Drill Issue Type: Task Re

Re: Review Request 37893: DRILL-3718: TSV reader fails when "" appears

2015-09-14 Thread Jacques Nadeau
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37893/#review98976 --- Ship it! Ship It! - Jacques Nadeau On Sept. 14, 2015, 10:52 p.m.

[GitHub] drill pull request: DRILL-3735: For partition pruning divide up th...

2015-09-14 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/156#discussion_r39465039 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/ParquetPartitionDescriptor.java --- @@ -125,4 +117,16 @@ private String getBaseTableLoc

Re: Design and Implementation Question - related to DRILL-3738

2015-09-14 Thread Edmon Begoli
(I know it is busy time with a release, but please don't forget to address this inquiry once the release rush is over.) I am working on Excel and EDI pieces, and given that Excel is easier, I really want to start moving forward and contribute plug in. I just need some serious direction. We can als

Re: Review Request 38359: DRILL-3201: Add authentication and authorization to Drill Web client

2015-09-14 Thread Jacques Nadeau
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38359/#review98978 --- Initial thoughts. distribution/src/resources/drill-override-exampl

Re: Review Request 38359: DRILL-3201: Add authentication and authorization to Drill Web client

2015-09-14 Thread Jacques Nadeau
> On Sept. 15, 2015, 2 a.m., Jacques Nadeau wrote: > > exec/java-exec/src/main/resources/rest/generic.ftl, line 59 > > > > > > You should leak authorization logic into the template. This should be > > constrained to

[GitHub] drill pull request: Upgrade to guava 18.0

2015-09-14 Thread adeneche
Github user adeneche commented on a diff in the pull request: https://github.com/apache/drill/pull/157#discussion_r39469304 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataConnectionCreator.java --- @@ -66,8 +67,8 @@ public DataTunnel getTunnel(DrillbitEn

Re: STRING_BINARY's intended function?

2015-09-14 Thread Steven Phillips
It looks like the comments for that function are not correct. If you look at the javadoc for the toBinaryString() method which gets called, you will get the complete story. In short, it prints the bytes that are printable, and prints a hex representation for bytes that are not printable. This is m

[GitHub] drill pull request: DRILL-3735: For partition pruning divide up th...

2015-09-14 Thread amansinha100
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/156#discussion_r39474612 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java --- @@ -176,81 +177,103 @@ protected void doOnM

[GitHub] drill pull request: DRILL-3735: For partition pruning divide up th...

2015-09-14 Thread amansinha100
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/156#discussion_r39474948 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/ParquetPartitionDescriptor.java --- @@ -125,4 +117,16 @@ private String getBaseTable

[GitHub] drill pull request: DRILL-3735: For partition pruning divide up th...

2015-09-14 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/156#discussion_r39478410 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/ParquetPartitionDescriptor.java --- @@ -125,4 +117,16 @@ private String getBaseTableLoc

RE: Drill- Query execution plan

2015-09-14 Thread Sudip Mukherjee
Hi Abdel, Sorry for that. The code flow that I am trying to understand is below Like in my query:: SELECT SUM(1) AS `COL` FROM mydb.testtable HAVING COUNT(1)>0 Is the Projection broken down to 1) Final record output , 2) Projection on Aggregation something like that. Please correct me if I am