Re: [VOTE] Release Apache Druid (incubating) 0.13.0 [RC1]

2018-11-16 Thread David Lim
Hello, Voting on this thread is now closed in favor of RC2. Please take a look at the proposed RC2 artifacts and vote! https://lists.apache.org/thread.html/48d595def20faeac8ac0362441a3c1d4e6af814a36b68c6d236e6be5@%3Cdev.druid.apache.org%3E On Wed, Oct 31, 2018 at 11:47 AM Roman Leventov

Re: [VOTE] Release Apache Druid (incubating) 0.13.0 [RC1]

2018-10-31 Thread Roman Leventov
Another issue that needs to be resolved before the release is https://github.com/apache/incubator-druid/issues/6559 On Wed, 31 Oct 2018 at 00:12, Julian Hyde wrote: > > > > On Oct 30, 2018, at 12:04 PM, Gian Merlino wrote: > > > > It says > > to use http://static.druid.io/, but we probably

Re: [VOTE] Release Apache Druid (incubating) 0.13.0 [RC1]

2018-10-30 Thread Julian Hyde
> On Oct 30, 2018, at 12:04 PM, Gian Merlino wrote: > > It says > to use http://static.druid.io/, but we probably won't put the artifacts > there. Indeed. It is mandatory that the artifacts and their checksums are hosted on apache.org . (There can be mirrors.) Julian

Re: [VOTE] Release Apache Druid (incubating) 0.13.0 [RC1]

2018-10-30 Thread Gian Merlino
-1 because there are issues tagged for 0.13.0 that are not part of this release: - https://github.com/apache/incubator-druid/pull/6512 - https://github.com/apache/incubator-druid/pull/6514 - https://github.com/apache/incubator-druid/pull/6516 - https://github.com/apache/incubator-druid/pull/6508

Re: [VOTE] Release Apache Druid (incubating) 0.13.0 [RC1]

2018-10-23 Thread Julian Hyde
Your’e right. After I imported the keys, using $ gpg --recv-keys 58B5D669D2FFD83B37D88DF8BB64B3727183DE56 it worked. I could have done ‘gpg —import KEYS’ also. Changing my vote to +0 (binding). I would give +1 but the artifacts I am asked to review contains a bin.tar.gz and I have no idea how

Re: [VOTE] Release Apache Druid (incubating) 0.13.0 [RC1]

2018-10-22 Thread David Lim
Hi Julian, I believe the PaxHeader files are the result of extracting a tarball built with POSIX tar with a GNU or other variant. I believe it is a result of this configuration: https://github.com/apache/incubator-druid/blob/master/distribution/pom.xml#L195 Does Apache have guidelines on what

Re: [VOTE] Release Apache Druid (incubating) 0.13.0 [RC1]

2018-10-22 Thread David Lim
Hi Julian, Thank you for the thorough review! For the GPG key, my understanding is that it was expected that users would fetch the key by either running 'gpg --import KEYS' on the KEYS file (as per https://www.apache.org/dev/release-signing.html#keys-policy) or by importing it from the Apache

Re: [VOTE] Release Apache Druid (incubating) 0.13.0 [RC1]

2018-10-22 Thread Julian Hyde
-1 due to GPG error; but also see other concerns below and fix them if there are genuine issues. As this is Druid’s first Apache release candidate, I am impressed by how many things you got right. I have completely ignored bin.tar.gz. It’s not possible to “release” binaries in Apache because

Re: [VOTE] Release Apache Druid (incubating) 0.13.0 [RC1]

2018-10-22 Thread Julian Hyde
Thanks for finding that list, David. There are a lot of things to check. Therefore, before voting +1 you need to do some due diligence, and with your vote you should describe how you validated the release. For example, in a recent Calcite release thread[1] a typical vote looked like this: >

Re: [VOTE] Release Apache Druid (incubating) 0.13.0 [RC1]

2018-10-22 Thread David Lim
I believe what Julian wanted to highlight was this line in the announcement: > As this is our first release under the Apache Incubator program, note that Apache has specific requirements that must be met before +1 binding votes can be cast by PMC members. Please refer to the policy at

Re: [VOTE] Release Apache Druid (incubating) 0.13.0 [RC1]

2018-10-22 Thread Slim Bouguerra
Hey Julian Thanks for pointing that out. For the Apache related major changes please carefully review https://github.com/apache/incubator-druid/labels/Apache For bugs/features the release note is what you want to check https://github.com/apache/incubator-druid/issues/6442/ On Sun, Oct 21, 2018

Re: [VOTE] Release Apache Druid (incubating) 0.13.0 [RC1]

2018-10-21 Thread Fangjin Yang
+1 On Sun, Oct 21, 2018 at 3:34 PM Julian Hyde wrote: > Hey Slim, > > Since this is an Apache release, and you've voted on Apache releases > before in Calcite and Hive, can you explain what you checked before > you voted "+1". There are many folks here who have not been through > the release

Re: [VOTE] Release Apache Druid (incubating) 0.13.0 [RC1]

2018-10-21 Thread Julian Hyde
Hey Slim, Since this is an Apache release, and you've voted on Apache releases before in Calcite and Hive, can you explain what you checked before you voted "+1". There are many folks here who have not been through the release process, and we veterans should show them the ropes. Julian On Sun,

Re: [VOTE] Release Apache Druid (incubating) 0.13.0 [RC1]

2018-10-21 Thread Slim Bouguerra
+1 > On Oct 21, 2018, at 8:41 AM, David Lim wrote: > > Hi all, > > I have created a build for Apache Druid (incubating) 0.13.0, release > candidate 1. > > Thanks to everyone who has contributed to this release! You can read the > proposed release notes here: >

[VOTE] Release Apache Druid (incubating) 0.13.0 [RC1]

2018-10-21 Thread David Lim
Hi all, I have created a build for Apache Druid (incubating) 0.13.0, release candidate 1. Thanks to everyone who has contributed to this release! You can read the proposed release notes here: https://github.com/apache/incubator-druid/issues/6442 The release candidate has been tagged in GitHub