Re: DS code formatting

2017-04-25 Thread David Jencks
I’ve investigated further. I think that at some point I must have modified the imported felix eclipse template. However, - the template is out of date, there are a lot of new language features with formatting settings. - the template doesn’t match the scr code very well. I’ve pushed a couple

Re: DS code formatting

2017-04-25 Thread Thomas Watson
I much prefer we use the eclipse formatting template. I have that template setup for my workspace that I use for felix. I have also noticed the code gets formatted on save. Looking at my workspace settings it does seem this is enabled to format the code on save. I am unsure if I set that myself

Re: DS code formatting

2017-04-25 Thread David Jencks
Hi Christian, Felix has such an eclipse fomatting template, apparently my problem is that I tried to use it. Perhaps it should be put in a more accessible place? I think we should either use it or remove it, I’m a bit in favor of using it. at the end of http://felix.apache.org/documentation/

Re: DS code formatting

2017-04-24 Thread Christian Schneider
Hi David, this might be an eclipse config. Open preferences and go to Java / Editor / Save Actions. There you can select to format the code on save of a file. Maybe this option is switched on for you. That said I think it would make sense to have a common formatter for the code. In CXF we have

Re: DS code formatting

2017-04-24 Thread Carsten Ziegeler
David Jencks wrote > For reasons unclear to me Eclipse has started saving modified files > reformatted with the felix eclipse code template. This, to put it mildly, > has shown that the code isn’t formatted with the template, and I can’t fish > out my actual changes by hand. > > What would pe

DS code formatting

2017-04-24 Thread David Jencks
For reasons unclear to me Eclipse has started saving modified files reformatted with the felix eclipse code template. This, to put it mildly, has shown that the code isn’t formatted with the template, and I can’t fish out my actual changes by hand. What would people think if I reformatted the