Re: Lombok usage?

2022-04-09 Thread Petri Tuomola
This is great news - very happy to see this! I agree this should significantly reduce the amount of boilerplate code. Well done - and yes, I’ll try to contribute to “cleanup” as well :-) Regards Petri > On 8 Apr 2022, at 22:06, Arnold Galovics wrote: > > Hi guys, > > Just wanted to notify ev

Re: Lombok usage?

2022-04-08 Thread VICTOR MANUEL ROMERO RODRIGUEZ
+1 El vie, 8 abr 2022 a las 9:45, Aleksandar Vidakovic (< chee...@monkeysintown.com>) escribió: > +1 > > On Fri, Apr 8, 2022 at 4:06 PM Arnold Galovics wrote: > >> Hi guys, >> >> Just wanted to notify everybody, Lombok has landed on develop and already >> showing a great deal of value in terms o

Re: Lombok usage?

2022-04-08 Thread Aleksandar Vidakovic
+1 On Fri, Apr 8, 2022 at 4:06 PM Arnold Galovics wrote: > Hi guys, > > Just wanted to notify everybody, Lombok has landed on develop and already > showing a great deal of value in terms of reducing the boilerplate code. > > I touched some classes to kick-off the refactoring effort; you can find

Re: Lombok usage?

2022-04-08 Thread Arnold Galovics
Hi guys, Just wanted to notify everybody, Lombok has landed on develop and already showing a great deal of value in terms of reducing the boilerplate code. I touched some classes to kick-off the refactoring effort; you can find it in this PR: https://github.com/apache/fineract/pull/2269 I'd like

Re: Lombok usage?

2022-03-19 Thread Gerald O'Sullivan
Dear Friends Regarding the use of Lombok in Fineract, note that concerns have been raised about its use, and its compatibility (or lack of it) with JDK 16. See this post or this article

Re: Lombok usage?

2022-03-17 Thread Avik Ganguly
+1 On Wed, Mar 16, 2022 at 6:18 PM Arnold Galovics wrote: > Dear Community, > > While I've contributed to the codebase, I realized there's a lot of > boilerplate code for a lot of classes. > Mainly, I see the constructors which are really not doing anything except > assigning parameters to field

Re: Lombok usage?

2022-03-17 Thread Aleksandar Vidakovic
.. in some classes we have a million (my exaggeration) constructor parameters with the same type (String) which makes it really easy to shoot ourselves in the foot. My 2c On Thu, Mar 17, 2022 at 10:04 AM wrote: > +1 > > > > *From:* Awasum Yannick > *Sent:* Wednesday, 16 Mar

RE: Lombok usage?

2022-03-17 Thread sifiso
+1 From: Awasum Yannick Sent: Wednesday, 16 March 2022 5:54 PM To: Dev Subject: Re: Lombok usage? +1 Great Idea. On Wed, Mar 16, 2022, 16:43 Aleksandar Vidakovic mailto:chee...@monkeysintown.com> > wrote: +1 ... very in favor of doing this... with Lombok we can also g

Re: Lombok usage?

2022-03-16 Thread Petri Tuomola
+1 yes absolutely… I think we discussed this earlier - the only challenge I believe was that quite a few of the getters / setters actually have business logic in them, so we need to be a bit careful when introducing Lombok. But it’s definitely doable and would remove a huge amount of the boilerp

Re: Lombok usage?

2022-03-16 Thread Awasum Yannick
+1 Great Idea. On Wed, Mar 16, 2022, 16:43 Aleksandar Vidakovic wrote: > +1 > > ... very in favor of doing this... with Lombok we can also get rid of a > lot of the "@Autowired" stuff... just saying > > On Wed, Mar 16, 2022 at 2:07 PM John Woodlock > wrote: > >> Arnold, >> >> I'm not aware if

Re: Lombok usage?

2022-03-16 Thread Aleksandar Vidakovic
+1 ... very in favor of doing this... with Lombok we can also get rid of a lot of the "@Autowired" stuff... just saying On Wed, Mar 16, 2022 at 2:07 PM John Woodlock wrote: > Arnold, > > I'm not aware if the community has considered this or other tools for > removing Java boilercode. However, n

Re: Lombok usage?

2022-03-16 Thread John Woodlock
Arnold, I'm not aware if the community has considered this or other tools for removing Java boilercode. However, not being a native Java programmer I abhor the Java noise. And I'm sure you'd do a great job demonstrating how Lombok can reduce it. Thanks a lot John On Wed, Mar 16, 2022 at 12:48 P