Re: [FLEXJS] Build failure significant

2016-01-12 Thread Josh Tynjala
Good! Sorry for the trouble! - Josh On Jan 12, 2016 9:23 PM, "Alex Harui" wrote: > And the builds are passing. Thanks for sticking with it. > > -Alex > > On 1/12/16, 4:58 PM, "Josh Tynjala" wrote: > > >Mike, > > > >flash.utils.clearTimeout.length

Re: [FLEXJS] Build failure significant

2016-01-12 Thread Alex Harui
And the builds are passing. Thanks for sticking with it. -Alex On 1/12/16, 4:58 PM, "Josh Tynjala" wrote: >Mike, > >flash.utils.clearTimeout.length became a member access expression. >IdentifierEmitter never used the fully-qualified name for a member access >expression,

Re: Updated Flash player / AIR hashes

2016-01-12 Thread Justin Mclean
HI, > Does it work for you when you run ant release locally? Yep running ant gives me 4.16 named artefacts from the develop branch. Thanks, Justin

Re: [FLEXJS] Build failure significant

2016-01-12 Thread Alex Harui
On 1/12/16, 10:29 PM, "Josh Tynjala" wrote: >Good! Sorry for the trouble! Well, if you looked closely, you'd see I made a change that broke the build as well ;-) So I don't expect anyone to go forever without breaking a build. I try to always run "ant all" from the

Re: [FLEXJS] Build failure significant

2016-01-12 Thread Alex Harui
Sounds good. What did you have to do to get the unit tests to run? It might help the next person who tries. Thanks, -Alex On 1/12/16, 11:36 PM, "Josh Tynjala" wrote: >Before today, I could never get the unit tests to run on my local machine. >However, now, I can do a

Re: Updated Flash player / AIR hashes

2016-01-12 Thread Alex Harui
On 1/12/16, 3:32 PM, "Justin Mclean" wrote: > >And it is still building 4.15 :-( Anyone knows what need to change to >make it build 4.16? Or do we have an issue with version numbers in the >develop branch? Does it work for you when you run ant release locally? -Alex

Re: Bug in mxmlc script

2016-01-12 Thread OmPrakash Muppirala
Ah, I see what's happening. If I change the SDK by selecting 'Use a specific SDK', it warns me about overwriting the html-template files. But, if I keep the 'Use default SDK' but change the default SDK in the 'Configurie Flex SDK's screen, then there is no such warnings. The new default SDK is

Re: Build failed in Jenkins: MD5Checker #7992

2016-01-12 Thread Justin Mclean
Hi, > Well, it wants the cacheID's updated so it doesn't have to download > everything just-in-case. I'll try to update them. In that case we may want to change the output message from "MD5's changed!”. Thanks, Justin

Re: [FlexJS] US States Map example - pure AS3

2016-01-12 Thread Deepak MS
Hi Om, I need it ASAP, as I need to wrap it up by this month end. That's great to hear from you. Surely, I'll pitch in. For now, I wanted UK's map with its states\bricks highlighting based on data(For Ex: red\yellow\green). If it's for SDK, then I guess it needs to be generalised(for both web and

Re: [FlexJS] US States Map example - pure AS3

2016-01-12 Thread OmPrakash Muppirala
Okay, I have created a map component from scratch in Flex. Here is the basic code https://github.com/bigosmallm/flexmapcomponent/tree/master/MapComponent For now, this supports only a WorldMap. You can follow the code and create a UK map, it should be straightforward. You can get your maps

RE: [FlexJS] US States Map example - pure AS3

2016-01-12 Thread Sugan Naicker
Hi Deepak, >> https://github.com/uhub/awesome-actionscript Wow, thanks for sharing, extensive set of libraries! Rgs Sugan -Original Message- From: Deepak MS [mailto:megharajdee...@gmail.com] Sent: Tuesday, January 12, 2016 10:34 AM To: dev@flex.apache.org Subject: Re: [FlexJS] US

Re: [FLEXJS] Build failure significant

2016-01-12 Thread Josh Tynjala
I discovered that when package-level and file-level functions or variables are parented by a MemberAccessExpressionNode, the old code wasn't outputting the proper fully-qualified name. This change was meant to handle that special case. It looks like goog.bind is a package-level function, though,

[FLEXJS] Build failure significant

2016-01-12 Thread Peter Ent
I updated falcon and flexjs this morning and ran into an issue. First thought it was my problem then looked at the logs. When I build I get the same issue as the warnings below and that causes a runtime failure. [java] WARNING:

Re: Build failed in Jenkins: MD5Checker #7992

2016-01-12 Thread Alex Harui
On 1/12/16, 1:21 AM, "Justin Mclean" wrote: >Hi, > >> Well, it wants the cacheID's updated so it doesn't have to download >> everything just-in-case. I'll try to update them. > >In that case we may want to change the output message from "MD5's >changed!”. Sure, go

Re: [FLEXJS] Build failure significant

2016-01-12 Thread Josh Tynjala
I'm running into some problem trying to fix this issue. I tried adding the following three tests to TestFlexJSExpressions: @Test public void testFunctionCallFullyQualified() { IFunctionNode node = (IFunctionNode) getNode( "import goog.bind; public class B {public function b() {

AW: AW: Updated Flash player / AIR hashes

2016-01-12 Thread Christofer Dutz
Hi Alex, I am already downloading the Air Runtimes ... has always been part of the Mavenizer. And yes, I only want the debug player for flash so we can automatically run tests against the correct version. Chris -Ursprüngliche Nachricht- Von: Alex Harui [mailto:aha...@adobe.com]

Re: [FLEXJS] Build failure significant

2016-01-12 Thread Alex Harui
What I typically do in these situations is examine the node tree and see if I can see some difference that I can test for. HTH, -Alex On 1/12/16, 3:17 PM, "Josh Tynjala" wrote: >I'm running into some problem trying to fix this issue. I tried adding the >following three

Re: [FLEXJS] Build failure significant

2016-01-12 Thread Josh Tynjala
Thanks for the hint! I determined that it matters which side of the member access expression the identifier appears on. If the identifier is on the right of the expression, it should not be qualified. - Josh On Tue, Jan 12, 2016 at 3:22 PM, Alex Harui wrote: > What I

Re: [FLEXJS] Build failure significant

2016-01-12 Thread Josh Tynjala
Mike, flash.utils.clearTimeout.length became a member access expression. IdentifierEmitter never used the fully-qualified name for a member access expression, so it was emitting as clearTimeout.length, without the package name. See my commit and/or my reply to Alex for the explanation of how I

Re: [FLEXJS] Build failure significant

2016-01-12 Thread Michael Schmalle
Josh, I have much experience with this identifier vrs. function call stuff in the compiler. I pulled my hair out when initally implementing the Identifier emitter and in the end made it as dumb as possible. I was looking at your commits, and read this, can you exactly explain what was failing ,

Re: Updated Flash player / AIR hashes

2016-01-12 Thread Justin Mclean
Hi, > You are right, it is still building 4.15.0 > http://apacheflexbuild.cloudapp.net:8080/job/flex-sdk_nightly/lastSuccessfulBuild/artifact/out/apache-flex-sdk-4.15.0-bin.tar.gz > >

Re: [4/5] git commit: [flex-falcon] [refs/heads/develop] - compiler.jx: added support for functions and variables in packages, and functions and variables after package (similar to internal classes)

2016-01-12 Thread Josh Tynjala
Yes, it should be resolved. Package-level functions are now working. - Josh On Jan 12, 2016 8:36 AM, "Andy Dufilie" wrote: > Josh, does this commit resolve > https://issues.apache.org/jira/browse/FLEX-35004 ? > > On Tue, Jan 12, 2016 at 11:24 AM, Alex Harui

Re: [4/5] git commit: [flex-falcon] [refs/heads/develop] - compiler.jx: added support for functions and variables in packages, and functions and variables after package (similar to internal classes)

2016-01-12 Thread Andy Dufilie
Josh, does this commit resolve https://issues.apache.org/jira/browse/FLEX-35004 ? On Tue, Jan 12, 2016 at 11:24 AM, Alex Harui wrote: > I haven't done thorough research, but I think this change is causing the > last remaining failure in the Falcon build. The failing case is >

Re: [4/5] git commit: [flex-falcon] [refs/heads/develop] - compiler.jx: added support for functions and variables in packages, and functions and variables after package (similar to internal classes)

2016-01-12 Thread Alex Harui
I haven't done thorough research, but I think this change is causing the last remaining failure in the Falcon build. The failing case is org.apache.flex.compiler.internal.codegen.js.vf2js.TestVF2JSFile.testVersio n in compiler.jx.tests. The test case is dealing with an variable defined in an

Re: [FLEXJS] Build failure significant

2016-01-12 Thread Alex Harui
Yep, I'm seeing this too. It could be the IdentifierEmitter changes. I think the emitter code needs to check if it is already part of a fully-qualified name, maybe by seeing if the IdentifierNode is parented by a MemberAccessExpressionNode. Josh, can you look into this? I think you can add a