Re: Package, Class and Method renaming

2017-08-08 Thread Harbs
I have a custom component “A” which implements a DisabledBead in ActionScript. It has a getter called “enabled”. I have another MXML file “B” which uses the component and specifies enabled=“false”. I’m assuming the “enabled” property in “A” will be renamed without an @export. The mxml in “B”

Re: Package, Class and Method renaming

2017-08-08 Thread Alex Harui
Interesting. Feel free to try it and see. I'm wondering where we use the class strings in FLEXJS_CLASS_INFO. Maybe they can be taken out. -Alex On 8/8/17, 2:12 PM, "Greg Dove" wrote: >Alex fyi I have wondered about breaking the class strings into literal >concatenation

Re: Package, Class and Method renaming

2017-08-08 Thread Alex Harui
I just tried DataBindingExample. MyInitialView is essentially a custom component. What are you thinking won't work? -Alex On 8/8/17, 2:30 PM, "Harbs" wrote: >Did you try MXML with custom components? I’m not sure I understand how >that would work. > >> On Aug 9, 2017,

Re: Package, Class and Method renaming

2017-08-08 Thread Harbs
Did you try MXML with custom components? I’m not sure I understand how that would work. > On Aug 9, 2017, at 12:01 AM, Alex Harui wrote: > > Some things I found were that MXML isn't a problem because the id maps to > a getter/setter which maps to Object.DefineProperty

Re: Package, Class and Method renaming

2017-08-08 Thread Greg Dove
I guess that might help with the code minification, but it may be irrelevant with the longer original strings with something like gzip compression already there are so many levels to this. On Wed, Aug 9, 2017 at 9:12 AM, Greg Dove wrote: > Alex fyi I have wondered

Re: Package, Class and Method renaming

2017-08-08 Thread Greg Dove
Alex fyi I have wondered about breaking the class strings into literal concatenation expressions with package parts for CLASS_INFO and in the reflection data. This should end up minifying via closure compiler much better, I think. e.g. 'org.'+'apache.'+'flex.'+'events.'+'Event' On Wed, Aug 9,

Re: Package, Class and Method renaming

2017-08-08 Thread Alex Harui
So I just pushed a first crack at suppressing most @export statements. Set -export-public-symbols=false and many @export statements should go away. The before size of TLFEditTestFlexJS was 813493 bytes. I recompiled TLF without @export symbols and the after size was 679609 bytes. And it ran.

Re: [01/10] git commit: [flex-asjs] [refs/heads/refactor-strand] - Core changes to IStrand

2017-08-08 Thread Harbs
Never mind. On JS it’s defined in the superclasses. > On Aug 8, 2017, at 11:56 PM, Harbs wrote: > > I’m not sure I understand how CreateJS passes at all. Application.as (in > CreateJS) has a call to addBead() and I don’t see the function defined > anywhere… > >> On Jul

Re: [01/10] git commit: [flex-asjs] [refs/heads/refactor-strand] - Core changes to IStrand

2017-08-08 Thread Harbs
I’m not sure I understand how CreateJS passes at all. Application.as (in CreateJS) has a call to addBead() and I don’t see the function defined anywhere… > On Jul 18, 2017, at 7:20 AM, piotrz wrote: > > Hi Harbs, > > I've created pipelines for your strand-work

Re: Flex 0.8.1 release?

2017-08-08 Thread Harbs
Thanks. That’s helpful. > On Aug 8, 2017, at 11:47 PM, Alex Harui wrote: > > FWIW, when I check examples, I first run ant in the examples folder and go > do something else while it builds all of the examples. > > Then I run "ant examine" and it will try to bring up

Re: Flex 0.8.1 release?

2017-08-08 Thread Alex Harui
FWIW, when I check examples, I first run ant in the examples folder and go do something else while it builds all of the examples. Then I run "ant examine" and it will try to bring up FireFox or AIR with the various examples. Saves typing stuff on the command line or picking things from the File

Re: Flex 0.8.1 release?

2017-08-08 Thread Harbs
DataBindingExample - works (with the exception of the API issue) DataBindingExampleWithFlexLayout - ditto Chart Example - works CreateJS - works, but the HTML output looks different than the swf output. I don’t know if it used to look better. DataGrid - works, but the images are not visible in

Re: Flex 0.8.1 release?

2017-08-08 Thread Harbs
Yeah. It looks like the API is broken: https://query.yahooapis.com/v1/public/yql?q=select%20*%20from%20yahoo.finance.quotes%20where%20symbol%20in%20(%22YHOO%22)%0A%09%09=store%3A%2F%2Fdatatables.org%2Falltableswithkeys=json

Re: Flex 0.8.1 release?

2017-08-08 Thread Harbs
For some reason the data is getting null values sometimes. Bad: https://paste.apache.org/g7Sv Good: https://paste.apache.org/Lloe > On Aug 8, 2017, at 11:09 PM, Alex Harui wrote: > > SWF and js-debug,

Re: Flex 0.8.1 release?

2017-08-08 Thread Alex Harui
SWF and js-debug, didn't try js-release. When I click the checkbox, the data is there. Could be that the price is not in the data returned. -Alex On 8/8/17, 1:06 PM, "Harbs" wrote: >js-debug, js-release or swf? > >> On Aug 8, 2017, at 10:54 PM, Alex Harui

Re: Flex 0.8.1 release?

2017-08-08 Thread Harbs
js-debug, js-release or swf? > On Aug 8, 2017, at 10:54 PM, Alex Harui wrote: > > Still not working for me. > > On 8/8/17, 12:42 PM, "Harbs" wrote: > >> I tried it before and it was not showing up, but I just tried now and it >> is. >> >> I

Re: Flex 0.8.1 release?

2017-08-08 Thread Alex Harui
Still not working for me. On 8/8/17, 12:42 PM, "Harbs" wrote: >I tried it before and it was not showing up, but I just tried now and it >is. > >I wonder if there was an API problem. > >I’m not 100% sure what it’s supposed to do, can you check again? > >> On Aug 8, 2017,

Re: Flex 0.8.1 release?

2017-08-08 Thread Harbs
I tried it before and it was not showing up, but I just tried now and it is. I wonder if there was an API problem. I’m not 100% sure what it’s supposed to do, can you check again? > On Aug 8, 2017, at 5:41 PM, Alex Harui wrote: > > However, I just saw that >

Re: Flex 0.8.1 release?

2017-08-08 Thread Alex Harui
Here are my notes from the previous release: https://lists.apache.org/thread.html/c5625d0ac1f8b28ae729cf82b547971ac4faec ede84d0c97b7713246@%3Cdev.flex.apache.org%3E -Alex On 8/8/17, 9:26 AM, "piotrz" wrote: >+1 for the release. > >But have to start from Maven which

Re: Flex 0.8.1 release?

2017-08-08 Thread piotrz
+1 for the release. But have to start from Maven which can do for us branch automatically. I don't know how to do this with specific commits. I think we shouldn't cherry pick up anything - we don't have as much stuff as it was for 0.8.0. We should just go taking develop as it is now. Piotr

Re: Flex 0.8.1 release?

2017-08-08 Thread Harbs
I don’t know I’d call TLF a “feature” at this point. It works great for me, but it can’t really be used yet without a custom engine. XML has been drastically improved. There’s definitely other newsworthy items. I’ll try to go through the commits to make a list. > On Aug 8, 2017, at 6:27 PM,

Re: Flex 0.8.1 release?

2017-08-08 Thread Alex Harui
What are the new features that would be 0.9.0 worthy? If it is TLF, the manual test for TLF with the Text.swc is also broken. I'm trying to fix that now. Personally, I don't care much about what we call this release or what goes in it, especially if I'm not the RM. I do think we need to make

Re: Flex 0.8.1 release?

2017-08-08 Thread Josh Tynjala
Yeah, I meant a hotfix with some bug fixes only. However, if it seems like there's been enough work to make a 0.9.0 release, and it's stable enough, then that's seems fine too. - Josh On Tue, Aug 8, 2017 at 7:45 AM, Harbs wrote: > I assume Josh was talking about a

Re: Flex 0.8.1 release?

2017-08-08 Thread Harbs
I assume Josh was talking about a hotfix. I was just thinking that it’s time to release 0.9.0.. I wonder if we could just try and get a new release out the door quickly. I’ll try and spend some time with the examples. > On Aug 8, 2017, at 5:41 PM, Alex Harui wrote:

Re: Flex 0.8.1 release?

2017-08-08 Thread Alex Harui
A 0.8.1 release is fine with me. However, I just saw that DataBindingExample is broken. The stock price doesn't show up. We will probably need to stop and check all of the examples again. Peter usually helps me do that, but he's on vacation. Other folks will need to step up to be the RM and

Re: FlexJS Bead dilemma

2017-08-08 Thread Alex Harui
OK. Well, IMO, the principle of composition, combined with the way we use CSS "Type Selectors" means that the most explicit recommended practice is to subclass to create a new type in order to get a new set of defaults to compose. That's why there is an ImageButton instead of some other

Flex 0.8.1 release?

2017-08-08 Thread Josh Tynjala
(copying from users) PMC, We should consider a 0.8.1 release with some of the recent bug fixes. The IntelliJ IDEA fix [1], in particular, seems especially important, considering this thread. Developers want to to try FlexJS in a familiar IDE, and 0.8.0 makes that harder right now. It's also

Re: FlexJS Bead dilemma

2017-08-08 Thread Harbs
None of this is really high priority for me right now. None of the layouts I’m using are really expensive layouts and any performance issues I’m having are caused by other problems. I’m more trying to figure out the best general resolution to this issue. Thanks, Harbs > On Aug 8, 2017, at

Re: FlexJS Bead dilemma

2017-08-08 Thread Alex Harui
I don't know the details of your scenario. I was thinking that on the first show event, the wrapper would remove the show event listener and thus not install the actual layout bead more than once, but that may not be what you want. I think your choices are: 1) Subclass Container and add a way

Re: FlexJS Bead dilemma

2017-08-08 Thread Harbs
If it doesn’t remove itself, it seems like you’d end up with two layout beads and it would probably keep injecting more layout beads each time the component is made visible. > On Aug 8, 2017, at 9:30 AM, Alex Harui wrote: > > I was thinking the wrapper was an

Re: FlexJS Bead dilemma

2017-08-08 Thread Alex Harui
I was thinking the wrapper was an IBeadLayout, otherwise you couldn't inject the wrapper via CSS without other changes. I'm not sure it has to remove itself before adding the actual bead or not. Somebody will find out if someone actually tries this. Other ideas are fine as well. I'm just

RE: FlexJS Bead dilemma

2017-08-08 Thread Yishay Weiss
But you would need to override all these calls (or remove the layout bead from CSS) addBead(new (ValuesManager.valuesImpl.getValue(this, "iBeadLayout")) as IBead); You wouldn’t need to if the wrapper was in itself an IBeadLayout, but then it would have to remove itself before