[jira] [Created] (FLINK-35779) Update documentation for PubSubSinkV2

2024-07-07 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-35779: --- Summary: Update documentation for PubSubSinkV2 Key: FLINK-35779 URL: https://issues.apache.org/jira/browse/FLINK-35779 Project: Flink Issue Type: Sub-task

Re: [DISCUSS] FLIP-299 Pub/Sub Lite Connector

2024-07-02 Thread Ahmed Hamdy
Hi Martijn, yes, I agree, thanks for confirmation. Best Regards Ahmed Hamdy On Tue, 2 Jul 2024 at 12:30, Martijn Visser wrote: > Hi, > > Since PubSub Lite is deprecated, I think we can safely close this FLIP and > not proceed further [1] > > Best regards, > &g

Re: [ANNOUNCE] Apache Flink CDC 3.1.1 released

2024-06-27 Thread Ahmed Hamdy
Congratulations, Thanks for the efforts Best Regards Ahmed Hamdy On Thu, 20 Jun 2024 at 12:57, Muhammet Orazov wrote: > Great, thanks Qingsheng for your efforts! > > Best, > Muhammet > > On 2024-06-18 15:50, Qingsheng Ren wrote: > > The Apache Flink community i

Re: [VOTE] FLIP-444: Native file copy support

2024-06-27 Thread Ahmed Hamdy
+1 (non-binding) Best Regards Ahmed Hamdy On Thu, 27 Jun 2024 at 17:29, Martijn Visser wrote: > +1 (binding) > > On Thu, Jun 27, 2024 at 3:32 AM Rui Fan <1996fan...@gmail.com> wrote: > > > +1(binding) > > > > Best, > > Rui > > > > On W

[jira] [Created] (FLINK-35697) Release Testing: Verify FLIP-451 Introduce timeout configuration to AsyncSink

2024-06-25 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-35697: --- Summary: Release Testing: Verify FLIP-451 Introduce timeout configuration to AsyncSink Key: FLINK-35697 URL: https://issues.apache.org/jira/browse/FLINK-35697 Project

Re: [ANNOUNCE] New Apache Flink Committer - Hang Ruan

2024-06-17 Thread Ahmed Hamdy
Congratulations Hang. Regards Ahmed On Mon, 17 Jun 2024, 14:01 Feifan Wang, wrote: > Congratulations Hang ! > > > —— > > Best regards, > > Feifan Wang > > > > > At 2024-06-17 11:17:13, "Leonard Xu" wrote: > >Hi everyone, > >On behalf of the PMC, I'm happy to let you know that Hang

Re: [DISCUSS] Connector Externalization Retrospective

2024-06-11 Thread Ahmed Hamdy
and removing it would be an Adhoc task for maintainers which I believe is an accepted tradeoff but would love to hear the feedback. 1- https://github.com/apache/flink/pull/24180/files#diff-2ffade463560e5941912b91b12a07c888313a4cc7e39ca8700398ed6975b8e90 Best Regards Ahmed Hamdy On Tue, 11 Jun 2024 at 08

Re: [Discuss] Non-retriable (partial) errors in Elasticsearch 8 connector

2024-06-11 Thread Ahmed Hamdy
Hi Mingliang, Yes sounds like a good solution, I am not very familiar with ElasticSearch internals and APIs but will try to assist with the PR when ready. Best Regards Ahmed Hamdy On Tue, 11 Jun 2024 at 07:07, Mingliang Liu wrote: > Thank you Ahmed for the explanation. > > Th

Re: [ANNOUNCE] New Apache Flink PMC Member - Fan Rui

2024-06-10 Thread Ahmed Hamdy
Congratulations Rui! Best Regards Ahmed Hamdy On Mon, 10 Jun 2024 at 09:10, David Radley wrote: > Congratulations, Rui! > > From: Sergey Nuyanzin > Date: Sunday, 9 June 2024 at 20:33 > To: dev@flink.apache.org > Subject: [EXTERNAL] Re: [ANNOUNCE] New Apache Flink PM

Re: [VOTE] Release 1.19.1, release candidate #1

2024-06-08 Thread Ahmed Hamdy
Hi Hong, Thanks for driving +1 (non-binding) - Verified signatures and hashes - Checked github release tag - Verified licenses - Checked that the source code does not contain binaries - Reviewed Web PR, nit: Could we address the comment of adding FLINK-34633 in the release Best Regards Ahmed

Re: [VOTE] FLIP-459: Support Flink hybrid shuffle integration with Apache Celeborn

2024-06-08 Thread Ahmed Hamdy
+1 (non-binding) Best Regards Ahmed Hamdy On Sat, 8 Jun 2024 at 22:26, Jeyhun Karimov wrote: > Hi Yuxin, > > Thanks for driving this. > +1 (non-binding) > > Regards, > Jeyhun > > On Fri, Jun 7, 2024 at 6:05 PM Jim Hughes > wrote: > > > HI all,

Re: [DISCUSS] FLIP-299 Pub/Sub Lite Connector

2024-06-08 Thread Ahmed Hamdy
of the discussion at the moment. I would love to hear your thoughts. 1-https://lists.apache.org/thread/63wdvo5hvr6koc3wzbqy2kw4krhmkfbx Best Regards Ahmed Hamdy On Fri, 17 Mar 2023 at 15:58, Daniel Collins wrote: > > would the repository ... be removed ... ? > > Yes, I would remove it once

Re: [Discuss] Non-retriable (partial) errors in Elasticsearch 8 connector

2024-06-07 Thread Ahmed Hamdy
r-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/sink/DynamoDbSinkWriter.java#L227 3-https://issues.apache.org/jira/browse/FLINK-35541 Best Regards Ahmed Hamdy On Thu, 6 Jun 2024 at 06:53, Mingliang Liu wrote: > Hi all, > > Currently the Elasticsearch 8 connector r

[jira] [Created] (FLINK-35548) Add E2E tests for PubSubSinkV2

2024-06-07 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-35548: --- Summary: Add E2E tests for PubSubSinkV2 Key: FLINK-35548 URL: https://issues.apache.org/jira/browse/FLINK-35548 Project: Flink Issue Type: Sub-task

Re: [ANNOUNCE] New Apache Flink PMC Member - Weijie Guo

2024-06-04 Thread Ahmed Hamdy
Congratulations Weijie Best Regards Ahmed Hamdy On Tue, 4 Jun 2024 at 10:51, Matthias Pohl wrote: > Congratulations, Weijie! > > Matthias > > On Tue, Jun 4, 2024 at 11:12 AM Guowei Ma wrote: > > > Congratulations! > > > > Best, > > Guowei

[jira] [Created] (FLINK-35500) DynamoDb SinkWriter fails to delete elements due to key not found

2024-05-31 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-35500: --- Summary: DynamoDb SinkWriter fails to delete elements due to key not found Key: FLINK-35500 URL: https://issues.apache.org/jira/browse/FLINK-35500 Project: Flink

Re: [DISCUSS] Add Flink CDC Channel to Apache Flink Slack Workspace

2024-05-29 Thread Ahmed Hamdy
Thanks Zhongqiang, +1 for sure. Best Regards Ahmed Hamdy On Wed, 29 May 2024 at 13:48, ConradJam wrote: > +1 best > > Hang Ruan 于2024年5月29日周三 11:28写道: > > > Hi, zhongqiang. > > > > Thanks for the proposal. +1 for it. > > > > Best, > >

[jira] [Created] (FLINK-35454) Connector ArchTests fails due to dependency on fink.util.Preconditions

2024-05-26 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-35454: --- Summary: Connector ArchTests fails due to dependency on fink.util.Preconditions Key: FLINK-35454 URL: https://issues.apache.org/jira/browse/FLINK-35454 Project: Flink

[jira] [Created] (FLINK-35445) Update Async Sink documentation for Timeout configuration

2024-05-24 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-35445: --- Summary: Update Async Sink documentation for Timeout configuration Key: FLINK-35445 URL: https://issues.apache.org/jira/browse/FLINK-35445 Project: Flink

[jira] [Created] (FLINK-35435) [FLIP-451] Introduce timeout configuration to AsyncSink

2024-05-23 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-35435: --- Summary: [FLIP-451] Introduce timeout configuration to AsyncSink Key: FLINK-35435 URL: https://issues.apache.org/jira/browse/FLINK-35435 Project: Flink Issue

[RESULT][VOTE] FLIP-451: Introduce timeout configuration to AsyncSink

2024-05-22 Thread Ahmed Hamdy
://lists.apache.org/thread/9mkzdv0gzssxh8p0y1cl3dvj6lvwyrc0 Best Regards Ahmed Hamdy

Re: [VOTE] FLIP-451: Introduce timeout configuration to AsyncSink

2024-05-22 Thread Ahmed Hamdy
Hi all, Thanks for all your votes, I hereby close the vote and I'll announce the results in a separate email. Best Regards Ahmed Hamdy On Wed, 22 May 2024 at 11:30, weijie guo wrote: > Thanks Ahmed for introducing this FLIP, nice improvement. > > +1(binding) > > Best rega

Re: [DISCUSS] FLIP-451: Refactor Async sink API

2024-05-22 Thread Ahmed Hamdy
ward compatibility has > been considered for all public interfaces the FLIP changed. > Done Best Regards Ahmed Hamdy On Wed, 22 May 2024 at 04:16, Leonard Xu wrote: > Thanks for your reply, Ahmed. > > > (2) The FLIP-451 aims to introduce a timeout configuration, but I didn’t

Re: [DISCUSS] FLIP-451: Refactor Async sink API

2024-05-21 Thread Ahmed Hamdy
, I fixed the incomplete methods, This should clarify how the new method is going to be integrated with the rest of the writer. Regarding the sendTime variable, I have replaced it with requestTimestamp; this is an unchanged part of the code to ensure the existing completeRequest method is unchanged. B

Re: [DISCUSS] FLIP-451: Refactor Async sink API

2024-05-21 Thread Ahmed Hamdy
Hi Hong, Thanks for pointing that out, no we are not deprecating getFatalExceptionCons(). I have updated the FLIP Best Regards Ahmed Hamdy On Mon, 20 May 2024 at 15:40, Hong Liang wrote: > Hi Ahmed, > Thanks for putting this together! Should we still be marking > getFatalExce

[jira] [Created] (FLINK-35401) Add SQS Table API support

2024-05-20 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-35401: --- Summary: Add SQS Table API support Key: FLINK-35401 URL: https://issues.apache.org/jira/browse/FLINK-35401 Project: Flink Issue Type: New Feature

Re: [ANNOUNCE] Apache Flink CDC 3.1.0 released

2024-05-17 Thread Ahmed Hamdy
Congratulations, Great Work! Best Regards Ahmed Hamdy On Fri, 17 May 2024 at 10:56, ConradJam wrote: > Congratulations! > > Thanks for the great work. > > Hang Ruan 于2024年5月17日周五 17:48写道: > > > Congratulations! > > > > Thanks for the great work. > > &

Re: [VOTE] FLIP-449: Reorganization of flink-connector-jdbc

2024-05-17 Thread Ahmed Hamdy
Hi all, +1 (non-binding) Best Regards Ahmed Hamdy On Fri, 17 May 2024 at 02:13, Jiabao Sun wrote: > Thanks for driving this proposal! > > +1 (binding) > > Best, > Jiabao > > > On 2024/05/10 22:18:04 Jeyhun Karimov wrote: > > Thanks for driving this! > &g

Re: [DISCUSS] FLIP-453: Promote Unified Sink API V2 to Public and Deprecate SinkFunction

2024-05-15 Thread Ahmed Hamdy
Hi Lorenzo, yes it is pretty useful to start tackling the ones that still don't implement the new interface, happy so sync offline to close this task, additionally a volunteer to review the migrations would be highly appreciated. Best Regards Ahmed Hamdy On Wed, 15 May 2024 at 10:01, wrote

Re: [DISCUSS] FLIP-XXX: Improve JDBC connector extensibility for Table API

2024-05-15 Thread Ahmed Hamdy
Hi Lorenzo, This seems like a very useful addition. +1 (non-binding) from my side. I echo Jeyhun's question about backward compatibility as it is not mentioned in the FLIP. Best Regards Ahmed Hamdy On Wed, 15 May 2024 at 08:12, wrote: > Hello Muhammet and Jeyhun! > Thanks for your co

Re: [VOTE] FLIP-453: Promote Unified Sink API V2 to Public and Deprecate SinkFunction

2024-05-15 Thread Ahmed Hamdy
+1 (non-binding). Thanks Martijn! Best Regards Ahmed Hamdy On Wed, 15 May 2024 at 14:11, Jing Ge wrote: > +1(binding) Thanks Martijn! > > Best regards, > Jing > > On Wed, May 15, 2024 at 7:00 PM Muhammet Orazov > wrote: > > > Thanks Martijn driving this!

Re: [VOTE] FLIP-451: Introduce timeout configuration to AsyncSink

2024-05-13 Thread Ahmed Hamdy
Thanks David, I have replied to your question in the discussion thread. Best Regards Ahmed Hamdy On Mon, 13 May 2024 at 16:21, David Radley wrote: > Hi, > I raised a question on the discussion thread, around retriable errors, as > a possible alternative, > Kind regards, David

Re: [DISCUSS] FLIP-451: Refactor Async sink API

2024-05-13 Thread Ahmed Hamdy
/c6e0abb65a0e51b40dd218b890a111886fbf797f/flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisStreamsSinkWriter.java#L106 Best Regards Ahmed Hamdy On Mon, 13 May 2024 at 16:20, David Radley wrote: > Hi, > I wonder if the way that the

Re: [DISCUSS] FLIP-453: Promote Unified Sink API V2 to Public and Deprecate SinkFunction

2024-05-13 Thread Ahmed Hamdy
Thanks for the clarification. +1 to starting the vote. Best Regards Ahmed Hamdy On Mon, 13 May 2024 at 09:10, Martijn Visser wrote: > Hi Ahmed, > > There's no reason to refrain from releases for Flink 1.* versions: these > connector implementations are still supported in the Flin

[VOTE] FLIP-451: Introduce timeout configuration to AsyncSink

2024-05-13 Thread Ahmed Hamdy
/ft7wcw7kyftvww25n5fm4l925tlgdfg0 2- https://cwiki.apache.org/confluence/display/FLINK/FLIP-451%3A+Introduce+timeout+configuration+to+AsyncSink+API Best Regards Ahmed Hamdy

Re: [DISCUSS] FLIP-453: Promote Unified Sink API V2 to Public and Deprecate SinkFunction

2024-05-12 Thread Ahmed Hamdy
blockers are implemented? > Could you please clarify? Best Regards Ahmed Hamdy On Sun, 12 May 2024 at 14:07, Martijn Visser wrote: > Hi all, > > If there are no more considerations, I'll open up a vote in the next couple > of days. > > Best regards, > > Martijn > &g

Re: Re: [VOTE] FLIP-448: Introduce Pluggable Workflow Scheduler Interface for Materialized Table

2024-05-11 Thread Ahmed Hamdy
+1 (non-binding) Best Regards Ahmed Hamdy On Sat, 11 May 2024 at 16:26, Keith Lee wrote: > +1 (non-binding) > > Best regards > Keith Lee > > > On Sat, 11 May 2024 at 04:58, Shengkai Fang wrote: > > > +1 (binding) > > > > Best, > > Shengkai >

[jira] [Created] (FLINK-35322) PubSub Connector Weekly build fails

2024-05-09 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-35322: --- Summary: PubSub Connector Weekly build fails Key: FLINK-35322 URL: https://issues.apache.org/jira/browse/FLINK-35322 Project: Flink Issue Type: Bug

Re: [VOTE] FLIP-447: Upgrade FRocksDB from 6.20.3 to 8.10.0

2024-05-09 Thread Ahmed Hamdy
Thanks for the effort and the data provided. +1 (non-binding) Best Regards Ahmed Hamdy On Thu, 9 May 2024 at 08:20, Keith Lee wrote: > +1 (non-binding) > > Great work on the benchmark data. > > Keith > > On Thu, May 9, 2024 at 4:53 AM 周仁祥 wrote: > > > +1 (non

[jira] [Created] (FLINK-35320) RabbitMQ Source fails to consume from quorum queues when prefetch Count is set

2024-05-09 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-35320: --- Summary: RabbitMQ Source fails to consume from quorum queues when prefetch Count is set Key: FLINK-35320 URL: https://issues.apache.org/jira/browse/FLINK-35320 Project

Re: [RESULT][VOTE] FLIP-454: New Apicurio Avro format

2024-05-08 Thread Ahmed Hamdy
Hi David, thanks for the update We should wait to reach threshold of "binding" votes as per the process[1] 1- https://cwiki.apache.org/confluence/display/FLINK/Flink+Bylaws#FlinkBylaws-Approvals Best Regards Ahmed Hamdy On Wed, 8 May 2024 at 16:06, David Radley wrote: > Hi eve

Re: [DISCUSS] FLIP-444: Native file copy support

2024-05-08 Thread Ahmed Hamdy
Hi Piotr +1 for the proposal, it seems to have a lot of gains. Best Regards Ahmed Hamdy On Mon, 6 May 2024 at 12:06, Zakelly Lan wrote: > Hi Piotrek, > > Thanks for your answers! > > Good question. The intention and use case behind `DuplicatingFileSystem` is > >

Re: [DISCUSS] Flink CDC 3.2 Release Planning

2024-05-08 Thread Ahmed Hamdy
Thanks Qinsheng for driving, +1 for the feature freeze date. I am happy to assist with any release duties. Best Regards Ahmed Hamdy On Wed, 8 May 2024 at 10:50, Jiabao Sun wrote: > Thanks Qingsheng, > > Improving stability is crucial for Flink CDC, looking forward to this

Re: [DISCUSS] FLIP-451: Refactor Async sink API

2024-05-06 Thread Ahmed Hamdy
d we add a list of possible connectors that this FLIP would improve? Good call, I have added under migration plan. Best Regards Ahmed Hamdy On Mon, 6 May 2024 at 08:49, Muhammet Orazov wrote: > Hey Ahmed, > > Thanks for the FLIP! +1 (non-binding) > > > Additionally the cu

Re: [DISCUSS] FLIP-451: Refactor Async sink API

2024-05-04 Thread Ahmed Hamdy
Hi Jeyhun, I have changed the scope of FLIP to exclude problems addressed by FLIP-284 and redefined scope to introduce timeout configuration. Best Regards Ahmed Hamdy On Mon, 29 Apr 2024 at 20:57, Ahmed Hamdy wrote: > Hi Jeyhun, > Thanks for your feedback. I agree the phrasing is

Re: [Vote] FLIP-438: Amazon SQS Sink Connector

2024-05-04 Thread Ahmed Hamdy
Hi Priya, It seems that we have acquired the threshold of binding votes, Should we close the vote, announce the result and create Jiras? Best Regards Ahmed Hamdy On Wed, 17 Apr 2024 at 03:24, Leonard Xu wrote: > +1 (binding) > > Best, > Leonard > > > 2024年4月17日 上午2:

Re: [VOTE] FLIP-436: Introduce Catalog-related Syntax

2024-05-04 Thread Ahmed Hamdy
+1 (non-binding) Best Regards Ahmed Hamdy On Sat, 27 Apr 2024 at 02:46, Muhammet Orazov wrote: > > Hey Yubin, +1 (non-binding) > > Looks good, thanks! > > Best, > Muhammet > > On 2024-04-24 08:56, Yubin Li wrote: > > Hi everyone, > > > > Durin

Re: [VOTE] FLIP-446: Kubernetes Operator State Snapshot CRD

2024-05-04 Thread Ahmed Hamdy
+1 (non-binding) Best Regards Ahmed Hamdy On Sat, 27 Apr 2024 at 05:33, ConradJam wrote: > +1 (non-binding) > > Biao Geng 于2024年4月26日周五 18:45写道: > > > +1 (non-binding) > > > > Best, > > Biao Geng > > > > > > gongzhongqi

Re: [VOTE] FLIP-454: New Apicurio Avro format

2024-05-04 Thread Ahmed Hamdy
+1 (non-binding) Best Regards Ahmed Hamdy On Fri, 3 May 2024 at 15:16, Jeyhun Karimov wrote: > +1 (non binding) > > Thanks for driving this FLIP David. > > Regards, > Jeyhun > > On Fri, May 3, 2024 at 2:21 PM Mark Nuttall wrote: > > > +1, I would also like to

Re: [VOTE] Apache Flink CDC Release 3.1.0, release candidate #1

2024-05-04 Thread Ahmed Hamdy
Hi Qisheng, +1 (non-binding) - Verified checksums and hashes - Verified signatures - Verified github tag exists - Verified no binaries in source - build source Best Regards Ahmed Hamdy On Fri, 3 May 2024 at 23:03, Jeyhun Karimov wrote: > Hi Qinsheng, > > Thanks for driving th

Re: [DISCUSS] FLIP-453: Promote Unified Sink API V2 to Public and Deprecate SinkFunction

2024-05-04 Thread Ahmed Hamdy
the blockers are implemented? Best Regards Ahmed Hamdy On Fri, 3 May 2024 at 14:32, Péter Váry wrote: > > With regards to FLINK-35149, the fix version indicates a change at Flink > CDC; is that indeed correct, or does it require a change in the SinkV2 > interface? > > The fix d

Re: [DISCUSS] FLIP-451: Refactor Async sink API

2024-04-29 Thread Ahmed Hamdy
Hi Jeyhun, Thanks for your feedback. I agree the phrasing is a bit confusing, the main scope for FLIP-451 is limited to introducing timeout configuration and the new "ResultHandler" to Async Sink API. I will remove reference to FLIP-284 from the FLIP to disambiguate. Best Regards A

[DISCUSS] FLIP-451: Refactor Async sink API

2024-04-29 Thread Ahmed Hamdy
requests. The FLIP targets 1.20 with backward compatible changes and we should proceed by adding support in all supporting connector repos. 1- https://cwiki.apache.org/confluence/display/FLINK/FLIP-451%3A+Refactor+Async+Sink+API Best Regards Ahmed Hamdy

Re: [ DISCUSS ] FLIP-XXX : [Plugin] Enhancing Flink Failure Management in Kubernetes with Dynamic Termination Log Integration

2024-04-24 Thread Ahmed Hamdy
enrichers into reference. Best Regards Ahmed Hamdy On Tue, 23 Apr 2024 at 15:23, Martijn Visser wrote: > From a procedural point of view, we shouldn't make FLIPs sub-tasks for > existing FLIPs that have been voted/are released. That will only cause > confusion down the line. A new FLIP sh

Re: [VOTE] Release flink-connector-cassandra v3.2.0, release candidate #1

2024-04-24 Thread Ahmed Hamdy
Thanks Danny, +1 (non-binding) - Verified Checksums and hashes - Verified Signatures - Reviewed web PR - github tag exists - Build source Best Regards Ahmed Hamdy On Tue, 23 Apr 2024 at 03:57, Muhammet Orazov wrote: > Thanks! +1 (non-binding) > > - Checked 512 hash > - Checked g

Re: [VOTE] Release flink-connector-kafka v3.2.0, release candidate #1

2024-04-24 Thread Ahmed Hamdy
Thanks Danny, +1 (non-binding) - Verified Checksums and hashes - Verified Signatures - Reviewed web PR - github tag exists - Build source Best Regards Ahmed Hamdy On Tue, 23 Apr 2024 at 03:47, Muhammet Orazov wrote: > Thanks Danny, +1 (non-binding) > > - Checked 512 hash > -

Re: [VOTE] FLIP-436: Introduce Catalog-related Syntax

2024-04-24 Thread Ahmed Hamdy
Hi, +1 (non-binding) Best Regards Ahmed Hamdy On Wed, 24 Apr 2024 at 09:58, Yubin Li wrote: > Hi everyone, > > During the implementation of the "describe catalog" syntax, it was > found that the original output style needed to be improved. > ``` >

Re: [VOTE] Release flink-connector-aws v4.3.0, release candidate #2

2024-04-22 Thread Ahmed Hamdy
Thanks Danny, +1 (non-binding) - Verified Checksums - Verified Signatures - No binaries exists in source archive - Built source - Reviewed Web PR - Run basic Kinesis example Best Regards Ahmed Hamdy On Sun, 21 Apr 2024 at 14:25, Hang Ruan wrote: > +1 (non-binding) > > - Validated

Re: [VOTE] FLIP-442: General Improvement to Configuration for Flink 2.0

2024-04-18 Thread Ahmed Hamdy
+1 (non-binding) Great work! Best Regards Ahmed Hamdy On Wed, 17 Apr 2024 at 14:36, Jeyhun Karimov wrote: > +1 (non binding) > > Regards, > Jeyhun > > On Wed, Apr 17, 2024 at 2:22 PM Zhu Zhu wrote: > > > +1 (binding) > > > > Thanks, > >

Re: [ DISCUSS ] FLIP-XXX : [Plugin] Enhancing Flink Failure Management in Kubernetes with Dynamic Termination Log Integration

2024-04-18 Thread Ahmed Hamdy
-304%3A+Pluggable+Failure+Enrichers Best Regards Ahmed Hamdy On Thu, 18 Apr 2024 at 08:23, Gyula Fóra wrote: > Hi Swathi! > > Thank you for creating this proposal. I really like the general idea of > increasing the K8s native observability of Flink job errors. > > I took a

Re: [VOTE] Release flink-connector-mongodb v1.2.0, release candidate #2

2024-04-18 Thread Ahmed Hamdy
+1 (non-binding) - verified hashes and checksums - verified signature - verified source contains no binaries - tag exists in github - reviewed web PR Best Regards Ahmed Hamdy On Thu, 18 Apr 2024 at 11:21, Danny Cranmer wrote: > Hi everyone, > > Please review and vote on th

Re: [VOTE] Release flink-connector-jdbc v3.2.0, release candidate #2

2024-04-18 Thread Ahmed Hamdy
+1 (non-binding) - Verified Checksums and hashes - Verified Signatures - No binaries in source - Build source - Github tag exists - Reviewed Web PR Best Regards Ahmed Hamdy On Thu, 18 Apr 2024 at 11:22, Danny Cranmer wrote: > Sorry for typos: > > > Please review and vote on

Re: [DISCUSS] FLIP-445: Support dynamic parallelism inference for HiveSource

2024-04-18 Thread Ahmed Hamdy
Hi Xia, I have read through the FLIP and discussion and the new version of the FLIP looks better. +1 for the proposal. Best Regards Ahmed Hamdy On Thu, 18 Apr 2024 at 12:21, Ron Liu wrote: > Hi, Xia > > Thanks for updating, looks good to me. > > Best, > Ron > > Xia Su

Re: [VOTE] Release flink-connector-gcp-pubsub v3.1.0, release candidate #1

2024-04-18 Thread Ahmed Hamdy
Hi Danny, +1 (non-binding) - verified hashes and checksums - verified signature - verified source contains no binaries - tag exists in github - reviewed web PR Best Regards Ahmed Hamdy On Thu, 18 Apr 2024 at 11:32, Danny Cranmer wrote: > Hi everyone, > > Please review and vote o

Re: [VOTE] Release flink-connector-aws v4.3.0, release candidate #1

2024-04-17 Thread Ahmed Hamdy
Hi Danny, Thanks for driving this. +1 (non-binding) - Checksum verified - Signature and Keys match - Licenses checked - Build from source - Run Kinesis example - Reviewed web PR Best Regards Ahmed Hamdy On Tue, 16 Apr 2024 at 13:01, Jeyhun Karimov wrote: > +1 (non-binding) > > -

Re: [VOTE] FLIP-435: Introduce a New Materialized Table for Simplifying Data Pipelines

2024-04-17 Thread Ahmed Hamdy
+ 1 (non-binding) Best Regards Ahmed Hamdy On Wed, 17 Apr 2024 at 08:28, Yuepeng Pan wrote: > +1(non-binding). > > > > > Best, > Yuepeng Pan > > At 2024-04-17 14:27:27, "Ron liu" wrote: > >Hi Dev, > > > >Thank you to everyone for th

Re: [ANNOUNCE] New Apache Flink Committer - Zakelly Lan

2024-04-15 Thread Ahmed Hamdy
Congratulations, Zakelly Best Regards Ahmed Hamdy On Mon, 15 Apr 2024 at 07:56, Hangxiang Yu wrote: > Congratulations, Zakelly! > > On Mon, Apr 15, 2024 at 1:58 PM Yun Tang wrote: > > > Congratulations, Zakelly! > > > > Best > > Yun Tang > >

Re: [Vote] FLIP-438: Amazon SQS Sink Connector

2024-04-14 Thread Ahmed Hamdy
Hi Priya +1 (non-binding) Best Regards Ahmed Hamdy On Fri, 12 Apr 2024 at 22:56, Dhingra, Priya wrote: > Hi devs, > > > > Thank you to everyone for the feedback on FLIP-438: Amazon SQS Sink > Connector< > https://cwiki.apache.org/confluence/display/FLINK/FLIP-438%3A+A

Re: [ANNOUNCE] New Apache Flink PMC Member - Lincoln Lee

2024-04-12 Thread Ahmed Hamdy
Congratulations Lincoln! Best Regards Ahmed Hamdy On Fri, 12 Apr 2024 at 11:09, yuxia wrote: > Congratulations, Lincoln! > > Best regards, > Yuxia > > - 原始邮件 - > 发件人: "Feng Jin" > 收件人: "dev" > 发送时间: 星期五, 2024年 4 月 12日 下午 5:23:40 &

Re: [ANNOUNCE] New Apache Flink PMC Member - Jing Ge

2024-04-12 Thread Ahmed Hamdy
Congratulations, Jing! Best Regards Ahmed Hamdy On Fri, 12 Apr 2024 at 10:46, weijie guo wrote: > Congratulations, Jing! > > Best regards, > > Weijie > > > Feng Jin 于2024年4月12日周五 17:24写道: > > > Congratulations, Jing > > > > Best, > > Feng Jin

Re: [DISCUSS] FLIP-438: Amazon SQS Sink Connector

2024-04-11 Thread Ahmed Hamdy
://nightlies.apache.org/flink/flink-docs-master/docs/connectors/datastream/guarantees/> > < > https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/datastream/guarantees/ > ;> > [2] > > https://docs.aws.amazon.com/AWSSimpleQueueService/latest/APIReference/API

Re: [VOTE] FLIP-441: Show the JobType and remove Execution Mode on Flink WebUI

2024-04-10 Thread Ahmed Hamdy
+1 (non-binding) Best Regards Ahmed Hamdy On Wed, 10 Apr 2024 at 06:39, Zhu Zhu wrote: > +1 > > Thanks, > Zhu > > gongzhongqiang 于2024年4月10日周三 13:11写道: > > > +1 (non binding) > > > > > > Bests, > > > > Zhongqiang Gong > > > &g

Re: Iceberg table maintenance

2024-04-09 Thread Ahmed Hamdy
Thanks Peter for forwarding this. Best Regards Ahmed Hamdy On Tue, 9 Apr 2024 at 05:51, Péter Váry wrote: > Forwarding the invite for the discussion we plan to do with the Iceberg > folks, as some of you might be interested in this. > > -- Forwarded message - &

Re: [VOTE] FLIP-399: Flink Connector Doris

2024-04-09 Thread Ahmed Hamdy
Hi Wudi, +1 (non-binding). Best Regards Ahmed Hamdy On Tue, 9 Apr 2024 at 09:21, Yuepeng Pan wrote: > Hi, Di. > > Thank you for driving it ! > > +1 (non-binding). > > Best, > Yuepeng Pan > > On 2024/04/09 02:47:55 wudi wrote: > > Hi devs, > > >

Re: [DISCUSS] Externalized Google Cloud Connectors

2024-04-08 Thread Ahmed Hamdy
Hi Claire, I am in favor of Martijn and Leonard's points, it is better to follow aws connectors and keep it under ASF. Do you have other suggestions for connectors than pub/sub at the moment? Best Regards Ahmed Hamdy On Thu, 4 Apr 2024 at 08:38, Martijn Visser wrote: > Hi Lorenzo, > &

Re: [DISCUSS] FLIP-441: Show the JobType and remove Execution Mode on Flink WebUI

2024-04-08 Thread Ahmed Hamdy
Acknowledged, +1 to start a vote. Best Regards Ahmed Hamdy On Mon, 8 Apr 2024 at 12:04, Rui Fan <1996fan...@gmail.com> wrote: > Sorry, it's a typo. It should be FLINK-32558[1]. > > [1] https://issues.apache.org/jira/browse/FLINK-32558 > > Best, > Rui > > On Mon

Re: [VOTE] Release flink-connector-rabbitmq, v3.0.2 release candidate #1

2024-04-08 Thread Ahmed Hamdy
Hi Martijn, Sorry for joining late, +1 (non-binding) - Verified Checksums and Signatures - Verified no binaries in archive - Built source successfully - Checked tag correctly in github - reviewed web PR Best Regards Ahmed Hamdy On Mon, 15 Jan 2024 at 13:54, Danny Cranmer wrote: >

Re: [DISCUSS] FLIP-441: Show the JobType and remove Execution Mode on Flink WebUI

2024-04-08 Thread Ahmed Hamdy
Hi Rui, Thanks for the proposal. Is the deprecation Jira mentioned (FLINK-32258) correct? Best Regards Ahmed Hamdy On Sun, 7 Apr 2024 at 03:37, Rui Fan <1996fan...@gmail.com> wrote: > If there are no extra comments, I will start voting in three days, thank > you~ > > Best, >

[jira] [Created] (FLINK-35050) Remove Lazy Initialization of DynamoDbBeanElementConverter

2024-04-08 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-35050: --- Summary: Remove Lazy Initialization of DynamoDbBeanElementConverter Key: FLINK-35050 URL: https://issues.apache.org/jira/browse/FLINK-35050 Project: Flink

[jira] [Created] (FLINK-35022) Add TypeInformed Element Converter for DynamoDbSink

2024-04-06 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-35022: --- Summary: Add TypeInformed Element Converter for DynamoDbSink Key: FLINK-35022 URL: https://issues.apache.org/jira/browse/FLINK-35022 Project: Flink Issue Type

Re: [DISCUSS] FLIP-438: Amazon SQS Sink Connector

2024-04-06 Thread Ahmed Hamdy
I would love to assist with the implementation and reviews if this FLIP was accepted. Best Regards Ahmed Hamdy On Fri, 5 Apr 2024 at 19:19, Dhingra, Priya wrote: > Hi Dev, > > I would like to start a discussion about FLIP-438: Amazon SQS Sink > Connector< > https://cwiki.apache.org/confluence

Re: [ANNOUNCE] Apache Paimon is graduated to Top Level Project

2024-03-28 Thread Ahmed Hamdy
Congratulations! Best Regards Ahmed Hamdy On Thu, 28 Mar 2024 at 08:16, Paul Lam wrote: > Congrats! > > Best, > Paul Lam > > > 2024年3月28日 16:03,Rui Fan <1996fan...@gmail.com> 写道: > > > > Congratulations~ > > > > Best, > > Rui > >

Re: [DISCUSS] Migrate Kinesis Table API source to KDS client

2024-03-24 Thread Ahmed Hamdy
Hi Aleks, Thanks for the valuable feedback, yeah I agree it might be confusing for some users. Best Regards Ahmed Hamdy On Sun, 24 Mar 2024 at 18:40, Aleksandr Pilipenko wrote: > Hi Ahmed, thank you for starting this discussion. > > In general, I am more inclined toward proposal 2

[DISCUSS] Migrate Kinesis Table API source to KDS client

2024-03-24 Thread Ahmed Hamdy
ed. Once all other features are implemented we migrate the factory as well. Proposal 2: We do nothing and wait for all features to be implemented. Let me know your thoughts. 1- https://issues.apache.org/jira/browse/FLINK-31813 2- https://issues.apache.org/jira/browse/FLINK-31987 Best Regards Ahmed Hamdy

Re: [VOTE] FLIP-433: State Access on DataStream API V2

2024-03-24 Thread Ahmed Hamdy
+1 (non-binding) Best Regards Ahmed Hamdy On Thu, 21 Mar 2024 at 10:45, Jinzhong Li wrote: > +1 (non-binding) > > Best, > Jinzhong > > On Thu, Mar 21, 2024 at 6:15 PM Zakelly Lan wrote: > > > +1 non-binding > > > > > > Best, > > Zakelly

Re: [DISCUSS] Planning Flink 1.20

2024-03-24 Thread Ahmed Hamdy
+1 for the proposed timeline and release managers. Best Regards Ahmed Hamdy On Fri, 22 Mar 2024 at 07:41, Xintong Song wrote: > +1 for the proposed timeline and Weijie & Rui as the release managers. > > I think it would be welcomed if another 1-2 volunteers join as the relea

Re: [DISCUSS] FLIP-437: Support ML Models in Flink SQL

2024-03-23 Thread Ahmed Hamdy
Hi everyone, +1 for this proposal, I believe it is very useful to the minimum, It would be great even having "ML_PREDICT" and "ML_EVALUATE" as built-in PTFs in this FLIP as discussed. IIUC this will be included in the 1.20 roadmap? Best Regards Ahmed Hamdy On Fri, 22 Mar 2

Re: [DISCUSS] FLIP-435: Introduce a New Dynamic Table for Simplifying Data Pipelines

2024-03-22 Thread Ahmed Hamdy
the FLIP an example where the table is further used in subsequent queries (specially in batch mode). - I really like the standard of keeping the unified batch and streaming approach Best Regards Ahmed Hamdy On Fri, 22 Mar 2024 at 12:07, Lincoln Lee wrote: > Hi Timo, > > Thanks for yo

Re: [ANNOUNCE] Donation Flink CDC into Apache Flink has Completed

2024-03-21 Thread Ahmed Hamdy
Congratulations, great work and great news. Best Regards Ahmed Hamdy On Thu, 21 Mar 2024 at 11:41, Benchao Li wrote: > Congratulations, and thanks for the great work! > > Yuan Mei 于2024年3月21日周四 18:31写道: > > > > Thanks for driving these efforts! > > > > Cong

Re: [ANNOUNCE] Apache Flink 1.19.0 released

2024-03-18 Thread Ahmed Hamdy
Congratulations! Best Regards Ahmed Hamdy On Mon, 18 Mar 2024 at 12:30, Xintong Song wrote: > Congratulations~! > > Best, > > Xintong > > > > On Mon, Mar 18, 2024 at 7:02 PM Feng Jin wrote: > > > Congratulations! > > > > Best, > > Fe

Re: [VOTE] FLIP-420: Add API annotations for RocksDB StateBackend user-facing classes

2024-03-13 Thread Ahmed Hamdy
Hi Jinzhong, Thanks for driving this, +1 (non-binding) Best Regards Ahmed Hamdy On Wed, 13 Mar 2024 at 01:33, Jing Ge wrote: > +1 (binding) Thanks! > > Best regards, > Jing > > On Sun, Mar 10, 2024 at 5:32 PM Jing Ge wrote: > > > Hi Jinzhong, > > > >

Re: [DISCUSS] FLIP-399: Flink Connector Doris

2024-03-11 Thread Ahmed Hamdy
Hello, Thanks for the proposal, +1 for the FLIP. Best Regards Ahmed Hamdy On Mon, 11 Mar 2024 at 15:12, wudi <676366...@qq.com.invalid> wrote: > Hi, Leonard > Thank you for your suggestion. > I referred to other Connectors[1], modified the naming and types of > relevant param

Re: [VOTE] Release 1.19.0, release candidate #2

2024-03-11 Thread Ahmed Hamdy
Hi Lincoln +1 (non-binding) from me - Verified Checksums & Signatures - Verified Source dists don't contain binaries - Built source successfully - reviewed web PR Best Regards Ahmed Hamdy On Mon, 11 Mar 2024 at 15:18, Lincoln Lee wrote: > Hi Robin, > > Thanks for help

Re: [DISCUSS] Externalized Python Connector Release/Dependency Process

2024-01-09 Thread Ahmed Hamdy
Hi Danny +1 (non-binding) Best Regards Ahmed Hamdy On Tue, 9 Jan 2024 at 11:59, Xingbo Huang wrote: > Hi Danny, > > +1 > > Thanks a lot for investigating this. Let me share the current code > management and release situation of pyflink here. I hope it will be helpful > to

Re: [VOTE] Release flink-connector-aws, v4.2.0 release candidate #1

2023-11-26 Thread Ahmed Hamdy
Hi Danny +1 (non-binding) - Verified signatures and checksums - verified no binaries exists in archive - built source - reviewed web PR - Ran E2E example with Kinesis, Firehose & DynamoDB datastream connectors. Best Regards Ahmed Hamdy On Fri, 24 Nov 2023 at 08:38, Martijn Visser w

Re: [VOTE] Release flink-connector-gcp-pubsub v3.0.2, release candidate #1

2023-11-06 Thread Ahmed Hamdy
+1(non-binding) -Checked release notes - Verified checksums and signatures - Verified no binaries in release - Build connector from source - Reviewed web PR. Best Regards Ahmed Hamdy On Fri, 3 Nov 2023 at 11:23, Danny Cranmer wrote: > Hi everyone, > > Please review and vote on th

Re: [VOTE] Release flink-connector-opensearch v1.1.0, release candidate #1

2023-11-06 Thread Ahmed Hamdy
Hi Danny, +1 (non-binding) - Checked release notes - Verified Checksums and Signature - Checked no binaries in release. - Reviewed web PR - Build Connector from source. Best Regards Ahmed Hamdy On Fri, 3 Nov 2023 at 13:05, Andriy Redko wrote: > +1 (non-binding), thanks a lot Danny! >

Re: [VOTE] Apache Flink Kafka connector version 3.0.1, RC1

2023-10-30 Thread Ahmed Hamdy
+1 (non-binding) - Verified Singatures - Verified Checksum - Build source successfully - Checked release tag exists - Reviewed the web PR Best Regards Ahmed Hamdy On Sun, 29 Oct 2023 at 08:02, Leonard Xu wrote: > +1 (binding) > > - Verified signatures > - Verified hashsums > -

Re: [VOTE] FLIP-239: Port JDBC Connector to FLIP-27-143

2023-10-13 Thread Ahmed Hamdy
+1(non-binding) Regards Ahmed On Fri, 13 Oct 2023, 10:49 Qingsheng Ren, wrote: > +1 (binding) > > Thanks for the work, Joao! > > Best, > Qingsheng > > > On Oct 12, 2023, at 19:32, Leonard Xu wrote: > > > > Thanks Joao for driving this work. > > > > +1 (binding) > > > > Best, > > Leonard > > >

Re: [VOTE] FLIP-367: Support Setting Parallelism for Table/SQL Sources

2023-10-09 Thread Ahmed Hamdy
+1 (non-binding) Best Regards Ahmed Hamdy On Mon, 9 Oct 2023 at 09:38, xiangyu feng wrote: > +1 (non-binding) > > Feng Jin 于2023年10月9日周一 16:00写道: > > > +1 (non-binding) > > > > Best, > > Feng > > > > On Mon, Oct 9, 2023 at 3:12 PM Yangze Guo

  1   2   >