Re: [VOTE] FLIP-295: Support lazy initialization of catalogs and persistence of catalog configurations

2023-06-14 Thread Hang Ruan
+1 (non-binding) Thanks for Feng driving it. Best, Hang Feng Jin 于2023年6月14日周三 10:36写道: > Hi everyone > > Thanks for all the feedback about the FLIP-295: Support lazy initialization > of catalogs and persistence of catalog configurations[1]. > [2] is the discussion thread. > > > I'd like to

Re: [DISCUSS] FLIP 295: Support persistence of Catalog configuration and asynchronous registration

2023-06-09 Thread Hang Ruan
; > >>>>> 3. About the open/close method in CatalogStoreFactory. > > >>>> > > >>>> I also agree with the proposed requirement scenario and design. I > have > > >>>> already made modifications to the interface. > > >

Re: [DISCUSS] FLIP 295: Support persistence of Catalog configuration and asynchronous registration

2023-06-02 Thread Hang Ruan
> > > > affect it. Point 6 described follow-up options for further > > > > > > improvement. > > > > > > > > > > > > > > > > > > Best regards, > > > > > > > > > Jing > > > > &

Re: [VOTE] Release 1.16.2, release candidate #1

2023-05-23 Thread Hang Ruan
+1(non-binding) - reviewed Jira release notes - built from source - verified signatures - verified hashes - verified that no binary exist in the source archive - run streaming job in sql-client successfully Best, Hang Samrat Deb 于2023年5月23日周二 16:23写道: > +1 (non-binding) > > - Verified

Re: [VOTE] FLIP-288: Enable Dynamic Partition Discovery by Default in Kafka Source

2023-04-23 Thread Hang Ruan
+1 (non-binding) Best, Hang Paul Lam 于2023年4月23日周日 11:58写道: > +1 (non-binding) > > Best, > Paul Lam > > > 2023年4月23日 10:57,Shammon FY 写道: > > > > +1 (non-binding) > > > > Best, > > Shammon FY > > > > On Sun, Apr 23, 2023 at 10:35 AM Qingsheng Ren > wrote: > > > >>

Re: [ANNOUNCE] New Apache Flink PMC Member - Leonard Xu

2023-04-23 Thread Hang Ruan
Congratulations, Leonard. Best, Hang Yanfei Lei 于2023年4月23日周日 18:34写道: > Congratulations, Leonard! > > Best, > Yanfei > > liu ron 于2023年4月23日周日 17:45写道: > > > > Congratulations, Leonard. > > > > Best, > > Ron > > > > Zhanghao Chen 于2023年4月23日周日 17:33写道: > > > > > Congratulations, Leonard! >

Re: [ANNOUNCE] New Apache Flink PMC Member - Qingsheng Ren

2023-04-23 Thread Hang Ruan
Congratulations, Qingsheng! Best, Hang Yanfei Lei 于2023年4月23日周日 18:33写道: > Congratulations, Qingsheng! > > Best, > Yanfei > > liu ron 于2023年4月23日周日 17:47写道: > > > > Congratulations, Qingsheng. > > > > Best, > > Ron > > > > Zhanghao Chen 于2023年4月23日周日 17:32写道: > > > > > Congratulations,

Re: Re: [VOTE] FLIP-302: Support TRUNCATE TABLE statement in batch mode

2023-04-18 Thread Hang Ruan
+1 (no-binding) Best, Hang Shammon FY 于2023年4月18日周二 13:33写道: > +1 (no-binding) > > Best, > Shammon FY > > On Tue, Apr 18, 2023 at 12:56 PM Jacky Lau wrote: > > > +1 (no-binding) > > > > Best, > > Jacky Lau > > > > Jingsong Li 于2023年4月18日周二 11:57写道: > > > > > +1 > > > > > > On Tue, Apr 18,

Re: Need Help with Slack Invite Link

2023-04-17 Thread Hang Ruan
Hi, Madhur, I create a new invite link https://join.slack.com/t/apache-flink/shared_invite/zt-1t4khgllz-Fm1CnXzdBbUchBz4HzJCAg . Hope it is useful. Best, Hang Madhur Pyasi 于2023年4月16日周日 05:03写道: > Hello Flink Community, > I am trying to use the slack invite to join the Flink workspace but the

Re: [DISCUSS] Releasing connectors for Flink 1.17

2023-04-03 Thread Hang Ruan
Hi Denny, I could help with JDBC connectors. Thanks~ Best, Hang Danny Cranmer 于2023年4月3日周一 17:57写道: > Hi everyone, > > I have created Jiras to investigate each failing build. Thanks Andriy, I > have assigned the Elasticsearch/Opensearch ones to you. Let me know if you > do not have capacity.

Re: [DISCUSS] FLIP 295: Support persistence of Catalog configuration and asynchronous registration

2023-03-30 Thread Hang Ruan
Hi Feng, Thanks for driving this FLIP. I have some questions about this FLIP: 1. I agree with Shammon's comment. The two methods `registerCatalog(String catalogName,Catalog catalog)` and `registerCatalog(String catalogName, Map properties)` make users confused. I think we should add a method

Re: [ANNOUNCE] Flink Table Store Joins Apache Incubator as Apache Paimon(incubating)

2023-03-27 Thread Hang Ruan
Congratulations! Best, Hang yu zelin 于2023年3月28日周二 10:27写道: > Congratulations! > > Best, > Yu Zelin > > 2023年3月27日 17:23,Yu Li 写道: > > Dear Flinkers, > > > > As you may have noticed, we are pleased to announce that Flink Table Store > has joined the Apache Incubator as a separate project

[jira] [Created] (FLINK-31615) Fix some parts forgot to translate in "Table API" page of "Table API & SQL"

2023-03-26 Thread Hang Ruan (Jira)
Hang Ruan created FLINK-31615: - Summary: Fix some parts forgot to translate in "Table API" page of "Table API & SQL" Key: FLINK-31615 URL: https://issues.apache.org/jira/browse/FLINK-31

Re: [ANNOUNCE] Apache Flink 1.17.0 released

2023-03-25 Thread Hang Ruan
Thanks for the great work ! Congrats all! Best, Hang Panagiotis Garefalakis 于2023年3月25日周六 03:22写道: > Congrats all! Well done! > > Cheers, > Panagiotis > > On Fri, Mar 24, 2023 at 2:46 AM Qingsheng Ren wrote: > > > I'd like to say thank you to all contributors of Flink 1.17. Your support > >

Re: Is there a way to control the parallelism of auto-generated Flink operators of the FlinkSQL job graph?

2023-03-24 Thread Hang Ruan
Hi, Elkhan, I think this is an intended behavior. If the parallelism of an operator is not specified, it will be the same as the previous one instead of the default parallelism. Actually the table planner will help us to do most jobs. There should not be a way to modify the parallelism for every

Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statement

2023-03-23 Thread Hang Ruan
Hi, yuxia, Thanks for starting the discussion. I wonder what the behavior is when we truncate a table which is used as a source. Source table and sink table may have different table options. IMO, the truncate sql should be supported no matter which kind the table is. Best, Hang Shammon FY

[jira] [Created] (FLINK-31559) Update the flink version to 1.18-SNAPSHOT in flink-connector-kafka

2023-03-22 Thread Hang Ruan (Jira)
Hang Ruan created FLINK-31559: - Summary: Update the flink version to 1.18-SNAPSHOT in flink-connector-kafka Key: FLINK-31559 URL: https://issues.apache.org/jira/browse/FLINK-31559 Project: Flink

Re: [DISCUSS] FLIP-288:Enable Dynamic Partition Discovery by Default in Kafka Source

2023-03-21 Thread Hang Ruan
Hi, Hongshun, Thank you for starting this discussion. I have some problems about the field `firstDiscoveryDone`. In the FLIP, why we need firstDiscoveryDone is as follows. > Why do we need firstDiscoveryDone? Only relying on the unAssignedInitialPartitons attribute cannot distinguish between

Re: [VOTE] FLIP-296: Extend watermark-related features for SQL

2023-03-20 Thread Hang Ruan
+1 (non-binding) Best, Hang 何军 于2023年3月21日周二 11:42写道: > +1 > > Leonard Xu 于2023年3月21日周二 11:35写道: > > > > > +1(binding) > > > > minor: The first SQL piece of the FLIP is incorrect as the column name > > current_time is a system built-in function. > > > > Best, > > Leonard > > > > > On Mar 21,

[jira] [Created] (FLINK-31511) Translate documentation sql_functions_zh.yml to the latest version

2023-03-18 Thread Hang Ruan (Jira)
Hang Ruan created FLINK-31511: - Summary: Translate documentation sql_functions_zh.yml to the latest version Key: FLINK-31511 URL: https://issues.apache.org/jira/browse/FLINK-31511 Project: Flink

Re: [VOTE] FLIP-293: Introduce Flink Jdbc Driver For Sql Gateway

2023-03-15 Thread Hang Ruan
+1 (non-binding) Best, Hang Leonard Xu 于2023年3月15日周三 15:53写道: > Thanks shammon for driving this FLIP. > > +1 (binding) > > Best, > Leonard > > On Wed, Mar 15, 2023 at 1:36 PM weijie guo > wrote: > > > +1 (binding) > > > > Best regards, > > > > Weijie > > > > > > Jacky Lau 于2023年3月15日周三

Re: [VOTE] FLIP-300: Add targetColumns to DynamicTableSink#Context to solve the null overwrite problem of partial-insert

2023-03-13 Thread Hang Ruan
+1 (non-binding) Best, Hang yuxia 于2023年3月13日周一 20:52写道: > +1 (binding) > Thanks Lincoln Lee for driving it. > > Best regards, > Yuxia > > - 原始邮件 - > 发件人: "Lincoln Lee" > 收件人: "dev" > 发送时间: 星期一, 2023年 3 月 13日 下午 8:17:52 > 主题: [VOTE] FLIP-300: Add targetColumns to

Re: [ANNOUNCE] New Apache Flink Committer - Yuxia Luo

2023-03-12 Thread Hang Ruan
Congratulations, Yuxia! Best, Hang Guowei Ma 于2023年3月13日周一 10:55写道: > congratulations Yuxia > Best, > Guowei > > > On Mon, Mar 13, 2023 at 10:43 AM Junrui Lee wrote: > > > Congratulations, Yuxia! > > > > Best, > > Junrui > > > > Yanfei Lei 于2023年3月13日周一 10:42写道: > > > > > Congratulations,

Re: Flink metric collection

2023-03-09 Thread Hang Ruan
Hi, Atul, I think the metric reporter[1] will be helpful for you. Best, Hang [1] https://nightlies.apache.org/flink/flink-docs-release-1.16/docs/deployment/metric_reporters/ Atul Lal 于2023年3月9日周四 17:49写道: > Hi everyone, > > I am trying to do some experiments with Flink. I am trying to modify

Re: [VOTE] FLIP-297: Improve Auxiliary Sql Statements

2023-03-07 Thread Hang Ruan
Thanks for Ran's work. +1 (non-binding). Best, Hang Ran Tao 于2023年3月7日周二 15:59写道: > thanks Lau. > > The vote will last for at least 72 hours (03/09, 19:30 UTC+8). > It needs consensus approval, requiring 3 binding +1 votes and no > binding vetoes. > > > Best Regards, > Ran Tao > > > Jacky Lau

Re: [DISCUSS] FLIP-300: Add targetColumns to DynamicTableSink#Context to solve the null overwrite problem of partial-insert

2023-03-06 Thread Hang Ruan
Hi, Lincoln, Thanks for bringing this up. It looks good to me. I also agree with Jingsong's suggestion. Best, Hang Jingsong Li 于2023年3月7日周二 11:15写道: > Wow, we have 300 FLIPs... > > Thanks Lincoln, > > Have you considered returning an Optional? > > Empty array looks a little weird to me. > >

[jira] [Created] (FLINK-31268) OperatorCoordinator.Context#metricGroup will return null when restore from a savepoint

2023-02-28 Thread Hang Ruan (Jira)
Hang Ruan created FLINK-31268: - Summary: OperatorCoordinator.Context#metricGroup will return null when restore from a savepoint Key: FLINK-31268 URL: https://issues.apache.org/jira/browse/FLINK-31268

Re: [DISCUSS] Deprecate deserialize method in DeserializationSchema

2023-02-27 Thread Hang Ruan
Hi, Shammon, I think the method `void deserialize(byte[] message, Collector out)` with a default implementation encapsulate how to deal with null for developers. If we remove the `T deserialize(byte[] message)`, the developers have to remember to handle null. Maybe we will get duplicate code

Re: [ANNOUNCE] New Apache Flink Committer - Sergey Nuyanzin

2023-02-22 Thread Hang Ruan
Congratulations Sergey! Jane Chan 于2023年2月22日周三 15:53写道: > Congratulations, Sergey! > > Best regards, > Jane > > > On Wed, Feb 22, 2023 at 9:44 AM Dian Fu wrote: > > > Congratulations Sergey! > > > > On Tue, Feb 21, 2023 at 9:07 PM Rui Fan wrote: > > > > > Congratulations, Sergey! > > > > > >

Should the sink writer and committer always be chained together

2023-02-17 Thread Hang Ruan
Hi all, I see that some users are finding the way to disable the chain of sink writer and committer [1]. This makes me think about the bug FLINK-29492 [2], which is caused by the operator chaining disabled. When operator chaining disabled, the kafka committer can not return the producers to the

Re: [ANNOUNCE] New Apache Flink PMC Member - Dong Lin

2023-02-15 Thread Hang Ruan
Congratulations, Dong! Best, Hang yuxia 于2023年2月16日周四 15:24写道: > Congratulations, Dong! > > Best regards, > Yuxia > > - 原始邮件 - > 发件人: "Junrui Lee" > 收件人: "dev" > 发送时间: 星期四, 2023年 2 月 16日 下午 2:40:39 > 主题: Re: [ANNOUNCE] New Apache Flink PMC Member - Dong Lin > > Congratulations, Dong!

Re: [ANNOUNCE] New Apache Flink Committer - Jing Ge

2023-02-14 Thread Hang Ruan
Congratulations Jing! Shammon FY 于2023年2月14日周二 16:04写道: > Congratulations Jing! > > Best, > Shammon > > On Tue, Feb 14, 2023 at 4:00 PM weijie guo > wrote: > > > Congratulations Jing! > > > > Best regards, > > > > Weijie > > > > > > Jingsong Li 于2023年2月14日周二 15:54写道: > > > > > Congratulations

Re: [ANNOUNCE] New Apache Flink Committer - Weijie Guo

2023-02-12 Thread Hang Ruan
Congratulations, Weijie! Best, Hang Samrat Deb 于2023年2月13日周一 12:40写道: > Congratulations, Weijie! > > On Mon, 13 Feb 2023 at 10:08 AM, Benchao Li wrote: > > > Congratulations, Weijie! > > > > Rui Fan <1996fan...@gmail.com> 于2023年2月13日周一 12:27写道: > > > > > Congratulations, Weijie! > > > > > >

[RESULT][VOTE] FLIP-274: Introduce metric group for OperatorCoordinator (FLINK-29801)

2023-02-07 Thread Hang Ruan
Hi all, I am happy to announce that FLIP-274: Introduce metric group for OperatorCoordinator (FLINK-29801)[1] has been accepted. There are 5 binding votes and 2 non-binding vote [2]: - Jark Wu (binding) - Chesnay Schepler (binding) - Martijn Visser (binding) - Dong Lin (binding) - Leonard Xu

Re: [Discuss] :Introduce Catalog dynamic registration in flink catalog manager.

2023-02-06 Thread Hang Ruan
Hi Feng, I agree with what Jark said. I think what you are looking for is lazy initialization. I don't think we should introduce the new interface CatalogProvider for lazy initialization. What we should do is to store the catalog properties and initialize the catalog when we need it. Could you

[VOTE] FLIP-274: Introduce metric group for OperatorCoordinator

2023-02-02 Thread Hang Ruan
Hi all, Thanks for all the help about this FLIP. Now let's start the vote again. Based on the discussion[1], we have come to a consensus, so I would like to start a vote on FLIP-274: Introduce metric group for OperatorCoordinator[2]. The vote will last for at least 72 hours (Feb 8th at 11:00

Re: [DISCUSS] FLIP-274 : Introduce metric group for OperatorCoordinator

2023-02-02 Thread Hang Ruan
and discussion make this FLIP clearer and more reasonable. Best, Hang Chesnay Schepler 于2023年2月2日周四 18:44写道: > Looks good from my side. > > On 01/02/2023 13:27, Hang Ruan wrote: > > Hi all, > > > > I make a mistake about the default value of the scope format > > JobMana

Re: [DISCUSS] FLIP-274 : Introduce metric group for OperatorCoordinator

2023-02-01 Thread Hang Ruan
Hi all, I make a mistake about the default value of the scope format JobManagerOperatorScopeFormat. It should be .jobmanager... I have fixed it in the FLIP. And the variables (task id and task name) have been added to the list. Best, Hang Hang Ruan 于2023年2月1日周三 14:11写道: > Hi all, > &g

Re: [DISCUSS] FLIP-274 : Introduce metric group for OperatorCoordinator

2023-01-31 Thread Hang Ruan
Hi all, > IIUC, there is only an OperatorCoordinatorMetricGroup interface without implementations (it never worked). There were no coordinator metrics implemented and registered. @Hang Ruan please correct me if I'm wrong. Yes, we shouldn't have to worry about backwards-compatibility as Ches

Re: [DISCUSS] FLIP-274 : Introduce metric group for OperatorCoordinator

2023-01-28 Thread Hang Ruan
ps as children for coordinators. >> Aka, you have the JMOperatorMG, then you call addGroup("coordinators") >> and then addGroup(coordinator_name) for each coordinator. >> >> > So there are two choice for the >> InternalOperatorCoordinatorMe

Re: [DISCUSS] FLIP-274 : Introduce metric group for OperatorCoordinator

2023-01-18 Thread Hang Ruan
r one to > >>> support it. > >>> > >>> Additionally, the configurable variables (operator name/id) are > >>> logically not attached to the coordinator, but operators, so to me it > >>> just doesn't make sense to structure it like this. >

Re: [DISCUSS] FLIP-274 : Introduce metric group for OperatorCoordinator

2023-01-15 Thread Hang Ruan
rth introducing the interface again and declaring > that > > we will implement the interface instead of a no-op method in this FLIP. > > > > Anyway, this is a minor problem and shouldn’t block this FLIP. I’m +1 to > > start a vote. > > > > Best, > > Jark > >

Re: [VOTE] FLIP-274: Introduce metric group for OperatorCoordinator

2023-01-11 Thread Hang Ruan
ly before being > >>>> allowed forward and making progress. It is hard to image what would > >>> happen > >>>> if every committer can take 30+ days to reply to a FLIP and still > >> expects > >>>> the FLIP to wait for the reply. Flink community will likel

Re: [ANNOUNCE] New Apache Flink Committer - Lincoln Lee

2023-01-09 Thread Hang Ruan
Congratulations, Lincoln! Best, Hang Biao Geng 于2023年1月10日周二 14:57写道: > Congrats, Lincoln! > Best, > Biao Geng > > 获取 Outlook for iOS > > 发件人: Wencong Liu > 发送时间: Tuesday, January 10, 2023 2:39:47 PM > 收件人: dev@flink.apache.org > 主题:

Re: [VOTE] FLIP-274: Introduce metric group for OperatorCoordinator

2023-01-05 Thread Hang Ruan
Best regards, > > > > Martijn > > > > On Wed, Jan 4, 2023 at 2:01 PM Dong Lin wrote: > > > >> Thanks for proposing the FLIP! > >> > >> +1 (binding) > >> > >> Regards, > >> Dong > >> > >> On Wed, Jan

[VOTE] FLIP-274: Introduce metric group for OperatorCoordinator

2023-01-03 Thread Hang Ruan
Hi all, Thanks for all the feedback so far. Based on the discussion[1], we have come to a consensus, so I would like to start a vote on FLIP-274: Introduce metric group for OperatorCoordinator[2]. The vote will last for at least 72 hours (Jan 7th at 11:00 GMT) unless there is an objection or

Re: [DISCUSS] FLIP-274 : Introduce metric group for OperatorCoordinator

2023-01-02 Thread Hang Ruan
ed in the public interface section, it might be useful to explicitly > discuss this topic and document it in the "*What are the "public > interfaces" of the project*" in this > < > https://cwiki.apache.org/confluence/display/FLINK/Flink+Improvement+Proposals > > >

Re: [DISCUSS] FLIP-274 : Introduce metric group for OperatorCoordinator

2022-12-26 Thread Hang Ruan
Hi Hang, > > I still see no strong reason why we need numEventsIn/numEventsOut > metrics. > > In the discussion in FLINK-29801, I can see the same concern from others. > > So I prefer to exclude them from this FLIP to avoid over-extending the > > scope. > >

Re: [DISCUSS] FLIP-274 : Introduce metric group for OperatorCoordinator

2022-12-22 Thread Hang Ruan
the comments. If there are no further comments, we plan to start the voting thread next week. Best, Hang Hang Ruan 于2022年12月15日周四 16:49写道: > Hi, Zhu Zhu, > > Thanks for your feedback! > > The OperatorCoordinator implementations are different. And their metrics > are much different t

Re: [VOTE] FLIP-275: Support Remote SQL Client Based on SQL Gateway

2022-12-20 Thread Hang Ruan
+1 (non-binding) Best, Hang Paul Lam 于2022年12月20日周二 17:36写道: > +1 (non-binding) > > Best, > Paul Lam > > > 2022年12月20日 11:35,Shengkai Fang 写道: > > > > +1(binding) > > > > Best, > > Shengkai > > > > yu zelin 于2022年12月14日周三 20:41写道: > > > >> Hi, all, > >> > >> Thanks for all your feedbacks so

Re: [VOTE] FLIP-208: Add RecordEvaluator to dynamically stop source based on de-serialized records

2022-12-20 Thread Hang Ruan
+1 (non-binding) Best, Hang Dong Lin 于2022年12月21日周三 15:13写道: > Hi all, > > We would like to start the vote for FLIP-208: Add RecordEvaluator to > dynamically stop source based on de-serialized records [1]. This FLIP was > discussed in this thread [2]. > > This feature is needed by users who

Re: [ANNOUNCE] New Apache Flink PMC Members - Godfrey He, Xingbo Huang

2022-12-18 Thread Hang Ruan
Congratulations, Godfrey and Xingbo! Jun Qin 于2022年12月17日周六 03:52写道: > Congratulations to both of you, Godfrey and Xingbo! > > > On Nov 25, 2022, at 1:29 AM, Dong Lin wrote: > > > > Congratulations, Godfrey and Xingbo! > > > > > > On Wed, Nov 23, 2022 at 12:19 PM Dian Fu wrote: > > > >> Hi

Re: [DISCUSS] FLIP-274 : Introduce metric group for OperatorCoordinator

2022-12-15 Thread Hang Ruan
> informative. > > > > > > > > I have just two minor comments regarding names: > > > > - Would it be useful to rename the config key as > > > > *metrics.scope.jm.job.operator-coordinator* for consistency with > > > > *metrics.scope.jm.job

Re: [DISCUSS] FLIP-274 : Introduce metric group for OperatorCoordinator

2022-12-09 Thread Hang Ruan
gt; *(which is not named as *jm-job)? > > - Maybe rename the variable as SCOPE_NAMING_OPERATOR_COORDINATOR for > > simplicity and consistency with SCOPE_NAMING_OPERATOR (which is not named > > as SCOPE_NAMING_TM_JOB_OPERATOR)? > > > > Cheers, > > Dong > &

Re: [DISCUSS] FLIP-274 : Introduce metric group for OperatorCoordinator

2022-12-09 Thread Hang Ruan
NAMING_OPERATOR_COORDINATOR for > simplicity and consistency with SCOPE_NAMING_OPERATOR (which is not named > as SCOPE_NAMING_TM_JOB_OPERATOR)? > > Cheers, > Dong > > > > On Thu, Dec 8, 2022 at 3:28 PM Hang Ruan wrote: > > > Hi all, > > > &g

[DISCUSS] FLIP-274 : Introduce metric group for OperatorCoordinator

2022-12-07 Thread Hang Ruan
Hi all, MengYue and I created FLIP-274[1] Introduce metric group for OperatorCoordinator. OperatorCoordinator is the coordinator for runtime operators and running on Job Manager. The coordination mechanism is operator events between OperatorCoordinator and its all operators, the coordination is

Re: [ANNOUNCE] New Apache Flink Committer - Matyas Orhidi

2022-11-21 Thread Hang Ruan
Congrats Matyas! Geng Biao 于2022年11月22日周二 10:06写道: > Congratulations Matyas! > > Best, > Biao Geng > > From: Leonard Xu > Date: Tuesday, November 22, 2022 at 10:03 AM > To: dev > Subject: Re: [ANNOUNCE] New Apache Flink Committer - Matyas Orhidi > Congratulations Matyas, well deserved! > >

Re: [DISCUSS] FLIP-268: Rack Awareness for Kafka Sources

2022-11-13 Thread Hang Ruan
Hi Jeremy, Thanks for the proposal. I think we should add some descriptions about how we plan to pass this configuration in Flink SQL. Maybe we need a new interface which is passed to the Kafka source like the serializer/deserializer. Best, Hang

Re: [ANNOUNCE] Apache Flink 1.16.0 released

2022-10-30 Thread Hang Ruan
Congratulations! Best, Hang Shengkai Fang 于2022年10月31日周一 09:40写道: > Congratulations! > > Best, > Shengkai > > Hangxiang Yu 于2022年10月31日周一 09:38写道: > > > Congratulations! > > Thanks Chesnay, Martijn, Godfrey & Xingbo for managing the release. > > > > On Fri, Oct 28, 2022 at 7:35 PM Jing Ge

Re: [DISCUSS] FLIP-264 Extract BaseCoordinatorContext

2022-10-16 Thread Hang Ruan
Hi, IMP, I agree to extract a base class for SourceCoordinatorContext. But I prefer to use the name `OperatorCoordinatorContextBase` or `CoordinatorContextBase` as the format like `SourceReaderBase`. I also agree to what Piotr said. Maybe more problems will occur when connectors start to use it.

Re: [VOTE] Reverting sink metric name changes made in 1.15

2022-10-13 Thread Hang Ruan
+1 from me (non-binding). The documents about these Kafka sink metrics( Flink metrics and Kafka sink monitoring

Re: [DISCUSS] Adding client.id.prefix to the KafkaSink

2022-10-13 Thread Hang Ruan
Hi Yaroslav, +1 from me. It is meaningful to keep the common Kafka client configuration the same between Kafka source and sink. Best, Hang Mason Chen 于2022年10月13日周四 13:51写道: > Hi Yaroslav, > > +1 from my end too. I get some questions internally on the warning logs due > to conflicting

Re: [ANNOUNCE] New Apache Flink PMC Member - Danny Cranmer

2022-10-12 Thread Hang Ruan
Congratulations Danny! Best, Hang Yun Gao 于2022年10月13日周四 10:56写道: > Congratulations Danny! > Best, > Yun Gao > -- > From:yuxia > Send Time:2022 Oct. 12 (Wed.) 09:49 > To:dev > Subject:Re: [ANNOUNCE] New Apache Flink PMC Member -

Re: [VOTE] Remove HCatalog connector

2022-10-12 Thread Hang Ruan
+1, Best, Hang Jingsong Li 于2022年10月13日周四 10:09写道: > +1 > > Thanks for driving. > > Best, > Jingsong > > On Thu, Oct 13, 2022 at 3:46 AM Martijn Visser > wrote: > > > > Hi everyone, > > > > Since no comments were made, I'm opening a vote to remove the HCatalog > > connector [1] > > > > The

Re: Re: Re: [Discuss]- Donate Iceberg Flink Connector

2022-10-12 Thread Hang Ruan
+1, I have used the iceberg connector and catalog before. It is easy to use. Márton Balassi 于2022年10月12日周三 16:38写道: > +1 from me, thanks for the clarification. > > On Wed, Oct 12, 2022 at 7:57 AM Péter Váry > wrote: > > > Thanks Abid, > > > > Count me in, and drop a note, if I can help in any

[jira] [Created] (FLINK-26126) Sink V2 will cause error numRecordsOut metric

2022-02-14 Thread Hang Ruan (Jira)
Hang Ruan created FLINK-26126: - Summary: Sink V2 will cause error numRecordsOut metric Key: FLINK-26126 URL: https://issues.apache.org/jira/browse/FLINK-26126 Project: Flink Issue Type: Bug

[jira] [Created] (FLINK-25840) Add semantic test support in the connector testframe

2022-01-27 Thread Hang Ruan (Jira)
Hang Ruan created FLINK-25840: - Summary: Add semantic test support in the connector testframe Key: FLINK-25840 URL: https://issues.apache.org/jira/browse/FLINK-25840 Project: Flink Issue Type

Re: Regarding Connector Options - value.deserializer

2022-01-10 Thread Hang Ruan
pt > 'value.format' in below code snippet so is that enough and handle > deserializer by itself internally? > > How to create custom format can you please share any link for sample > example for the same ? > > > > Thanks > > Ronak Beejawat > > > > > &

Re: Regarding Connector Options - value.deserializer

2022-01-10 Thread Hang Ruan
Hi, Ronak, I think you should implement a custom format by yourself instead of overriding. The 'value.format' is a required table option. Best, Hang Ronak Beejawat (rbeejawa) 于2022年1月10日周一 17:09写道: > Hi Team, > > Is there any way we use value.deserializer in Connector Options from kafka > via

Re: Flink SQL Kafka connector

2022-01-10 Thread Hang Ruan
Hi, There is already an on-going issue about it. ( https://issues.apache.org/jira/browse/FLINK-24456) Best, hang 聂荧屏 于2022年1月10日周一 10:06写道: > hello > > > Is there any plan to develop batch mode of Flink SQL Kafka connector? > > I would like to use kafka connector for

Re: [DISCUSS] JUnit 5 Migration

2022-01-05 Thread Hang Ruan
or JUnit4 once the migration > process > > is finished, i.e. when all subclasses are JUnit5 tests. It is a trade-off > > solution. Hopefully we could find another better solution during the > > discussion. > > > > Speaking of replacing @Test with @TestTemplate, sin

[jira] [Created] (FLINK-25545) [JUnit5 Migration] Module: flink-clients

2022-01-05 Thread Hang Ruan (Jira)
Hang Ruan created FLINK-25545: - Summary: [JUnit5 Migration] Module: flink-clients Key: FLINK-25545 URL: https://issues.apache.org/jira/browse/FLINK-25545 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-25550) [JUnit5 Migration] Module: flink-kuberbetes

2022-01-05 Thread Hang Ruan (Jira)
Hang Ruan created FLINK-25550: - Summary: [JUnit5 Migration] Module: flink-kuberbetes Key: FLINK-25550 URL: https://issues.apache.org/jira/browse/FLINK-25550 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-25549) [JUnit5 Migration] Module: flink-dstl

2022-01-05 Thread Hang Ruan (Jira)
Hang Ruan created FLINK-25549: - Summary: [JUnit5 Migration] Module: flink-dstl Key: FLINK-25549 URL: https://issues.apache.org/jira/browse/FLINK-25549 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-25548) [JUnit5 Migration] Module: flink-sql-parser

2022-01-05 Thread Hang Ruan (Jira)
Hang Ruan created FLINK-25548: - Summary: [JUnit5 Migration] Module: flink-sql-parser Key: FLINK-25548 URL: https://issues.apache.org/jira/browse/FLINK-25548 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-25547) [JUnit5 Migration] Module: flink-optimizer

2022-01-05 Thread Hang Ruan (Jira)
Hang Ruan created FLINK-25547: - Summary: [JUnit5 Migration] Module: flink-optimizer Key: FLINK-25547 URL: https://issues.apache.org/jira/browse/FLINK-25547 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-25546) [JUnit5 Migration] Module: flink-connector-base

2022-01-05 Thread Hang Ruan (Jira)
Hang Ruan created FLINK-25546: - Summary: [JUnit5 Migration] Module: flink-connector-base Key: FLINK-25546 URL: https://issues.apache.org/jira/browse/FLINK-25546 Project: Flink Issue Type: Sub

[jira] [Created] (FLINK-25544) [JUnit5 Migration] Module: flink-streaming-java

2022-01-05 Thread Hang Ruan (Jira)
Hang Ruan created FLINK-25544: - Summary: [JUnit5 Migration] Module: flink-streaming-java Key: FLINK-25544 URL: https://issues.apache.org/jira/browse/FLINK-25544 Project: Flink Issue Type: Sub

[jira] [Created] (FLINK-25543) [JUnit5 Migration] Module: flink-yarn

2022-01-05 Thread Hang Ruan (Jira)
Hang Ruan created FLINK-25543: - Summary: [JUnit5 Migration] Module: flink-yarn Key: FLINK-25543 URL: https://issues.apache.org/jira/browse/FLINK-25543 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-25542) [JUnit5 Migration] Module: flink-runtime-web

2022-01-05 Thread Hang Ruan (Jira)
Hang Ruan created FLINK-25542: - Summary: [JUnit5 Migration] Module: flink-runtime-web Key: FLINK-25542 URL: https://issues.apache.org/jira/browse/FLINK-25542 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-25541) [JUnit5 Migration] Module: flink-test-utils

2022-01-05 Thread Hang Ruan (Jira)
Hang Ruan created FLINK-25541: - Summary: [JUnit5 Migration] Module: flink-test-utils Key: FLINK-25541 URL: https://issues.apache.org/jira/browse/FLINK-25541 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-25540) [JUnit5 Migration] Module: flink-runtime

2022-01-05 Thread Hang Ruan (Jira)
Hang Ruan created FLINK-25540: - Summary: [JUnit5 Migration] Module: flink-runtime Key: FLINK-25540 URL: https://issues.apache.org/jira/browse/FLINK-25540 Project: Flink Issue Type: Sub-task

[DISCUSS] JUnit 5 Migration

2021-12-17 Thread Hang Ruan
Hi, all, Apache Flink is using JUnit for unit tests and integration tests widely in the project, however, it binds to the legacy JUnit 4 deeply. It is important to migrate existing cases to JUnit 5 in order to avoid splitting the project into different JUnit versions. Qingsheng Ren and I have

[jira] [Created] (FLINK-25342) DataStream.sinkTo will not add sink to the sinks field in the StreamGraph

2021-12-16 Thread Hang Ruan (Jira)
Hang Ruan created FLINK-25342: - Summary: DataStream.sinkTo will not add sink to the sinks field in the StreamGraph Key: FLINK-25342 URL: https://issues.apache.org/jira/browse/FLINK-25342 Project: Flink

[jira] [Created] (FLINK-25315) Add some extensions and utils to help the Junit5 migration

2021-12-14 Thread Hang Ruan (Jira)
Hang Ruan created FLINK-25315: - Summary: Add some extensions and utils to help the Junit5 migration Key: FLINK-25315 URL: https://issues.apache.org/jira/browse/FLINK-25315 Project: Flink Issue

[jira] [Created] (FLINK-25104) Kafka table source cannot be used as bounded

2021-11-29 Thread Hang Ruan (Jira)
Hang Ruan created FLINK-25104: - Summary: Kafka table source cannot be used as bounded Key: FLINK-25104 URL: https://issues.apache.org/jira/browse/FLINK-25104 Project: Flink Issue Type

[jira] [Created] (FLINK-24697) Kafka table source cannot change the auto.offset.reset setting

2021-10-29 Thread Hang Ruan (Jira)
Hang Ruan created FLINK-24697: - Summary: Kafka table source cannot change the auto.offset.reset setting Key: FLINK-24697 URL: https://issues.apache.org/jira/browse/FLINK-24697 Project: Flink

[jira] [Created] (FLINK-24627) Add some generic junit5 extensions to replace junit4 rules

2021-10-24 Thread Hang Ruan (Jira)
Hang Ruan created FLINK-24627: - Summary: Add some generic junit5 extensions to replace junit4 rules Key: FLINK-24627 URL: https://issues.apache.org/jira/browse/FLINK-24627 Project: Flink Issue

[jira] [Created] (FLINK-23854) KafkaSink error when restart from the checkpoint with a lower parallelism

2021-08-18 Thread Hang Ruan (Jira)
Hang Ruan created FLINK-23854: - Summary: KafkaSink error when restart from the checkpoint with a lower parallelism Key: FLINK-23854 URL: https://issues.apache.org/jira/browse/FLINK-23854 Project: Flink

[jira] [Created] (FLINK-23764) add RuntimeContext to SourceReaderContext

2021-08-13 Thread Hang Ruan (Jira)
Hang Ruan created FLINK-23764: - Summary: add RuntimeContext to SourceReaderContext Key: FLINK-23764 URL: https://issues.apache.org/jira/browse/FLINK-23764 Project: Flink Issue Type: Improvement

<    1   2