+1, make sense.
Best,
Ron
Wencong Liu 于2023年7月27日周四 09:47写道：
> Hi Matthias,
>
> Thanks for your reply. Due to my busy work reasons, I would like to focus
> only on
> the `Path` class in FLIP-347 for now. As for the implementation of other
> modules,
> I will review them when I have available ti
Hi Matthias,
Thanks for your reply. Due to my busy work reasons, I would like to focus only
on
the `Path` class in FLIP-347 for now. As for the implementation of other
modules,
I will review them when I have available time later on.
Best regards,
Wencong Liu
At 2023-07-26 18:35:
Correct. I don't have the intention to block this FLIP if it's too much
effort to expand it. Sorry if that's the message that came across.
On Wed, Jul 26, 2023 at 12:17 PM Xintong Song wrote:
> I think it worth looking into all implementations of IOReadeableWritable.
> However, I would not consi
I think it worth looking into all implementations of IOReadeableWritable.
However, I would not consider that as a concern of this FLIP.
An important convention of the open-source community is volunteer work. If
Wencong only wants to work on the `Path` case, I think he should not be
asked to invest
Is the time constraint driven by the fact that you wanted to have that
effort being included in 1.18? If so, it looks like that's not possible
based on the decision being made for 1.18 to only allow document changes
[1]. So, there would be actually time to look into it. WDYT?
[1] https://lists.apa
+1
Best,
Junrui
Jing Ge 于2023年7月24日周一 23:28写道：
> agree, since we want to try our best to deprecate APIs in 1.18, it makes
> sense.
>
>
> Best regards,
> Jing
>
> On Mon, Jul 24, 2023 at 12:11 PM Wencong Liu wrote:
>
> > Hi Jing and Matthias,
> >
> >
> > I believe it is reasonable to examin
agree, since we want to try our best to deprecate APIs in 1.18, it makes
sense.
Best regards,
Jing
On Mon, Jul 24, 2023 at 12:11 PM Wencong Liu wrote:
> Hi Jing and Matthias,
>
>
> I believe it is reasonable to examine all classes that implement the
> IOReadableWritable
> interface and sum
Hi Jing and Matthias,
I believe it is reasonable to examine all classes that implement the
IOReadableWritable
interface and summarize their actual usage. However, due to time constraints, I
suggest
we minimize the scope of this FLIP to focus on the Path class. As for other
components
that
+1
Best regards,
Weijie
Jing Ge 于2023年7月22日周六 00:47写道：
> Hi Wencong,
>
> Thanks for the clarification. I got your point. It makes sense.
>
> Wrt IOReadableWritable, the suggestion was to check all classes that
> implemented it, e.g. BlockInfo, Value, Configuration, etc. Not limited to
> the P
Hi Wencong,
Thanks for the clarification. I got your point. It makes sense.
Wrt IOReadableWritable, the suggestion was to check all classes that
implemented it, e.g. BlockInfo, Value, Configuration, etc. Not limited to
the Path.
Best regards,
Jing
On Fri, Jul 21, 2023 at 4:31 PM Wencong Liu wr
Hello Jing,
Thanks for your reply. The URI field should be final and the
Path will be immutable.The static method deserializeFromDataInputView
will create a new Path object instead of replacing the URI field
in a existed Path Object.
For the crossing multiple modules issue, I've explained it in
Hello Matthias,
Thanks for your response. As described in FLIP-347, I have thoroughly reviewed
all instances where the IOReadableWritable serialization of the Path class is
used,
and I have identified three classes that still utilize it for de/serializing
the Path.
1. FileSourceSplitSerial
Hi Wencong,
Just out of curiosity, will the newly introduced
deserializeFromDataInputView() method make the Path mutable again?
What Matthias suggested makes sense, although the extension might make this
FLIP cross multiple modules.
Best regards,
Jing
On Fri, Jul 21, 2023 at 10:23 AM Matthias P
There's a kind-of-related issue FLINK-4758 [1] that proposes removing the
IOReadableWritable interface from more classes. It was briefly mentioned in
the must-have work items discussion [2].
I'm not too sure about the usage of IOReadableWritable: ...whether it would
go away with the removal of the
+1
Best,
Yuxin
Xintong Song 于2023年7月21日周五 12:04写道：
> +1
>
> Best,
>
> Xintong
>
>
>
> On Fri, Jul 21, 2023 at 10:54 AM Wencong Liu wrote:
>
> > Hi devs,
> >
> > I would like to start a discussion on FLIP-347: Remove IOReadableWritable
> > serialization in Path [1].
> >
> >
> > The Path class
+1
Best,
Xintong
On Fri, Jul 21, 2023 at 10:54 AM Wencong Liu wrote:
> Hi devs,
>
> I would like to start a discussion on FLIP-347: Remove IOReadableWritable
> serialization in Path [1].
>
>
> The Path class is currently mutable to support IOReadableWritable
> serialization. However, many pa
Hi devs,
I would like to start a discussion on FLIP-347: Remove IOReadableWritable
serialization in Path [1].
The Path class is currently mutable to support IOReadableWritable
serialization. However, many parts
of the code assume that the Path is immutable. By making the Path class
immutable
17 matches
Mail list logo
