Hi all,
I want to propose to enable the spotless scalafmt integration and remove
the scalastyle plugin.
>From an initial analysis, scalafmt can do everything scalastyle can do, and
the integration with spotless looks easy to enable:
https://github.com/diffplug/spotless/tree/main/plugin-maven#scal
+1 I've never written any Scala in Flink, but this makes a lot of sense to
me. Converging on a smaller set of tools and simplifying the build is
always a good idea and the Community already concluded before that spotless
is generally a good approach.
On Tue, Mar 1, 2022 at 5:52 PM Francesco Guardi
: Konstantin Knauf
Sent: Wednesday, March 2, 2022 15:01
To: dev
Subject: Re: [DISCUSS] Enable scala formatting check
+1 I've never written any Scala in Flink, but this makes a lot of sense to
me. Converging on a smaller set of tools and simplifying the build is
always a good idea and the Comm
which has no release in the past 4 years.
>
>
> [1] https://github.com/scalameta/scalafmt/releases
> [2] https://github.com/scalastyle/scalastyle/tags
>
> Best
> Yun Tang
>
>
> From: Konstantin Knauf
> Sent: Wednesday, March 2, 2022 1
+1
I still remember my first pr. Lack of experience, I had to pay attention to
Scala code format and corrected the format manually, which made me a
little embarrassed(though I'm a big fan of Scala). I think this proposal
will lighten the burden of writing Scala code.
Shouwei Liu
--
yle [2], which has no release in the past 4 years.
> >
> >
> > [1] https://github.com/scalameta/scalafmt/releases
> > [2] https://github.com/scalastyle/scalastyle/tags
> >
> > Best
> > Yun Tang
> >
> > ____________
> > Fro
tyle/scalastyle/tags
> > >
> > > Best
> > > Yun Tang
> > >
> > >
> > > From: Konstantin Knauf
> > > Sent: Wednesday, March 2, 2022 15:01
> > > To: dev
> > > Subject: Re: [DISCUSS] Enable scala form
>
> > > >
> > > > [1] https://github.com/scalameta/scalafmt/releases
> > > > [2] https://github.com/scalastyle/scalastyle/tags
> > > >
> > > > Best
> > > > Yun Tang
> > > >
> > > > _
> I also noticed that the project of scalafmt [1] is much more active
> > than
> > > scalatyle [2], which has no release in the past 4 years.
> > > >
> > > >
> > > > [1] https://github.com/scalameta/scalafmt/releases
> > > > [2] https://gith
is much more active
>>> than
>>>> scalatyle [2], which has no release in the past 4 years.
>>>>>
>>>>>
>>>>> [1] https://github.com/scalameta/scalafmt/releases
>>>>> [2] https://github.com/scalastyle/scalastyle/tag
an do better.
> >>>>
> >>>> Best,
> >>>> Jingsong
> >>>>
> >>>> On Wed, Mar 2, 2022 at 4:19 PM Yun Tang wrote:
> >>>>>
> >>>>> +1
> >>>>>
> >>>>> I also notic
gt; > >>>> can do better.
> > >>>>
> > >>>> Best,
> > >>>> Jingsong
> > >>>>
> > >>>> On Wed, Mar 2, 2022 at 4:19 PM Yun Tang wrote:
> > >>>>>
> > >>>>> +1
> > >>>>>
> > >>>
Big +1
This will improve the contribution experience. Even though we stopped
adding more Scala code, it is still necessary from time to time.
Regards,
Timo
Am 02.03.22 um 09:29 schrieb 刘首维:
+1
I still remember my first pr. Lack of experience, I had to pay attention to Scala
code format an
- 原始邮件 --
> > 发件人:
> "dev"
> <
> kna...@apache.org>;
> > 发送时间: 2022年3月2日(星期三) 下午3:01
> > 收件人: "dev" >
> > 主题: Re: [DISCUSS] Enable scala formatting check
gt; 发件人:
> > "dev"
> > <
> > kna...@apache.org>;
> > > 发送时间: 2022年3月2日(星期三) 下午3:01
> > > 收件人: "dev" > >
> >
of writing Scala code.
> > > >
> > > >
> > > > Shouwei Liu
> > > >
> > > >
> > > > -- 原始邮件 --
> > > > 发件人:
> > > "dev&quo
ience, I had to pay
> > > attention
> > > > to Scala code format and corrected the format manually, which made
> me a
> > > > little embarrassed(though I'm a big fan of Scala). I think this
> > > > proposal will lighten the burden of writing Scala code.
> > > >
02.03.22 um 09:29 schrieb 刘首维:
> > > > > > +1
> > > > > >
> > > > > >
> > > > > > I still remember my first pr. Lack of experience, I had to pay
> > > > attention
> > > > > to Scala code format and
; > > > > Timo
> > > > > >
> > > > > > Am 02.03.22 um 09:29 schrieb 刘首维:
> > > > > > > +1
> > > > > > >
> > > > > > >
> > > > > > > I still remember my first pr. Lack of experi
t; > This will improve the contribution experience. Even though we
> > > stopped
> > > > > > > adding more Scala code, it is still necessary from time to
> time.
> > > > > > >
> > > > > > > Regards,
> > > > &g
Just merge it to master & release-1.15 after 1.15.0 is released. No
impact on the current release, but also no issues with backports.
On 10/03/2022 07:33, Jark Wu wrote:
I also have some concerns because it's a huge change and the 1.15 will be
released soon.
I remember the last time when we mer
21 matches
Mail list logo
