Re: [DISCUSS] FLIP-280: Introduce a new explain mode to provide SQL advice

2023-01-09 Thread Jane Chan
L scope, the advice content is specific to certain nodes >> > > (E.g., some >> > > > > >> certain rel nodes are sensitive to state TTL configuration). >> In this >> > > > > >> situation, the plan cannot be omitted. On the other hand, the >> plan >> > > is >> > > &

Re: [DISCUSS] FLIP-280: Introduce a new explain mode to provide SQL advice

2023-01-06 Thread Jane Chan
t; > >> > > > > > >> Here is an example to illustrate the non-deterministic update > issue. > > > > > >> > > > > > >> create temporary table cdc_with_meta ( > > > > > >> a int, > > > > > >> b bigint, > > > > > >> c string, >

Re: [DISCUSS] FLIP-280: Introduce a new explain mode to provide SQL advice

2023-01-06 Thread Jingsong Li
t; > >> 'connector' = 'values', > > > > >> 'sink-insert-only' = 'false' > > > > >> ); > > > > >> > > > > >> insert into sink_without_pk > > > > >> select a, metadata_3, c > > > > >> fr

Re: [DISCUSS] FLIP-280: Introduce a new explain mode to provide SQL advice

2023-01-05 Thread Jane Chan
gt; >> metadata_3], upsertKeys=[[a]])", > > > >> "changelog_mode" : "I,UB,UA,D" > > > >> }, { > > > >> "id" : 2, > > > >> "type" : "StreamPhysicalCalc", > >

Re: [DISCUSS] FLIP-280: Introduce a new explain mode to provide SQL advice

2023-01-03 Thread Jingsong Li
}, { > > >> "id" : 3, > > >> "type" : "StreamPhysicalSink", > > >> "digest" : > > >> "Sink(table=[default_catalog.default_database.sink_without_pk], > > >> fields=[a, metadata_3,

Re: [DISCUSS] FLIP-280: Introduce a new explain mode to provide SQL advice

2023-01-02 Thread godfrey he
quot; : "ANY", > >> "changelog_mode" : "I,UB,UA,D" > >> } ] > >> } ], > >> "advice" : [ { > >> "kind" : "WARNING", > >> "scope" : "GLOBAL", > &g

Re: [DISCUSS] FLIP-280: Introduce a new explain mode to provide SQL advice

2023-01-02 Thread Shengkai Fang
these columns or use a non-cdc source that only has insert >> messages.\nsource node:\nTableSourceScan(table=[[default_catalog, >> default_database, cdc_with_meta, project=[a, c], metadata=[metadata_3]]], >> fields=[a, c, metadata_3], changelogMode=[I,UB,UA,D], upsertKeys=[[

Re: [DISCUSS] FLIP-280: Introduce a new explain mode to provide SQL advice

2023-01-02 Thread Shengkai Fang
so expected to be implemented by users > > just like DynamicTableSourceFactory or other factories? If so, I notice > > that in the code of PlanAnalyzerManager#registerAnalyzers, the code is as > > follows: > > FactoryUtil.discoverFactory(classLoader, PlanAnalyzerFactory.cla

Re: [DISCUSS] FLIP-280: Introduce a new explain mode to provide SQL advice

2022-12-27 Thread Jane Chan
? Would it > be better to make it an interface and we provide a default implementation? > My concern is some users may want have their own implementation for > PlanAdvice. But it may be overthinking. If you think it won't bring any > problem, I'm also fine with that. > > 3: Is

Re: [DISCUSS] FLIP-280: Introduce a new explain mode to provide SQL advice

2022-12-27 Thread yuxia
收件人: "dev" 发送时间: 星期一, 2022年 12 月 26日 下午 9:39:18 主题: [DISCUSS] FLIP-280: Introduce a new explain mode to provide SQL advice Hi, devs, I would like to start a discussion on FLIP-280: Introduce a new explain mode to provide SQL advice[1]. Currently, Flink SQL EXPLAIN statement pr

[DISCUSS] FLIP-280: Introduce a new explain mode to provide SQL advice

2022-12-26 Thread Jane Chan
Hi, devs, I would like to start a discussion on FLIP-280: Introduce a new explain mode to provide SQL advice[1]. Currently, Flink SQL EXPLAIN statement provides three details to display the plan. However, there is a considerable gap between the current explained result and the actual, applicable