Re: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI

2023-09-19 Thread Jing Ge
instead. Given that we've reached consensus on the topic, I'll restart the > voting. > > Best, > Zhanghao Chen > > 发件人: Rui Fan > 发送时间: 2023年9月19日 12:16 > 收件人: Chen Zhanghao ; dev > 主题: Re: [DISCUSS] FLIP-363: Unify the Represe

回复: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI

2023-09-18 Thread Chen Zhanghao
发件人: Rui Fan 发送时间: 2023年9月19日 12:16 收件人: Chen Zhanghao ; dev 主题: Re: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI +1, thanks everyone who discussed here. Best, Rui On Tue, 19 Sep 2023 at 11:41, Chen Zhanghao mailto:zhangha

Re: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI

2023-09-18 Thread Rui Fan
- > *发件人:* Yangze Guo > *发送时间:* 2023年9月19日 11:18 > > *收件人:* dev@flink.apache.org > *主题:* Re: [DISCUSS] FLIP-363: Unify the Representation of TaskManager > Location in REST API and Web UI > > Thanks for the clarification, Jing. I agree that using another term &g

回复: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI

2023-09-18 Thread Chen Zhanghao
cation and JobExceptions-related classes. > > > > WDYT? > > > > Best, > > Zhanghao Chen > > ____________ > > 发件人: Jing Ge > > 发送时间: 2023年9月13日 4:52 > > 收件人: dev@flink.apache.org > > 主题: Re: [DISCUSS] FLIP-363: U

Re: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI

2023-09-18 Thread Yangze Guo
ce the meaning of "host" is not aligned, it seems good for me to > > remove > > > it in the future release. > > > > > > Best, > > > Weihua > > > > > > > > > On Mon, Sep 11, 2023 at 11:48 AM Chen Zhanghao < &g

Re: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI

2023-09-18 Thread Jing Ge
ion" is already used widely in the codebase, e.g. > TaskManagerLocation and JobExceptions-related classes. > > WDYT? > > Best, > Zhanghao Chen > > 发件人: Jing Ge > 发送时间: 2023年9月13日 4:52 > 收件人: dev@flink.apache.org > 主题: Re: [DISCUSS] FLIP

Re: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI

2023-09-18 Thread Rui Fan
gt; word > > > in the networking world but I think location is more suited here for > two > > > reasons: > > > > > > > > 1. The term here is for uniquely identifying the TaskManager where > > > the task is deployed while providing the host machine info as

Re: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI

2023-09-18 Thread Yangze Guo
be kept for at least 2 minor > > versions before removal. > > > > Best, > > Zhanghao Chen > > ________________ > > 发件人: Yangze Guo > > 发送时间: 2023年9月15日 17:26 > > 收件人: dev@flink.apache.org > > 主题: Re: [DISCUSS] FLIP-363: Unify

Re: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI

2023-09-17 Thread Rui Fan
Yangze Guo > 发送时间: 2023年9月15日 17:26 > 收件人: dev@flink.apache.org > 主题: Re: [DISCUSS] FLIP-363: Unify the Representation of TaskManager > Location in REST API and Web UI > > Thanks for driving this, Zhanghao. +1 for the overall proposal. > > Some cents from my side: > > 1.

回复: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI

2023-09-17 Thread Chen Zhanghao
old host field will be kept for at least 2 minor versions before removal. Best, Zhanghao Chen 发件人: Yangze Guo 发送时间: 2023年9月15日 17:26 收件人: dev@flink.apache.org 主题: Re: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI Tha

回复: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI

2023-09-15 Thread Chen Zhanghao
d classes. > > WDYT? > > Best, > Zhanghao Chen > > 发件人: Jing Ge > 发送时间: 2023年9月13日 4:52 > 收件人: dev@flink.apache.org > 主题: Re: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location > in REST API and Web UI > > Hi Zhanghao, &

Re: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI

2023-09-15 Thread Yangze Guo
d classes. > > WDYT? > > Best, > Zhanghao Chen > > 发件人: Jing Ge > 发送时间: 2023年9月13日 4:52 > 收件人: dev@flink.apache.org > 主题: Re: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location > in REST API and Web UI > > Hi Zhanghao, > > Tha

回复: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI

2023-09-13 Thread Chen Zhanghao
nghao Chen 发件人: Jing Ge 发送时间: 2023年9月13日 4:52 收件人: dev@flink.apache.org 主题: Re: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI Hi Zhanghao, Thanks for bringing this to our attention. It is a good proposal to improve data c

Re: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI

2023-09-12 Thread Jing Ge
Thanks for clarifying the definition of "public interfaces", that helps a > > lot! > > > > Best, > > Zhanghao Chen > > ____ > > 发件人: Rui Fan <1996fan...@gmail.com> > > 发送时间: 2023年9月11日 11:18 > > 收件人: dev@fl

Re: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI

2023-09-10 Thread Weihua Hu
that helps a > lot! > > Best, > Zhanghao Chen > > 发件人: Rui Fan <1996fan...@gmail.com> > 发送时间: 2023年9月11日 11:18 > 收件人: dev@flink.apache.org > 主题: Re: [DISCUSS] FLIP-363: Unify the Representation of TaskManager > Location in REST API

回复: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI

2023-09-10 Thread Chen Zhanghao
> > them are marked as @public yet. Maybe we should do that. ccing > > @chesnay<mailto:ches...@apache.org> for confirmation. > > > > Best, > > Zhanghao Chen > > ____________________ > > 发件人: Shammon FY > > 发送时间: 2023年9月11日 10:22

回复: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI

2023-09-10 Thread Chen Zhanghao
; > 发件人: Shammon FY > 发送时间: 2023年9月11日 10:22 > 收件人: dev@flink.apache.org > 主题: Re: [DISCUSS] FLIP-363: Unify the Representation of TaskManager > Location in REST API and Web UI > > Thanks Zhanghao for initialing this discussion, I have ju

Re: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI

2023-09-10 Thread Rui Fan
re marked as @public yet. Maybe we should do that. ccing > > @chesnay<mailto:ches...@apache.org> for confirmation. > > > > Best, > > Zhanghao Chen > > ________________ > > 发件人: Shammon FY > > 发送时间: 2023年9月11日 10:22 > > 收件人: dev@flink.apache.org > > 主题: Re:

Re: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI

2023-09-10 Thread Weihua Hu
> 发件人: Shammon FY > 发送时间: 2023年9月11日 10:22 > 收件人: dev@flink.apache.org > 主题: Re: [DISCUSS] FLIP-363: Unify the Representation of TaskManager > Location in REST API and Web UI > > Thanks Zhanghao for initialing this discussion, I have just one comment: >

回复: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI

2023-09-10 Thread Chen Zhanghao
hes...@apache.org> for confirmation. Best, Zhanghao Chen 发件人: Shammon FY 发送时间: 2023年9月11日 10:22 收件人: dev@flink.apache.org 主题: Re: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI Thanks Zhanghao for initialing this discuss

Re: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI

2023-09-10 Thread Shammon FY
Thanks Zhanghao for initialing this discussion, I have just one comment: I checked the classes `SubtasksAllAccumulatorsHandler`, `SubtasksTimesHandler`, `SubtaskCurrentAttemptDetailsHandler`, `JobVertexTaskManagersHandler` and `JobExceptionsHandler` you mentioned in `Public Interfaces` and they ar

[DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI

2023-09-08 Thread Chen Zhanghao
Hi Devs, I would like to start a discussion on FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI [1]. The TaskManager location of subtasks is important for identifying TM-related problems. There are a number of places in REST API and Web UI where TaskManager loc