Hello guys and thank you for your feedback!
Very well appreciated.
Sorry for the late reply, but it took a lot of time to address your concerns.
I had to re-design the refactor and convince myself of the best way to
accomodate both rewriting existing connectors (e.g. Postgres) and new ones.
Hope
Hi Lorenzo
I have a couple of questions:
1. Can the FLIP include at least one implementation of JDBC based connector
using proposed changes? Implementing a connector and solving challenges
that arise using the proposed change will give good insight.
2. The example seems to restrict the connector
Thanks Lorenzo for kicking off this discussion.
+1 for the motivation, and I left some comments as following:
(1) Please add API annotation for all Proposed public interfaces
(2)
JdbcConnectionOptionsParser/JdbcReadOptionsParser/JdbcExecutionOptionsParser
offer two methods validate and
Hi Lorenzo,
This seems like a very useful addition.
+1 (non-binding) from my side. I echo Jeyhun's question about backward
compatibility as it is not mentioned in the FLIP.
Best Regards
Ahmed Hamdy
On Wed, 15 May 2024 at 08:12, wrote:
> Hello Muhammet and Jeyhun!
> Thanks for your comments!
>
Hello Muhammet and Jeyhun!
Thanks for your comments!
@Jeyhun:
> Could you please elaborate more on how the new approach will be backwards
compatible?
In the FLIP I provide how the current Factories in JDBC would be changed with
this refactor, do you mean something different? Can you be more
Hi Lorenzo,
Thanks for driving this FLIP. +1 for it.
Could you please elaborate more on how the new approach will be backwards
compatible?
Regards,
Jeyhun
On Tue, May 14, 2024 at 10:00 AM Muhammet Orazov
wrote:
> Hey Lorenzo,
>
> Thanks for driving this FLIP! +1
>
> It will improve the user
Hey Lorenzo,
Thanks for driving this FLIP! +1
It will improve the user experience of using JDBC based
connectors and help developers to build with different drivers.
Best,
Muhammet
On 2024-05-13 10:20, lorenzo.affe...@ververica.com.INVALID wrote:
Hello dev!
I want to share a draft of my
Hello dev!
I want to share a draft of my FLIP to refactor the JDBC connector to improve
its extensibility [1].
The goal is to allow implementers to write new connectors on top of the JDBC
one for Table API with clean and maintainable code.
Any feedback from the community is more and welcome.
