[DISCUSS] FLIP-XXX Amazon SQS Source Connector

2024-07-19 Thread Saurabh Singh
Hi Fink Devs, Our team has been working on migrating various data pipelines to Flink to leverage the benefits of exactly-once processing, checkpointing, and stateful computing. We have several use cases built around the AWS SQS Service. For this migration, we have developed an SQS Source Connector

Re: [DISCUSS] FLIP-XXX Amazon SQS Source Connector

2024-07-21 Thread Yanquan Lv
Hi Dhingra, thanks for driving this. I am not very familiar with SQS, but this should be some kind of message queue. So could we add metric of currentFetchEventTimeLag and currentEmitEventTimeLag from FLIP-33[1] in SQS source? and I want to know what metrics do we provide in SQS source. [1] http

Re: [DISCUSS] FLIP-XXX Amazon SQS Source Connector

2024-07-22 Thread Saurabh Singh
Hi Yanquan, Yes, you are right about SQS - It is a MessageQueue. https://aws.amazon.com/sqs/features/ Thanks for reviewing the FLIP and valuable suggestions about adding observability. We have reviewed the above-mentioned Standardize Connector Metric FLIP [1] and added a section about it in the

Re: [DISCUSS] FLIP-XXX Amazon SQS Source Connector

2024-07-23 Thread Samrat Deb
Hi Saurabh, Thank you for sharing the FLIP for the SQS source connector. An SQS source connector will be a great addition to the Flink ecosystem, as there is a growing demand for SQS source/sink integration. I have a few queries: 1. AWS has announced JSON protocol support in SQS [1]. Can you she

Re: [DISCUSS] FLIP-XXX Amazon SQS Source Connector

2024-07-25 Thread Saurabh Singh
Hi Samrat, Thanks for the review and feedback. We have evaluated all the three points. Please find the answers below: 1. AWS has announced JSON protocol support in SQS [1]. Can you shed some light on how different protocols will be supported? - We will utilize the AWS client library to connect w

Re: [DISCUSS] FLIP-XXX Amazon SQS Source Connector

2024-07-26 Thread Li Wang
Hi Saurabh, Thanks for the FLIP. Given the ongoing effort to implement the SQS sink connector ( https://cwiki.apache.org/confluence/display/FLINK/FLIP-438%3A+Amazon+SQS+Sink+Connector), it is important to consider how the SQS source connector supports this development, ensuring a unified framework

Re: [DISCUSS] FLIP-XXX Amazon SQS Source Connector

2024-07-26 Thread Saurabh Singh
Hi Li Wang, Thanks for the review and appreciate your feedback. I completely understand your concern and agree with it. Our goal is to provide users of connectors with a consistent and coherent ecosystem, free of any issues. To ensure that, we are closely monitoring/reviewing the SQS Sink implemen

Re: [DISCUSS] FLIP-XXX Amazon SQS Source Connector

2024-07-27 Thread Ahmed Hamdy
Hi Saurabh I think this is going to be a valuable addition which is needed. I have a couple of comments - In the FLIP you mention the split is going to be 1 sqs Queue, does this mean we would support reading from multiple queues? The builder example seems to support a single queue SqsSource.builder

Re: [DISCUSS] FLIP-XXX Amazon SQS Source Connector

2024-07-31 Thread Saurabh Singh
Hi Ahmed, Thank you very much for the detailed, valuable review. Please find our responses below: - In the FLIP you mention the split is going to be 1 sqs Queue, does this mean we would support reading from multiple queues? This is also not clear in the implementation of `addSplitsBack`

Re: [DISCUSS] FLIP-XXX Amazon SQS Source Connector

2024-08-07 Thread Ahmed Hamdy
Hi Saurabh Thanks for addressing, I see the FLIP is in much better state. Could we specify where we queue messages for deletion, In my opinion the record emitter is a good place for that where we delete messages that are forwarded to the next operator. Other than that I don't have further comments.

Re: [DISCUSS] FLIP-XXX Amazon SQS Source Connector

2024-08-08 Thread Saurabh Singh
Hi Ahmed, Yes, you're correct. Currently, we're utilizing the "record emitter" to send messages into the queue for deletion. However, for the actual deletion process, which is dependent on the checkpoints, we've been using the source reader class because it allows us to override the notifyCheckpoi

Re: [DISCUSS] FLIP-XXX Amazon SQS Source Connector

2024-08-13 Thread Saurabh Singh
Hi Flink Devs, Thanks for all the feedback flink devs. Following the procedure outlined on the Flink Improvement Proposal Confluence page [1], we kindly ask the PMC/Committers to transfer the content from the Amazon SQS Source Connector Google Doc [2] and assign a FLIP Number for us, which we wil

Re: [DISCUSS] FLIP-XXX Amazon SQS Source Connector

2024-08-20 Thread Ahmed Hamdy
Hi Abhisagar and Saurabh I have created the FLIP page and assigned it FLIP-477[1]. Feel free to resume with the next steps. 1- https://cwiki.apache.org/confluence/display/FLINK/FLIP-+477+Amazon+SQS+Source+Connector Best Regards Ahmed Hamdy On Tue, 20 Aug 2024 at 06:05, Abhisagar Khatri wrote:

Re: [DISCUSS] FLIP-XXX Amazon SQS Source Connector

2024-09-03 Thread Danny Cranmer
Hello Saurabh, Thanks for contributing this, I have seen multiple custom implementations of SQS sources, so a community supported version will be a great addition. // .setFailOnError(false) A general callout that this is not ideal, I know we use it elsewhere but we should consider some pluggable

Re: [DISCUSS] FLIP-XXX Amazon SQS Source Connector

2024-09-03 Thread Arvid Heise
Sorry for being late to the party. I saw your call to vote and looked at the FLIP. First, most of the design is looking really good and it will be good to have another connector integrated into the AWS ecosystem. A couple of questions/remarks: 1) Since we only have 1 split, we should also limit th