Re: [DISCUSS] First release of flink-shaded

2017-07-12 Thread Chesnay Schepler
I've opened a PR to include non-apache licenses in the jars: https://github.com/apache/flink-shaded/pull/7 On 12.07.2017 16:25, Stephan Ewen wrote: +1 I chatted with Chesnay privately, bringing up the issue that we need to have the License files added to the shaded jar files to properly obey B

Re: [DISCUSS] First release of flink-shaded

2017-07-12 Thread Stephan Ewen
+1 I chatted with Chesnay privately, bringing up the issue that we need to have the License files added to the shaded jar files to properly obey BSD / MIT licenses (similarly as we did in Flink for the 1.3.0 release). Other than that, good to go! On Mon, Jul 10, 2017 at 8:42 PM, Robert Metzger

Re: [DISCUSS] First release of flink-shaded

2017-07-10 Thread Robert Metzger
+1 to go ahead with a release. I can offer to take care of all the PMC-related actions in the release process. On Mon, Jul 3, 2017 at 6:50 PM, Aljoscha Krettek wrote: > Yes, that’s definitely possible. I was referring to the fact that this > would break the user-facing API and these are method

Re: [DISCUSS] First release of flink-shaded

2017-07-03 Thread Aljoscha Krettek
Yes, that’s definitely possible. I was referring to the fact that this would break the user-facing API and these are methods declared as @Public, i.e. they cannot change. > On 3. Jul 2017, at 18:45, Ted Yu wrote: > > Currently StreamExecutionEnvironment exposes Kryo thru the following: > > i

Re: [DISCUSS] First release of flink-shaded

2017-07-03 Thread Ted Yu
Currently StreamExecutionEnvironment exposes Kryo thru the following: import com.esotericsoftware.kryo.Serializer; I think shading is possible since we can declare the Serializer class to come from shaded Kryo namespace. On Mon, Jul 3, 2017 at 9:25 AM, Aljoscha Krettek wrote: > Is it even poss

Re: [DISCUSS] First release of flink-shaded

2017-07-03 Thread Aljoscha Krettek
Is it even possible to shade Kryo with it being in the public API? I don’t think it is (without looking into this to deeply, though). > On 3. Jul 2017, at 17:23, Chesnay Schepler wrote: > > I would tackle Kryo later as it is exposed through the API > (StreamExecutionEnvironment#addDefaultKryoS

Re: [DISCUSS] First release of flink-shaded

2017-07-03 Thread Chesnay Schepler
I would tackle Kryo later as it is exposed through the API (StreamExecutionEnvironment#addDefaultKryoSerializer) which will make the shading process more difficult than for the modules that are done so far. Technically this doesn't prevent us from adding a flink-shaded-kryo2/3 module right now

Re: [DISCUSS] First release of flink-shaded

2017-07-03 Thread Stephan Ewen
Other non-Hadoop dependencies that I think are important are the Kryo dependencies. Do we want them in the first release, or tackle them later? Specifically, I think we need - flink-shaded-kryo2 which includes kryo2 plus chill in the version we currently use - flink-shaded-kryo3 which includ

Re: [DISCUSS] First release of flink-shaded

2017-07-03 Thread Fabian Hueske
Thanks for working on this Chesnay. I think releasing flink-shaded and integrating it in the build before touching the Hadoop dependencies it sounds like a good plan. +1 Cheers, Fabian 2017-07-03 14:32 GMT+02:00 Chesnay Schepler : > Hello, > > I would like to kick off the first release of flink

Re: [DISCUSS] First release of flink-shaded

2017-07-03 Thread Aljoscha Krettek
+1 Sounds good! I have followed the process on the various issues and the new shaded repository and the changes seem straightforward (more or less ;-)) > On 3. Jul 2017, at 14:32, Chesnay Schepler wrote: > > Hello, > > I would like to kick off the first release of flink-shaded. > > In the cu

[DISCUSS] First release of flink-shaded

2017-07-03 Thread Chesnay Schepler
Hello, I would like to kick off the first release of flink-shaded. In the current state the release would include shaded dependencies for asm, guava and netty. All changes required for the integration into Flink have been prepared and tested locally and on yarn. In order for these changes