Hi Gary Kurt, and Jark
I am canceling the vote and restart it since the POC has some changes from
the initial one.
All the changes are following the proposal in this mail thread.
please vote again in the new thread, thanks
Jark Wu 于2020年3月4日周三 下午12:13写道：
> +1 from my side.
>
> Best,
> Jark
>
+1 from my side.
Best,
Jark
On Wed, 4 Mar 2020 at 11:39, Kurt Young wrote:
> LGTM now, +1 from my side.
>
> Best,
> Kurt
>
>
> On Wed, Mar 4, 2020 at 12:27 AM Gary Yao wrote:
>
>> Hi Yadong,
>>
>> Thank you for updating the wiki page.
>>
>> Only one minor suggestion – I would change:
>>
>>
LGTM now, +1 from my side.
Best,
Kurt
On Wed, Mar 4, 2020 at 12:27 AM Gary Yao wrote:
> Hi Yadong,
>
> Thank you for updating the wiki page.
>
> Only one minor suggestion – I would change:
>
> > If show-history is true return the information of attempt.
>
> to
>
> > If show-history is
Hi Yadong,
Thank you for updating the wiki page.
Only one minor suggestion – I would change:
> If show-history is true return the information of attempt.
to
> If show-history is true, information for all attempts including
previous ones will be returned
That being said, FLIP-100
Hi all
The rest API part has been updated with Gary and Till's suggestions
here is the link:
https://cwiki.apache.org/confluence/display/FLINK/FLIP-100%3A+Add+Attempt+Information
Yadong Xie 于2020年3月3日周二 下午9:14写道：
> Hi Chesnay
>
> most discussions in this vote are about the more feature/demo
Hi Chesnay
most discussions in this vote are about the more feature/demo request in
POC or discussion about response format, the main proposal the web UI part
which is not changed
and the discussion about the response is converging, the response format
discussion could happen either here or at
I suggest to cancel this vote.
Several discussion items have been brought up during the vote, some of
which are still unresolved, others which resulted in changes to the
proposal.
My conclusion is that this proposal needs more discussions.
On 20/02/2020 10:46, Yadong Xie wrote:
Hi all
I
> * Why are we duplicating the subtask index in the objects that are
stored in the attempts-time-info array? I thought that all objects in the
same array share the same subtask index.
yes, I agree with you that subtask could be removed in the
`attempts-time-info`
> * Are we confident that the
Hi Yadong,
Thanks for driving this FLIP. I have a few questions/remarks:
* Why are we duplicating the subtask index in the objects that are
stored in the attempts-time-info array? I thought that all objects in the
same array share the same subtask index.
* Are we confident that the
Hi everyone
A subtask filter and an attempt id filter was added to the attempt timeline
page now
check the POC here:
http://101.132.122.69:8081/web/#/job/9d651769488466d33e7a607e85203543/timeline
FLIP doc was also updated:
I think your proposal is better because then we don't have to bump the REST
API version.
Cheers,
Till
On Thu, Feb 27, 2020 at 8:02 AM Yadong Xie wrote:
> Hi Till
>
> We keep response a flattened SubtaskTimeInfo and an array of
> SubtaskTimeInfo to keep the restAPI backward compatible, since
Hi Till
We keep response a flattened SubtaskTimeInfo and an array of
SubtaskTimeInfo to keep the restAPI backward compatible, since Flink users
may still need the API('/jobs/{jobId}/vertices/{vertexId}/subtasktimes') to
get the flattened SubtaskTimeInfo.
If we want to get an array of
Fair enough. If this should become a problem we could introduce it later as
well.
What about changing the SubtasksTimeInfo response type into an array of
SubtaskTimeInfo? At the moment SubtasksTimeInfo contains a
flattened SubtaskTimeInfo and and array of SubtaskTimeInfo for the previous
Hi Till
Thanks for your comments.
> I have a comment concerning the SubtasksTimesHandler
It would be much easier for the frontend to handle a large amount of data
if we have a rest API parameter filter, but in my opinion, the attempt list
data is not large enough that we have to rely on the
Hi Yadong,
thanks for creating this FLIP. I like the idea to make the web-ui
information richer wrt to subtask attempt information.
I have a comment concerning the SubtasksTimesHandler: Should we change the
response type SubtasksTimeInfo so that it simply contains an
array of SubtaskTimeInfo?
Hi Yadong,
Thanks for the updating. LGTM now.
+1 (non-binding)
Yadong Xie 于2020年2月25日周二 下午4:41写道：
> Hi Kurt
>
> There will be no differences between batch jobs and stream jobs in
> subtask-attempt level in the UI
> The only differences are in the vertex timeline, I have added a screenshot
>
Hi Kurt
There will be no differences between batch jobs and stream jobs in
subtask-attempt level in the UI
The only differences are in the vertex timeline, I have added a screenshot
of the batch job in the FLIP-100 since the batch job will disappear from
the list after it finished soon.
here is
Hi Jark and Benchao
The link to taks manager log was added to the attempt timeline now, here is
the new POC url
check it here:
http://101.132.122.69:8081/web/#/job/9d651769488466d33e7a607e85203543/timeline
thanks for your suggestions!
lining jing 于2020年2月24日周一 下午5:16写道：
> I agree with Jark.
I agree with Jark.
The user can find the previous taskmanager according to the log link in the
history of the attempt.
The reason for adding attempts' information to the timeline is that for
some reason, the job failover failed or took a long time. This problem is
challenging to locate. As the
I agree with Jark.
It's helpful to add a TM logs link for each attempt. Usually there are
multiple TMs per host, so only host name cannot determine the real TM.
Jark Wu 于2020年2月21日周五 下午2:06写道：
> Thanks Yadong,
>
> I think one of the purpose to find the failed attempts is that we want to
> look
Thanks Yadong,
I think one of the purpose to find the failed attempts is that we want to
look into the logs in the failed node (node may change across attempts).
However, from the POC, I didn't find a log link on each attempts. Maybe we
can add such feature?
Best,
Jark
On Fri, 21 Feb 2020 at
Hi Yadong,
Thanks for the proposal, it's a useful feature, especially for batch jobs.
But according
to the examples you gave, I can't tell whether i got required information
from that.
Can you replace the demo job to a more complex batch job and then we can
see some
differences of start/stop time
Hi all
I want to start the vote for FLIP-100, which proposes to add attempt
information inside subtask and timeline in web UI.
To help everyone better understand the proposal, we spent some efforts on
making an online POC
Timeline Attempt (click the vertex timeline to see the differences):
23 matches
Mail list logo
