Github user asfgit closed the pull request at:
https://github.com/apache/incubator-gearpump/pull/134
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/134
LGTM. Please fix unattended comments in following PRs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/134#discussion_r97287804
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/client/RunningApplication.scala
---
@@ -18,17 +18,21 @@
package org.apache.gearpu
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/134#discussion_r97293869
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/client/RunningApplication.scala
---
@@ -18,17 +18,21 @@
package org.apache.gearp
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/134#discussion_r97287682
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/client/RunningApplication.scala
---
@@ -40,6 +44,16 @@ class RunningApplication(val ap
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/134#discussion_r97273193
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/client/RunningApplication.scala
---
@@ -18,17 +18,21 @@
package org.apache.gearp
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/134#discussion_r97268898
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/ClusterMessage.scala ---
@@ -155,26 +158,20 @@ object MasterToClient {
/*
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/134#discussion_r97272651
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/client/RunningApplication.scala
---
@@ -40,6 +44,16 @@ class RunningApplication(val a
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/134#discussion_r97268430
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/client/RunningApplication.scala
---
@@ -40,6 +44,16 @@ class RunningApplication(val a
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/134#discussion_r97268263
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/client/RunningApplication.scala
---
@@ -40,6 +44,16 @@ class RunningApplication(val a
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/134#discussion_r97263936
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/client/RunningApplication.scala
---
@@ -40,6 +44,16 @@ class RunningApplication(val a
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/134#discussion_r97263412
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/AppDescription.scala ---
@@ -142,4 +139,26 @@ case class ExecutorContext(
case cl
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/134#discussion_r97263634
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/appmaster/ApplicationRuntimeInfo.scala
---
@@ -0,0 +1,52 @@
+/*
+ * Licensed
[
https://issues.apache.org/jira/browse/GEARPUMP-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834257#comment-15834257
]
ASF GitHub Bot commented on GEARPUMP-252:
-
Github user manuzhang commented on a
[
https://issues.apache.org/jira/browse/GEARPUMP-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834217#comment-15834217
]
ASF GitHub Bot commented on GEARPUMP-252:
-
Github user huafengw commented on a d
[
https://issues.apache.org/jira/browse/GEARPUMP-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834215#comment-15834215
]
ASF GitHub Bot commented on GEARPUMP-252:
-
Github user huafengw commented on a d
[
https://issues.apache.org/jira/browse/GEARPUMP-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834080#comment-15834080
]
ASF GitHub Bot commented on GEARPUMP-252:
-
Github user manuzhang commented on a
[
https://issues.apache.org/jira/browse/GEARPUMP-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834074#comment-15834074
]
ASF GitHub Bot commented on GEARPUMP-252:
-
Github user manuzhang commented on a
[
https://issues.apache.org/jira/browse/GEARPUMP-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834051#comment-15834051
]
ASF GitHub Bot commented on GEARPUMP-252:
-
Github user manuzhang commented on a
[
https://issues.apache.org/jira/browse/GEARPUMP-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834044#comment-15834044
]
ASF GitHub Bot commented on GEARPUMP-252:
-
Github user manuzhang commented on a
[
https://issues.apache.org/jira/browse/GEARPUMP-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834041#comment-15834041
]
ASF GitHub Bot commented on GEARPUMP-252:
-
Github user manuzhang commented on a
21 matches
Mail list logo
