Build failed in Jenkins: Geode-nightly #926

See Changes: [bschuchardt] GEODE-3249: Validate internal client/server messages [eshu] GEODE-3444: Release the locks held when beforeCompletion failed with [dbarnes] GEODE-3395 Variable-ize product version and

Re: Review Request 61722: GEODE-3047 Atomic creation flag is not set if the region is recoverd from the disk.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61722/#review183187 --- Ship it! Ship It! - Nick Reich On Aug. 17, 2017, 11:20

Review Request 61722: GEODE-3047 Atomic creation flag is not set if the region is recoverd from the disk.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61722/ --- Review request for geode, Darrel Schneider, Eric Shu, Lynn Gallinat, and Nick

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133847775 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProtoclMessageHandlerLoader.java --- @@ -0,0 +1,64 @@ +/*

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #650 was SUCCESSFUL (with 2027 tests)

--- Spring Data GemFire > Nightly-ApacheGeode > #650 was successful. --- Scheduled 2029 tests in total. https://build.spring.io/browse/SGF-NAG-650/ -- This

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133847176 --- Diff: geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandlerJUnitTest.java --- @@

[GitHub] geode pull request #719: GEODE-3447 Implement client authorization for the n...

GitHub user bschuchardt opened a pull request: https://github.com/apache/geode/pull/719 GEODE-3447 Implement client authorization for the new protocol Implementation of authorization checks for the new protocol. This will have to be merged with the Locator Protobuf communications

Re: Review Request 61701: GEODE-3277: Fix error path constructors of Launcher inner State classess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61701/#review183168 --- Ship it! Ship It! - Kirk Lund On Aug. 16, 2017, 9:21 p.m.,

Re: Review Request 61694: GEODE-3235: Deploy jar registers functions which extend FunctionAdapter

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61694/#review183167 --- Ship it! Ship It! - Kirk Lund On Aug. 17, 2017, 8:21 p.m.,

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133844781 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java --- @@ -334,42 +342,46 @@ protected void run() {

[GitHub] geode pull request #718: GEODE-3434: Allow old tomcat server sessions to be ...

GitHub user jhuynh1 opened a pull request: https://github.com/apache/geode/pull/718 GEODE-3434: Allow old tomcat server sessions to be compatible with new tomcat session modules Thank you for submitting a contribution to Apache Geode. In order to streamline the review of

[GitHub] geode pull request #712: GEODE-3434: Allow the modules to be interoperable w...

Github user jhuynh1 closed the pull request at: https://github.com/apache/geode/pull/712 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #712: GEODE-3434: Allow the modules to be interoperable w...

Github user jhuynh1 commented on a diff in the pull request: https://github.com/apache/geode/pull/712#discussion_r133843663 --- Diff: geode-old-versions/build.gradle --- @@ -65,6 +92,21 @@ task createGeodeClasspathsFile { new FileOutputStream(classpathsFile).withStream {

[GitHub] geode pull request #712: GEODE-3434: Allow the modules to be interoperable w...

Github user jhuynh1 commented on a diff in the pull request: https://github.com/apache/geode/pull/712#discussion_r133843603 --- Diff: extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/DeltaSession.java --- @@ -553,8 +555,30 @@ public void

[GitHub] geode pull request #712: GEODE-3434: Allow the modules to be interoperable w...

Github user jhuynh1 commented on a diff in the pull request: https://github.com/apache/geode/pull/712#discussion_r133843558 --- Diff: extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/DeltaSession.java --- @@ -586,6 +610,20 @@ public int

[geode-native] branch develop updated: GEODE-3457: Linking fails on Solaris SPARC due to -xatomic=none option

This is an automated email from the ASF dual-hosted git repository. jbarrett pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/geode-native.git The following commit(s) were added to refs/heads/develop by this push: new 8e4fd71 GEODE-3457: Linking fails on

Re: [DISCUSS] authorizing function execution

I like the simplicity of the annotation, but that simplicity has some problems other than just playing nicely with lambdas. If permission required is dependent on function parameters or cluster state, it can't (currently) be resolved as part of the annotation. We already work-around this in a

[GitHub] geode pull request #666: GEODE-3329: Changed logging output of modify_war sc...

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/666 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #712: GEODE-3434: Allow the modules to be interoperable w...

Github user upthewaterspout commented on a diff in the pull request: https://github.com/apache/geode/pull/712#discussion_r133827499 --- Diff: extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/DeltaSession.java --- @@ -553,8 +555,30 @@ public void

[GitHub] geode pull request #712: GEODE-3434: Allow the modules to be interoperable w...

Github user upthewaterspout commented on a diff in the pull request: https://github.com/apache/geode/pull/712#discussion_r133827419 --- Diff: extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/DeltaSession.java --- @@ -586,6 +610,20 @@ public int

Re: [DISCUSS] authorizing function execution

We already have a similar annotation that we use internally to secure GFSH commands: @ResourceOperation(resource = Resource.DATA, operation = Operation.MANAGE) public Result createRegion( One option might be to move this annotation into a public package and to enforce it if present on

Native commit messages going to dev instead of commit list

Was: Re: [geode-native] branch develop updated: GEODE-3455: Update Solaris build images. Probably need to file an infra ticket. I'm guessing this was caused by the gitbox migration. On Thu, Aug 17, 2017 at 1:40 PM, Jacob Barrett wrote: > I wonder if the native repo wasn't

Re: [DISCUSS] authorizing function execution

On Thu, Aug 17, 2017 at 12:10 PM, Swapnil Bawaskar wrote: > So, it sounds like if we did #1 above: i.e: > 1) externalize SecurityService so that function author can use it in the > function.execute code to check authorization. > > we could get this to work with lambdas: >

Re: [geode-native] branch develop updated: GEODE-3455: Update Solaris build images.

I wonder if the native repo wasn't reconfigured when the main repo was. It is not something I can change even though we are not a mirror site. Mark, do you have karma to change this? -Jake On Thu, Aug 17, 2017 at 11:25 AM Dan Smith wrote: > I think these messages should

Re: [DISCUSS] authorizing function execution

Y'all should checkout PicketLink (now KeyCloak) and how they handle this. I used this heavily in the past with JBoss AS. It supports annotation and inline restrictions. Also supports EL but that's for another day. While I am not advocating today (maybe tomorrow) that we witch to PicketLink but

Re: [DISCUSS] authorizing function execution

I don't think we should give a user explicit permissions to change the authorization levels for their function. I think that the SecurityService should have some knowledge about authorization levels on a per-user or per-role. That would check the authorization level on a per-user basis for

Re: Review Request 61694: GEODE-3235: Deploy jar registers functions which extend FunctionAdapter

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61694/ --- (Updated Aug. 17, 2017, 8:21 p.m.) Review request for geode, Emily Yeh, Jared

[GitHub] geode issue #717: Feature/geode 3411 Monitor the neighbour JVM using neihbou...

Github user kohlmu-pivotal commented on the issue: https://github.com/apache/geode/pull/717 @aravindmusigumpula could you please explain why this feature is required and why the member now has to adhere to his neighbor's member-timeout. What problem is this change addressing

Re: [DISCUSS] authorizing function execution

So, it sounds like if we did #1 above: i.e: 1) externalize SecurityService so that function author can use it in the function.execute code to check authorization. we could get this to work with lambdas: ResultCollector rc = getExecution().execute(context ->

Re: [DISCUSS] authorizing function execution

Is there a requirement of, changing the permission in future time...E.g. Currently the function has WRITE permission, but needs to be changed to READ, without re-writing/deploying the function. In that case, permissions needs to be independent of function implementation. -Anil. On Thu, Aug 17,

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133782267 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProtoclMessageHandlerLoader.java --- @@ -0,0 +1,64 @@ +/*

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133783618 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProtoclMessageHandlerLoader.java --- @@ -0,0 +1,64 @@ +/*

[DISCUSS] geode-native c++ exceptions

C++ client uses a custom standalone base exception class [1 ] and several derived exceptions [2

Re: [DISCUSS] authorizing function execution

In the case of lambda executions... we have no way to annotate the lambda... So maybe the "outer" service call needs to help us... Maybe the security framework should automatically prevent the execution of any function is the user does not have "DATA:READ"/"DATA:WRITE" or "FUNCTION:EXEC"

Re: [geode-native] branch develop updated: GEODE-3455: Update Solaris build images.

I think these messages should be going to commits@geode? On Thu, Aug 17, 2017 at 11:15 AM, wrote: > This is an automated email from the ASF dual-hosted git repository. > > jbarrett pushed a commit to branch develop > in repository

[geode-native] branch develop updated: GEODE-3455: Update Solaris build images.

This is an automated email from the ASF dual-hosted git repository. jbarrett pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/geode-native.git The following commit(s) were added to refs/heads/develop by this push: new 0fba5ce GEODE-3455: Update Solaris

Re: Changes to Jenkins geode-nightly build job

+1 awesome change... Looking forward to seeing how these work. On 8/17/17 10:35, Jens Deppe wrote: Hi, I'm making changes to the geode-nightly build such that it will use docker containers for distributedTests. This means that these tests can also be parallelized, although for now I'm

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133780406 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandler.java --- @@ -50,51 +37,19 @@

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133778667 --- Diff: geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java --- @@ -392,7 +388,7 @@ public void

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133781367 --- Diff: geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandlerJUnitTest.java --- @@ -32,75

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133778013 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ExecutionContext.java --- @@ -0,0 +1,54 @@ +/* + * Licensed

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133778501 --- Diff: geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java --- @@ -392,7 +388,7 @@ public void

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133779835 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandler.java --- @@ -50,51 +37,19 @@

Re: [DISCUSS] authorizing function execution

> if we get to Lambda-based functions No if about it, this works right now and we do this in our tests :) ResultCollector rc = getExecution().execute(context -> context.getResultSender().lastResult("done") ); -Dan On Thu, Aug 17, 2017 at 9:59 AM, Udo Kohlmeyer wrote:

Re: Changes to Jenkins geode-nightly build job

Thanks Jens, this will be a huge improvement! > On Aug 17, 2017, at 10:35 AM, Jens Deppe wrote: > > Hi, > > I'm making changes to the geode-nightly build such that it will use docker > containers for distributedTests. This means that these tests can also be >

Re: Review Request 61701: GEODE-3277: Fix error path constructors of Launcher inner State classess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61701/#review183145 ---

Changes to Jenkins geode-nightly build job

Hi, I'm making changes to the geode-nightly build such that it will use docker containers for distributedTests. This means that these tests can also be parallelized, although for now I'm setting the parallelism to 1. Initially, this change should help with network isolation for tests so that

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133777949 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java --- @@ -334,42 +342,46 @@ protected void run() {

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133774197 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java --- @@ -334,42 +342,46 @@ protected void run() {

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133775965 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProtoclMessageHandlerLoader.java --- @@ -0,0 +1,64 @@ +/*

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133775201 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java --- @@ -334,42 +342,46 @@ protected void run() {

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133775860 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProtoclMessageHandlerLoader.java --- @@ -0,0 +1,64 @@ +/*

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133775690 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java --- @@ -76,7 +76,9 @@ */ public interface

Re: Review Request 61672: GEODE-3249: internal messages should require credentials

> On Aug. 16, 2017, 4:51 p.m., Brian Rowe wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java > > Lines 1059 (patched) > > > > > > Is this intended to be new

Re: How to export region keys in json file

I think you need to wrap the entire json string in quotes. From GEODE-3001 : gfsh>put --key-class=io.pivotal.gemfire.testing.MyKey --key="{'identifier': 'KIWI131117+65', 'name':'name'}" --value=foo2 --region=/foo On Thu, Aug 17, 2017 at 6:15 AM

Re: [DISCUSS] authorizing function execution

I think there might be more to this than just "Data:READ"/"Data:WRITE". Why would we not support something like /*@Authorize(hasRole("functionExecutor"))*/ or /*@Authorize(requiresPermission("DATA:READ"))*/ The next question in my mind would be, if we get to Lambda-based functions, how do we

Re: [DISCUSS] authorizing function execution

I like the annotation idea, especially considering that Jared was talking about adding a @RegisterableFunction annotation as well. maybe something like @ResourcePermission("Data:READ") or something like that? -Dan On Thu, Aug 17, 2017 at 8:18 AM, Michael William Dodge wrote:

Re: [DISCUSS] authorizing function execution

What about an annotation for read-only functions or a subinterface off org.apache.geode.cache.execute.Function? Sarge > On 17 Aug, 2017, at 01:42, Swapnil Bawaskar wrote: > > Discuss fix for GEODE-2817 > > > Currently

RE: How to export region keys in json file

Hi I tried below, gfsh>query --query='select e.key from /CUSTOMER_1.entrySet e' Result : true startCount : 0 endCount : 20 Rows : 7 name| customerID | cycleCode | customerGroup | partitionID -- | -- | -

RE: How to export region keys in json file

Hi I tried below, gfsh>query --query='select e.key from /CUSTOMER_1.entrySet e' Result : true startCount : 0 endCount : 20 Rows : 7 name| customerID | cycleCode | customerGroup | partitionID -- | -- | -

[GitHub] geode pull request #609: GEODE-2886 : sent IllegalStateException instead of ...

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/609 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #717: Feature/geode 3411

GitHub user aravindmusigumpula opened a pull request: https://github.com/apache/geode/pull/717 Feature/geode 3411 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have

[DISCUSS] authorizing function execution

Discuss fix for GEODE-2817 Currently to execute a function, you will need "data:write" permission, but it really depends on what the function is doing. For example, if a function is just reading data, the function author might want users with