Re: Review Request 59492: GEODE-2966: Refactor LauncherLifecycleCommands (Part 1)

re/src/main/java/org/apache/geode/management/internal/configuration/utils/SharedConfiguration.java Lines 30 (patched) <https://reviews.apache.org/r/59492/#comment249157> Maybe name this ClusterConfiguration instead? - Kirk Lund On May 23, 2017, 5:01 p.m., Jared S

Re: Issues due to Special exceptions in RVV

Are you sure you're using Geode? The signature of RegionVersionHolder#recordVersion in Geode is: RegionVersionHolder#recordVersion(long) I recommend checking out develop branch of Geode, write a test to confirm your bug and then submit that test with a Jira ticket. On Tue, May 23, 2017 at 7:10

Re: Review Request 59287: GEODE-2420: Enable export logs size estimation and user warning

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59287/#review175805 --- Ship it! Ship It! - Kirk Lund On May 23, 2017, 3:45 p.m

Update on final classes and methods

Last week I removed "final" from most class and method declarations in product classes. I left it on several User API classes that represent enumerated types. The reason for removing "final" is to better facilitate mocking in UnitTests. The enumerated types in the User API are very simple and

[jira] [Resolved] (GEODE-2929) Remove superfluous uses of final from classes and methods

[ https://issues.apache.org/jira/browse/GEODE-2929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-2929. -- Resolution: Fixed Fix Version/s: 1.2.0 > Remove superfluous uses of final from clas

[jira] [Resolved] (GEODE-2959) LocatorLauncherTest fails with AssertionError: expected null, but was:<>

[ https://issues.apache.org/jira/browse/GEODE-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-2959. -- Resolution: Fixed Fix Version/s: 1.2.0 CacheXmlParserJUnitTest#testCacheXmlParserWithSimplePool

Fix for LocatorLauncherTest

to existingSystems. This then caused LocatorLauncherTest to fail because that test expects existingSystems to contain zero instances. commit aa189b1a620e543c5fabf007384612f20376be4c Author: Kirk Lund <kl...@apache.org> Date: Mon May 22 11:03:43 2017 -0700 GEODE-2959: remove DistributedSystem in

Re: Review Request 59457: GEODE-2959: remove DistributedSystem instance in tearDown

b0f5c8dc39ff557e6a550bf17eb61fdfc594fd64 Diff: https://reviews.apache.org/r/59457/diff/2/ Changes: https://reviews.apache.org/r/59457/diff/1-2/ Testing --- precheckin in progress Thanks, Kirk Lund

Review Request 59457: GEODE-2959: remove DistributedSystem instance in tearDown

in progress Thanks, Kirk Lund

Fwd: Build failed in Jenkins: Geode-nightly #842

FYI: I'm currently working on the cause of LocatorLauncherTest (UnitTest) finding a DistributedSystem instance. -- Forwarded message -- From: Apache Jenkins Server Date: Sun, May 21, 2017 at 10:37 AM Subject: Build failed in Jenkins: Geode-nightly #842

Re: LocatorLauncherTest is failing

eproduce on any local machines, well that's just weird and I don't know what to do for precheckin runs on AWS. On Fri, May 19, 2017 at 3:13 PM, Kirk Lund <kl...@apache.org> wrote: > The LocatorLauncherTest (a UnitTest) is now failing but only in > precheckin. When I run it locally it passe

[jira] [Commented] (GEODE-2959) LocatorLauncherTest fails with AssertionError: expected null, but was:<>

[ https://issues.apache.org/jira/browse/GEODE-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018119#comment-16018119 ] Kirk Lund commented on GEODE-2959: -- This test consistently passes when executed in isolation. It runs

[jira] [Updated] (GEODE-2959) LocatorLauncherTest fails with AssertionError: expected null, but was:<>

[ https://issues.apache.org/jira/browse/GEODE-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2959: - Description: {noformat} :geode-core:test org.apache.geode.distributed.LocatorLauncherTest

[jira] [Created] (GEODE-2959) LocatorLauncherTest fails with AssertionError: expected null, but was:<>

Kirk Lund created GEODE-2959: Summary: LocatorLauncherTest fails with AssertionError: expected null, but was:<> Key: GEODE-2959 URL: https://issues.apache.org/jira/browse/GEODE-2959 Project:

[jira] [Assigned] (GEODE-2959) LocatorLauncherTest fails with AssertionError: expected null, but was:<>

[ https://issues.apache.org/jira/browse/GEODE-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-2959: Assignee: Kirk Lund > LocatorLauncherTest fails with AssertionError: expected n

LocatorLauncherTest is failing

The LocatorLauncherTest (a UnitTest) is now failing but only in precheckin. When I run it locally it passes consistently. I don't have a fix yet but I'm looking into it. It might continue failing all weekend. Sorry.

Re: Review Request 59384: GEODE-1930: temporarily disable verifySystemNotifications

: https://reviews.apache.org/r/59384/diff/1/ Testing (updated) --- precheckin passed Thanks, Kirk Lund

Review Request 59386: GEODE-2929: remove superfluous uses of final to facilitate mocking

/support/RegionData.java ea9237e973f96c51a71a4b16305bd9c889fc22b9 geode-web-api/src/test/java/org/apache/geode/rest/internal/web/controllers/support/RegionDataTest.java PRE-CREATION Diff: https://reviews.apache.org/r/59386/diff/1/ Testing --- precheckin passed Thanks, Kirk Lund

Review Request 59384: GEODE-1930: temporarily disable verifySystemNotifications

/diff/1/ Testing --- precheckin in progress Thanks, Kirk Lund

What to do with Singletons

I've been digging through our code with close attention to the singletons. I believe the majority of singletons in Geode exist for two main reasons: 1) Insufficient context or lack of service lookup for Function, DistributionMessage and (Client)Command implementations. 2) Poor OO design. This is

Re: Review Request 59374: GEODE-1597: fix auto-complete when user input ends with space

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59374/#review175429 --- Ship it! Ship It! - Kirk Lund On May 18, 2017, 7:42 p.m

[jira] [Resolved] (GEODE-2934) Refactor AnalyzeSerializablesJUnitTest and subclasses

[ https://issues.apache.org/jira/browse/GEODE-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-2934. -- Resolution: Fixed Fix Version/s: 1.2.0 > Refactor AnalyzeSerializablesJUnitTest and subclas

Re: org.apache.geode.internal.InternalDataSerializer API Changes...

s/current/api/ > org/springframework/data/gemfire/client/PoolFactoryBean.html > > > On Thu, May 18, 2017 at 10:18 AM, Bruce Schuchardt <bschucha...@pivotal.io > > > wrote: > > > John, is it possible to list the internal APIs needed by SDG? I don't > &

Re: org.apache.geode.internal.InternalDataSerializer API Changes...

Hi John! How did the addition of getOnlineLocators() cause SDG build to fail? I checked [9] but I couldn't quite grok what happened. I would've thought that adding would be ok but removing could potentially break SDG. The InternalDataSerializer change was probably mine. I reduced scope of methods

Re: Review Request 59326: GEODE-2934: refactor AnalyzeSerializablesJUnitTest and subclasses

; equivalent of "import package.Class" -- spotless doesn't seem to care either way - Kirk --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59326/#review175277 --

Review Request 59326: GEODE-2934: refactor AnalyzeSerializablesJUnitTest and subclasses

s://reviews.apache.org/r/59326/diff/1/ Testing --- precheckin in progress Thanks, Kirk Lund

[jira] [Assigned] (GEODE-2934) Refactor AnalyzeSerializablesJUnitTest and subclasses

[ https://issues.apache.org/jira/browse/GEODE-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-2934: Assignee: Kirk Lund > Refactor AnalyzeSerializablesJUnitTest and subclas

[jira] [Created] (GEODE-2934) Refactor AnalyzeSerializablesJUnitTest and subclasses

Kirk Lund created GEODE-2934: Summary: Refactor AnalyzeSerializablesJUnitTest and subclasses Key: GEODE-2934 URL: https://issues.apache.org/jira/browse/GEODE-2934 Project: Geode Issue Type: Wish

Review Request 59324: GEODE-1279: rename Bug51193DUnitTest to ClientFunctionTimeoutRegressionTest

, Kirk Lund

Problems in the gradle idea generated project

If I use the idea plugin to generate an IntelliJ project for Geode: $ ./gradlew idea ...the resulting IntelliJ project contains "5 Problems" involving the extensions modules: *Module geode-modules-session: invalid item 'extensions/geode-modules-session-internal' in the dependencies list*

Re: Review Request 59316: GEODE-2927: fix pulse logging and useLocator, SSL flags

(patched) <https://reviews.apache.org/r/59316/#comment248517> Everything in this file is commented out? Also, all of the other config files for log4j2 in geode are xml instead of properties. It's probably best to keep them all the same format. - Kirk Lund On May 16, 2017, 5:

[jira] [Assigned] (GEODE-2930) Remove unused serialVersionUIDs from non-Serializable clases

[ https://issues.apache.org/jira/browse/GEODE-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-2930: Assignee: Kirk Lund > Remove unused serialVersionUIDs from non-Serializable cla

[jira] [Created] (GEODE-2930) Remove unused serialVersionUIDs from non-Serializable clases

Kirk Lund created GEODE-2930: Summary: Remove unused serialVersionUIDs from non-Serializable clases Key: GEODE-2930 URL: https://issues.apache.org/jira/browse/GEODE-2930 Project: Geode Issue

Review Request 59298: GEODE-2929: remove final from classes in internal or test packages

/geode/management/internal/web/shell/SimpleHttpOperationInvokerJUnitTest.java a704654c3223296d2ded64aef5ee99e7c3ead236 Diff: https://reviews.apache.org/r/59298/diff/1/ Testing --- precheckin in progress Thanks, Kirk Lund

Re: Review Request 59287: GEODE-2420: Enable export logs size estimation and user warning

/internal/cli/commands/ExportLogsCommandTest.java Lines 160 (patched) <https://reviews.apache.org/r/59287/#comment248340> My merge to develop might cause you some weirdness. You might want to mock InternalCache instead but I'm not sure. - Kirk Lund On May 15, 2017, 7:50 p.m., Ke

Use InternalCache instead of GemFireCacheImpl

I just merged in a big refactoring which changes classes that were using GemFireCacheImpl to using InternalCache. InternalCache is an interface representing the internal view of Cache which exposes all the operations that aren't exposed in the User API of Cache or GemFireCache. InternalCache and

[jira] [Assigned] (GEODE-2929) Remove superfluous uses of final from classes and methods

[ https://issues.apache.org/jira/browse/GEODE-2929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-2929: Assignee: Kirk Lund > Remove superfluous uses of final from classes and meth

[jira] [Created] (GEODE-2929) Remove superfluous uses of final from classes and methods

Kirk Lund created GEODE-2929: Summary: Remove superfluous uses of final from classes and methods Key: GEODE-2929 URL: https://issues.apache.org/jira/browse/GEODE-2929 Project: Geode Issue Type

[jira] [Commented] (GEODE-1930) JMX DistributedTests are in need of overhauling

[ https://issues.apache.org/jira/browse/GEODE-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011070#comment-16011070 ] Kirk Lund commented on GEODE-1930: -- RegionManagementDUnitTest has multiple flaky tests and is failing

Re: Review Request 59246: GEODE-2876: reset isGfshVM flag to false when tearing down tests using CliCommandTestBase.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59246/#review174864 --- Ship it! Ship It! - Kirk Lund On May 12, 2017, 10:12 p.m

[jira] [Commented] (GEODE-2911) LocatorDUnitTest.testLeadAndCoordFailure

[ https://issues.apache.org/jira/browse/GEODE-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008752#comment-16008752 ] Kirk Lund commented on GEODE-2911: -- I seem to be hitting this failure very consistently

Re: Review Request 59035: GEODE-2883: Fix GFSH gc heap size output

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59035/#review174347 --- Ship it! Ship It! - Kirk Lund On May 5, 2017, 11:19 p.m

Re: Review Request 59098: GEODE-2876: add logging to diagnose parser test failure in Jenkins

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59098/#review174346 --- Ship it! Ship It! - Kirk Lund On May 9, 2017, 3:32 p.m

Re: Revert gradle upgrade

I've reverted the upgrade to gradle 3.4.1. I also went ahead and created a branch that repeats the upgrade: feature/gradle-3.4.1 Feel free to experiment with that branch. On Tue, May 9, 2017 at 9:53 AM, Kirk Lund <kl...@apache.org> wrote: > I'll go ahead and revert the upgrade. Hop

Re: Revert gradle upgrade

I'll go ahead and revert the upgrade. Hopefully we can eventually find the cause so we can repeat the upgrade. On Mon, May 8, 2017 at 4:19 PM, Bruce Schuchardt <bschucha...@pivotal.io> wrote: > The "eclipse" target fails, too. > > Le 5/8/2017 à 3:32 PM, Kirk Lund a écri

GMSMembershipManagerJUnitTest failing consistently in precheckin

I don't see this test failing in the nightly build but it seems to fail consistently for me in precheckin (last 6 precheckins). Any ideas what's wrong? Is anyone already looking into this failure? :geode-core:test

Re: gradle upgrade has broken IntelliJ

: Update Minimum Gradle Version To 3.4.1 commit 9ed9e329f89f09ff2d91e1de48f17c9bbbf54512 Author: Mark Bretl <mbr...@kollective.com> Date: Sat Apr 8 12:11:19 2017 -0700 GEODE-2708: Update Gradle Wrapper To 3.4.1 Tested and Verified By: ./gradlew precheckin On Mon, May 8, 2017 at 1

Re: Build failed in Jenkins: Geode-nightly #829

Looks like AdminRegion isn't "a Region" -- it's some sort of snapshot of a Region. I don't know anything more than you unfortunately. On Mon, May 8, 2017 at 11:05 AM, Avinash Dongre wrote: > It looks like >

Re: gradle upgrade has broken IntelliJ

Looks like other projects are seeing this or something similar. Anyone with more gradle expertise want to try and fix this? There's some mention of a workaround here: https://github.com/akhikhl/gretty/issues/306 On Mon, May 8, 2017 at 11:00 AM, Kirk Lund <kl...@apache.org> wrote: > L

Re: gradle upgrade has broken IntelliJ

he rest of us. On Mon, May 8, 2017 at 10:46 AM, Kirk Lund <kl...@apache.org> wrote: > Our recent gradle upgrade seems to have broken IntelliJ. I've tried > refreshing from gradle. I've even tried deleting .idea and my IntelliJ > output directory and rebuilding my IntelliJ project

gradle upgrade has broken IntelliJ

Our recent gradle upgrade seems to have broken IntelliJ. I've tried refreshing from gradle. I've even tried deleting .idea and my IntelliJ output directory and rebuilding my IntelliJ project in a couple different ways. No matter what I do, it seems to be stuck and IntelliJ refuses to work now.

[jira] [Assigned] (GEODE-2887) Exclude build-* output directories from rat license checking

[ https://issues.apache.org/jira/browse/GEODE-2887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-2887: Assignee: Kirk Lund > Exclude build-* output directories from rat license check

[jira] [Updated] (GEODE-2887) Exclude build-* output directories from rat license checking

[ https://issues.apache.org/jira/browse/GEODE-2887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2887: - Description: The rat.gradle excludes "build" which is the directory that gradle writes to whe

[jira] [Updated] (GEODE-2887) Exclude build-* output directories from rat license checking

[ https://issues.apache.org/jira/browse/GEODE-2887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2887: - Description: The rat.gradle excludes \**/build/\** which is the directory that gradle writes to when

[jira] [Created] (GEODE-2887) Exclude build-* output directories from rat license checking

Kirk Lund created GEODE-2887: Summary: Exclude build-* output directories from rat license checking Key: GEODE-2887 URL: https://issues.apache.org/jira/browse/GEODE-2887 Project: Geode Issue

Re: Review Request 58682: GEODE-2662: Missing keys cause columns to shift in gfsh table display.

> This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58682/ > --- > > (Updated May 5, 2017, 9:22 p.m.) > > > Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, > and

[jira] [Comment Edited] (GEODE-2858) Add test to verify successful load of configuration with pool or locator

[ https://issues.apache.org/jira/browse/GEODE-2858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999038#comment-15999038 ] Kirk Lund edited comment on GEODE-2858 at 5/5/17 10:12 PM: --- I discovered

[jira] [Commented] (GEODE-2858) Add test to verify successful load of configuration with pool or locator

[ https://issues.apache.org/jira/browse/GEODE-2858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999038#comment-15999038 ] Kirk Lund commented on GEODE-2858: -- I discovered and filed GEODE-2884 while testing GEODE-2858. I'll

[jira] [Updated] (GEODE-2884) ClassPathLoader.getLatestAsClassLoader() throws NullPointerException if called before getLatest()

[ https://issues.apache.org/jira/browse/GEODE-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2884: - Affects Version/s: 1.0.0-incubating 1.1.0 1.1.1

[jira] [Created] (GEODE-2884) ClassPathLoader.getLatestAsClassLoader() throws NullPointerException if called before getLatest()

Kirk Lund created GEODE-2884: Summary: ClassPathLoader.getLatestAsClassLoader() throws NullPointerException if called before getLatest() Key: GEODE-2884 URL: https://issues.apache.org/jira/browse/GEODE-2884

[jira] [Assigned] (GEODE-2884) ClassPathLoader.getLatestAsClassLoader() throws NullPointerException if called before getLatest()

[ https://issues.apache.org/jira/browse/GEODE-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-2884: Assignee: Kirk Lund > ClassPathLoader.getLatestAsClassLoader() throws NullPointerExcept

[jira] [Assigned] (GEODE-2858) Add test to verify successful load of configuration with pool or locator

[ https://issues.apache.org/jira/browse/GEODE-2858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-2858: Assignee: Kirk Lund > Add test to verify successful load of configuration with pool or loca

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

ly, visit: https://reviews.apache.org/r/5/#review173972 ------- On May 3, 2017, 10:10 p.m., Kirk Lund wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 58996: GEODE-2876: Add logging to diagnose CI failure

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58996/#review173938 --- Ship it! Ship It! - Kirk Lund On May 4, 2017, 5:12 p.m

[jira] [Updated] (GEODE-2790) DiskSpaceLimitIntegrationTest.aboveZeroDeletesPreviousFiles_nameWithHyphen fails intermittently with ComparisonFailure

[ https://issues.apache.org/jira/browse/GEODE-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2790: - Labels: Flaky (was: ) > DiskSpaceLimitIntegrationTest.aboveZeroDeletesPreviousFiles_nameWithHyp

[jira] [Resolved] (GEODE-2857) Add getProcess to ProcessWrapper

[ https://issues.apache.org/jira/browse/GEODE-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-2857. -- Resolution: Fixed > Add getProcess to ProcessWrap

[jira] [Updated] (GEODE-2857) Add getProcess to ProcessWrapper

[ https://issues.apache.org/jira/browse/GEODE-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2857: - Fix Version/s: 1.2.0 > Add getProcess to ProcessWrap

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

ched) <https://reviews.apache.org/r/5/#comment246876> Delete these valueOf calls. - Kirk Lund On May 3, 2017, 10:10 p.m., Kirk Lund wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

, Kirk Lund

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

f5495b37d47df008cb9b8126396bba02ddcc62f3 Diff: https://reviews.apache.org/r/5/diff/3/ Changes: https://reviews.apache.org/r/5/diff/2-3/ Testing --- precheckin and full regression in progress Thanks, Kirk Lund

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

tomatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review173655 --- On May 2, 2017, 12:06 a.m., Kirk Lund wrote: > > --- > This is an au

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

ly, visit: https://reviews.apache.org/r/5/#review173650 --- On May 2, 2017, 12:06 a.m., Kirk Lund wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

il. To reply, visit: https://reviews.apache.org/r/5/#review173786 --- On May 2, 2017, 12:06 a.m., Kirk Lund wrote: > > --- > This is an automat

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

to volatile. - Kirk --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review173605 --- On May 2, 2017, 12:06 a.m., K

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review173665 ------- On May 2, 2017, 12:06 a.m., Kirk Lund wrote: > > --- > Thi

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

is is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review173596 --- On May 2, 2017, 12:06 a.m., Kirk Lund wrote: > > --- > Thi

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

--- On May 2, 2017, 12:06 a.m., Kirk Lund wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5/ > ---

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

lines later that didn't get changed. - Kirk --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review173754 --- On May 2, 2017, 12:06 a.m., Kirk Lund wrote: > > ---

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

eviews.apache.org/r/5/#review173753 ------- On May 2, 2017, 12:06 a.m., Kirk Lund wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

/PartitionedRegion.java Lines 8623 (patched) <https://reviews.apache.org/r/5/#comment246727> Remove this Cause - Kirk Lund On May 2, 2017, 12:06 a.m., Kirk Lund wrote: > > --- > This is an automatically generated e-mail.

Re: Build failed in Jenkins: Geode-nightly #823

ailed. > :geode-core:distributedTestBuild was aborted > > > > On Wed, May 3, 2017 at 9:40 AM, Kirk Lund <kl...@apache.org> wrote: > > > Nightly build failed but the Tests tab says all tests passed. I don't see > > any problems in build output. Anyone know what caus

Fwd: Build failed in Jenkins: Geode-nightly #823

Nightly build failed but the Tests tab says all tests passed. I don't see any problems in build output. Anyone know what caused it to fail? -- Forwarded message -- From: Apache Jenkins Server Date: Tue, May 2, 2017 at 8:45 PM Subject: Build failed in

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

> On May 1, 2017, 11:34 p.m., Kirk Lund wrote: > > geode-core/src/test/java/org/apache/geode/cache/query/CacheUtils.java > > Line 77 (original), 80 (patched) > > <https://reviews.apache.org/r/5/diff/1/?file=1704521#file1704521line95> > > > >

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

/ Testing --- precheckin and full regression in progress Thanks, Kirk Lund

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

. I'll fix that as well. - Kirk --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review173512 --- On May 1,

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review173500 --- On May 1, 2017, 7:59 p.m., Kirk Lund wrote: > > ---

[jira] [Created] (GEODE-2857) Add getProcess to ProcessWrapper

Kirk Lund created GEODE-2857: Summary: Add getProcess to ProcessWrapper Key: GEODE-2857 URL: https://issues.apache.org/jira/browse/GEODE-2857 Project: Geode Issue Type: Wish Components

[jira] [Assigned] (GEODE-2857) Add getProcess to ProcessWrapper

[ https://issues.apache.org/jira/browse/GEODE-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-2857: Assignee: Kirk Lund > Add getProcess to ProcessWrap

[jira] [Resolved] (GEODE-2856) CacheServerLauncherDUnitTest.testRebalance intermittently fails assertion for number of buckets

[ https://issues.apache.org/jira/browse/GEODE-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-2856. -- Resolution: Won't Fix Test does not exist > CacheServerLauncherDUnitTest.testRebalance intermitten

[jira] [Closed] (GEODE-2856) CacheServerLauncherDUnitTest.testRebalance intermittently fails assertion for number of buckets

[ https://issues.apache.org/jira/browse/GEODE-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund closed GEODE-2856. > CacheServerLauncherDUnitTest.testRebalance intermittently fails assertion for > number of b

[jira] [Created] (GEODE-2856) CacheServerLauncherDUnitTest.testRebalance intermittently fails assertion for number of buckets

Kirk Lund created GEODE-2856: Summary: CacheServerLauncherDUnitTest.testRebalance intermittently fails assertion for number of buckets Key: GEODE-2856 URL: https://issues.apache.org/jira/browse/GEODE-2856

Re: Review Request 58849: GEODE-2840: add a DUnit test to test concurrent deploy

/test/java/org/apache/geode/management/internal/cli/commands/ConcurrentDeployDUnitTest.java Lines 74 (patched) <https://reviews.apache.org/r/58849/#comment246478> You should null out the static variable as well: ```java Invoke.invokeInEveryVM(() -> gfsh = null); ``` -

Re: Review Request 58682: GEODE-2662: Missing keys cause columns to shift in gfsh table display.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58682/#review173481 --- Ship it! Ship It! - Kirk Lund On April 27, 2017, 6:30 p.m

Re: Review Request 58848: GEODE-2632: prevent ClassCastException from ConnectionCountProbe to Identifiable

://reviews.apache.org/r/58848/diff/2-3/ Testing --- precheckin in progress Thanks, Kirk Lund

Re: Review Request 58848: GEODE-2632: prevent ClassCastException from ConnectionCountProbe to Identifiable

f3510dafa3da854317af32cadbb09cab9af98e4c Diff: https://reviews.apache.org/r/58848/diff/2/ Changes: https://reviews.apache.org/r/58848/diff/1-2/ Testing --- precheckin in progress Thanks, Kirk Lund

Review Request 58848: GEODE-2632: prevent ClassCastException from ConnectionCountProbe to Identifiable

- geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java f3510dafa3da854317af32cadbb09cab9af98e4c Diff: https://reviews.apache.org/r/58848/diff/1/ Testing --- precheckin in progress Thanks, Kirk Lund

Re: Review Request 58682: GEODE-2662: Missing keys cause columns to shift in gfsh table display.

/cli/commands/DataCommands.java Line 167 (original), 170 (patched) <https://reviews.apache.org/r/58682/#comment246298> Delete these two unused HashSets. I know it's not part of your change, but yuck this is bad! - Kirk Lund On April 27, 2017, 6:30 p.m., Patrick Rhomberg

Re: Simple Java Client

"geode-client-api.jar" (not ai) On Thu, Apr 27, 2017 at 2:20 PM, Kirk Lund <kl...@pivotal.io> wrote: > Different module or different repo is same thing I'm suggesting. Make it > separate and independent such that a Client can be compiled only with > geode-client-ai.jar.

Re: Simple Java Client

ient code with a new API. We should > keep the new client code separate from the server. Maybe even in a > different repo, as I think Fred suggested. > > Le 4/26/2017 à 3:12 PM, Kirk Lund a écrit : > >> If we want to add a new API then I suggest we create new API packages an

Re: Simple Java Client

> > > > > > Microservices/applications are the new concurrency), then I > > am > > > > > really > > > > > > > > > saying the same thing." > > > > > > > > > > > > > &

<    4   5   6   7   8   9   10   11   12   13   >