Github user dgkimura commented on the issue:
https://github.com/apache/geode-native/pull/115
@pivotal-jbarrett: Ship-it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user dgkimura commented on the issue:
https://github.com/apache/geode-native/pull/115
@pivotal-jbarrett I was referring to `FindNativeClient.cmake` and
`FindNativeClientCPPCache.cmake`.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/115#discussion_r132757951
--- Diff: CMakeLists.txt ---
@@ -242,7 +242,7 @@ add_subdirectory(dhimpl)
add_subdirectory(sqliteimpl)
add_subdirectory(tests
Github user dgkimura closed the pull request at:
https://github.com/apache/geode-native/pull/114
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user dgkimura opened a pull request:
https://github.com/apache/geode-native/pull/114
GEODE-2729: Remove global variables
- Remove CacheImpl::getInstance calls
- Converted PdxTypeRegistry clear to non-static method
- Adding Type Registry to cpp code as a public object
Github user dgkimura closed the pull request at:
https://github.com/apache/geode-native/pull/112
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user dgkimura closed the pull request at:
https://github.com/apache/geode-native/pull/109
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user dgkimura opened a pull request:
https://github.com/apache/geode-native/pull/112
GEODE-3173: Upgrade to gtest 1.8
Upgrade to gtest 1.8 which also gives us gmock.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dgkimura
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/107#discussion_r128660879
--- Diff: src/cppcache/src/StructSetImpl.cpp ---
@@ -66,25 +66,22 @@ SelectResultsIterator StructSetImpl::getIterator() {
return
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/107#discussion_r128661186
--- Diff: src/cppcache/test/StructSetTest.cpp ---
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/107#discussion_r126173633
--- Diff: src/cppcache/include/geode/Struct.hpp ---
@@ -138,7 +138,7 @@ class CPPCACHE_EXPORT Struct : public Serializable {
* Returns
GitHub user dgkimura opened a pull request:
https://github.com/apache/geode-native/pull/109
GEODE-3173: Upgrade to gtest 1.8
Upgrades to gtest 1.8.
Testing: Unittests compiled and ran
You can merge this pull request into a Git repository by running:
$ git pull https
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/107#discussion_r126027361
--- Diff: src/cppcache/include/geode/Struct.hpp ---
@@ -138,7 +138,7 @@ class CPPCACHE_EXPORT Struct : public Serializable {
* Returns
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/107#discussion_r126027851
--- Diff: src/cppcache/include/geode/Struct.hpp ---
@@ -152,9 +152,7 @@ class CPPCACHE_EXPORT Struct : public Serializable {
Struct
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/107#discussion_r126028200
--- Diff: src/cppcache/integration-test/testThinClientRemoteQuerySS.cpp ---
@@ -56,59 +57,63 @@ const wchar_t* checkNullString(const wchar_t* str
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/103#discussion_r123862142
--- Diff: src/tests/cpp/fwklib/GsRandom.cpp ---
@@ -18,60 +18,16 @@
#include "GsRandom.hpp"
#include
-#include
Github user dgkimura closed the pull request at:
https://github.com/apache/geode-native/pull/97
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user dgkimura opened a pull request:
https://github.com/apache/geode-native/pull/97
Ignore me. This is a test for Scott
Ignore me. This is a test for Scott
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dgkimura/geode
Github user dgkimura closed the pull request at:
https://github.com/apache/geode-native/pull/83
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/83#discussion_r109744732
--- Diff: src/cppcache/src/ExecutionImpl.cpp ---
@@ -100,33 +94,31 @@ ResultCollectorPtr ExecutionImpl::execute(const char*
fn, uint32_t timeout
GitHub user dgkimura opened a pull request:
https://github.com/apache/geode-native/pull/83
GEODE-2691: Fix function execution attributes mismatch
Fixes function execution invocation which previously passed in attributes
that
function execute would compare to the server's view
Github user dgkimura commented on the issue:
https://github.com/apache/geode-native/pull/54
@pivotal-jbarrett Okay. Fair enough. That's going to add some cycles to
this pull-request.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user dgkimura commented on the issue:
https://github.com/apache/geode-native/pull/54
@echobravopapa We're only human.
Our unittest didn't catch it originally because the output that's written
to DataOutput in the constructor is the same with/without this variable set
GitHub user dgkimura opened a pull request:
https://github.com/apache/geode-native/pull/54
GEODE-2657: Execute Region Function sends incorrect message format
`TcrMessageExecuteRegionFunction` is missing a call to set `m_hasResults`.
This causes the message response to be parsed
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/42#discussion_r103572486
--- Diff: src/quickstart/cpp/CMakeLists.txt ---
@@ -26,16 +26,6 @@ elseif(UNIX)
set(DYNAMIC_LIBRARY_PATH LD_LIBRARY_PATH=${NATIVECLIENT_DIR
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/42#discussion_r103572140
--- Diff: src/quickstart/runcpp.sh.in ---
@@ -69,7 +69,6 @@ else
echo 22.PdxRemoteQuery
echo 23.PdxSerializer
echo 24
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/42#discussion_r103572155
--- Diff: src/quickstart/runcpp.sh.in ---
@@ -150,9 +149,6 @@ else
"24")
exname='PdxInstance'
;;
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/42#discussion_r103564551
--- Diff: src/tests/cli/NewFwkLib/NewFwkLib.csproj.in ---
@@ -272,9 +272,6 @@
SmokePerf\NoopAuthInit.cs
GitHub user dgkimura opened a pull request:
https://github.com/apache/geode-native/pull/42
GEODE-2441: Remove leftover pdx auto serializer references
Remove leftover references from previous commits under GEODE-2441. After
this pull-request there are no references returned from
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103251295
--- Diff: src/tests/cpp/security/Security.cpp ---
@@ -1014,12 +1016,15 @@ int32_t Security::doEntryOperations() {
reinterpret_cast
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103258079
--- Diff: src/cppcache/src/LRUList.cpp ---
@@ -96,33 +102,38 @@ void LRUList<TEntry,
TCreateEntry>::getLRUEntry(LRUListEntryPtr&a
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103258922
--- Diff: src/cppcache/src/MapSegment.cpp ---
@@ -19,18 +19,22 @@
#include "TrackedMapEntry.hpp"
#include "RegionInternal.hpp
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103256152
--- Diff: src/cppcache/src/CqQueryVsdStats.cpp ---
@@ -20,43 +20,38 @@
#include "CqQueryVsdStats.hpp"
//#include "Statis
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103252234
--- Diff: src/cppcache/src/MapSegment.hpp ---
@@ -164,9 +166,9 @@ class CPPCACHE_EXPORT MapSegment {
m_entryFactory->newMapEntry(key, newEn
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103252978
--- Diff: src/cppcache/integration-test/testSpinLock.cpp ---
@@ -20,48 +20,44 @@
#include "fw_dunit.hpp"
#include
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103257643
--- Diff: src/cppcache/src/LRUList.cpp ---
@@ -15,12 +15,18 @@
* limitations under the License.
*/
#include "LRULis
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103256958
--- Diff: src/cppcache/src/CqQueryVsdStats.cpp ---
@@ -108,21 +98,21 @@ CqQueryStatType::CqQueryStatType
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103262976
--- Diff: src/cppcache/src/MapSegment.hpp ---
@@ -41,6 +40,9 @@
#include
#include "TombstoneList.hpp"
#include
+
GitHub user dgkimura opened a pull request:
https://github.com/apache/geode-native/pull/35
GEODE-2439: Fix build breaking merge from merge conflict
Build broke after bad merge with commits: GEODE-2439 and GEODE-2440.
Conflict was resolved incorrectly by accidentally
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103045677
--- Diff: src/tests/cpp/fwklib/Timer.hpp ---
@@ -28,18 +28,18 @@
#ifdef _WIN32
-#include
-#include
-#include
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103044451
--- Diff: src/cppcache/src/Utils.cpp ---
@@ -22,7 +22,7 @@
#include
extern "C" {
-#include
+#include
--
Github user dgkimura commented on the issue:
https://github.com/apache/geode-native/pull/33
@PivotalSarge This is the relevant code after the patch is applied so my
guess is there was a workaround in `antlr` that was probably non-portable.
```cpp
#if ( _MSC_VER == 1200
GitHub user dgkimura reopened a pull request:
https://github.com/apache/geode-native/pull/32
GEODE-2439: Replace c-style headers with c++ headers
Purpose is to remove potentially non-portable c headers with the c++
equivalent headers.
Testing - built on OSX
You can merge
Github user dgkimura commented on the issue:
https://github.com/apache/geode-native/pull/32
@echobravopapa Yessir
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user dgkimura closed the pull request at:
https://github.com/apache/geode-native/pull/32
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103009496
--- Diff: src/tests/cpp/security/PkcsAuthInit.cpp ---
@@ -19,7 +19,7 @@
#include
#include
#include
-#include "st
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103009417
--- Diff: src/tests/cpp/security/XmlAuthzCredentialGenerator.hpp ---
@@ -27,7 +27,7 @@
#include
#include
--- End diff
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103009143
--- Diff: src/tests/cpp/fwklib/TaskClient.cpp ---
@@ -20,12 +20,12 @@
#include "fwklib/FwkLog.hpp"
#include "fwk
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103008731
--- Diff: src/cppcache/test/ByteArray.cpp ---
@@ -20,7 +20,7 @@
#include "config.h"
#ifdef _MACOSX
-#include // Fo
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103008420
--- Diff: src/cppcache/test/ByteArray.cpp ---
@@ -20,7 +20,7 @@
#include "config.h"
#ifdef _MACOSX
--- End diff --
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103008324
--- Diff: src/cppcache/src/statistics/HostStatHelperWin.hpp ---
@@ -27,10 +27,10 @@
#include
#include
-#include
-#include
GitHub user dgkimura opened a pull request:
https://github.com/apache/geode-native/pull/32
GEODE-2439: Replace c-style headers with c++ headers
Purpose is to remove potentially non-portable c headers with the c++
equivalent headers.
Testing - built on OSX
You can merge
Github user dgkimura commented on the issue:
https://github.com/apache/geode-native/pull/27
@echobravopapa Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user dgkimura commented on the issue:
https://github.com/apache/geode-native/pull/27
@pivotal-jbarrett Yes. Shall I redo? I had decided to use the github UI
to resolve conflict and that's how it came out. I guess that's what I get for
leaving the terminal?
---
If your
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102826049
--- Diff: src/cppcache/src/statistics/StatisticDescriptorImpl.cpp ---
@@ -41,8 +41,8 @@ StatisticDescriptorImpl::StatisticDescriptorImpl(const
char
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102825954
--- Diff: src/cppcache/src/statistics/HostStatHelperSolaris.cpp ---
@@ -86,23 +86,23 @@ void
HostStatHelperSolaris::refreshProcess(ProcessStats
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102825908
--- Diff: src/cppcache/src/statistics/GeodeStatisticsFactory.hpp ---
@@ -98,50 +98,50 @@ class GeodeStatisticsFactory : public StatisticsFactory
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102825863
--- Diff: src/cppcache/src/RegionStats.hpp ---
@@ -129,7 +129,7 @@ class CPPCACHE_EXPORT RegionStats {
class RegionStatType {
private
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102774038
--- Diff: src/cppcache/src/PdxHelper.cpp ---
@@ -183,9 +183,9 @@ void PdxHelper::serializePdx(DataOutput& output,
nType->Initial
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102774094
--- Diff: src/cppcache/src/statistics/StatArchiveWriter.cpp ---
@@ -228,10 +228,10 @@ void ResourceInst::writeStatValue(StatisticDescriptor
*sd, int64
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102774081
--- Diff: src/cppcache/src/PdxType.hpp ---
@@ -89,7 +89,7 @@ class PdxType : public Serializable,
int32_t* m_localToRemoteFieldMap
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102774104
--- Diff: src/cppcache/src/statistics/StatArchiveWriter.cpp ---
@@ -434,17 +434,17 @@ void StatArchiveWriter::openFile(std::string
filename
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102772118
--- Diff:
src/cppcache/integration-test/testThinClientFixedPartitionResolver.cpp ---
@@ -245,7 +245,7 @@ DUNIT_TASK_DEFINITION(CLIENT1
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102772225
--- Diff: src/cppcache/src/CacheImpl.cpp ---
@@ -185,8 +185,8 @@ bool CacheImpl::getAndResetNetworkHopFlag() {
return networkhop
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102772209
--- Diff: src/cppcache/src/BucketServerLocation.hpp ---
@@ -130,7 +130,7 @@ class BucketServerLocation : public ServerLocation
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102772252
--- Diff: src/cppcache/src/CqServiceVsdStats.hpp ---
@@ -108,7 +108,7 @@ class CPPCACHE_EXPORT CqServiceVsdStats : public
CqServiceStatistics
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102772268
--- Diff: src/cppcache/src/RegionStats.hpp ---
@@ -129,7 +129,7 @@ class CPPCACHE_EXPORT RegionStats {
class RegionStatType {
private
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102771834
--- Diff: src/cppcache/include/geode/statistics/StatisticsFactory.hpp ---
@@ -96,7 +96,7 @@ class CPPCACHE_EXPORT StatisticsFactory
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102771046
--- Diff: src/cppcache/include/geode/geode_base.hpp ---
@@ -69,32 +69,9 @@
#define GF_TEMPLATE_EXPORT
#endif
-#if defined(_MSC_VER
GitHub user dgkimura opened a pull request:
https://github.com/apache/geode-native/pull/27
GEODE-2439: Remove int type definitions
Purpose of this pull-request is to remove references to alleged
non-portable `inttypes.h` header. References are replaced with fixed width
integer
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/24#discussion_r102532340
--- Diff: src/cppcache/src/CppCacheLibrary.cpp ---
@@ -127,15 +127,18 @@ std::string CppCacheLibrary::getProductLibDir() {
for (int i = 0; i
GitHub user dgkimura opened a pull request:
https://github.com/apache/geode-native/pull/21
GEODE-2441: Remove pdx auto serializer from core sources
Purpose of this pull-request is to simplify core dependencies and core
source size by removing PdxAutoSerializer and related tests
GitHub user dgkimura opened a pull request:
https://github.com/apache/geode-native/pull/18
Revert "GEODE-2484 Replace ace calls to standard functions"
Revert build break on VS 2013 which does not have complete
C++11 features, e.g. std::snprintf.
This reve
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/15#discussion_r101652960
--- Diff: src/cppcache/src/TcrMessage.hpp ---
@@ -20,6 +20,10 @@
* limitations under the License.
*/
+//#include
--- End
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/15#discussion_r101655637
--- Diff: src/cppcache/src/TcrMessage.hpp ---
@@ -1113,12 +1117,11 @@ class TcrMessageHelper {
return NULL_OBJECT;
} else
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/15#discussion_r101580799
--- Diff: src/cppcache/src/TcrMessage.hpp ---
@@ -1135,7 +1137,7 @@ class TcrMessageHelper {
return EXCEPTION;
} else
GitHub user dgkimura opened a pull request:
https://github.com/apache/geode-native/pull/12
GEODE-2309: Remove or ignore apache-rat flagged files
`resolv.config` used to work around Solaris SPARC networking issues on a
local OpenStack instance. It should not be needed going forward
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/3#discussion_r100938599
--- Diff: src/cppcache/src/CacheXmlParser.cpp ---
@@ -1165,7 +1166,7 @@ void CacheXmlParser::startPersistenceManager(const
xmlChar** atts
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/3#discussion_r100917160
--- Diff: src/cppcache/src/TcrMessage.hpp ---
@@ -1170,7 +1170,7 @@ class TcrMessageHelper {
}
if (compId != expectedPartType
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/3#discussion_r10091
--- Diff: src/cppcache/src/CacheXmlParser.cpp ---
@@ -1165,7 +1166,7 @@ void CacheXmlParser::startPersistenceManager(const
xmlChar** atts
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/3#discussion_r100904404
--- Diff: src/cppcache/src/CacheXmlParser.cpp ---
@@ -1165,7 +1166,7 @@ void CacheXmlParser::startPersistenceManager(const
xmlChar** atts
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/3#discussion_r100903407
--- Diff: src/cppcache/src/TcrMessage.hpp ---
@@ -1170,7 +1170,7 @@ class TcrMessageHelper {
}
if (compId != expectedPartType
GitHub user dgkimura opened a pull request:
https://github.com/apache/geode-native/pull/3
Replace ace calls to standard functions
Rather than call ACE library functions, lets try using standard functions,
like `std::snprintf` which was introduced in C++11.
You can merge this pull
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode/pull/391#discussion_r100191055
--- Diff: src/clicache/integration-test/CacheHelperN.cs ---
@@ -2389,7 +2389,7 @@ public static void KillJavaProcesses()
string commandline
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode/pull/394#discussion_r99882331
--- Diff: .travis.yml ---
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode/pull/394#discussion_r99881517
--- Diff: .travis.yml ---
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements
Github user dgkimura closed the pull request at:
https://github.com/apache/geode/pull/346
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user dgkimura opened a pull request:
https://github.com/apache/geode/pull/346
GEODE-2326: Adjust testLogger hardcoded value
Fixes the failing logger integration test. This was caused when we changed
the log header to the Apache License.
You can merge this pull request
88 matches
Mail list logo
