[GitHub] geode pull request #651: GEODE-3230: Cleaning up unused (Cli)Strings

2017-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/651 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #651: GEODE-3230: Cleaning up unused (Cli)Strings

2017-08-02 Thread pdxrunner
Github user pdxrunner commented on a diff in the pull request: https://github.com/apache/geode/pull/651#discussion_r130982335 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/DataCommandFunction.java --- @@ -633,8 +631,8 @@ public

[GitHub] geode pull request #651: GEODE-3230: Cleaning up unused (Cli)Strings

2017-08-02 Thread YehEmily
Github user YehEmily commented on a diff in the pull request: https://github.com/apache/geode/pull/651#discussion_r130959623 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/DataCommandFunction.java --- @@ -633,8 +631,8 @@ public

[GitHub] geode pull request #651: GEODE-3230: Cleaning up unused (Cli)Strings

2017-08-02 Thread YehEmily
Github user YehEmily commented on a diff in the pull request: https://github.com/apache/geode/pull/651#discussion_r130959557 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/Launcher.java --- @@ -99,7 +99,6 @@ protected Launcher() {

[GitHub] geode pull request #651: GEODE-3230: Cleaning up unused (Cli)Strings

2017-08-02 Thread YehEmily
Github user YehEmily commented on a diff in the pull request: https://github.com/apache/geode/pull/651#discussion_r130958981 --- Diff: geode-core/src/main/java/org/apache/geode/internal/process/MBeanProcessController.java --- @@ -260,6 +265,7 @@ private JMXServiceURL

[GitHub] geode pull request #651: GEODE-3230: Cleaning up unused (Cli)Strings

2017-08-01 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/651#discussion_r130677475 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/Launcher.java --- @@ -99,7 +99,6 @@ protected Launcher() {

[GitHub] geode pull request #651: GEODE-3230: Cleaning up unused (Cli)Strings

2017-08-01 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/651#discussion_r130678413 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/DataCommandFunction.java --- @@ -633,8 +631,8 @@ public

[GitHub] geode pull request #651: GEODE-3230: Cleaning up unused (Cli)Strings

2017-08-01 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/651#discussion_r130677047 --- Diff: geode-core/src/main/java/org/apache/geode/internal/process/MBeanProcessController.java --- @@ -260,6 +265,7 @@ private JMXServiceURL

[GitHub] geode pull request #651: GEODE-3230: Cleaning up unused (Cli)Strings

2017-07-26 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/651#discussion_r129647633 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java --- @@ -639,29 +639,34 @@ public Result

[GitHub] geode pull request #651: GEODE-3230: Cleaning up unused (Cli)Strings

2017-07-24 Thread YehEmily
GitHub user YehEmily opened a pull request: https://github.com/apache/geode/pull/651 GEODE-3230: Cleaning up unused (Cli)Strings [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3230) `CliStrings.java` contained a lot of Strings that were not used