Re: [VOTE] Apache Geode 1.8.0 RC1

2018-12-03 Thread Alexander Murmann
Thanks for finding the issue, Dan! Let's cancel this vote and do another one, once these issues are resolved. On Mon, Dec 3, 2018 at 2:27 PM Dan Smith wrote: > -1 for the this RC based on these native source issues: > > * Missing license headers: native_shared_ptr.hpp and others listed by >

Re: [VOTE] Apache Geode 1.8.0 RC1

2018-12-03 Thread Blake Bender
I can look into the files missing license headers when I get home (probably in an hour or so). The cmake-build-debug directory is a thing left behind by JetBrains products, so probably just developer cruft. There’s apparently a doc change I have to cherry-pick over to the release branch as well,

Re: [VOTE] Apache Geode 1.8.0 RC1

2018-12-03 Thread Dan Smith
-1 for the this RC based on these native source issues: * Missing license headers: native_shared_ptr.hpp and others listed by travis) * Binary executables in the source distribution: cmake-build-debug * The source distribution is somehow missing this directory:

Re: [VOTE] Apache Geode 1.8.0 RC1

2018-12-03 Thread Dan Smith
I see some issues with the native source release that I think are a problem. I looked into the travis for the native code - it looks like travis is passing, but finding files with missing license headers? Eg /geode-native/clicache/src/native_shared_ptr.hpp.

Re: [VOTE] Apache Geode 1.8.0 RC1

2018-12-03 Thread Alexander Murmann
Thanks again for all the input! Both Geode and Geode Native source distributions are now signed with an armored signature. Release manager docs are updated accordingly. I also added tickets to make the geode build also the sign source release

Re: [VOTE] Apache Geode 1.8.0 RC1

2018-12-03 Thread Robert Houghton
+1. Thanks Owen On Mon, Dec 3, 2018, 10:07 Owen Nichols > 2. No zip file for the geode, just .tgz. > > I believe this was changed a few months ago to simplify our build and > release process. Distributing as both .zip and .tgz is a relic of a time > before WinZip, WinRar, 7-Zip, and most other

Re: [VOTE] Apache Geode 1.8.0 RC1

2018-12-03 Thread Owen Nichols
> 2. No zip file for the geode, just .tgz. I believe this was changed a few months ago to simplify our build and release process. Distributing as both .zip and .tgz is a relic of a time before WinZip, WinRar, 7-Zip, and most other popular zip utilities gained native support for .tgz

Re: [VOTE] Apache Geode 1.8.0 RC1

2018-12-03 Thread Ernest Burghardt
for geode-native following Building.md is a good verfication On Mon, Dec 3, 2018 at 11:02 AM Nabarun Nag wrote: > Thank you Alexander and Anthony for the explanation. > I am sorry for missing the signature checks for the apache geode src. :( > Was able to build and run geode-native code. > >

Re: [VOTE] Apache Geode 1.8.0 RC1

2018-12-03 Thread Nabarun Nag
Thank you Alexander and Anthony for the explanation. I am sorry for missing the signature checks for the apache geode src. :( Was able to build and run geode-native code. Regards Nabarun Nag On Mon, Dec 3, 2018 at 9:52 AM Dan Smith wrote: > I see a few things with the artifacts that I think

Re: [VOTE] Apache Geode 1.8.0 RC1

2018-12-03 Thread Dan Smith
I see a few things with the artifacts that I think should be tweaked 1. No pgp signature for the sources! 2. No zip file for the geode, just .tgz. Older releases on our website have both zip and tgz. See the differences between [1] and [2] 3. pgp signature for the native source is not ascii

Re: [VOTE] Apache Geode 1.8.0 RC1

2018-12-03 Thread Alexander Murmann
Thanks for taking such a detailed a look, Nabarun! That's awesome input. 1. Is there a reason why geode-native is signed with SHA512 while all the > rest are signed with SHA256? Not really. I used the defaults provided by the Gradle signing task in the case of the core codebase and the GPG

Re: [VOTE] Apache Geode 1.8.0 RC1

2018-12-03 Thread Anthony Baker
The ‘gradlew’ script in the source distribution is expected to differ. The gradew[.bat] files generated by gradle rely on the presence of a jar file. We’re using a wrapper script that will download the jar file if needed. This is consistent with a number of other apache projects. KEYS is

Re: [VOTE] Apache Geode 1.8.0 RC1

2018-12-03 Thread Nabarun Nag
Following checks completed: - checked signatures - checked SHA's - builds from source [geode] - run gfsh - start locator, server - create region - do put and get - execute OQL query - examples run cleanly [geode-examples] - the correct version in gfsh command version Questions: 1. Is there a

Re: [VOTE] Apache Geode 1.8.0 RC1

2018-11-30 Thread Alexander Murmann
Hi everyone, Per above discussion the release now contains Geode Native. Here is the updated release information: Apache Geode: https://github.com/apache/geode/tree/rel/v1.8.0.RC1 Apache Geode examples: https://github.com/apache/geode-examples/tree/rel/v1.8.0.RC1 Apache Geode Native:

Re: [VOTE] Apache Geode 1.8.0 RC1

2018-11-30 Thread Anthony Baker
Because this is confusing, let me clarify our current approach again: When we do a release of the Geode Project, it will include all the constituent pieces we deem appropriate regardless of the repo the source comes from. Currently this includes: - geode - geode-examples - geode-native

Re: [VOTE] Apache Geode 1.8.0 RC1

2018-11-30 Thread Alexander Murmann
Sorry, I was unaware that we were planning on releasing geode-native as part of the same release and not as a separate release that goes out at a similar time. I am happy to work on a new candidate that includes geode-native. On Fri, Nov 30, 2018 at 6:39 AM Anthony Baker wrote: > Is there a

Re: [VOTE] Apache Geode 1.8.0 RC1

2018-11-30 Thread Anthony Baker
Is there a reason the geode-native repo was not included in the release? Anthony > On Nov 29, 2018, at 11:15 PM, Alexander Murmann wrote: > > Hello Geode dev community! > > I am happy to announce the first release candidate for Apache Geode 1.8.0! > Thanks to all the community members for

[VOTE] Apache Geode 1.8.0 RC1

2018-11-29 Thread Alexander Murmann
Hello Geode dev community! I am happy to announce the first release candidate for Apache Geode 1.8.0! Thanks to all the community members for their contributions to this release! Please review and give your feedback! The deadline is the end of day Dec. 4th 2018. It resolves 162 issues on Apache