[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #196 was SUCCESSFUL (with 1222 tests). Change made by Jens Deppe.

2016-01-20 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #196 was successful. --- Scheduled with changes by Jens Deppe. 1226 tests in total. https://build.spring.io/brows

Re: [VOTE] Apache Geode (Incubating) first Milestone release - v1.0.0-incubating.M1

2016-01-20 Thread Dave Barnes
+1 w/r/t copyright - single year policy is tried and tested in the pubs world, stands up to legal challenges. Note, however, that in some disputes the earlier date wins. > On Jan 20, 2016, at 7:02 PM, Justin Erenkrantz wrote: > > On Tue, Jan 19, 2016 at 11:07 PM, Niall Pemberton > wrote: >> F

Re: Client/Server?

2016-01-20 Thread John Blum
Heh! So, apparently the ClientMembership class [0] is the (only)

Re: [VOTE] Apache Geode (Incubating) first Milestone release - v1.0.0-incubating.M1

2016-01-20 Thread Justin Erenkrantz
On Tue, Jan 19, 2016 at 11:07 PM, Niall Pemberton wrote: > Firstly, great job on producing the first RC. From an ASF release PoV, the > main concerns for me would be gemfire-joptsimple and the binary distro > NOTICE file and those stop me giving a +1 vote. From a user PoV the > dependencies in the

Re: Client/Server?

2016-01-20 Thread John Blum
Hi Barry- Thank you for the quick response. In my test class, I only start one (standalone) server (i.e. no locators, no other servers, etc) during setup, and the client (test) connects directly to that server. Unfortunately, without explicit coordination, it is entirely possible that the client

Re: [VOTE] Apache Geode (Incubating) first Milestone release - v1.0.0-incubating.M1

2016-01-20 Thread Justin Erenkrantz
On Wed, Jan 20, 2016 at 12:31 PM, Kirk Lund wrote: > +1 for extending the vote to 72 hours (is this possible or do we have to > end this vote and start a new one?) You can definitely extend the vote without restarting it. 72 hours should be viewed as a minimum especially for a new release stream

Re: [ANNOUNCE] Donation of GemFire WAN and CQ code

2016-01-20 Thread Michael Stolz
This doesn't yet include gemz. -- Mike Stolz Principal Engineer - Gemfire Product Manager Mobile: 631-835-4771 On Jan 20, 2016 11:36 AM, "David Muirhead" wrote: > Hi Mike - > > That’s great news. Will that include Gem/Z? Hope so! > > Thanks, > > Dave > > > > Dave Muirhead > Blue River S

Re: Client/Server?

2016-01-20 Thread Barry Oglesby
John, CacheServer isRunning is not a reliable way to determine whether the CacheServer acceptor is actually listening for connections. BridgeServerImpl isRunning (the implementation) asks if the Acceptor is non-null and isRunning, which in turn just asks whether it (the Acceptor) is not shutdown.

Client/Server?

2016-01-20 Thread John Blum
Is there a recommended, (more) reliable means to determine whether a CacheServer (listening for cache clients) has successfully started in a GemFire server from the client-side? Currently, I am employing a form of inter-process communication (e.g. control file) to coordinate the successful startup

Re: [VOTE] Apache Geode (Incubating) first Milestone release - v1.0.0-incubating.M1

2016-01-20 Thread Anthony Baker
> On Jan 20, 2016, at 2:57 PM, Dan Smith wrote: > > I noticed the KEYS file is not part of the source distribution. Is that > intentional? > Yes, the KEYS file is intentionally excluded. > How are we planning on shipping/publishing the javadocs? They're not part > of the binary distribution b

Re: [VOTE] Apache Geode (Incubating) first Milestone release - v1.0.0-incubating.M1

2016-01-20 Thread Anilkumar Gingade
Hi Nitin, Thanks for creating JIRA tickets capturing Niall's concerns/comments regarding the RC candidate... (GEODE-815) RC Feedback: Fix LICENSE and NOTICE files (GEODE-816) Source Distribution NOTICE needs updates (GEODE-817) Binary distribution NOTICE needs update (GEODE-818) RC Feedback: Fix

Re: [VOTE] Apache Geode (Incubating) first Milestone release - v1.0.0-incubating.M1

2016-01-20 Thread Dan Smith
I noticed the KEYS file is not part of the source distribution. Is that intentional? How are we planning on shipping/publishing the javadocs? They're not part of the binary distribution but will they be hosted somewhere? -Dan On Wed, Jan 20, 2016 at 1:45 PM, Nitin Lamba wrote: > Sure. One bene

Re: [VOTE] Apache Geode (Incubating) first Milestone release - v1.0.0-incubating.M1

2016-01-20 Thread Nitin Lamba
Sure. One benefit of defining subtasks is that subtasks have separate issue numbers for traceability, and we can track the complete feedback with a few JIRAs. Other mechanisms of using labels or explicit issue linking are additional steps with some overhead. Anyway, I've created a new version i

[GitHub] incubator-geode pull request: Added cache to FunctionalContextImpl

2016-01-20 Thread upthewaterspout
Github user upthewaterspout commented on the pull request: https://github.com/apache/incubator-geode/pull/74#issuecomment-173369343 This is GEODE-393. I discussed this with Shreedhar, these changes need some tests and then they should be good to merge. I'll pick this up. --- If your

[GitHub] incubator-geode pull request: Added cache to FunctionalContextImpl

2016-01-20 Thread hardikar
GitHub user hardikar opened a pull request: https://github.com/apache/incubator-geode/pull/74 Added cache to FunctionalContextImpl You can merge this pull request into a Git repository by running: $ git pull https://github.com/hardikar/incubator-geode feature/GEODE-393 Altern

Re: Review Request 42261: GEODE-779: Adding upgrade offline diskstore unit test

2016-01-20 Thread Jens Deppe
> On Jan. 20, 2016, 6:37 p.m., Dan Smith wrote: > > I'm not sure we need to support upgrading from 6.6.4. Even pivotal doesn't > > support 6.6 any more. My preference would be to not add this test if it's > > introducing nastyness to the build. Thanks Dan. I'm just going to remove the original

Re: [VOTE] Apache Geode (Incubating) first Milestone release - v1.0.0-incubating.M1

2016-01-20 Thread Anthony Baker
I think it makes sense to capture the feedback as individual issues (and some have already been filed, e.g. GEODE-27 for pom correctness). Not all the comments are release blockers and thus can be addressed over time. Let’s wait for the discussion to complete so we can reach consensus around n

Re: [VOTE] Apache Geode (Incubating) first Milestone release - v1.0.0-incubating.M1

2016-01-20 Thread Nitin Lamba
Sorry have been away from my e-mails. @Roman, Greg, Mike: Yes, first time miss. Didn't see a timing guideline but now we know! It makes sense to wait until Friday, and ask for 72 hrs on the next RC VOTE. @Niall: Thanks a lot for your feedback! NOTICE and LICENSE files was somewhat of a known i

Re: Review Request 42564: GEODE-787 MemoryIndexStore needs unit tests

2016-01-20 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42564/#review115484 --- Ship it! Ship It! - anilkumar gingade On Jan. 20, 2016, 6:34 p.

Re: Review Request 41492: GEODE-681: Measuring event queue size without using the stat for gfsh

2016-01-20 Thread xiaojian zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41492/#review115474 --- Ship it! Ship It! - xiaojian zhou On Jan. 16, 2016, 1:45 a.m.,

Re: Review Request 42039: GEODE-716: Getting the bucket creation lock when setting the CacheLoader

2016-01-20 Thread xiaojian zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42039/#review115467 --- Ship it! Ship It! - xiaojian zhou On Jan. 15, 2016, 1:55 a.m.,

Re: [ANNOUNCE] Donation of GemFire WAN and CQ code

2016-01-20 Thread David Muirhead
Hi Mike - That’s great news. Will that include Gem/Z? Hope so! Thanks, Dave Dave Muirhead Blue River Systems Group, LLC http://www.brsg.biz d...@brsg.biz 303-638-4618 Mobile 303-309-6242 Office 303-309-6243 Fax > On Jan 20, 2016, at 2:21 AM, Michael Stolz wrote: > > We are in the

Re: Review Request 42531: testCreateOffHeapStorage now uses mocks instead of creating a real Cache

2016-01-20 Thread Scott Jewell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42531/#review115459 --- Ship it! Ship It! - Scott Jewell On Jan. 20, 2016, 6:38 p.m., D

Re: [VOTE] Apache Geode (Incubating) first Milestone release - v1.0.0-incubating.M1

2016-01-20 Thread Roman Shaposhnik
On Wed, Jan 20, 2016 at 9:23 AM, Michael Stolz wrote: > What caused it to have such a short deadline? Did we do something to cause > it to be so short or is that the default and we just didn't know to > override it somehow? That's a good question for a release manager. Nitin? Thanks, Roman. P.S

Re: Geode versions in Jira tickets

2016-01-20 Thread Anthony Baker
We should have the $NEXT version tag already created in JIRA. Then it makes sense to mark it directly when that fix is merged to develop. Anthony > On Jan 20, 2016, at 10:30 AM, Dan Smith wrote: > > One question on that is do we fill in the fix version at the time the bug > is fixed, or when

Re: Review Request 42531: testCreateOffHeapStorage now uses mocks instead of creating a real Cache

2016-01-20 Thread Swapnil Bawaskar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42531/#review115455 --- Ship it! Ship It! - Swapnil Bawaskar On Jan. 20, 2016, 6:38 p.m

Re: Review Request 42261: GEODE-779: Adding upgrade offline diskstore unit test

2016-01-20 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42261/#review115452 --- I'm not sure we need to support upgrading from 6.6.4. Even pivotal

Re: Geode versions in Jira tickets

2016-01-20 Thread John Blum
If the bug is fixed, and committed to the appropriate repository (in-time) for the next release, then it is fine to set the fix version. The only time setting a fix version is bad is when a fix version has be set for a particular release, but has not been committed and subsequently does not make i

Review Request 42564: GEODE-787 MemoryIndexStore needs unit tests

2016-01-20 Thread Jason Huynh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42564/ --- Review request for geode, anilkumar gingade, Bruce Schuchardt, Hitesh Khamesra,

Re: Geode versions in Jira tickets

2016-01-20 Thread Dan Smith
One question on that is do we fill in the fix version at the time the bug is fixed, or when the release is made? For example right now we're making fixes that will probably be in a .M2 release, but there is no .M2 in JIRA yet. -Dan On Wed, Jan 20, 2016 at 10:22 AM, John Blum wrote: > With Sprin

Re: [ANNOUNCE] Donation of GemFire WAN and CQ code

2016-01-20 Thread Dan Smith
This is great! These two features are separate gradle modules, so there are no changes to existing code. As you are looking at the changes, all of the new code is in the gemfire-wan and gemfire-cq modules. One important point is that these modules are not adding new public API, they are providing

Re: Geode versions in Jira tickets

2016-01-20 Thread John Blum
With Spring projects, we use "affects" version that an issue was reported in (though with Geode not having an official release yet, hmmm). The fix (or target) version is the version that the fix will be released in. On Wed, Jan 20, 2016 at 8:58 AM, Kirk Lund wrote: > Darrel and I were just disc

Re: Build failed in Jenkins: Geode-nightly #352

2016-01-20 Thread Anthony Baker
Looks like the build script should check for the presence of the settings.xml file: if (settingsXml.exists()) { … } Of course, the uploadArchives task will still fail since there are no credentials available when uploading into the Maven repository. Anthony > On Jan 20, 2016, at 9:03 AM,

Re: [VOTE] Apache Geode (Incubating) first Milestone release - v1.0.0-incubating.M1

2016-01-20 Thread Greg Chase
On Wed, Jan 20, 2016 at 9:23 AM, Michael Stolz wrote: > What caused it to have such a short deadline? Did we do something to cause > it to be so short or is that the default and we just didn't know to > override it somehow? > > Why we're still "incubating". Its our first candidate for our first

Re: [VOTE] Apache Geode (Incubating) first Milestone release - v1.0.0-incubating.M1

2016-01-20 Thread Kirk Lund
+1 for extending the vote to 72 hours (is this possible or do we have to end this vote and start a new one?) On Wed, Jan 20, 2016 at 9:23 AM, Michael Stolz wrote: > What caused it to have such a short deadline? Did we do something to cause > it to be so short or is that the default and we just

Re: [VOTE] Apache Geode (Incubating) first Milestone release - v1.0.0-incubating.M1

2016-01-20 Thread Michael Stolz
What caused it to have such a short deadline? Did we do something to cause it to be so short or is that the default and we just didn't know to override it somehow? -- Mike Stolz Principal Engineer, GemFire Product Manager Mobile: 631-835-4771 On Tue, Jan 19, 2016 at 8:36 PM, Roman Shaposhnik wro

Review Request 42561: Move dunit.standalone pkg to com.gemstone.gemfire.test.dunit.standalone

2016-01-20 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42561/ --- Review request for geode, Jens Deppe and Jinmei Liao. Bugs: GEODE-715 https

Re: [VOTE] Apache Geode (Incubating) first Milestone release - v1.0.0-incubating.M1

2016-01-20 Thread Bruce Schuchardt
#5 should include jgroups for non-clients Le 1/19/2016 8:07 PM, Niall Pemberton a écrit : Hi, Firstly, great job on producing the first RC. From an ASF release PoV, the main concerns for me would be gemfire-joptsimple and the binary distro NOTICE file and those stop me giving a +1 vote. From a

Fwd: Build failed in Jenkins: Geode-nightly #352

2016-01-20 Thread Kirk Lund
Root cause of our nightly build failure appears to be an environment problem: Caused by: java.io.FileNotFoundException: /home/jenkins/.m2/settings.xml (No such file or directory) -Kirk -- Forwarded message -- From: Apache Jenkins Server Date: Tue, Jan 19, 2016 at 7:52 PM Subject

Geode versions in Jira tickets

2016-01-20 Thread Kirk Lund
Darrel and I were just discussing and wondering: What's the current guidelines for the Geode versions that should be specified in the Affects Versions and Fix Versions of Jira tickets? It's still not clear to me. -Kirk

Re: Review Request 42520: Reducing join/leave time

2016-01-20 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42520/ --- (Updated Jan. 20, 2016, 4:35 p.m.) Review request for geode, anilkumar gingade,

Re: Review Request 42520: Reducing join/leave time

2016-01-20 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42520/#review115438 --- gemfire-core/src/main/java/com/gemstone/gemfire/distributed/intern

Re: [VOTE] Apache Geode (Incubating) first Milestone release - v1.0.0-incubating.M1

2016-01-20 Thread Anthony Baker
Niall, this is great work and many things for your continued contributions! I think we need to go through this in detail and writeup about 20 JIRA’s. Anthony > On Jan 19, 2016, at 8:07 PM, Niall Pemberton > wrote: > > Hi, > > Firstly, great job on producing the first RC. From an ASF release

Re: [VOTE] Apache Geode (Incubating) first Milestone release - v1.0.0-incubating.M1

2016-01-20 Thread Anthony Baker
Let’s extend the VOTE deadline until Friday, January 22, 1400 US Pacific time for a full 72h review period. One of the best things are getting from this process (as evidenced by Niall’s work) is great feedback from our mentors and community. Anthony > On Jan 19, 2016, at 8:36 PM, Roman Shapos

[GitHub] incubator-geode pull request: Feature/geode 12

2016-01-20 Thread jdeppe-pivotal
Github user jdeppe-pivotal commented on the pull request: https://github.com/apache/incubator-geode/pull/70#issuecomment-173229772 It looks like the integration tests are still failing. We should either fix those or mark them as `Ignore`. If the selenium tests (which require a local b