Re: Review Request: GIRAPH-415: Refactor / cleanup Hadoop Counters

2012-11-12 Thread Nitay Joffe
On Nov. 9, 2012, 7:03 p.m., Maja Kabiljo wrote: giraph/src/main/java/org/apache/giraph/counters/GiraphStats.java, line 170 https://reviews.apache.org/r/7980/diff/1/?file=187458#file187458line170 Am I missing something or this is not used? I understand the idea of it being

Re: Review Request: Create BinaryCombiner ands specialized message store for it

2012-11-12 Thread Maja Kabiljo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7975/ --- (Updated Nov. 12, 2012, 6:39 p.m.) Review request for giraph. Changes ---

[jira] [Created] (GIRAPH-418) Create maven profile for CDH 4.1.1

2012-11-12 Thread Eugene Koontz (JIRA)
Eugene Koontz created GIRAPH-418: Summary: Create maven profile for CDH 4.1.1 Key: GIRAPH-418 URL: https://issues.apache.org/jira/browse/GIRAPH-418 Project: Giraph Issue Type: Improvement

Re: Giraph and Hadoop Cloudera CDH4.1.1

2012-11-12 Thread Eugene Koontz
Hi Mirko, Thanks for looking at this and trying it on CDH! I filed a JIRA here: https://issues.apache.org/jira/browse/GIRAPH-418 You are right that the docs need work too. -Eugene

[jira] [Updated] (GIRAPH-418) Create maven profile for CDH 4.1.1

2012-11-12 Thread Eugene Koontz (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eugene Koontz updated GIRAPH-418: - Description: Mirko writes: bq. Hello all, bq. I created a now pom.xml file, which allows

Re: Review Request: GIRAPH-415: Refactor / cleanup Hadoop Counters

2012-11-12 Thread Maja Kabiljo
On Nov. 9, 2012, 7:03 p.m., Maja Kabiljo wrote: giraph/src/main/java/org/apache/giraph/graph/BspServiceMaster.java, line 769 https://reviews.apache.org/r/7980/diff/1/?file=187462#file187462line769 You can use setValue here Nitay Joffe wrote: That makes the logic different

[jira] [Updated] (GIRAPH-415) Refactor / cleanup Hadoop Counters

2012-11-12 Thread Nitay Joffe (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitay Joffe updated GIRAPH-415: --- Attachment: GIRAPH-415-2.patch Refactor / cleanup Hadoop Counters

[jira] [Commented] (GIRAPH-418) Create maven profile for CDH 4.1.1

2012-11-12 Thread Nitay Joffe (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495576#comment-13495576 ] Nitay Joffe commented on GIRAPH-418: The patch looks okay but there are a few things I

[jira] [Commented] (GIRAPH-418) Create maven profile for CDH 4.1.1

2012-11-12 Thread Nitay Joffe (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495582#comment-13495582 ] Nitay Joffe commented on GIRAPH-418: Also for ease of use you can make the id

[jira] [Commented] (GIRAPH-392) Can't build hadoop 0.23+ profiles

2012-11-12 Thread Eugene Koontz (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495584#comment-13495584 ] Eugene Koontz commented on GIRAPH-392: -- Hi Roman, thanks for your comment in

[jira] [Commented] (GIRAPH-418) Create maven profile for CDH 4.1.1

2012-11-12 Thread Roman Shaposhnik (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495602#comment-13495602 ] Roman Shaposhnik commented on GIRAPH-418: - I'd suggest cdh4 (since cdh4 and cdh3

Re: Review Request: GIRAPH-415: Refactor / cleanup Hadoop Counters

2012-11-12 Thread Maja Kabiljo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7980/#review13368 --- Ship it! +1, thanks Nitay. - Maja Kabiljo On Nov. 12, 2012, 6:59

[jira] [Commented] (GIRAPH-418) Create maven profile for CDH 4.1.1

2012-11-12 Thread Nitay Joffe (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495605#comment-13495605 ] Nitay Joffe commented on GIRAPH-418: oh I realized you might not be able to pull

[jira] [Commented] (GIRAPH-415) Refactor / cleanup Hadoop Counters

2012-11-12 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495655#comment-13495655 ] Hudson commented on GIRAPH-415: --- Integrated in Giraph-trunk-Commit #278 (See

[jira] [Commented] (GIRAPH-415) Refactor / cleanup Hadoop Counters

2012-11-12 Thread Avery Ching (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495675#comment-13495675 ] Avery Ching commented on GIRAPH-415: There is a checkstyle error. Please don't forget

[jira] [Updated] (GIRAPH-415) Refactor / cleanup Hadoop Counters

2012-11-12 Thread Maja Kabiljo (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maja Kabiljo updated GIRAPH-415: Attachment: GIRAPH-415.patch There was an '@Override' missing in Nitay's patch.

[jira] [Updated] (GIRAPH-415) Refactor / cleanup Hadoop Counters

2012-11-12 Thread Maja Kabiljo (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maja Kabiljo updated GIRAPH-415: Attachment: GIRAPH-415.patch Refactor / cleanup Hadoop Counters

[jira] [Commented] (GIRAPH-415) Refactor / cleanup Hadoop Counters

2012-11-12 Thread Nitay Joffe (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495704#comment-13495704 ] Nitay Joffe commented on GIRAPH-415: sorry about that, thanks for fixing.

[jira] [Commented] (GIRAPH-415) Refactor / cleanup Hadoop Counters

2012-11-12 Thread Avery Ching (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495706#comment-13495706 ] Avery Ching commented on GIRAPH-415: +1 on Maja's fix. Please commit.

[jira] [Commented] (GIRAPH-415) Refactor / cleanup Hadoop Counters

2012-11-12 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495722#comment-13495722 ] Hudson commented on GIRAPH-415: --- Integrated in Giraph-trunk-Commit #279 (See

[jira] [Updated] (GIRAPH-420) Make Giraph build on all profiles

2012-11-12 Thread Nitay Joffe (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitay Joffe updated GIRAPH-420: --- Attachment: GIRAPH-420.patch Make Giraph build on all profiles

[jira] [Created] (GIRAPH-421) Aggregate metrics to Master

2012-11-12 Thread Nitay Joffe (JIRA)
Nitay Joffe created GIRAPH-421: -- Summary: Aggregate metrics to Master Key: GIRAPH-421 URL: https://issues.apache.org/jira/browse/GIRAPH-421 Project: Giraph Issue Type: Improvement

[jira] [Commented] (GIRAPH-420) Make Giraph build on all profiles

2012-11-12 Thread Nitay Joffe (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495834#comment-13495834 ] Nitay Joffe commented on GIRAPH-420: Perhaps we split formats into giraph-hive,

[jira] [Created] (GIRAPH-422) Setting the log level of the root logger to the same level can cause issues in Hadoop

2012-11-12 Thread Avery Ching (JIRA)
Avery Ching created GIRAPH-422: -- Summary: Setting the log level of the root logger to the same level can cause issues in Hadoop Key: GIRAPH-422 URL: https://issues.apache.org/jira/browse/GIRAPH-422

[jira] [Updated] (GIRAPH-422) Setting the log level of the root logger to the same level can cause issues in Hadoop

2012-11-12 Thread Avery Ching (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Avery Ching updated GIRAPH-422: --- Attachment: GIRAPH-422.patch Setting the log level of the root logger to the same level can

[jira] [Updated] (GIRAPH-421) Aggregate metrics to Master

2012-11-12 Thread Nitay Joffe (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitay Joffe updated GIRAPH-421: --- Description: (was: https://reviews.apache.org/r/8030/) Aggregate metrics to Master

Re: Review Request: Create BinaryCombiner ands specialized message store for it

2012-11-12 Thread Avery Ching
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7975/#review13375 --- This is almost ready to go. Looks great, although I will need to

[jira] [Commented] (GIRAPH-422) Setting the log level of the root logger to the same level can cause issues in Hadoop

2012-11-12 Thread Alessandro Presta (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495857#comment-13495857 ] Alessandro Presta commented on GIRAPH-422: -- +1, thanks for the quick fix!

Review Request: Edge-based input from HCatalog

2012-11-12 Thread Alessandro Presta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8034/ --- Review request for giraph. Description --- Implemented Edge/VertexValue

[jira] [Updated] (GIRAPH-405) Edge-based input from HCatalog

2012-11-12 Thread Alessandro Presta (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Presta updated GIRAPH-405: - Attachment: GIRAPH-405.patch Matches https://reviews.apache.org/r/8034/

[jira] [Commented] (GIRAPH-422) Setting the log level of the root logger to the same level can cause issues in Hadoop

2012-11-12 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495910#comment-13495910 ] Hudson commented on GIRAPH-422: --- Integrated in Giraph-trunk-Commit #280 (See

Re: Review Request: Create BinaryCombiner ands specialized message store for it

2012-11-12 Thread Maja Kabiljo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7975/ --- (Updated Nov. 13, 2012, 4:40 a.m.) Review request for giraph. Changes ---

Re: Review Request: Create BinaryCombiner ands specialized message store for it

2012-11-12 Thread Avery Ching
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7975/#review13385 --- Ship it! +1, thanks Maja! Please make sure 'mvn clean install'

Re: [jira] [Commented] (GIRAPH-418) Create maven profile for CDH 4.1.1

2012-11-12 Thread Mirko Kämpf
Thanks a lot for the comments. I will go over all this comments today and than I send the patch file. Best wishes Mirko On Mon, Nov 12, 2012 at 9:35 PM, Nitay Joffe (JIRA) j...@apache.org wrote: [