On Nov. 9, 2012, 7:03 p.m., Maja Kabiljo wrote:
giraph/src/main/java/org/apache/giraph/counters/GiraphStats.java, line 170
https://reviews.apache.org/r/7980/diff/1/?file=187458#file187458line170
Am I missing something or this is not used?
I understand the idea of it being
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7975/
---
(Updated Nov. 12, 2012, 6:39 p.m.)
Review request for giraph.
Changes
---
Eugene Koontz created GIRAPH-418:
Summary: Create maven profile for CDH 4.1.1
Key: GIRAPH-418
URL: https://issues.apache.org/jira/browse/GIRAPH-418
Project: Giraph
Issue Type: Improvement
Hi Mirko,
Thanks for looking at this and trying it on CDH! I filed a JIRA here:
https://issues.apache.org/jira/browse/GIRAPH-418
You are right that the docs need work too.
-Eugene
[
https://issues.apache.org/jira/browse/GIRAPH-418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eugene Koontz updated GIRAPH-418:
-
Description:
Mirko writes:
bq. Hello all,
bq. I created a now pom.xml file, which allows
On Nov. 9, 2012, 7:03 p.m., Maja Kabiljo wrote:
giraph/src/main/java/org/apache/giraph/graph/BspServiceMaster.java, line 769
https://reviews.apache.org/r/7980/diff/1/?file=187462#file187462line769
You can use setValue here
Nitay Joffe wrote:
That makes the logic different
[
https://issues.apache.org/jira/browse/GIRAPH-415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nitay Joffe updated GIRAPH-415:
---
Attachment: GIRAPH-415-2.patch
Refactor / cleanup Hadoop Counters
[
https://issues.apache.org/jira/browse/GIRAPH-418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495576#comment-13495576
]
Nitay Joffe commented on GIRAPH-418:
The patch looks okay but there are a few things I
[
https://issues.apache.org/jira/browse/GIRAPH-418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495582#comment-13495582
]
Nitay Joffe commented on GIRAPH-418:
Also for ease of use you can make the id
[
https://issues.apache.org/jira/browse/GIRAPH-392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495584#comment-13495584
]
Eugene Koontz commented on GIRAPH-392:
--
Hi Roman, thanks for your comment in
[
https://issues.apache.org/jira/browse/GIRAPH-418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495602#comment-13495602
]
Roman Shaposhnik commented on GIRAPH-418:
-
I'd suggest cdh4 (since cdh4 and cdh3
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7980/#review13368
---
Ship it!
+1, thanks Nitay.
- Maja Kabiljo
On Nov. 12, 2012, 6:59
[
https://issues.apache.org/jira/browse/GIRAPH-418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495605#comment-13495605
]
Nitay Joffe commented on GIRAPH-418:
oh I realized you might not be able to pull
[
https://issues.apache.org/jira/browse/GIRAPH-415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495655#comment-13495655
]
Hudson commented on GIRAPH-415:
---
Integrated in Giraph-trunk-Commit #278 (See
[
https://issues.apache.org/jira/browse/GIRAPH-415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495675#comment-13495675
]
Avery Ching commented on GIRAPH-415:
There is a checkstyle error. Please don't forget
[
https://issues.apache.org/jira/browse/GIRAPH-415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maja Kabiljo updated GIRAPH-415:
Attachment: GIRAPH-415.patch
There was an '@Override' missing in Nitay's patch.
[
https://issues.apache.org/jira/browse/GIRAPH-415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maja Kabiljo updated GIRAPH-415:
Attachment: GIRAPH-415.patch
Refactor / cleanup Hadoop Counters
[
https://issues.apache.org/jira/browse/GIRAPH-415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495704#comment-13495704
]
Nitay Joffe commented on GIRAPH-415:
sorry about that, thanks for fixing.
[
https://issues.apache.org/jira/browse/GIRAPH-415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495706#comment-13495706
]
Avery Ching commented on GIRAPH-415:
+1 on Maja's fix. Please commit.
[
https://issues.apache.org/jira/browse/GIRAPH-415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495722#comment-13495722
]
Hudson commented on GIRAPH-415:
---
Integrated in Giraph-trunk-Commit #279 (See
[
https://issues.apache.org/jira/browse/GIRAPH-420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nitay Joffe updated GIRAPH-420:
---
Attachment: GIRAPH-420.patch
Make Giraph build on all profiles
Nitay Joffe created GIRAPH-421:
--
Summary: Aggregate metrics to Master
Key: GIRAPH-421
URL: https://issues.apache.org/jira/browse/GIRAPH-421
Project: Giraph
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/GIRAPH-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495834#comment-13495834
]
Nitay Joffe commented on GIRAPH-420:
Perhaps we split formats into giraph-hive,
Avery Ching created GIRAPH-422:
--
Summary: Setting the log level of the root logger to the same
level can cause issues in Hadoop
Key: GIRAPH-422
URL: https://issues.apache.org/jira/browse/GIRAPH-422
[
https://issues.apache.org/jira/browse/GIRAPH-422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Avery Ching updated GIRAPH-422:
---
Attachment: GIRAPH-422.patch
Setting the log level of the root logger to the same level can
[
https://issues.apache.org/jira/browse/GIRAPH-421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nitay Joffe updated GIRAPH-421:
---
Description: (was: https://reviews.apache.org/r/8030/)
Aggregate metrics to Master
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7975/#review13375
---
This is almost ready to go. Looks great, although I will need to
[
https://issues.apache.org/jira/browse/GIRAPH-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495857#comment-13495857
]
Alessandro Presta commented on GIRAPH-422:
--
+1, thanks for the quick fix!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8034/
---
Review request for giraph.
Description
---
Implemented Edge/VertexValue
[
https://issues.apache.org/jira/browse/GIRAPH-405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Presta updated GIRAPH-405:
-
Attachment: GIRAPH-405.patch
Matches https://reviews.apache.org/r/8034/
[
https://issues.apache.org/jira/browse/GIRAPH-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495910#comment-13495910
]
Hudson commented on GIRAPH-422:
---
Integrated in Giraph-trunk-Commit #280 (See
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7975/
---
(Updated Nov. 13, 2012, 4:40 a.m.)
Review request for giraph.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7975/#review13385
---
Ship it!
+1, thanks Maja! Please make sure 'mvn clean install'
Thanks a lot for the comments.
I will go over all this comments today and than I send the patch file.
Best wishes
Mirko
On Mon, Nov 12, 2012 at 9:35 PM, Nitay Joffe (JIRA) j...@apache.org wrote:
[
34 matches
Mail list logo