Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/456#discussion_r234475362
--- Diff: griffin-doc/measure/measure-configuration-guide.md ---
@@ -188,7 +188,7 @@ Above lists DQ job configure parameters.
- **sinks
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/455
I'm fine on this change
---
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/453
LGTM.
it's necessary to rename mock entity class.
---
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/452
LGTM
---
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/444
It's long process of discussion and review, but we get a consensus finally
and close this change.
thanks guys @chemikadze @gavlyukovskiy @guoyuepeng
---
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r232269364
--- Diff:
service/src/main/java/org/apache/griffin/core/event/GriffinEventListeners.java
---
@@ -0,0 +1,50 @@
+package
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/444
probably we can think about labeling something during onEvent
implementation in testcase
---
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/444
@guoyuepeng
I revise test case, can you review it again
---
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r231352539
--- Diff:
service/src/main/java/org/apache/griffin/core/event/GriffinEventListeners.java
---
@@ -0,0 +1,51 @@
+package
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r230622329
--- Diff: service/src/main/resources/application.properties ---
@@ -62,3 +62,5 @@ elasticsearch.scheme=http
livy.uri=http://localhost:8998
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r230622132
--- Diff:
service/src/main/java/org/apache/griffin/core/job/JobServiceImpl.java ---
@@ -158,17 +162,22 @@ public JobServiceImpl
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/444
summary of comments
1.considering general usage, I do not use 'GriffinJobEventManager' but
actually name it 'GriffinEventManager'
2.I keep empt
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r230621999
--- Diff:
service/src/main/java/org/apache/griffin/core/job/JobServiceImpl.java ---
@@ -158,17 +162,22 @@ public JobServiceImpl
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/444
let me change name to GriffinJobEventManage
---
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/444
@guoyuepeng @chemikadze
Thanks for your comments on first version of hook implementation.
I have completed new implementation, here I simplify hook load, extend
event
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r230049250
--- Diff:
service/src/main/java/org/apache/griffin/core/job/JobServiceImpl.java ---
@@ -168,7 +175,14 @@ public AbstractJob addJob(AbstractJob
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r230047870
--- Diff:
service/src/main/java/org/apache/griffin/core/integration/GriffinEvent.java ---
@@ -0,0 +1,44 @@
+/*
+Licensed to the Apache
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r230047399
--- Diff:
service/src/test/java/org/apache/griffin/core/job/EventServiceTest.java ---
@@ -0,0 +1,69 @@
+package org.apache.griffin.core.job
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r230047076
--- Diff:
service/src/main/java/org/apache/griffin/core/integration/GriffinEventListeners.java
---
@@ -0,0 +1,61 @@
+package
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r230046860
--- Diff:
service/src/main/java/org/apache/griffin/core/integration/GriffinEventListeners.java
---
@@ -0,0 +1,61 @@
+package
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r230046728
--- Diff:
service/src/main/java/org/apache/griffin/core/integration/JobEventHook.java ---
@@ -0,0 +1,11 @@
+package
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r230045266
--- Diff:
service/src/main/java/org/apache/griffin/core/integration/GriffinEventListeners.java
---
@@ -0,0 +1,61 @@
+package
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r228040937
--- Diff:
service/src/main/java/org/apache/griffin/core/job/JobServiceImpl.java ---
@@ -128,10 +129,22 @@ Licensed to the Apache Software
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r228040806
--- Diff:
service/src/main/java/org/apache/griffin/core/integration/GriffinEvent.java ---
@@ -0,0 +1,44 @@
+/*
+Licensed to the Apache
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/441
LGTM
---
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/444
Define griffin plain-vanilla hook.
the purpose of hook is for integration with components outside. Griffin
would offer information about internal task status.
Task: GRIFFIN
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/442#discussion_r226905150
--- Diff:
service/src/main/java/org/apache/griffin/core/measure/entity/Rule.java ---
@@ -81,6 +81,9 @@ Licensed to the Apache Software
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/441#discussion_r226904188
--- Diff:
service/src/main/java/org/apache/griffin/core/login/ldap/SelfSignedSocketFactory.java
---
@@ -0,0 +1,68 @@
+package
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/441#discussion_r226904191
--- Diff:
service/src/main/java/org/apache/griffin/core/login/ldap/SelfSignedSocketFactory.java
---
@@ -0,0 +1,68 @@
+package
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/441#discussion_r226903885
--- Diff:
service/src/main/java/org/apache/griffin/core/login/ldap/SelfSignedSocketFactory.java
---
@@ -0,0 +1,68 @@
+package
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/441#discussion_r226903865
--- Diff:
service/src/main/java/org/apache/griffin/core/login/ldap/SelfSignedSocketFactory.java
---
@@ -0,0 +1,68 @@
+package
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/439
Complement stuffs to docker guide.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/toyboxman/incubator-griffin doc/docker
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/432#discussion_r225024005
--- Diff: griffin-doc/measure/measure-batch-sample.md ---
@@ -18,7 +18,7 @@ under the License.
-->
# Measure Batch Sam
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/433
Fix a bug in postman script
postman collection is not up to date, some APIs don't work well.
script has been refreshed in this patch by postman 2.1 standard.
Jira
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/432
Fix a little doc bug concerning measure part.
fix linguistic error and improve content
You can merge this pull request into a Git repository by running:
$ git pull https
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/429
@guoyuepeng @chemikadze
I agree to keeping -q parameter, as travis only permit 4M log file size.
please see latest update, decrease git pull/clone log output, I think
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/428
@guoyuepeng @chemikadze
travis offers cache feature which prevents from downloading maven
dependencies every time.
I made pr429 to solve this issue.
https
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/429
Fix timeout failure in travis CI.
Build times out because no output was received.
'travis_wait mvn clean verify -q' will spawn a process to deal with mvn task
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/426
Fix code bug.
1.add java method description
2.reformat import statements violating Griffin's code rule
https://github.com/apache/incubator-griffin/blob/master/griffin-doc/dev
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/420
retry again, it's fine.
Thanks guys
---
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/420
---
T E S T S
---
Picked up _JAVA_OPTIONS: -Xmx2048m -Xms512m
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/420
@bhlx3lyx7 just update doc description, please review again
thanks
---
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/420
Sure, I'll update this PR and keep Distinctness instead of Uniqueness
---
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/420
Fix doc issue.
dsl-guide describes two kinds of rules, Uniqueness and Distinctness.
actually they are similiar rule, so we merely keep Uniqueness rule.
You can merge this pull request
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/416
@chemikadze
I have double checked, release version has been 0.3.0
incubator-griffin/service/src/main/resources/banner.txt.
thank for your reminder
---
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/416
Fix rest api bug in service component
GET /api/v1/version returns mistaken release version 0.2.0 instead of 0.3.0
You can merge this pull request into a Git repository by running
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/412
Fix API doc bug and complement some stuffs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/toyboxman/incubator-griffin api
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/411
Improve document quality
Revise docker guide document and append more descriptions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/407
In order to improve readability, complement some stuffs into readme doc
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/toyboxman
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/384
@guoyuepeng
I append guide part about how to enable style-check in maven and idea. I
think we can add scala and type script code style rule here as well
thanks
---
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/388
@guoyuepeng
William,
I see recent changes still have some violations against basic code style
rules. like import statement using * instead of concrete class name, too long
code
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/388
conflicts have been resolved
---
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/388
@guoyuepeng
William,
I'll resolve those conflicts. any question, let me know
---
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/384
I agree with you @guoyuepeng
actually a code style guide is better than code template here. I will
revise this patch
---
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/388
Fix bugs about code style violation against Griffin rules
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/toyboxman/incubator
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/386
Trim and reformat resource files
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/toyboxman/incubator-griffin property
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/385
Fix import violations by Griffin code check rules
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/toyboxman/incubator-griffin
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/384
Initialize java code checks rules for griffin
this config could be used by maven checkStyle plugin
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/383
Fix code style violations and improve quality
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/toyboxman/incubator-griffin
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/380
@guoyuepeng @bhlx3lyx7
please consider to keep same code style and we can do those work step by
step
---
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/380
by Griffin's code style rules extends google/sun, we need to reformat
import statement.
here I have gone thru service packages and cleaned/adjusted all import
statements
---
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/380
Fix java import style violations in codes by code style suggested by sâ¦
â¦un/google
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/379
Fix code style bug in MeasureRepo
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/toyboxman/incubator-griffin MeasureRepo
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/378
Fix code bugs and correct code style
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/toyboxman/incubator-griffin SimpleCORSFilter
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/377
Remove unused method and clean codes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/toyboxman/incubator-griffin measure
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/375
Fix code bug and improve code quality
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/toyboxman/incubator-griffin measure/fix
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/374
invalidate this change and resubmit again later
---
Github user toyboxman closed the pull request at:
https://github.com/apache/incubator-griffin/pull/374
---
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/374
Fix bug and improve code quality
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/toyboxman/incubator-griffin measure/fix1
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/372
Fix doc bug and make it more clear and understandable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/toyboxman/incubator-griffin
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/371
Fix doc bug and improve doc readability
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/toyboxman/incubator-griffin doc/fix1
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/368
Fix doc bug and improve readability of Griffin project introduction
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/toyboxman
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/367
Fix doc bugs and improve its quality and readability
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/toyboxman/incubator-griffin
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/364
Fix bug and refactor ExternalMeasureOperatorImpl test codes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/toyboxman/incubator
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/355
Fix bug and enable new test cases to verify GriffinMeasureOperatorImpl
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/toyboxman
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/351
Pr/testcase
Refactor codes and fix unit test bug
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/toyboxman/incubator-griffin pr
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/347
Test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/toyboxman/incubator-griffin test
Alternatively you can review and apply
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/345
Head option
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/toyboxman/incubator-griffin headOption
Alternatively you can review
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/342
Fix unit case bug
JobInstanceRepoTest always fails to run due to code bug, fix it here
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/338
correct minor literal mistakes in doc
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/toyboxman/incubator-griffin l1
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/337
fix a bad practice, Empty interpolated string
String declared as interpolated but has no parameters:
scala.StringContext.apply("...").s()
You can merge this pull request
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/336
fix a bad practice, Empty interpolated string
String declared as interpolated but has no parameters:
scala.StringContext.apply("...").s()
You can merge this pull request
Github user toyboxman closed the pull request at:
https://github.com/apache/incubator-griffin/pull/332
---
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/332
Hi, @whhe @guoyuepeng
I submit a new patch to revise, please review again
https://github.com/apache/incubator-griffin/pull/335
---
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/335
fix a bad practice
1.Format string should use %n rather than \n
In format strings, it is generally preferable better to use %n,
which will produce the platform-specific line
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/332
let me check how many times '\n' was used in codes and make a new patch
---
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/334
fix a bad practice, Empty interpolated string
String declared as interpolated but has no parameters:
scala.StringContext.apply("cache after replace old df").s()
You can
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/332
Hi @whhe
I got you here. but I wanna clarify why I change it.
Java Formatter suggests % as special notation character instead of '\'
https://docs.oracle.
Github user toyboxman closed the pull request at:
https://github.com/apache/incubator-griffin/pull/331
---
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/331
root cause is about spring context association in different testcases, let
me remove it and submit again
---
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/333
refactor dead test cases
1.active KafkaSchemaServiceImplTest and resolve failures
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/331
I don't touch those testcases, just add some test cases for kafka service.
I need to check it later
---
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/332
fix a bad practice
Format string should use %n rather than \n
In format strings, it is generally preferable better to use %n,
which will produce the platform-specific line
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/331
refactor dead test cases
1.active KafkaSchemaServiceImplTest and resolve failures
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user toyboxman closed the pull request at:
https://github.com/apache/incubator-griffin/pull/329
---
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/329
fix potential stream resource loss
After BufferedReader is used, it should be closed explicitly
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/326
fix potential stream resource loss
when BufferedReader is used, it should be closed explicitly
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/325
refactor dead test cases
1.active KafkaSchemaControllerTest and resolve failures
2.trim and tidy up codes
You can merge this pull request into a Git repository by running
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/324
refactor some java codes including,
1.unused system.out statement
2.extra blank line in codes
3.same string constants used in multiple methods
You can merge this pull request
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/323
refactor test codes in service/src/test/java/org/apache/griffin/core/â¦
â¦util/PropertiesUtilTest.java
1.remove assert keyword instead of Junit Assert class
You can merge
1 - 100 of 106 matches
Mail list logo
