Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/354#discussion_r246567460
--- Diff: guacamole-docker/bin/start.sh ---
@@ -317,6 +317,10 @@ END
"ldap-search-bind-pas
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/353#discussion_r245858704
--- Diff:
guacamole-ext/src/main/java/org/apache/guacamole/net/auth/simple/SimpleConnection.java
---
@@ -68,21 +72,34 @@ public
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/353#discussion_r245858747
--- Diff:
guacamole-ext/src/main/java/org/apache/guacamole/net/auth/Connection.java ---
@@ -125,5 +125,17 @@
* connection
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/353#discussion_r245858656
--- Diff:
guacamole-ext/src/main/java/org/apache/guacamole/net/auth/simple/SimpleConnection.java
---
@@ -68,21 +72,34 @@ public
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/353#discussion_r245858609
--- Diff:
guacamole-ext/src/main/java/org/apache/guacamole/net/auth/Connection.java ---
@@ -125,5 +125,17 @@
* connection
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/353#discussion_r245858540
--- Diff:
guacamole-ext/src/main/java/org/apache/guacamole/net/auth/Connection.java ---
@@ -125,5 +125,17 @@
* connection
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/353#discussion_r245858363
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/connection/ConnectionService.java
---
@@ -148,12 +169,25
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/353#discussion_r245858320
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/connection/ConnectionService.java
---
@@ -148,12 +169,25
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/353#discussion_r245858199
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/connection/ConnectionService.java
---
@@ -167,18 +201,34
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/353#discussion_r245818609
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/connection/ConnectionService.java
---
@@ -167,18 +201,34
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/353#discussion_r245789239
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/connection/ConnectionService.java
---
@@ -167,18 +201,34
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/353#discussion_r245760171
--- Diff:
guacamole-ext/src/main/java/org/apache/guacamole/net/auth/simple/SimpleConnection.java
---
@@ -68,21 +72,34 @@ public
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/353#discussion_r245757432
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/connection/ConnectionService.java
---
@@ -148,12 +169,25
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/353#discussion_r245757512
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/connection/ConnectionService.java
---
@@ -148,12 +169,25
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/353#discussion_r245756503
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/connection/ConnectionService.java
---
@@ -167,18 +201,34
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-website/pull/64#discussion_r245422999
--- Diff: _releases/1.0.0.md ---
@@ -0,0 +1,805 @@
+---
+
+released: false
+title: 1.0.0
+date: 2018-12-20 22:00:00 -0800
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-website/pull/64#discussion_r245422397
--- Diff: _releases/1.0.0.md ---
@@ -0,0 +1,805 @@
+---
+
+released: false
+title: 1.0.0
+date: 2018-12-20 22:00:00 -0800
GitHub user necouchman opened a pull request:
https://github.com/apache/guacamole-client/pull/353
GUACAMOLE-577: Support for configuring the Guacamole Proxy in LDAP
Connections
This pull request implements the changes necessary to support the
`GuacamoleProxyConfiguration` in LDAP
GitHub user necouchman opened a pull request:
https://github.com/apache/guacamole-client/pull/352
GUACAMOLE-684: Insufficient credentials should take precedence over other
failures
This resolves an issue where, depending on the order of stacked
authentication modules
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/351#discussion_r244603234
--- Diff: guacamole-docker/bin/start.sh ---
@@ -404,6 +404,37 @@ END
ln -s /opt/guacamole/radius/guacamole-auth-*.jar "$GUACAMOL
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/351#discussion_r244544987
--- Diff: guacamole-docker/bin/build-guacamole.sh ---
@@ -126,3 +126,15 @@ if [ -f
extensions/guacamole-auth-radius/target/guacamole-auth
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/205#discussion_r244046919
--- Diff: src/guacd/conf-file.c ---
@@ -169,48 +192,40 @@ int guacd_conf_parse_file(guacd_config* conf, int fd
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/205#discussion_r244047068
--- Diff: src/guacd/conf-file.h ---
@@ -24,6 +24,11 @@
#include "conf.h"
+/**
+ * Creates a new configuration
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/205#discussion_r244047256
--- Diff: src/guacd/conf-file.h ---
@@ -32,10 +37,17 @@
int guacd_conf_parse_file(guacd_config* conf, int fd);
--- End diff
GitHub user necouchman opened a pull request:
https://github.com/apache/guacamole-client/pull/349
GUACAMOLE-678: Implement new UriGuacamoleProperty
This PR implements a new property type, the `UriGuacamoleProperty`, which
parses a string into a URI. Several of the extensions were
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/254#discussion_r243860177
--- Diff:
extensions/guacamole-auth-saml/src/main/java/org/apache/guacamole/auth/saml/AuthenticationProviderService.java
---
@@ -0,0 +1,202
GitHub user necouchman opened a pull request:
https://github.com/apache/guacamole-client/pull/348
GUACAMOLE-422: Forward Timezone to RDP and SSH Connections
These are the client-side changes to allow both detection of (via JSTZ) and
overriding of the client timezone for remote
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/347#discussion_r243608567
--- Diff: guacamole-docker/bin/build-guacamole.sh ---
@@ -53,7 +54,12 @@ mkdir -p "$DESTINATION"
#
cd "$BUIL
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/347#discussion_r243608670
--- Diff: guacamole-docker/bin/build-guacamole.sh ---
@@ -107,3 +113,11 @@ tar -xzf
extensions/guacamole-auth-ldap/target/*.tar.gz
GitHub user necouchman opened a pull request:
https://github.com/apache/guacamole-client/pull/346
GUACAMOLE-680: Rearrange logout handling
Per discussion on the mailing list, I've taken a stab at renaming the
pre-logout broadcast and implenting a post-logout broadcast in order
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/345#discussion_r241958169
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java
---
@@ -240,17
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/345#discussion_r241933797
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ObjectQueryService.java
---
@@ -188,46 +183,50 @@ public
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/345#discussion_r241928473
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/conf/LdapDnGuacamoleProperty.java
---
@@ -0,0 +1,50
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/345#discussion_r241928458
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/conf/LdapFilterGuacamoleProperty.java
---
@@ -0,0 +1,53
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/345#discussion_r241928420
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/LDAPConnectionService.java
---
@@ -156,38 +146,84
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/345#discussion_r241928440
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ObjectQueryService.java
---
@@ -188,46 +183,50 @@ public
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/345#discussion_r241919019
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java
---
@@ -240,17
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/345#discussion_r241916742
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/conf/LdapDnGuacamoleProperty.java
---
@@ -0,0 +1,50
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/345#discussion_r241916665
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ObjectQueryService.java
---
@@ -188,46 +183,50 @@ public
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/345#discussion_r241916587
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ObjectQueryService.java
---
@@ -188,46 +183,50 @@ public
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/345#discussion_r241916353
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java
---
@@ -240,17
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/336#discussion_r238684733
--- Diff: extensions/guacamole-auth-vault/.gitignore ---
@@ -0,0 +1,2 @@
+target/
--- End diff --
Looks like these .gitignore
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/336#discussion_r240048911
--- Diff:
extensions/guacamole-auth-vault/modules/guacamole-auth-vault-base/src/main/java/org/apache/guacamole/auth/vault/user
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/336#discussion_r238686408
--- Diff:
extensions/guacamole-auth-vault/modules/guacamole-auth-vault-azure/src/main/java/org/apache/guacamole/auth/vault/azure
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/336#discussion_r240043908
--- Diff:
extensions/guacamole-auth-vault/modules/guacamole-auth-vault-azure/src/main/java/org/apache/guacamole/auth/vault/azure/secret
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/336#discussion_r240044367
--- Diff:
extensions/guacamole-auth-vault/modules/guacamole-auth-vault-base/src/main/java/org/apache/guacamole/auth/vault/user
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/336#discussion_r240043831
--- Diff:
extensions/guacamole-auth-vault/modules/guacamole-auth-vault-azure/src/main/java/org/apache/guacamole/auth/vault/azure/conf
Github user necouchman closed the pull request at:
https://github.com/apache/guacamole-client/pull/204
---
GitHub user necouchman opened a pull request:
https://github.com/apache/guacamole-client/pull/345
GUACAMOLE-234: Migrate to Apache Directory API for LDAP Extension
This change request takes a new stab at migrating from the legacy Novell
JLDAP API to the Apache Directory API
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/342#discussion_r239272644
--- Diff:
guacamole/src/main/webapp/app/navigation/directives/guacUserMenu.js ---
@@ -95,13 +95,10 @@ angular.module('navigation').directive
GitHub user necouchman opened a pull request:
https://github.com/apache/guacamole-client/pull/343
GUACAMOLE-526: Correct redirect issue with CAS module
These changes clean up code and correct a minor typo that caused the CAS
redirect to fail.
You can merge this pull request
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/342#discussion_r238886562
--- Diff:
guacamole/src/main/webapp/app/navigation/directives/guacUserMenu.js ---
@@ -95,13 +95,10 @@ angular.module('navigation').directive
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/207#discussion_r238667965
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_fs_service.c ---
@@ -153,5 +153,42 @@ void guac_rdpdr_register_fs(guac_rdpdrPlugin* rdpdr,
char
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/207#discussion_r238668883
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_fs_service.c ---
@@ -153,5 +153,42 @@ void guac_rdpdr_register_fs(guac_rdpdrPlugin* rdpdr,
char
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/207#discussion_r238670994
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_fs_service.c ---
@@ -153,5 +153,42 @@ void guac_rdpdr_register_fs(guac_rdpdrPlugin* rdpdr,
char
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/207#discussion_r238669729
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_fs_service.c ---
@@ -153,5 +153,42 @@ void guac_rdpdr_register_fs(guac_rdpdrPlugin* rdpdr,
char
GitHub user necouchman opened a pull request:
https://github.com/apache/guacamole-client/pull/341
GUACAMOLE-670: Add slf4j logging to CAS and RADIUS modules
Looks like there are some differing versions of slf4j getting pulled into
some of the extension modules by other dependencies
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/205#discussion_r238082585
--- Diff: src/guacd/conf-file.c ---
@@ -188,15 +188,21 @@ guacd_config* guacd_conf_load() {
conf->key_file = NULL;
#en
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/205#discussion_r236387468
--- Diff: src/guacd/conf-args.c ---
@@ -122,3 +128,15 @@ int guacd_conf_parse_args(guacd_config* config, int
argc, char** argv
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/205#discussion_r236386735
--- Diff: src/guacd/conf-file.c ---
@@ -188,15 +188,21 @@ guacd_config* guacd_conf_load() {
conf->key_file = NULL;
#en
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/205#discussion_r236385213
--- Diff: src/guacd/conf-file.c ---
@@ -188,15 +188,21 @@ guacd_config* guacd_conf_load() {
conf->key_file = NULL;
#en
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/169#discussion_r232741345
--- Diff: src/protocols/ssh/ssh.c ---
@@ -256,6 +256,17 @@ void* ssh_client_thread(void* data) {
return NULL
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/169#discussion_r232737279
--- Diff: src/protocols/rdp/rdp_settings.c ---
@@ -1264,6 +1281,14 @@ void guac_rdp_push_settings(guac_rdp_settings*
guac_settings, freerdp
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/169#discussion_r232737390
--- Diff: src/protocols/rdp/rdp_settings.c ---
@@ -1264,6 +1281,14 @@ void guac_rdp_push_settings(guac_rdp_settings*
guac_settings, freerdp
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/169#discussion_r232507335
--- Diff: src/protocols/rdp/rdp_settings.c ---
@@ -1265,6 +1281,9 @@ void guac_rdp_push_settings(guac_rdp_settings*
guac_settings, freerdp* rdp
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/169#discussion_r232507326
--- Diff: src/protocols/rdp/rdp_settings.c ---
@@ -1265,6 +1277,9 @@ void guac_rdp_push_settings(guac_rdp_settings*
guac_settings, freerdp* rdp
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/201#discussion_r232504541
--- Diff: src/common-ssh/ssh.c ---
@@ -321,6 +321,10 @@ static int
guac_common_ssh_authenticate(guac_common_ssh_session* common_session
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/201#discussion_r232504438
--- Diff: src/common-ssh/ssh.c ---
@@ -321,6 +321,10 @@ static int
guac_common_ssh_authenticate(guac_common_ssh_session* common_session
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/169#discussion_r232504386
--- Diff: src/protocols/rdp/rdp_settings.c ---
@@ -356,6 +357,11 @@ enum RDP_ARGS_IDX {
*/
IDX_PRECONNECTION_BLOB
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/169#discussion_r232504348
--- Diff: src/protocols/rdp/rdp_settings.c ---
@@ -1265,6 +1277,9 @@ void guac_rdp_push_settings(guac_rdp_settings*
guac_settings, freerdp* rdp
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/169#discussion_r232504354
--- Diff: src/protocols/ssh/ssh.c ---
@@ -256,6 +256,10 @@ void* ssh_client_thread(void* data) {
return NULL
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/169#discussion_r232504364
--- Diff: src/protocols/ssh/settings.h ---
@@ -253,6 +253,10 @@ typedef struct guac_ssh_settings {
* environment variable
GitHub user necouchman opened a pull request:
https://github.com/apache/guacamole-server/pull/201
GUACAMOLE-547: Add support for SSH NONE authentication method
I'm not 100% certain that this is all that's needed, because I don't have a
SSH server to test this against
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/200#discussion_r232485885
--- Diff: src/protocols/ssh/argv.c ---
@@ -81,16 +110,51 @@ static int guac_ssh_argv_blob_handler(guac_user* user,
static int
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/198#discussion_r232439189
--- Diff: src/protocols/ssh/argv.c ---
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/198#discussion_r232438968
--- Diff: src/protocols/ssh/argv.c ---
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/199#discussion_r231131516
--- Diff: src/protocols/ssh/ssh.c ---
@@ -320,6 +320,17 @@ void* ssh_client_thread(void* data) {
return NULL
GitHub user necouchman opened a pull request:
https://github.com/apache/guacamole-server/pull/196
GUACAMOLE-527: Correct order of SFTP parameters in VNC.
Corrects the order of parameters in the VNC settings that I believe was
causing issues with VNC known host checking
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/328#discussion_r222318256
--- Diff: guacamole-common-js/src/main/webapp/modules/Keyboard.js ---
@@ -953,37 +1006,58 @@ Guacamole.Keyboard = function Keyboard(element
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/319#discussion_r221599026
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/319#discussion_r221436490
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/base/RelatedObjectSet.java
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/319#discussion_r221438180
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/319#discussion_r221280997
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/pom.xml ---
@@ -109,33 +109,33
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/319#discussion_r221253121
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/usergroup
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/319#discussion_r220513791
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/pom.xml ---
@@ -109,33 +109,33
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/319#discussion_r220506258
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-mysql/src/main/resources/org/apache/guacamole/auth/jdbc/connection
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/319#discussion_r220396450
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-mysql/schema/upgrade/upgrade-pre-1.0.0.sql
---
@@ -17,6 +17,319
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/319#discussion_r220395193
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/usergroup
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/319#discussion_r220397742
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-mysql/src/main/resources/org/apache/guacamole/auth/jdbc/connection
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/319#discussion_r220395046
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/usergroup
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/319#discussion_r220390959
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/319#discussion_r220394415
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/usergroup
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/319#discussion_r220390391
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/319#discussion_r219843129
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/base
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/320#discussion_r219650390
--- Diff: guacamole-docker/README.md ---
@@ -28,14 +28,25 @@ Once the Guacamole image is running, Guacamole will be
accessible at
`-p 8080
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/320#discussion_r219652878
--- Diff: guacamole-docker/README.md ---
@@ -90,6 +107,9 @@ the image will stop:
1. `MYSQL_DATABASE` - The name of the database to use
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/320#discussion_r219652862
--- Diff: guacamole-docker/README.md ---
@@ -90,6 +107,9 @@ the image will stop:
1. `MYSQL_DATABASE` - The name of the database to use
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/320#discussion_r219652808
--- Diff: guacamole-docker/README.md ---
@@ -45,6 +56,9 @@ the image will stop:
1. `POSTGRES_DATABASE` - The name of the database to use
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/320#discussion_r219652842
--- Diff: guacamole-docker/README.md ---
@@ -45,6 +56,9 @@ the image will stop:
1. `POSTGRES_DATABASE` - The name of the database to use
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/187#discussion_r217197430
--- Diff: src/protocols/telnet/settings.h ---
@@ -253,6 +267,16 @@ typedef struct guac_telnet_settings {
guac_telnet_settings
1 - 100 of 469 matches
Mail list logo