Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/191#discussion_r141450769
--- Diff:
guacamole-ext/src/main/java/org/apache/guacamole/net/auth/ActivityRecordSet.java
---
@@ -0,0 +1,128
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/191#discussion_r140896419
--- Diff:
guacamole-ext/src/main/java/org/apache/guacamole/net/auth/ActivityRecordSet.java
---
@@ -0,0 +1,128
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/176#discussion_r128304961
--- Diff: doc/guacamole-playback-example/src/main/webapp/index.html ---
@@ -28,10 +28,19
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/173#discussion_r127118531
--- Diff: guacamole/src/main/webapp/app/groupList/types/GroupListItem.js ---
@@ -187,7 +187,7 @@ angular.module('groupList').factory
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/95#discussion_r121854232
--- Diff: src/common-ssh/ssh.c ---
@@ -285,6 +285,38 @@ static void guac_common_ssh_kbd_callback(const char
*name, int name_len
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/95#discussion_r121854188
--- Diff: src/common-ssh/common-ssh/ssh.h ---
@@ -93,12 +94,17 @@ void guac_common_ssh_uninit();
* @param user
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/158#discussion_r118812447
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/base
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/158#discussion_r118812426
--- Diff:
guacamole/src/main/webapp/app/manage/controllers/manageUserController.js ---
@@ -261,6 +261,31 @@
angular.module('manage
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/158#discussion_r118810040
--- Diff: guacamole/src/main/webapp/app/form/directives/form.js ---
@@ -163,6 +181,59 @@ angular.module('form').directive('guacForm
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/158#discussion_r118810011
--- Diff:
guacamole/src/main/webapp/app/manage/controllers/manageUserController.js ---
@@ -225,8 +225,8 @@
angular.module('manage
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/158#discussion_r118809952
--- Diff:
guacamole/src/main/webapp/app/manage/controllers/manageUserController.js ---
@@ -261,6 +261,31 @@
angular.module('manage
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/158#discussion_r118809943
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/base
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/92#discussion_r118809754
--- Diff: src/terminal/display.c ---
@@ -118,7 +118,7 @@ int __guac_terminal_set_colors(guac_terminal_display*
display
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/152#discussion_r115174709
--- Diff: guacamole-docker/bin/start.sh ---
@@ -427,15 +427,15 @@ fi
# Validate that at least one authentication backend
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/152#discussion_r115174505
--- Diff: guacamole-docker/bin/start.sh ---
@@ -427,15 +427,15 @@ fi
# Validate that at least one authentication backend
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/88#discussion_r113616225
--- Diff: src/terminal/terminal_handlers.c ---
@@ -967,6 +967,18 @@ int guac_terminal_csi(guac_terminal* term, unsigned
char c
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/89#discussion_r113614127
--- Diff: src/terminal/terminal_handlers.c ---
@@ -1196,6 +1226,10 @@ int guac_terminal_osc(guac_terminal* term, unsigned
char c
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/86#discussion_r113610589
--- Diff: src/terminal/terminal_handlers.c ---
@@ -779,13 +919,30 @@ int guac_terminal_csi(guac_terminal* term, unsigned
char c
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/86#discussion_r113608643
--- Diff: src/terminal/display.c ---
@@ -127,24 +104,27 @@ int __guac_terminal_hash_codepoint(int codepoint) {
int
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/143#discussion_r111638369
--- Diff: guacamole-common-js/src/main/webapp/modules/Client.js ---
@@ -151,39 +153,53 @@ Guacamole.Client = function(tunnel
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/139#discussion_r111062649
--- Diff: guacamole-common-js/src/main/webapp/modules/Client.js ---
@@ -133,6 +133,124 @@ Guacamole.Client = function(tunnel
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/131#discussion_r107064307
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/DereferenceAliasesProperty.java
---
@@ -0,0
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/131#discussion_r107064241
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ConfigurationService.java
---
@@ -216,11
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/131#discussion_r107064203
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/DereferenceAliasesMode.java
---
@@ -0,0 +1,74
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/76#discussion_r105828074
--- Diff: src/common/cursor.c ---
@@ -295,25 +209,19 @@ void guac_common_cursor_set_argb(guac_common_cursor*
cursor, int hx, int hy
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/76#discussion_r105828607
--- Diff: src/common/cursor.c ---
@@ -295,25 +209,19 @@ void guac_common_cursor_set_argb(guac_common_cursor*
cursor, int hx, int hy
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/125#discussion_r103522286
--- Diff: extensions/guacamole-auth-duo/pom.xml ---
@@ -209,19 +209,11
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/125#discussion_r103519319
--- Diff: extensions/guacamole-auth-duo/pom.xml ---
@@ -209,19 +209,11
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/59#discussion_r101442133
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.c ---
@@ -373,21 +110,25 @@ void
guac_rdpdr_process_print_job_write
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/42#discussion_r97692703
--- Diff: src/common/common/surface.h ---
@@ -317,10 +363,77 @@ void guac_common_surface_clip(guac_common_surface*
surface, int x, int
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/39#discussion_r97635653
--- Diff: src/libguac/client.c ---
@@ -544,12 +273,12 @@ int guac_client_add_user(guac_client* client,
guac_user* user, int argc, char
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/102#discussion_r94854369
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/user
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/101#discussion_r94816705
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/security
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/99#discussion_r94526966
--- Diff: guacamole/src/main/webapp/app/rest/types/Error.js ---
@@ -43,6 +43,15 @@ angular.module('rest').factory('Error', [function
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/99#discussion_r94526301
--- Diff: guacamole/src/main/webapp/app/rest/types/Error.js ---
@@ -43,6 +43,15 @@ angular.module('rest').factory('Error', [function
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/99#discussion_r94525332
--- Diff:
guacamole-ext/src/main/java/org/apache/guacamole/language/Translatable.java ---
@@ -0,0 +1,41 @@
+/*
+ * Licensed
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/94#discussion_r91015645
--- Diff:
extensions/guacamole-auth-duo/src/main/java/org/apache/guacamole/auth/duo/DuoAuthenticationProvider.java
---
@@ -0,0 +1,100
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/94#discussion_r91014257
--- Diff:
extensions/guacamole-auth-duo/src/main/java/org/apache/guacamole/auth/duo/AuthenticationProviderService.java
---
@@ -0,0
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/89#discussion_r90749865
--- Diff: guacamole/src/licenses/dependencies/jsr250-api-1.0/CDDLv1.0.txt
---
@@ -0,0 +1,119 @@
+COMMON DEVELOPMENT
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/78#discussion_r87678304
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/24#discussion_r85266312
--- Diff: README ---
@@ -4,15 +4,11 @@
This README
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-manual/pull/17#discussion_r84208938
--- Diff: src/chapters/adding-protocol.xml ---
@@ -118,385 +221,564 @@ AM_CFLAGS = -Werror -Wall -pedantic
lib_LTLIBRARIES
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-manual/pull/17#discussion_r84207528
--- Diff: src/chapters/adding-protocol.xml ---
@@ -118,385 +221,564 @@ AM_CFLAGS = -Werror -Wall -pedantic
lib_LTLIBRARIES
GitHub user jmuehlner opened a pull request:
https://github.com/apache/incubator-guacamole-client/pull/71
GUACAMOLE-104: Sanitize filenames before upload or download.
To make tomcat happy, we can just replace slashes with something else - in
this case underscores.
You can merge
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/68#discussion_r77439985
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/68#discussion_r77439971
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/68#discussion_r77439888
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/68#discussion_r77439884
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java
GitHub user jmuehlner opened a pull request:
https://github.com/apache/incubator-guacamole-server/pull/20
GUACAMOLE-87: Bump guacamole-server version numbers to 0.9.10-incubating.
The Dockerfile is untouched because it needs more work before the release;
simply bumping the version
GitHub user jmuehlner opened a pull request:
https://github.com/apache/incubator-guacamole-client/pull/59
GUACAMOLE-80 Remove trailing comma to fix sharing profile creation in mysql
auth provider.
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user jmuehlner opened a pull request:
https://github.com/apache/incubator-guacamole-client/pull/58
GUACAMOLE-73: Clear permission cache when saving or updating to force
permission reload.
The permissions live in the user cache, so clearing the user cache upon
save/update
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/18#discussion_r75054973
--- Diff: src/protocols/rdp/keyboard.c ---
@@ -0,0 +1,283 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/57#discussion_r74715340
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/user/UserService.java
---
@@ -86,14 +87,18
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/57#discussion_r74715309
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/LDAPGuacamoleProperties.java
---
@@ -145,4
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/57#discussion_r74715279
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ConfigurationService.java
---
@@ -206,4 +206,22
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/57#discussion_r74715220
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ConfigurationService.java
---
@@ -206,4 +206,22
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/52#discussion_r74366237
--- Diff:
guacamole/src/main/webapp/app/manage/controllers/manageSharingProfileController.js
---
@@ -0,0 +1,406
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/47#discussion_r73638190
--- Diff:
guacamole/src/main/webapp/app/manage/controllers/manageUserController.js ---
@@ -918,6 +961,28 @@
angular.module('manage
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/47#discussion_r73637665
--- Diff:
guacamole/src/main/webapp/app/manage/controllers/manageUserController.js ---
@@ -918,6 +961,28 @@
angular.module('manage
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/46#discussion_r73237046
--- Diff: guacamole/src/main/webapp/app/navigation/templates/guacMenu.html
---
@@ -0,0 +1,7 @@
+
+{{menuTitle
GitHub user jmuehlner opened a pull request:
https://github.com/apache/incubator-guacamole-client/pull/35
GUACAMOLE-5 Fix syntax error in mysql create script by adding missing comma.
We need to fix this to restore the mysql schema create script to working
order.
You can merge
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/33#discussion_r72099720
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/tunnel
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/17#discussion_r72010270
--- Diff: src/protocols/rdp/user.c ---
@@ -88,12 +94,24 @@ int guac_rdp_user_join_handler(guac_user* user, int
argc, char** argv
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/32#discussion_r71819635
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/sharing
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/31#discussion_r71465971
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-postgresql/src/main/resources/org/apache/guacamole/auth/jdbc
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/31#discussion_r71465897
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-postgresql/src/main/resources/org/apache/guacamole/auth/jdbc
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/30#discussion_r71088295
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/connection
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/30#discussion_r71088214
--- Diff:
guacamole/src/main/java/org/apache/guacamole/tunnel/UserTunnel.java ---
@@ -0,0 +1,120 @@
+/*
+ * Licensed
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/30#discussion_r71088115
--- Diff:
guacamole/src/main/java/org/apache/guacamole/rest/permission/PermissionSetResource.java
---
@@ -205,6 +212,19 @@ else
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/26#discussion_r70560762
--- Diff:
guacamole/src/main/java/org/apache/guacamole/rest/user/UserResource.java ---
@@ -0,0 +1,195 @@
+/*
+ * Licensed
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/26#discussion_r70559396
--- Diff:
guacamole/src/main/java/org/apache/guacamole/rest/directory/DirectoryResource.java
---
@@ -0,0 +1,265
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/26#discussion_r70557739
--- Diff:
guacamole/src/main/java/org/apache/guacamole/rest/activeconnection/ActiveConnectionResource.java
---
@@ -0,0 +1,70
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/24#discussion_r68854489
--- Diff:
guacamole/src/main/webapp/app/clipboard/directives/guacClipboard.js ---
@@ -0,0 +1,312 @@
+/*
+ * Licensed
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/16#discussion_r67436488
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.h ---
@@ -25,44 +25,32 @@
#include "rdpdr_service.h"
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/16#discussion_r65923641
--- Diff:
guacamole/src/main/java/org/apache/guacamole/tunnel/GuacamoleStreamException.java
---
@@ -0,0 +1,61
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/16#discussion_r6592
--- Diff:
guacamole/src/main/java/org/apache/guacamole/tunnel/InterceptedStream.java ---
@@ -0,0 +1,161 @@
+/*
+ * Licensed
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/14#discussion_r65634966
--- Diff: guacamole-common-js/src/main/webapp/modules/ArrayBufferWriter.js
---
@@ -62,6 +62,20 @@ Guacamole.ArrayBufferWriter
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/12#discussion_r65482888
--- Diff: src/protocols/rdp/rdp_disp.h ---
@@ -102,7 +103,7 @@ void guac_rdp_disp_free(guac_rdp_disp* disp);
*
* @param
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/11#discussion_r65446708
--- Diff: guacamole-docker/README.md ---
@@ -129,17 +126,17 @@ Deploying Aoache Guacamole with LDAP authentication
-e
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/11#discussion_r65219207
--- Diff: guacamole-docker/README.md ---
@@ -115,6 +119,35 @@ The process for doing this via the `mysql` utility
included with MySQL
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/10#discussion_r64323904
--- Diff: src/protocols/rdp/rdp_settings.c ---
@@ -925,9 +925,31 @@ void guac_rdp_push_settings(guac_rdp_settings*
guac_settings
81 matches
Mail list logo
