[GitHub] incubator-guacamole-server pull request: GUACAMOLE-35: Ensure perf...

2016-05-23 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-server/pull/10#discussion_r64323904 --- Diff: src/protocols/rdp/rdp_settings.c --- @@ -925,9 +925,31 @@ void guac_rdp_push_settings(guac_rdp_settings* guac_settings

[GitHub] incubator-guacamole-server pull request: GUACAMOLE-35: Ensure perf...

2016-05-23 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-server/pull/10#discussion_r64324484 --- Diff: src/protocols/rdp/rdp_settings.c --- @@ -925,9 +925,31 @@ void guac_rdp_push_settings(guac_rdp_settings* guac_settings

[GitHub] incubator-guacamole-client pull request: GUACAMOLE-25: Only stream...

2016-05-23 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/9#discussion_r64326188 --- Diff: guacamole-common-js/src/main/webapp/modules/AudioRecorder.js --- @@ -213,6 +240,14 @@ Guacamole.RawAudioRecorder = function

[GitHub] incubator-guacamole-client pull request: GUACAMOLE-41: Add LDAP se...

2016-05-31 Thread jmuehlner
GitHub user jmuehlner opened a pull request: https://github.com/apache/incubator-guacamole-client/pull/11 GUACAMOLE-41: Add LDAP section to readme. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jmuehlner/incubator-guacamole

[GitHub] incubator-guacamole-client pull request: GUACAMOLE-41: Add LDAP section to r...

2016-05-31 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/11#discussion_r65219207 --- Diff: guacamole-docker/README.md --- @@ -115,6 +119,35 @@ The process for doing this via the `mysql` utility included with MySQL is

[GitHub] incubator-guacamole-client pull request: GUACAMOLE-41: Add LDAP section to r...

2016-05-31 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/11#discussion_r65219380 --- Diff: guacamole-docker/README.md --- @@ -115,6 +119,35 @@ The process for doing this via the `mysql` utility included with MySQL is

[GitHub] incubator-guacamole-client pull request: GUACAMOLE-41: Add LDAP section to r...

2016-05-31 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/11#discussion_r65219302 --- Diff: guacamole-docker/README.md --- @@ -12,8 +12,12 @@ How to use this image = Using this image

[GitHub] incubator-guacamole-client pull request: GUACAMOLE-41: Add LDAP section to r...

2016-05-31 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/11#discussion_r65219418 --- Diff: guacamole-docker/README.md --- @@ -115,6 +119,35 @@ The process for doing this via the `mysql` utility included with MySQL is

[GitHub] incubator-guacamole-client pull request: GUACAMOLE-41: Add LDAP section to r...

2016-05-31 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/11#discussion_r65219507 --- Diff: guacamole-docker/README.md --- @@ -115,6 +119,35 @@ The process for doing this via the `mysql` utility included with MySQL is

[GitHub] incubator-guacamole-client pull request: GUACAMOLE-41: Add LDAP section to r...

2016-05-31 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/11#discussion_r65241348 --- Diff: guacamole-docker/README.md --- @@ -12,8 +12,12 @@ How to use this image = Using this image

[GitHub] incubator-guacamole-client pull request #11: GUACAMOLE-41: Add LDAP section ...

2016-06-01 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/11#discussion_r65446586 --- Diff: guacamole-docker/README.md --- @@ -120,7 +117,7 @@ documented in [the Guacamole manual](http

[GitHub] incubator-guacamole-client pull request #11: GUACAMOLE-41: Add LDAP section ...

2016-06-01 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/11#discussion_r65446708 --- Diff: guacamole-docker/README.md --- @@ -129,17 +126,17 @@ Deploying Aoache Guacamole with LDAP authentication -e

[GitHub] incubator-guacamole-client pull request #11: GUACAMOLE-41: Add LDAP section ...

2016-06-01 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/11#discussion_r65446605 --- Diff: guacamole-docker/README.md --- @@ -148,6 +145,24 @@ binding as `LDAP_SEARCH_BIND_DN` to authenticate other users. (Optional

[GitHub] incubator-guacamole-client pull request #11: GUACAMOLE-41: Add LDAP section ...

2016-06-01 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/11#discussion_r65447767 --- Diff: guacamole-docker/README.md --- @@ -148,6 +145,24 @@ binding as `LDAP_SEARCH_BIND_DN` to authenticate other users. (Optional

[GitHub] incubator-guacamole-server pull request #12: GUACAMOLE-25: Add audio input s...

2016-06-01 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-server/pull/12#discussion_r65482888 --- Diff: src/protocols/rdp/rdp_disp.h --- @@ -102,7 +103,7 @@ void guac_rdp_disp_free(guac_rdp_disp* disp); * * @param

[GitHub] incubator-guacamole-client pull request #14: GUACAMOLE-44: Slice uploaded fi...

2016-06-02 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/14#discussion_r65634256 --- Diff: guacamole-common-js/src/main/webapp/modules/ArrayBufferWriter.js --- @@ -62,6 +62,20 @@ Guacamole.ArrayBufferWriter

[GitHub] incubator-guacamole-client pull request #14: GUACAMOLE-44: Slice uploaded fi...

2016-06-02 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/14#discussion_r65634966 --- Diff: guacamole-common-js/src/main/webapp/modules/ArrayBufferWriter.js --- @@ -62,6 +62,20 @@ Guacamole.ArrayBufferWriter

[GitHub] incubator-guacamole-client pull request #16: GUACAMOLE-44: Implement uploads...

2016-06-06 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/16#discussion_r6592 --- Diff: guacamole/src/main/java/org/apache/guacamole/tunnel/InterceptedStream.java --- @@ -0,0 +1,161 @@ +/* + * Licensed to

[GitHub] incubator-guacamole-client pull request #16: GUACAMOLE-44: Implement uploads...

2016-06-06 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/16#discussion_r65923641 --- Diff: guacamole/src/main/java/org/apache/guacamole/tunnel/GuacamoleStreamException.java --- @@ -0,0 +1,61

[GitHub] incubator-guacamole-client pull request #16: GUACAMOLE-44: Implement uploads...

2016-06-06 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/16#discussion_r65923500 --- Diff: guacamole/src/main/java/org/apache/guacamole/rest/tunnel/TunnelRESTService.java --- @@ -143,4 +150,53 @@ public void write

[GitHub] incubator-guacamole-client pull request #16: GUACAMOLE-44: Implement uploads...

2016-06-06 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/16#discussion_r65931141 --- Diff: guacamole/src/main/java/org/apache/guacamole/tunnel/InterceptedStream.java --- @@ -0,0 +1,161 @@ +/* + * Licensed to

[GitHub] incubator-guacamole-client pull request #16: GUACAMOLE-44: Implement uploads...

2016-06-06 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/16#discussion_r65933244 --- Diff: guacamole/src/main/java/org/apache/guacamole/tunnel/InterceptedStream.java --- @@ -0,0 +1,161 @@ +/* + * Licensed to

[GitHub] incubator-guacamole-client pull request #22: GUACAMOLE-53: Implement session...

2016-06-14 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/22#discussion_r67100796 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/connectiongroup

[GitHub] incubator-guacamole-manual pull request #5: GUACAMOLE-52: Document changes t...

2016-06-14 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-manual/pull/5#discussion_r67101184 --- Diff: src/chapters/jdbc-auth.xml --- @@ -839,15 +839,32 @@ INSERT INTO guacamole_connection_parameter VALUES (1

[GitHub] incubator-guacamole-manual pull request #5: GUACAMOLE-52: Document changes t...

2016-06-14 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-manual/pull/5#discussion_r67101573 --- Diff: src/chapters/jdbc-auth.xml --- @@ -839,15 +839,32 @@ INSERT INTO guacamole_connection_parameter VALUES (1

[GitHub] incubator-guacamole-server pull request #16: GUACAMOLE-44: Refactor the RDPD...

2016-06-16 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-server/pull/16#discussion_r67436488 --- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.h --- @@ -25,44 +25,32 @@ #include "rdpdr_service.h"

[GitHub] incubator-guacamole-client pull request #24: GUACAMOLE-55: Add interface-lev...

2016-06-28 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/24#discussion_r68854489 --- Diff: guacamole/src/main/webapp/app/clipboard/directives/guacClipboard.js --- @@ -0,0 +1,312 @@ +/* + * Licensed to the

[GitHub] incubator-guacamole-client pull request #24: GUACAMOLE-55: Add interface-lev...

2016-06-28 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/24#discussion_r68857396 --- Diff: guacamole/src/main/webapp/app/clipboard/services/clipboardService.js --- @@ -0,0 +1,409 @@ +/* + * Licensed to the

[GitHub] incubator-guacamole-client pull request #24: GUACAMOLE-55: Add interface-lev...

2016-06-28 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/24#discussion_r68862714 --- Diff: guacamole/src/main/webapp/app/clipboard/directives/guacClipboard.js --- @@ -0,0 +1,312 @@ +/* + * Licensed to the

[GitHub] incubator-guacamole-client pull request #26: GUACAMOLE-5: Refactor /api/data...

2016-07-13 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/26#discussion_r70557739 --- Diff: guacamole/src/main/java/org/apache/guacamole/rest/activeconnection/ActiveConnectionResource.java --- @@ -0,0 +1,70

[GitHub] incubator-guacamole-client pull request #26: GUACAMOLE-5: Refactor /api/data...

2016-07-13 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/26#discussion_r70559307 --- Diff: guacamole/src/main/java/org/apache/guacamole/rest/directory/DirectoryResource.java --- @@ -0,0 +1,265

[GitHub] incubator-guacamole-client pull request #26: GUACAMOLE-5: Refactor /api/data...

2016-07-13 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/26#discussion_r70556797 --- Diff: guacamole/src/main/java/org/apache/guacamole/rest/ObjectRetrievalService.java --- @@ -23,19 +23,11 @@ import

[GitHub] incubator-guacamole-client pull request #26: GUACAMOLE-5: Refactor /api/data...

2016-07-13 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/26#discussion_r70559396 --- Diff: guacamole/src/main/java/org/apache/guacamole/rest/directory/DirectoryResource.java --- @@ -0,0 +1,265

[GitHub] incubator-guacamole-client pull request #26: GUACAMOLE-5: Refactor /api/data...

2016-07-13 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/26#discussion_r70560762 --- Diff: guacamole/src/main/java/org/apache/guacamole/rest/user/UserResource.java --- @@ -0,0 +1,195 @@ +/* + * Licensed to

[GitHub] incubator-guacamole-client pull request #29: GUACAMOLE-5: Move common equals...

2016-07-16 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/29#discussion_r71068836 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/net/auth/AbstractIdentifiable.java --- @@ -0,0 +1,75

[GitHub] incubator-guacamole-client pull request #30: GUACAMOLE-5: Add concept of sha...

2016-07-17 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/30#discussion_r71088115 --- Diff: guacamole/src/main/java/org/apache/guacamole/rest/permission/PermissionSetResource.java --- @@ -205,6 +212,19 @@ else if

[GitHub] incubator-guacamole-client pull request #30: GUACAMOLE-5: Add concept of sha...

2016-07-17 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/30#discussion_r71088144 --- Diff: guacamole/src/main/java/org/apache/guacamole/rest/sharingprofile/APISharingProfile.java --- @@ -0,0 +1,207

[GitHub] incubator-guacamole-client pull request #30: GUACAMOLE-5: Add concept of sha...

2016-07-17 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/30#discussion_r71088214 --- Diff: guacamole/src/main/java/org/apache/guacamole/tunnel/UserTunnel.java --- @@ -0,0 +1,120 @@ +/* + * Licensed to the

[GitHub] incubator-guacamole-client pull request #30: GUACAMOLE-5: Add concept of sha...

2016-07-17 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/30#discussion_r71088295 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/connection

[GitHub] incubator-guacamole-client pull request #30: GUACAMOLE-5: Add concept of sha...

2016-07-17 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/30#discussion_r71091014 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/connection

[GitHub] incubator-guacamole-client pull request #31: GUACAMOLE-5: Implement sharing ...

2016-07-19 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/31#discussion_r71464564 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/sharingprofile

[GitHub] incubator-guacamole-client pull request #31: GUACAMOLE-5: Implement sharing ...

2016-07-19 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/31#discussion_r71465897 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-postgresql/src/main/resources/org/apache/guacamole/auth/jdbc

[GitHub] incubator-guacamole-client pull request #31: GUACAMOLE-5: Implement sharing ...

2016-07-19 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/31#discussion_r71465971 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-postgresql/src/main/resources/org/apache/guacamole/auth/jdbc

[GitHub] incubator-guacamole-client pull request #32: GUACAMOLE-5: Implement connecti...

2016-07-21 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/32#discussion_r71816717 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/sharing

[GitHub] incubator-guacamole-client pull request #32: GUACAMOLE-5: Implement connecti...

2016-07-21 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/32#discussion_r71816809 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/sharing

[GitHub] incubator-guacamole-client pull request #32: GUACAMOLE-5: Implement connecti...

2016-07-21 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/32#discussion_r71816991 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/sharing

[GitHub] incubator-guacamole-client pull request #32: GUACAMOLE-5: Implement connecti...

2016-07-21 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/32#discussion_r71817820 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/sharing

[GitHub] incubator-guacamole-client pull request #32: GUACAMOLE-5: Implement connecti...

2016-07-21 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/32#discussion_r71817913 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/sharing

[GitHub] incubator-guacamole-client pull request #32: GUACAMOLE-5: Implement connecti...

2016-07-21 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/32#discussion_r71819529 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/tunnel

[GitHub] incubator-guacamole-client pull request #32: GUACAMOLE-5: Implement connecti...

2016-07-21 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/32#discussion_r71819635 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/sharing

[GitHub] incubator-guacamole-client pull request #32: GUACAMOLE-5: Implement connecti...

2016-07-21 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/32#discussion_r71819978 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/tunnel

[GitHub] incubator-guacamole-server pull request #17: GUACAMOLE-5: Add per-user "read...

2016-07-24 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-server/pull/17#discussion_r72010270 --- Diff: src/protocols/rdp/user.c --- @@ -88,12 +94,24 @@ int guac_rdp_user_join_handler(guac_user* user, int argc, char** argv

[GitHub] incubator-guacamole-client pull request #33: GUACAMOLE-5: Invalidate share k...

2016-07-25 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/33#discussion_r72099720 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/tunnel

[GitHub] incubator-guacamole-client pull request #35: GUACAMOLE-5 Fix syntax error in...

2016-07-26 Thread jmuehlner
GitHub user jmuehlner opened a pull request: https://github.com/apache/incubator-guacamole-client/pull/35 GUACAMOLE-5 Fix syntax error in mysql create script by adding missing comma. We need to fix this to restore the mysql schema create script to working order. You can merge this

[GitHub] incubator-guacamole-client pull request #37: GUACAMOLE-66: Remove Apache Com...

2016-07-27 Thread jmuehlner
GitHub user jmuehlner opened a pull request: https://github.com/apache/incubator-guacamole-client/pull/37 GUACAMOLE-66: Remove Apache Commons Codec dependency. We already have a standard way of converting a byte array to a hex string, so let's just use that instead. You can

[GitHub] incubator-guacamole-client pull request #39: GUACAMOLE-5: Separate sharing s...

2016-07-29 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/39#discussion_r72879376 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-postgresql/src/main/java/org/apache/guacamole/auth/postgresql

[GitHub] incubator-guacamole-client pull request #45: GUACAMOLE-5: Add support for mu...

2016-07-31 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/45#discussion_r72906901 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/sharing

[GitHub] incubator-guacamole-client pull request #45: GUACAMOLE-5: Add support for mu...

2016-07-31 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/45#discussion_r72914173 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/sharing

[GitHub] incubator-guacamole-client pull request #46: GUACAMOLE-5: Implement user-fac...

2016-08-02 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/46#discussion_r73237046 --- Diff: guacamole/src/main/webapp/app/navigation/templates/guacMenu.html --- @@ -0,0 +1,7 @@ + +{{menuTitle

[GitHub] incubator-guacamole-client pull request #47: GUACAMOLE-5: Add support for ma...

2016-08-04 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/47#discussion_r73637665 --- Diff: guacamole/src/main/webapp/app/manage/controllers/manageUserController.js --- @@ -918,6 +961,28 @@ angular.module('m

[GitHub] incubator-guacamole-client pull request #47: GUACAMOLE-5: Add support for ma...

2016-08-04 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/47#discussion_r73638190 --- Diff: guacamole/src/main/webapp/app/manage/controllers/manageUserController.js --- @@ -918,6 +961,28 @@ angular.module('m

[GitHub] incubator-guacamole-client pull request #52: GUACAMOLE-5: Implement administ...

2016-08-10 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/52#discussion_r74364633 --- Diff: guacamole/src/main/webapp/app/manage/controllers/manageSharingProfileController.js --- @@ -0,0 +1,406

[GitHub] incubator-guacamole-client pull request #52: GUACAMOLE-5: Implement administ...

2016-08-10 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/52#discussion_r74366237 --- Diff: guacamole/src/main/webapp/app/manage/controllers/manageSharingProfileController.js --- @@ -0,0 +1,406

[GitHub] incubator-guacamole-client pull request #56: GUACAMOLE-78: Handle anonymous ...

2016-08-13 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/56#discussion_r74694423 --- Diff: guacamole/src/main/webapp/app/index/config/indexRouteConfig.js --- @@ -88,7 +88,7 @@ angular.module('index

[GitHub] incubator-guacamole-client pull request #57: GUACAMOLE-79: LDAPConnection ha...

2016-08-14 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/57#discussion_r74715220 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ConfigurationService.java --- @@ -206,4 +206,22

[GitHub] incubator-guacamole-client pull request #57: GUACAMOLE-79: LDAPConnection ha...

2016-08-14 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/57#discussion_r74715279 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ConfigurationService.java --- @@ -206,4 +206,22

[GitHub] incubator-guacamole-client pull request #57: GUACAMOLE-79: LDAPConnection ha...

2016-08-14 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/57#discussion_r74715309 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/LDAPGuacamoleProperties.java --- @@ -145,4

[GitHub] incubator-guacamole-client pull request #57: GUACAMOLE-79: LDAPConnection ha...

2016-08-14 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/57#discussion_r74715340 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/user/UserService.java --- @@ -86,14 +87,18

[GitHub] incubator-guacamole-server pull request #18: GUACAMOLE-51: Separate RDP keyb...

2016-08-16 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-server/pull/18#discussion_r75054973 --- Diff: src/protocols/rdp/keyboard.c --- @@ -0,0 +1,283 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] incubator-guacamole-client pull request #58: GUACAMOLE-73: Clear permission ...

2016-08-16 Thread jmuehlner
GitHub user jmuehlner opened a pull request: https://github.com/apache/incubator-guacamole-client/pull/58 GUACAMOLE-73: Clear permission cache when saving or updating to force permission reload. The permissions live in the user cache, so clearing the user cache upon save/update of

[GitHub] incubator-guacamole-client pull request #59: GUACAMOLE-80 Remove trailing co...

2016-08-16 Thread jmuehlner
GitHub user jmuehlner opened a pull request: https://github.com/apache/incubator-guacamole-client/pull/59 GUACAMOLE-80 Remove trailing comma to fix sharing profile creation in mysql auth provider. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] incubator-guacamole-client pull request #62: GUACAMOLE-81: Verify primary co...

2016-08-20 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/62#discussion_r75587735 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/base

[GitHub] incubator-guacamole-client pull request #64: GUACAMOLE-87: Bump guacamole-cl...

2016-08-25 Thread jmuehlner
GitHub user jmuehlner opened a pull request: https://github.com/apache/incubator-guacamole-client/pull/64 GUACAMOLE-87: Bump guacamole-client version numbers to 0.9.10-incubating The Dockerfile is untouched because it needs more work before the release; simply bumping the version

[GitHub] incubator-guacamole-server pull request #20: GUACAMOLE-87: Bump guacamole-se...

2016-08-25 Thread jmuehlner
GitHub user jmuehlner opened a pull request: https://github.com/apache/incubator-guacamole-server/pull/20 GUACAMOLE-87: Bump guacamole-server version numbers to 0.9.10-incubating. The Dockerfile is untouched because it needs more work before the release; simply bumping the version

[GitHub] incubator-guacamole-manual pull request #6: GUACAMOLE-87: Bump guacamole-man...

2016-08-25 Thread jmuehlner
GitHub user jmuehlner opened a pull request: https://github.com/apache/incubator-guacamole-manual/pull/6 GUACAMOLE-87: Bump guacamole-manual version numbers to 0.9.10-incubating. You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-guacamole-client pull request #68: add additional search filter fu...

2016-09-03 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/68#discussion_r77439884 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java

[GitHub] incubator-guacamole-client pull request #68: add additional search filter fu...

2016-09-03 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/68#discussion_r77439888 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java

[GitHub] incubator-guacamole-client pull request #68: add additional search filter fu...

2016-09-03 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/68#discussion_r77439930 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java

[GitHub] incubator-guacamole-client pull request #68: add additional search filter fu...

2016-09-03 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/68#discussion_r77439936 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java

[GitHub] incubator-guacamole-client pull request #68: add additional search filter fu...

2016-09-03 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/68#discussion_r77439956 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/user/UserService.java --- @@ -84,14 +84,17

[GitHub] incubator-guacamole-client pull request #68: add additional search filter fu...

2016-09-03 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/68#discussion_r77439971 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java

[GitHub] incubator-guacamole-client pull request #68: add additional search filter fu...

2016-09-03 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/68#discussion_r77439985 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java

[GitHub] incubator-guacamole-client pull request #71: GUACAMOLE-104: Sanitize filenam...

2016-09-07 Thread jmuehlner
GitHub user jmuehlner opened a pull request: https://github.com/apache/incubator-guacamole-client/pull/71 GUACAMOLE-104: Sanitize filenames before upload or download. To make tomcat happy, we can just replace slashes with something else - in this case underscores. You can merge

[GitHub] incubator-guacamole-manual pull request #17: GUACAMOLE-88: Update client plu...

2016-10-19 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-manual/pull/17#discussion_r84207528 --- Diff: src/chapters/adding-protocol.xml --- @@ -118,385 +221,564 @@ AM_CFLAGS = -Werror -Wall -pedantic lib_LTLIBRARIES

[GitHub] incubator-guacamole-manual pull request #17: GUACAMOLE-88: Update client plu...

2016-10-19 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-manual/pull/17#discussion_r84208885 --- Diff: src/chapters/adding-protocol.xml --- @@ -118,385 +221,564 @@ AM_CFLAGS = -Werror -Wall -pedantic lib_LTLIBRARIES

[GitHub] incubator-guacamole-manual pull request #17: GUACAMOLE-88: Update client plu...

2016-10-19 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-manual/pull/17#discussion_r84208938 --- Diff: src/chapters/adding-protocol.xml --- @@ -118,385 +221,564 @@ AM_CFLAGS = -Werror -Wall -pedantic lib_LTLIBRARIES

[GitHub] incubator-guacamole-manual pull request #17: GUACAMOLE-88: Update client plu...

2016-10-19 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-manual/pull/17#discussion_r84208194 --- Diff: src/chapters/adding-protocol.xml --- @@ -118,385 +221,564 @@ AM_CFLAGS = -Werror -Wall -pedantic lib_LTLIBRARIES

[GitHub] incubator-guacamole-server pull request #24: GUACAMOLE-107 Remove references...

2016-10-26 Thread jmuehlner
GitHub user jmuehlner opened a pull request: https://github.com/apache/incubator-guacamole-server/pull/24 GUACAMOLE-107 Remove references to old website and Apachify project name It looks like only the README had to be touched here. You can merge this pull request into a Git

[GitHub] incubator-guacamole-server pull request #24: GUACAMOLE-107 Remove references...

2016-10-26 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-server/pull/24#discussion_r85266312 --- Diff: README --- @@ -4,15 +4,11 @@ This README is

[GitHub] incubator-guacamole-server pull request #24: GUACAMOLE-107 Remove references...

2016-10-26 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-server/pull/24#discussion_r85267077 --- Diff: README --- @@ -6,11 +6,16 @@ This README is intended to provide quick and to-the-point documentation for technical

[GitHub] incubator-guacamole-client pull request #78: GUACAMOLE-70: Allow access to b...

2016-11-11 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/78#discussion_r87638742 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc

[GitHub] incubator-guacamole-client pull request #78: GUACAMOLE-70: Allow access to b...

2016-11-11 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/78#discussion_r87640259 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc

[GitHub] incubator-guacamole-client pull request #78: GUACAMOLE-70: Allow access to b...

2016-11-11 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/78#discussion_r87671874 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc

[GitHub] incubator-guacamole-client pull request #76: GUACAMOLE-99: Support linking D...

2016-11-11 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/76#discussion_r87677828 --- Diff: guacamole-docker/bin/start.sh --- @@ -352,20 +352,42 @@ mkdir -p "$GUACAMOLE_LIB" # Point to associ

[GitHub] incubator-guacamole-client pull request #78: GUACAMOLE-70: Allow access to b...

2016-11-11 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/78#discussion_r87678304 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc

[GitHub] incubator-guacamole-client pull request #89: GUACAMOLE-133: Document all dep...

2016-12-02 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/89#discussion_r90749865 --- Diff: guacamole/src/licenses/dependencies/jsr250-api-1.0/CDDLv1.0.txt --- @@ -0,0 +1,119 @@ +COMMON DEVELOPMENT AND

[GitHub] incubator-guacamole-client pull request #94: GUACAMOLE-136: Add support for ...

2016-12-05 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/94#discussion_r91014257 --- Diff: extensions/guacamole-auth-duo/src/main/java/org/apache/guacamole/auth/duo/AuthenticationProviderService.java --- @@ -0,0

[GitHub] incubator-guacamole-client pull request #94: GUACAMOLE-136: Add support for ...

2016-12-05 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/94#discussion_r91015645 --- Diff: extensions/guacamole-auth-duo/src/main/java/org/apache/guacamole/auth/duo/DuoAuthenticationProvider.java --- @@ -0,0 +1,100

[GitHub] incubator-guacamole-client pull request #94: GUACAMOLE-136: Add support for ...

2016-12-05 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/94#discussion_r91015717 --- Diff: extensions/guacamole-auth-duo/src/main/resources/controllers/duoSignedResponseController.js --- @@ -0,0 +1,78

[GitHub] incubator-guacamole-client pull request #98: GUACAMOLE-144: Do not list Cate...

2016-12-18 Thread jmuehlner
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/98#discussion_r92948063 --- Diff: guacamole/src/licenses/bundled/logback-1.1.2/LICENSE.txt --- @@ -13,3 +13,5 @@ the Eclipse Foundation under the terms of

  1   2   >