Heya, and happy Friday.
I would like to propose that we drop support for receiving contributions by
way of attaching a patch file to a Jira issue. From my perspective, in the
face of modern interfaces for PR-style review, this is an "archaic" form of
contribution that is "actively harmful" to proj
+1 to the idea, having one contribution workflow instead of two is 50% less
confusing (or 100% depending how you count it).
> applying a patch for local evaluation is more tedious than checking out a
PR branch.
Except it's not necessary to download and apply the patch to evaluate it,
we have prec
+1, can only see benefits of using GitHub PRs over attached patches.
On Fri, 21 Feb 2020, 21:33 Andrew Purtell, wrote:
> +1 to the idea, having one contribution workflow instead of two is 50% less
> confusing (or 100% depending how you count it).
>
> > applying a patch for local evaluation is m
The bot is for lots of projects, not only HBase, so we can not shut it down.
My concern is that, do we really need to shut it down completely? The pre
commit job is still fine I think? So just leave it as is? And when
sometimes it is broken and needs a lot of effort to maintain, then we can
shut i
There's a dedicated precommit job just for the hbase main repo. We can shut
it down without impacting other projects or even other hbase repos. There's
already debt on that job; Nick has been starting to pay it down and I'd
imagine that's how we got to this thread about just turning it off. For
exa
> The bot is for lots of projects, not only HBase, so we can not shut it
down.
Pardon me Duo. I am proposing we terminate PreCommit-HBASE-Build. The
PreCommit-Admin job appears to be the responsibility of Yetus and is out of
scope of my discussion here.
> There's already debt on that job; Nick ha
If it is not easy to add JDK11 support for the PreCommit-HBASE-Build job
then I'm +1 with stopping it. We should make all the contribution ways have
the same pre commit check.
Nick Dimiduk 于2020年2月25日周二 上午7:33写道：
> > The bot is for lots of projects, not only HBase, so we can not shut it
> down.
> If it is not easy to add JDK11 support for the PreCommit-HBASE-Build job
then I'm +1 with stopping it.
It's a bit of work to bring Jira PreCommit up to feature parity with GitHub
PreCommit, especially seeing the work that was necessary to get GitHub
PreCommit to do JDK11. From what I can tell, t
Per this discussion, I have posted a patch on HBASE-25228 that removes the
script we used to use that hooked up the Jenkins Precommit job to Jira. I
have closed the above issues as "won't fix".
It also looks like our documentation needs an update, so I filed
HBASE-25233. I think we might also be a
