Re: [DISCUSS] First release candidate for 2.5.0 (RC0) is available for evaluation

Thanks, Andrew. Had now committed HBASE-27017 into branch-2.5. Em dom., 5 de jun. de 2022 às 21:25, Andrew Purtell escreveu: > Thanks Wellington. > > I changed the issue type of HBASE-26826 so it will show up as a new > feature. > > Please feel free to commit HBASE-27017 (and any other bug fix)

Re: [DISCUSS] First release candidate for 2.5.0 (RC0) is available for evaluation

Thanks Wellington. I changed the issue type of HBASE-26826 so it will show up as a new feature. Please feel free to commit HBASE-27017 (and any other bug fix) to branch-2.5. There are a few other changes committed to the branch post 2.5.0RC0 too that will get rolled up into RC1 on Monday. On Su

Re: [DISCUSS] First release candidate for 2.5.0 (RC0) is available for evaluation

> > Even for branch-2.4, we can start placing links into the file, at the top, > leaving the output of the prior process in place below. I think it is fine > to make this change everywhere. Curious what others think. > Sounds ok to me. Regarding CHANGES.md content, it's listing HBASE-26826

Re: [DISCUSS] First release candidate for 2.5.0 (RC0) is available for evaluation

+1 to make the change everywhere. Sometimes, there is a need to update the release field after jira is released (in theory, it should not happen). Thanks Huaxiang On Thu, Jun 2, 2022 at 10:56 AM Andrew Purtell wrote: > Even for branch-2.4, we can start placing links into the file, at the top,

Re: [DISCUSS] First release candidate for 2.5.0 (RC0) is available for evaluation

Even for branch-2.4, we can start placing links into the file, at the top, leaving the output of the prior process in place below. I think it is fine to make this change everywhere. Curious what others think. On Thu, Jun 2, 2022 at 10:54 AM Andrew Purtell wrote: > I see, that would be totally fi

Re: [DISCUSS] First release candidate for 2.5.0 (RC0) is available for evaluation

I see, that would be totally fine with me if we just do the link instead of generating the files every time. On Thu, Jun 2, 2022 at 9:31 AM 张铎(Duo Zhang) wrote: > Oh, wait a minute. IIRC we have a consensus to use the jira page as release > note instead of committing a file to the repo? The prob

Re: [DISCUSS] First release candidate for 2.5.0 (RC0) is available for evaluation

Oh, wait a minute. IIRC we have a consensus to use the jira page as release note instead of committing a file to the repo? The problem is that, sometimes we just missed something in CHANGES.md or RELEASENOTES.md, no actually code change, but since we have committed these files to our git repo, we h

Re: [DISCUSS] First release candidate for 2.5.0 (RC0) is available for evaluation

I just noticed the release notes issue on the branch last evening. Let’s add the spotless application to the release note generation step in create-release at least or it will keep happening. The RM does not get a chance to intervene. The script uses the RM credentials to commit immediately afte

Re: [DISCUSS] First release candidate for 2.5.0 (RC0) is available for evaluation

Oh, I think we should include HBASE-27023, it fixes the license issue after we apply the spotless formatter where it will add the license header automatically. And also, it seems that the generated RELEASENOTE.md will introduce some lines ending with whitespace, then it will cause pre commit build

Re: [DISCUSS] First release candidate for 2.5.0 (RC0) is available for evaluation

OK, got it. Thanks for the clarification~ Andrew Purtell 于2022年6月2日周四 11:12写道： > I don’t think a flaky test is cause to fail the release. So these all have > a fix version of 2.5.1. I mentioned them so people could be aware of these > known issue when evaluating their own findings. Hope that hel

Re: [DISCUSS] First release candidate for 2.5.0 (RC0) is available for evaluation

I don’t think a flaky test is cause to fail the release. So these all have a fix version of 2.5.1. I mentioned them so people could be aware of these known issue when evaluating their own findings. Hope that helps. > On Jun 1, 2022, at 8:11 PM, 张铎 wrote: > > On flakyness, if it is a big prob

Re: [DISCUSS] First release candidate for 2.5.0 (RC0) is available for evaluation

On flakyness, if it is a big problem on promoting the RC, I think we can ignore the test first(instead of removing it). Can open a follow on issue to make it stable. Thanks. Andrew Purtell 于2022年6月1日周三 23:25写道： > Makes sense and if nobody has a concern we can do that. > > Also you wanted to su

Re: [DISCUSS] First release candidate for 2.5.0 (RC0) is available for evaluation

Makes sense and if nobody has a concern we can do that. Also you wanted to support the change to the RSGroup API and put back the unit test (and fix it to not flake), correct, which seems fine to me too. On Tue, May 31, 2022 at 10:54 PM 张铎(Duo Zhang) wrote: > The ReplicationLoadSink change is d

Re: [DISCUSS] First release candidate for 2.5.0 (RC0) is available for evaluation

The ReplicationLoadSink change is done in HBASE-26490, this is the commit https://github.com/apache/hbase/commit/b5b286d793f00ec8b9ed02f51fd9324e46f29c86 The constructor is marked as IA.Private so I do not think we need to restore it back. Thanks. Andrew Purtell 于2022年6月1日周三 13:08写道： > This i

[DISCUSS] First release candidate for 2.5.0 (RC0) is available for evaluation

This is not a VOTE. HBase 2.5.0RC0 is ready for testing, other evaluation, and consideration of compatibility concerns. The release notes need to be rebased on the latest 2.4.x release, 2.4.12. Fix versions on relvant JIRAs must be cleaned up first. This is in progress. I also plan to try our new