Re: [DISCUSS] Merge HBASE-16961 (Space Quotas) into master

2017-05-05 Thread Josh Elser
@Stack ok, wasn't sure if you had asked for the info because you were actively looking at it or not. @Andrew Cool beans. Code review at any point is appreciated. We can definitely continue to clean things up. With that said, let me just start a VOTE now so I don't forget to do it Monday morn

Re: [DISCUSS] Merge HBASE-16961 (Space Quotas) into master

2017-05-05 Thread Andrew Purtell
I'll try to review beyond page two of the diffs soon Josh, for specific code issues (if any). So far I've only seen the one, which you called out, about a potential bottleneck executing admin actions if wanting to apply a lot of changes at once. In terms of high level design and the ops model, I'd

Re: [DISCUSS] Merge HBASE-16961 (Space Quotas) into master

2017-05-05 Thread Stack
On Fri, May 5, 2017 at 9:12 AM, Josh Elser wrote: > Just an update: Andrew P provided some great feedback which I've finally > got all merged into the feature branch [1][2][3]. Many thanks again -- it > was some really nice feedback. > > @Stack: do you have review/thoughts pending? > > I'm on som

Re: [DISCUSS] Merge HBASE-16961 (Space Quotas) into master

2017-05-05 Thread Josh Elser
Just an update: Andrew P provided some great feedback which I've finally got all merged into the feature branch [1][2][3]. Many thanks again -- it was some really nice feedback. @Stack: do you have review/thoughts pending? Anyone else maybe thinking in the back of their head, but haven't said

Re: [DISCUSS] Merge HBASE-16961 (Space Quotas) into master

2017-04-26 Thread Josh Elser
I published a current copy of the book -- check out the new chapter on the feature to start [1]. Then, to walk through using the feature, I'd take a look at this comment[2] which has a little script to create some tables/quotas and tries to step you a (contrived) example workflow. LMK if you h

Re: [DISCUSS] Merge HBASE-16961 (Space Quotas) into master

2017-04-26 Thread Stack
Sounds like an excellent idea to me. If I were to take a tour over the quotas feature, how would you direct my perambulations Josh? Thanks, St.Ack On Tue, Apr 25, 2017 at 9:13 AM, Josh Elser wrote: > Hi folks, > > Here's a formal thread for discussion on merging the space quota feature > (presen

[DISCUSS] Merge HBASE-16961 (Space Quotas) into master

2017-04-25 Thread Josh Elser
Hi folks, Here's a formal thread for discussion on merging the space quota feature (presently in the branch HBASE-16961[1]) into master. The tl;dr on the feature is that this extends the RPC quota feature to include configurable limits on the size of tables and namespaces. Please check the ar